Diffusion Phabricator (master) History

phabricator/src/applications/differential/controller
master

Mar 17 2021

1d1003af7854 When using "Update Diff" from the web UI, prefill "Repository" properly
Author
epriestley
Revisions
D21638: When using "Update Diff" from the web UI, prefill "Repository" properly
Browse Repository
Passed
No Audits

Mar 15 2021

925c9a71e7ea Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the…
Author
epriestley
Revisions
D21619: Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the revision view
Browse Repository
Passed
No Audits

e919b4c35a2a Add a debug view of the "Affected Path" index to Differential
Author
epriestley
Revisions
D21615: Add a debug view of the "Affected Path" index to Differential
Browse Repository
Passed
No Audits

Oct 16 2020

2b8bbae5fb27 Set an explicit height when drawing the dependent revision graph
Author
epriestley
Revisions
D21481: Set an explicit height when drawing the dependent revision graph
Browse Repository
Passed
No Audits

May 20 2020

846562158aae Roughly support inline comment suggestions
Author
epriestley
Revisions
D21276: Roughly support inline comment suggestions
Browse Repository
Passed
No Audits

May 8 2020

6dc20d1e2e71 Fix an issue where storage inlines are fed to InlineAdjustmentEngine
Author
epriestley
Revisions
D21239: Fix an issue where storage inlines are fed to InlineAdjustmentEngine
Browse Repository
Passed
No Audits

fa2d30ee3698 Lift inline comment draft behaviors to "InlineController"
Author
epriestley
Revisions
D21235: Lift inline comment draft behaviors to "InlineController"
Browse Repository
Passed
No Audits

May 7 2020

79107574a762 Remove "DifferentialInlineCommentQuery"
Author
epriestley
Revisions
D21233: Remove "DifferentialInlineCommentQuery"
Browse Repository
Passed
No Audits

983d77848b4c Move the "Inline List" view to "DiffInlineCommentQuery"
Author
epriestley
Revisions
D21232: Move the "Inline List" view to "DiffInlineCommentQuery"
Browse Repository
Passed
No Audits

af5b94b23473 Lift most "InlineController" querying to the base class
Author
epriestley
Revisions
D21231: Lift most "InlineController" querying to the base class
Browse Repository
Passed
No Audits

May 4 2020

fe501bd7f736 Save drafts for inline comments currently being edited
Author
epriestley
Revisions
D21216: Save drafts for inline comments currently being edited
Browse Repository
Passed
No Audits

9307f57747b2 When rendering changesets, discard empty draft inline comments
Author
epriestley
Revisions
D21214: When rendering changesets, discard empty draft inline comments
Browse Repository
Passed
No Audits

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Revisions
D21186: Make "editing" state persistent for inline comments
Browse Repository
Passed
No Audits

Apr 28 2020

befeb17f6ff1 Improve the construction of synthetic "comparison/intradiff" changesets
Author
epriestley
Revisions
D21180: Improve the construction of synthetic "comparison/intradiff" changesets
Browse Repository
Passed
No Audits

Apr 22 2020

60de1506fe3b Make "hidden" changesets sticky, and show hidden state in the filetree
Author
epriestley
Revisions
D21158: Make "hidden" changesets sticky, and show hidden state in the filetree
Browse Repository
Passed
No Audits

a72a66caa833 Mark "low importance" and "owned" changes in the filetree
Author
epriestley
Revisions
D21157: Mark "low importance" and "owned" changes in the filetree
Browse Repository
Passed
No Audits

646280972b88 Glue the new FormationView on top of the older Filetree view in Differential
Author
epriestley
Revisions
D21151: Glue the new FormationView on top of the older Filetree view in Differential
Browse Repository
Passed
No Audits

Apr 19 2020

c3c55d82ae9d Make "renderer", "engine", and "encoding" sticky across reloads in Differential…
Author
epriestley
Revisions
D21138: Make "renderer", "engine", and "encoding" sticky across reloads in Differential and Diffusion
Browse Repository
Passed
No Audits

8aac55cc57cb Make "Highlight As..." sticky across reloads in Diffusion and Differential
Author
epriestley
Revisions
D21137: Make "Highlight As..." sticky across reloads in Diffusion and Differential
Browse Repository
Passed
No Audits

Sep 25 2019

a73f592d7d08 Allow DocumentEngine to elect into diff construction
Author
epriestley
Revisions
D20830: Allow DocumentEngine to elect into diff construction
Browse Repository
Passed
No Audits

Jun 17 2019

14b076578f8e In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes
Author
epriestley
Revisions
D20579: In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes
Browse Repository
Passed
No Audits

Apr 30 2019

6eae75d8f2ff When building a synthetic diff in Differential, adjust diff properties correctly
Author
epriestley
Browse Repository
Passed
No Audits

Apr 24 2019

ec0085fd0c7a Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
Author
epriestley
Revisions
D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
Browse Repository
Passed
No Audits

Feb 25 2019

dc9aaa0fc2bf Fix a stray "%Q" warning when hiding/showing inline comments
Author
epriestley
Revisions
D20212: Fix a stray "%Q" warning when hiding/showing inline comments
Browse Repository
Passed
No Audits

Feb 20 2019

a33409991c27 Remove an old Differential selection behavior
Author
epriestley
Revisions
D20196: Remove an old Differential selection behavior
Browse Repository
Passed
No Audits

Feb 19 2019

5310f1cdd90e Remove all whitespace options/configuration everywhere
Author
epriestley
Revisions
D20185: Remove all whitespace options/configuration everywhere
Browse Repository
Passed
No Audits

Feb 16 2019

c5e16f9bd996 Give HarbormasterBuildUnitMessage a real Query class
Author
epriestley
Revisions
D20179: Give HarbormasterBuildUnitMessage a real Query class
Browse Repository
Passed
No Audits

Feb 14 2019

5892c7898603 Replace all "setQueryParam()" calls with "remove/replaceQueryParam()"
Author
epriestley
Revisions
D20154: Replace all "setQueryParam()" calls with "remove/replaceQueryParam()"
Browse Repository
Passed
No Audits

Feb 12 2019

1fd69f788cee Replace "getQueryParams()" callsites in Phabricator
Author
epriestley
Revisions
D20141: Replace "getQueryParams()" callsites in Phabricator
Browse Repository
Passed
No Audits

Feb 5 2019

b8fe991ba28e Improve description text in the "Create Diff" form
Author
leoluk
Revisions
D20092: Improve description text in the "Create Diff" form
Browse Repository
Passed
No Audits

Sep 7 2018

16a6fc8341ea Allow reviewers to mark their own inlines as "Done" before they submit them
Author
epriestley
Revisions
D19634: Allow reviewers to mark their own inlines as "Done" before they submit them
Browse Repository
Passed
No Audits

Sep 6 2018

650e74933abb Update some inline comment logic to use more modern "Viewer"-oriented…
Author
epriestley
Revisions
D19633: Update some inline comment logic to use more modern "Viewer"-oriented calls/variables
Browse Repository
Passed
No Audits

Aug 28 2018

614f9ba1fba6 Allow unit test results to specify that their details are formatted with…
Author
epriestley
Revisions
D19615: Allow unit test results to specify that their details are formatted with remarkup when reporting to "harbormaster.sendmessage"
Browse Repository
Passed
No Audits

Aug 24 2018

b584834b1934 In Differential: when the file tree is enabled, default to the "History" tab…
Author
epriestley
Revisions
D19601: In Differential: when the file tree is enabled, default to the "History" tab instead of "Files"
Browse Repository
Passed
No Audits

Aug 13 2018

e5906f4e127e In Differential standalone views, disable some keyboard shortcuts which don't…
Author
epriestley
Revisions
D19571: In Differential standalone views, disable some keyboard shortcuts which don't work
Browse Repository
Passed
No Audits

Jul 27 2018

9e451879d998 Add a "Changes Since Last Action" view to Differential revisions
Author
epriestley
Revisions
D19541: Add a "Changes Since Last Action" view to Differential revisions
Browse Repository
Passed
No Audits

May 17 2018

8f9b9484471a When showing a diff-of-diffs, hide files which didn't get any more changes and…
Author
epriestley
Revisions
D19453: When showing a diff-of-diffs, hide files which didn't get any more changes and have no inlines
Browse Repository
Passed
No Audits

May 7 2018

a4a22dd2f889 Mention the "inline comments" rule in the callout for "Large" diffs
Author
epriestley
Revisions
D19430: Mention the "inline comments" rule in the callout for "Large" diffs
Browse Repository
Passed
No Audits

May 5 2018

5e2af4b9b5cd Prepare to support an "Ignore generated files" flag in Owners
Author
epriestley
Revisions
D19426: Prepare to support an "Ignore generated files" flag in Owners
Browse Repository
Passed
No Audits

Apr 30 2018

ee32c186dd82 Stop computing ownership for changed paths for Very Large revisions
Author
epriestley
Revisions
D19418: Stop computing ownership for changed paths for Very Large revisions
Browse Repository
Passed
No Audits

24305cadb902 Hide the "large" diff warning on "very large" diffs
Author
epriestley
Revisions
D19416: Hide the "large" diff warning on "very large" diffs
Browse Repository
Passed
No Audits

Apr 5 2018

f01c2e36948b Remove "Large Changes" documentation and make some minor behavioral improvements
Author
epriestley
Revisions
D19298: Remove "Large Changes" documentation and make some minor behavioral improvements
Browse Repository
Passed
No Audits

1b363a831e7c When a revision changes more than 1,000 files, don't show the changes on the…
Author
epriestley
Revisions
D19296: When a revision changes more than 1,000 files, don't show the changes on the main page
Browse Repository
Passed
No Audits

8c8e7f07b575 Add a standalone view for browsing changesets of very large revisions
Author
epriestley
Revisions
D19295: Add a standalone view for browsing changesets of very large revisions
Browse Repository
Passed
No Audits

Apr 3 2018

e40aec0210dc When a revision has more than 7 reviewers, render only the first 7 in the list…
Author
epriestley
Revisions
D19293: When a revision has more than 7 reviewers, render only the first 7 in the list view
Browse Repository
Passed
No Audits

615d27c8e97f Show an additional "Draft" tag on non-broadcasting revisions in a non-draft…
Author
epriestley
Revisions
D19285: Show an additional "Draft" tag on non-broadcasting revisions in a non-draft state
Browse Repository
Passed
No Audits

Mar 4 2018

584495215301 Show lint messages in deleted files on the left-hand side of the change
Author
epriestley
Revisions
D19171: Show lint messages in deleted files on the left-hand side of the change
Browse Repository
Passed
No Audits

Feb 22 2018

4c7370a1a3b0 Make the filetree view width sticky across show/hide and reload
Author
epriestley
Revisions
D19129: Make the filetree view width sticky across show/hide and reload
Browse Repository
Passed
No Audits

Oct 9 2017

9bd6a3705559 Fix spelling
Author
0
Revisions
D18693: Fix spelling
Browse Repository
Failed
No Audits

Sep 29 2017

fe646ec32828 Mark Owners package reviewers which own nothing in the current diff
Author
epriestley
Revisions
D18663: Mark Owners package reviewers which own nothing in the current diff
Browse Repository
Passed
No Audits

Sep 15 2017

8982e3e52dd8 Update major RefCursor callsites to work properly with RefPosition
Author
epriestley
Revisions
D18614: Update major RefCursor callsites to work properly with RefPosition
Browse Repository
Passed
No Audits

Sep 13 2017

c310f08b7a5c Work around workflow blocking error with duplicate "master" refs in "Land…
Author
epriestley
Revisions
D18599: Work around workflow blocking error with duplicate "master" refs in "Land Revision"
Browse Repository
Passed
No Audits

Sep 6 2017

818b90cf12d4 Update Create Diff page for new Edit UI
Author
Chad Little <chad@phacility.com>
Revisions
D18529: Update Create Diff page for new Edit UI
Browse Repository
Passed
No Audits

Aug 11 2017

50dfdb8d0355 Replace legacy Differential queries for "open" revisions with a modern mechanism
Author
epriestley
Revisions
D18395: Replace legacy Differential queries for "open" revisions with a modern mechanism
Browse Repository
Passed
No Audits

Aug 9 2017

46d1596bf797 Pull legacy revision query status filters out of the main Query class
Author
epriestley
Revisions
D18343: Pull legacy revision query status filters out of the main Query class
Browse Repository
Passed
No Audits

70088f7eec8f Continue reducing callsites to ArcanistDifferentialRevisionStatus
Author
epriestley
Revisions
D18340: Continue reducing callsites to ArcanistDifferentialRevisionStatus
Browse Repository
Passed
No Audits

Jul 26 2017

e47f85cd98b8 In Differential, filter repository operations to just "Land" operations again
Author
epriestley
Revisions
D18281: In Differential, filter repository operations to just "Land" operations again
Browse Repository
Passed
No Audits

Jul 25 2017

1588d3e224fe In Differential, render status for any active Drydock repository operation, not…
Author
epriestley
Revisions
D18276: In Differential, render status for any active Drydock repository operation, not just "Land" operations
Browse Repository
Passed
No Audits

Jun 26 2017

d4632f4b78a0 Restore "Land Revision" action to UI
Author
epriestley
Revisions
D18154: Restore "Land Revision" action to UI
Browse Repository
Passed
No Audits

Jun 23 2017

219ae8b6c950 Remove old "Landing Strategy" code
Author
epriestley
Revisions
D18150: Remove old "Landing Strategy" code
Browse Repository
Passed
No Audits

Jun 15 2017

9b93697d52f4 Move "List Inline Comments" to the inline header dropdown menu
Author
epriestley
Revisions
D18129: Move "List Inline Comments" to the inline header dropdown menu
Browse Repository
Passed
No Audits

Jun 12 2017

283a95d2aae0 Build a page for viewing all inline comments
Author
Chad Little <chad@phacility.com>
Revisions
D18112: Build a page for viewing all inline comments
Browse Repository
Passed
No Audits

Jun 5 2017

d3c464a610bc Separate button CSS classes
Author
Chad Little <chad@phacility.com>
Revisions
D18077: Separate button CSS classes
Browse Repository
Passed
No Audits

May 16 2017

588a66c04d03 Move most Differetial keyboard shortcuts into DiffChangesetList
Author
epriestley
Revisions
D17859: Move most Differetial keyboard shortcuts into DiffChangesetList
Browse Repository
Passed
No Audits

Apr 4 2017

873b39be8211 Remove PhabricatorFile::buildFromFileDataOrHash()
Author
epriestley
Revisions
D17617: Remove PhabricatorFile::buildFromFileDataOrHash()
Browse Repository
Passed
No Audits

45b386596e62 Make the Files "TTL" API more structured
Author
epriestley
Revisions
D17616: Make the Files "TTL" API more structured
Browse Repository
Passed
No Audits

Mar 28 2017

2fbc9a52da9b Allow users to "Force accept" package reviews if they own a more general package
Author
epriestley
Revisions
D17569: Allow users to "Force accept" package reviews if they own a more general package
Browse Repository
Passed
No Audits

Mar 20 2017

a15df4f8d580 Rename "needReviewerStatus()" into "needReviewers()"
Author
epriestley
Revisions
D17519: Rename "needReviewerStatus()" into "needReviewers()"
Browse Repository
Passed
No Audits

d179d0150c4c Remove obsolete "relationships" code from Differential
Author
epriestley
Revisions
D17518: Remove obsolete "relationships" code from Differential
Browse Repository
Passed
No Audits

Mar 16 2017

7626ec0ce10e Correct an issue where "View Raw File" in Differential generated a file with…
Author
epriestley
Revisions
D17504: Correct an issue where "View Raw File" in Differential generated a file with overbroad permissions
Browse Repository
Passed
No Audits

Feb 1 2017

9b92e56dfc03 Don't link "Dxxx" on Differential revision pages
Author
epriestley
Revisions
D17283: Don't link "Dxxx" on Differential revision pages
Browse Repository
Passed
No Audits

Jan 13 2017

7276af6a81f4 Make yellow "draft" bubbles more generic
Author
epriestley
Revisions
D17205: Make yellow "draft" bubbles more generic
Browse Repository
Passed
No Audits

Jan 11 2017

b5722a99635a Use EditEngine stacked comments in Diffusion
Author
epriestley
Revisions
D17183: Use EditEngine stacked comments in Diffusion
Browse Repository
Passed
No Audits

Jan 9 2017

fda83094ac59 Restore missing behavior for Differential keyboard navigation
Author
epriestley
Revisions
D17166: Restore missing behavior for Differential keyboard navigation
Browse Repository
Passed
No Audits

Jan 1 2017

65c1c758ed26 Use extended policies in Differential diffs
Author
epriestley
Revisions
D17123: Use extended policies in Differential diffs
Browse Repository
Passed
No Audits

Dec 31 2016

9b4090af5565 Restore quote and warning behaviors to Differential EditEngine comment area
Author
epriestley
Revisions
D17117: Restore quote and warning behaviors to Differential EditEngine comment area
Browse Repository
Passed
No Audits

18249b097fb6 Make inline comment preview and submission mostly work on EditEngine
Author
epriestley
Revisions
D17116: Make inline comment preview and submission mostly work on EditEngine
Browse Repository
Passed
No Audits

c05306d746d7 Move Differential to EditEngine comments
Author
epriestley
Revisions
D17106: Move Differential to EditEngine comments
Browse Repository
Passed
No Audits

Dec 16 2016

28d74ae572f3 Rename Differenital "EditPro" controller back to "Edit"
Author
epriestley
Revisions
D17091: Rename Differenital "EditPro" controller back to "Edit"
Browse Repository
Passed
No Audits

Dec 14 2016

102ea3cfa41d Replace Differential Edit controller with EditEngine-driven EditPro controller
Author
epriestley
Revisions
D17054: Replace Differential Edit controller with EditEngine-driven EditPro controller
Browse Repository
Passed
No Audits

32ce21a18197 Allow the new Differential EditEngine form to create/update diffs for revisions
Author
epriestley
Revisions
D17053: Allow the new Differential EditEngine form to create/update diffs for revisions
Browse Repository
Passed
No Audits

Dec 13 2016

eda64b85497b Add a very basic EditPro controller for Differential
Author
epriestley
Revisions
D17043: Add a very basic EditPro controller for Differential
Browse Repository
Passed
No Audits

77fa1ea73835 Rename "DifferentialReviewer" to "DifferentialReviewerProxy"
Author
epriestley
Revisions
D17041: Rename "DifferentialReviewer" to "DifferentialReviewerProxy"
Browse Repository
Passed
No Audits

Sep 19 2016

adf9d5ffdd61 Removed willProcessRequest from DifferentialRevisionLandController
Author
jcox
Revisions
D16572: Removed willProcessRequest from DifferentialRevisionLandController
Browse Repository
Passed
No Audits

Sep 2 2016

31c5f39506bd Show broken units in revision history
Author
avivey
Revisions
D16483: Show broken units in revision history
Browse Repository
Passed
No Audits

Jul 13 2016

b6daa049de73 Rename Event "userPHID" to "hostPHID"
Author
epriestley
Revisions
D16291: Rename Event "userPHID" to "hostPHID"
Browse Repository
Passed
No Audits

Jul 1 2016

bc3ac3158448 Don't load the entire graph for tasks
Author
epriestley
Revisions
D16218: Don't load the entire graph for tasks
Browse Repository
Passed
No Audits

cc7ae60aaf10 Make the revision graph view more flexible
Author
epriestley
Revisions
D16213: Make the revision graph view more flexible
Browse Repository
Passed
No Audits

dc37789d530f Build that thing someone posted a screenshot of on Facebook
Author
epriestley
Revisions
D16210: Build that thing someone posted a screenshot of on Facebook
Browse Repository
Passed
No Audits

6c7e392f8936 Merge "Table of Contents", "Local Commits", "Update History" and "Similar…
Author
epriestley
Revisions
D16209: Merge "Table of Contents", "Local Commits", "Update History" and "Similar Revisions"
Browse Repository
Passed
No Audits

5a4ecc7a9c5b Convert "Diff Details" tabs to PHUITabGroup
Author
epriestley
Revisions
D16206: Convert "Diff Details" tabs to PHUITabGroup
Browse Repository
Passed
No Audits

Jun 30 2016

7574f8dcf51a When all actions in a submenu are disabled, disable the submenu header
Author
epriestley
Revisions
D16201: When all actions in a submenu are disabled, disable the submenu header
Browse Repository
Passed
No Audits

Jun 29 2016

dc9283b85d71 Convert all standard relationship-editing actions to modern Relationships code
Author
epriestley
Revisions
D16193: Convert all standard relationship-editing actions to modern Relationships code
Browse Repository
Passed
No Audits

Jun 4 2016

fc45de29a6fa Modernize various menu collapse settings
Author
epriestley
Revisions
D16034: Modernize various menu collapse settings
Browse Repository
Passed
No Audits

Jun 3 2016

a34b769b4fea Prevent creation of inline comments with mismatched changesetID / revisionPHID
Author
epriestley
Revisions
D16031: Prevent creation of inline comments with mismatched changesetID / revisionPHID
Browse Repository
Passed
No Audits

Jun 2 2016

edfc6a69345a Convert some loadPreferences() to getUserSetting()
Author
epriestley
Revisions
D16004: Convert some loadPreferences() to getUserSetting()
Browse Repository
Passed
No Audits

May 30 2016

e81637a6c686 Fix some issues with the "Explain Why" dialog
Author
epriestley
Revisions
D15989: Fix some issues with the "Explain Why" dialog
Browse Repository
Passed
No Audits

Apr 7 2016

437ff2a71814 Normalize case on active operations
Author
Chad Little <chad@phacility.com>
Revisions
D15651: Normalize case on active operations
Browse Repository
Passed
No Audits

Apr 6 2016

8f67d59d2865 Bump font size on property headers
Author
Chad Little <chad@phacility.com>
Revisions
D15647: Bump font size on property headers
Browse Repository
Passed
No Audits

8aad862cd4e2 Normalize casing on property boxes
Author
Chad Little <chad@phacility.com>
Revisions
D15645: Normalize casing on property boxes
Browse Repository
Passed
No Audits