Diffusion Phabricator (master) History

phabricator/src/applications/differential
master

Apr 16 2020

894d9b658706 Remove Ferret function aliases and overrides
Author
epriestley
Revisions
D21130: Remove Ferret function aliases and overrides
Browse Repository
Passed
No Audits

Apr 13 2020

471e89a8b76d Add "uri" to "paste.search" API output
Author
epriestley
Revisions
D21105: Add "uri" to "paste.search" API output
Browse Repository
Passed
No Audits

19e0abcb27b4 Fix an issue where raw diffs that are not attached to revisions could skip…
Author
epriestley
Revisions
D21103: Fix an issue where raw diffs that are not attached to revisions could skip repository policy checks
Browse Repository
Passed
No Audits

5597f4e6f229 Add "uri" to the fields returned by "differential.revision.search"
Author
epriestley
Revisions
D21102: Add "uri" to the fields returned by "differential.revision.search"
Browse Repository
Passed
No Audits

Apr 5 2020

f1d1ec3d77f1 Add an "isDone" flag to "transaction.search" for Differential inline comments
Author
epriestley
Revisions
D21059: Add an "isDone" flag to "transaction.search" for Differential inline comments
Browse Repository
Passed
No Audits

Feb 15 2020

64cc4fe91515 Add a test to verify that all routing maps are plausibly valid, and remove some…
Author
epriestley
Revisions
D21000: Add a test to verify that all routing maps are plausibly valid, and remove some dead routes
Browse Repository
Passed
No Audits

Feb 13 2020

dc35ce79e484 Unprototype "Draft" mode in Differential
Author
epriestley
Revisions
D20983: Unprototype "Draft" mode in Differential
Browse Repository
Passed
No Audits

Feb 12 2020

f9b3e3360b0c Continue moving classes with no callers in libphutil or Arcanist to Phabricator
Author
epriestley
Revisions
D20977: Continue moving classes with no callers in libphutil or Arcanist to Phabricator
Browse Repository
Passed
No Audits

Jan 30 2020

ccf28a81121e Fix an issue where the last line of block-based diffs could be incorrectly…
Author
epriestley
Revisions
D20959: Fix an issue where the last line of block-based diffs could be incorrectly hidden
Browse Repository
Passed
No Audits

Jan 23 2020

b38449ce8f4b Implement an "Author's packages" Herald field for Differential
Author
epriestley
Revisions
D20947: Implement an "Author's packages" Herald field for Differential
Browse Repository
Passed
No Audits

Nov 9 2019

72f82abe0723 Improve recovery from panel action rendering exceptions, and mark "Changeset"…
Author
epriestley
Revisions
D20902: Improve recovery from panel action rendering exceptions, and mark "Changeset" queries as not suitable for panel generation
Browse Repository
Passed
No Audits

Nov 8 2019

d4491ddc225e Fix an issue with 1up diff block rendering for added or removed blocks
Author
epriestley
Revisions
D20897: Fix an issue with 1up diff block rendering for added or removed blocks
Browse Repository
Passed
No Audits

Oct 31 2019

b0d9f89c9535 Remove "State Icons" from handles
Author
epriestley
Revisions
D20882: Remove "State Icons" from handles
Browse Repository
Passed
No Audits

Oct 26 2019

292f8fc612bd Fix an issue where added or removed source files could incorrectly select a…
Author
epriestley
Revisions
D20866: Fix an issue where added or removed source files could incorrectly select a DocumentEngine
Browse Repository
Passed
No Audits

8ff0e3ab351f Support rich diff rendering with DocumentEngine for added/removed files
Author
epriestley
Revisions
D20865: Support rich diff rendering with DocumentEngine for added/removed files
Browse Repository
Passed
No Audits

Oct 17 2019

5dafabd5b4d0 Fix deprecated argument order for "implode()"
Author
epriestley
Revisions
D20858: Fix deprecated argument order for "implode()"
Browse Repository
Passed
No Audits

Oct 2 2019

9f7aaa8ee4cb Fix an issue where any diff which could possibly be rendered as Jupyter decided…
Author
epriestley
Revisions
D20850: Fix an issue where any diff which could possibly be rendered as Jupyter decided to render as Jupyter
Browse Repository
Passed
No Audits

Sep 30 2019

76d9912932bc Force unified abstract block diffs into roughly usable shape
Author
epriestley
Revisions
D20848: Force unified abstract block diffs into roughly usable shape
Browse Repository
Passed
No Audits

d9515e82a3ec Perform basic block interdiffs when diffing abstract blocks, and interdiff…
Author
epriestley
Revisions
D20845: Perform basic block interdiffs when diffing abstract blocks, and interdiff markdown in Jupyter notebooks
Browse Repository
Passed
No Audits

5afdc620db59 Make basic Juypter notebook rendering improvements and roughly support folding…
Author
epriestley
Revisions
D20844: Make basic Juypter notebook rendering improvements and roughly support folding unchanged context
Browse Repository
Passed
No Audits

a7f3316aa3df Improve sequencing of various content/header checks in abstract block diffs
Author
epriestley
Revisions
D20843: Improve sequencing of various content/header checks in abstract block diffs
Browse Repository
Passed
No Audits

Sep 26 2019

2c06815edb0f When rendering Jupyter notebook diffs, split code inputs into individual blocks
Author
epriestley
Revisions
D20840: When rendering Jupyter notebook diffs, split code inputs into individual blocks
Browse Repository
Passed
No Audits

Sep 25 2019

281598d65cfc Use a hash-and-diff strategy to produce a diff layout for block-based documents
Author
epriestley
Revisions
D20836: Use a hash-and-diff strategy to produce a diff layout for block-based documents
Browse Repository
Passed
No Audits

932d829af339 Improve behavior of inline comment highlight reticle for block diffs
Author
epriestley
Revisions
D20835: Improve behavior of inline comment highlight reticle for block diffs
Browse Repository
Passed
No Audits

a09b298d85d7 Correct DOM node metadata to let inline comments work against block-based diffs
Author
epriestley
Revisions
D20834: Correct DOM node metadata to let inline comments work against block-based diffs
Browse Repository
Passed
No Audits

1c4450d39f9b Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as…
Author
epriestley
Revisions
D20833: Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as blocks
Browse Repository
Passed
No Audits

7ae711ed3e0b Add a "View as..." option to diff dropdowns for selecting between document…
Author
epriestley
Revisions
D20832: Add a "View as..." option to diff dropdowns for selecting between document engines
Browse Repository
Passed
No Audits

bb71ef6ad6cd Render image diffs as abstract blocks diffs via DocumentEngine
Author
epriestley
Revisions
D20831: Render image diffs as abstract blocks diffs via DocumentEngine
Browse Repository
Passed
No Audits

a73f592d7d08 Allow DocumentEngine to elect into diff construction
Author
epriestley
Revisions
D20830: Allow DocumentEngine to elect into diff construction
Browse Repository
Passed
No Audits

Aug 22 2019

353155a2034e Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision.
Author
epriestley
Revisions
D20730: Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision.search"
Browse Repository
Passed
No Audits

5741514aeb5b When a client submits an overlong "sourcePath", truncate it and continue
Author
epriestley
Revisions
D20727: When a client submits an overlong "sourcePath", truncate it and continue
Browse Repository
Passed
No Audits

Jun 18 2019

753828649956 Fix missing link targets for "View Object" header buttons in HTML email
Author
epriestley
Revisions
D20586: Fix missing link targets for "View Object" header buttons in HTML email
Browse Repository
Passed
No Audits

Jun 17 2019

14b076578f8e In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes
Author
epriestley
Revisions
D20579: In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes
Browse Repository
Passed
No Audits

2bc045bab8d7 Fix another stray "msort()/msortv()" issue
Author
epriestley
Revisions
D20585: Fix another stray "msort()/msortv()" issue
Browse Repository
Passed
No Audits

Jun 4 2019

760406762a6f When a revision is closed, always promote it out of draft
Author
epriestley
Revisions
D20565: When a revision is closed, always promote it out of draft
Browse Repository
Passed
No Audits

May 30 2019

9a32a563f047 Add a "View Task" button to HTML mail from Maniphest
Author
epriestley
Revisions
D20561: Add a "View Task" button to HTML mail from Maniphest
Browse Repository
Passed
No Audits

May 22 2019

b95bf722d55e Drop the "update revision with commit diff" transaction if the revision is…
Author
epriestley
Revisions
D20545: Drop the "update revision with commit diff" transaction if the revision is already closed
Browse Repository
Passed
No Audits

1eff4fdca332 Prevent "Differential Revision: ..." from counting as a mention in commit…
Author
epriestley
Revisions
D20544: Prevent "Differential Revision: ..." from counting as a mention in commit messages
Browse Repository
Passed
No Audits

fa4dcaa3aaff Stabilize sorting of feed stories with similar strength
Author
epriestley
Revisions
D20540: Stabilize sorting of feed stories with similar strength
Browse Repository
Passed
No Audits

May 21 2019

7c1f6519e0b2 Support "none()" in Differential to find revisions with no (un-resigned)…
Author
epriestley
Revisions
D20537: Support "none()" in Differential to find revisions with no (un-resigned) reviewers
Browse Repository
Passed
No Audits

May 16 2019

6bff2cee22fc Improve the performance of tab replacement in common cases
Author
epriestley
Revisions
D20477: Improve the performance of tab replacement in common cases
Browse Repository
Passed
No Audits

4a3481a49384 Enrich "draft", "summary", and "testPlan" transactions from Differential in…
Author
epriestley
Browse Repository
Passed
No Audits

May 7 2019

7a8d489ebdbd Fix a HunkParser typo, "identcal" -> "identical"
Author
epriestley
Browse Repository
Passed
No Audits

May 1 2019

a15b0063df3d Add "Revision has passing builds" Herald rules for commit content (pushes) and…
Author
epriestley
Browse Repository
Passed
No Audits

a78f141b3fa8 Unify code for parsing "Reverts X" magic, and when something "reverts <hash>"…
Author
epriestley
Browse Repository
Passed
No Audits

Apr 30 2019

6eae75d8f2ff When building a synthetic diff in Differential, adjust diff properties correctly
Author
epriestley
Browse Repository
Passed
No Audits

Apr 24 2019

a2d3d8edeb93 Move "update related object after commit" to a separate worker in the task queue
Author
epriestley
Revisions
D20463: Move "update related object after commit" to a separate worker in the task queue
Browse Repository
Passed
No Audits

42c02557e4e3 Remove all remaining readers and writers for TABLE_COMMIT
Author
epriestley
Revisions
D20461: Remove all remaining readers and writers for TABLE_COMMIT
Browse Repository
Passed
No Audits

ec0085fd0c7a Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
Author
epriestley
Revisions
D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
Browse Repository
Passed
No Audits

7e8dc0742bdc Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"
Author
epriestley
Revisions
D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"
Browse Repository
Passed
No Audits

Apr 23 2019

7b8ac020b521 Change "Revision Close" story to use commit identities only with no fallback to…
Author
epriestley
Revisions
D20460: Change "Revision Close" story to use commit identities only with no fallback to commit data
Browse Repository
Passed
No Audits

Apr 17 2019

5b6d6c4fb313 Use repository identities, not denormalized strings, to identify authors for…
Author
epriestley
Revisions
D20418: Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories
Browse Repository
Passed
No Audits

4b8a67ccde91 Index and show Owners packages affected by Herald rules
Author
epriestley
Revisions
D20413: Index and show Owners packages affected by Herald rules
Browse Repository
Passed
No Audits

Apr 11 2019

d02256df3ca5 Remove very old "vsDiff" data from commit update / diff extraction pipeline
Author
epriestley
Revisions
D20395: Remove very old "vsDiff" data from commit update / diff extraction pipeline
Browse Repository
Passed
No Audits

Apr 10 2019

9e65e6c50342 Support "JIRA Issue URIs" as a Herald field for revisions
Author
epriestley
Revisions
D20386: Support "JIRA Issue URIs" as a Herald field for revisions
Browse Repository
Passed
No Audits

Apr 2 2019

c9d3fb2ac5b6 Fix the incorrect link target for "Create Revision" as a Menu Item
Author
epriestley
Revisions
D20360: Fix the incorrect link target for "Create Revision" as a Menu Item
Browse Repository
Passed
No Audits

Apr 1 2019

cddbe306f927 Correct a case where a single-hunk diff may incorrectly be identified as multi…
Author
epriestley
Revisions
D20363: Correct a case where a single-hunk diff may incorrectly be identified as multi-hunk by the Scope engine
Browse Repository
Passed
No Audits

Mar 19 2019

d4847c3eeb78 Convert simple query subclasses to use internal cursors
Author
epriestley
Revisions
D20292: Convert simple query subclasses to use internal cursors
Browse Repository
Passed
No Audits

Mar 7 2019

a3ebaac0f026 Tweak the visual style of the ">>" / "<<" depth change indicators slightly
Author
epriestley
Revisions
D20251: Tweak the visual style of the ">>" / "<<" depth change indicators slightly
Browse Repository
Passed
No Audits

Mar 6 2019

7e4681234467 Add a warning to revision timelines when changes land with ongoing or failed…
Author
epriestley
Revisions
D20239: Add a warning to revision timelines when changes land with ongoing or failed builds
Browse Repository
Passed
No Audits

718cdc24471a Implement Build Plan "Hold Drafts" behavior
Author
epriestley
Revisions
D20232: Implement Build Plan "Hold Drafts" behavior
Browse Repository
Passed
No Audits

Mar 5 2019

cc8dda629905 Recognize the official "Go" magic regexp for generated code as generated
Author
epriestley
Revisions
D20237: Recognize the official "Go" magic regexp for generated code as generated
Browse Repository
Passed
No Audits

Feb 28 2019

814e6d2de927 Add more type checking to transactions queued by Herald
Author
epriestley
Revisions
D20214: Add more type checking to transactions queued by Herald
Browse Repository
Passed
No Audits

Feb 25 2019

dc9aaa0fc2bf Fix a stray "%Q" warning when hiding/showing inline comments
Author
epriestley
Revisions
D20212: Fix a stray "%Q" warning when hiding/showing inline comments
Browse Repository
Passed
No Audits

Feb 20 2019

1b8325642112 Don't enable the "ScopeEngine" or try to identify scope context for diffs…
Author
epriestley
Revisions
D20198: Don't enable the "ScopeEngine" or try to identify scope context for diffs without context
Browse Repository
Passed
No Audits

f1a035d5c2c6 In Differential, give the "moved/copied from" gutter a more clear visual look
Author
epriestley
Revisions
D20197: In Differential, give the "moved/copied from" gutter a more clear visual look
Browse Repository
Passed
No Audits

a33409991c27 Remove an old Differential selection behavior
Author
epriestley
Revisions
D20196: Remove an old Differential selection behavior
Browse Repository
Passed
No Audits

Feb 19 2019

cf048f4402fe Tweak some display behaviors for indent indicators
Author
epriestley
Revisions
D20195: Tweak some display behaviors for indent indicators
Browse Repository
Passed
No Audits

fe7047d12d69 Display some invisible/nonprintable characters in diffs by default
Author
epriestley
Revisions
D20194: Display some invisible/nonprintable characters in diffs by default
Browse Repository
Passed
No Audits

efccd75ae371 Correct various minor diff copy behaviors
Author
epriestley
Revisions
D20192: Correct various minor diff copy behaviors
Browse Repository
Passed
No Audits

37f12a05ea62 Behold! Copy text from either side of a diff!
Author
epriestley
Revisions
D20191: Behold! Copy text from either side of a diff!
Browse Repository
Passed
No Audits

d4b96bcf6b01 Remove hidden zero-width spaces affecting copy behavior
Author
epriestley
Revisions
D20189: Remove hidden zero-width spaces affecting copy behavior
Browse Repository
Passed
No Audits

98fe8fae4a90 Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers
Author
epriestley
Revisions
D20188: Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers
Browse Repository
Passed
No Audits

3f8eccdaec8f Put some whitespace behaviors back, but only for "diff alignment", not display
Author
epriestley
Revisions
D20187: Put some whitespace behaviors back, but only for "diff alignment", not display
Browse Repository
Passed
No Audits

5310f1cdd90e Remove all whitespace options/configuration everywhere
Author
epriestley
Revisions
D20185: Remove all whitespace options/configuration everywhere
Browse Repository
Passed
No Audits

661c758ff9d1 Render indent depth changes more clearly
Author
epriestley
Revisions
D20181: Render indent depth changes more clearly
Browse Repository
Passed
No Audits

92abe3c8fb84 Extract scope line selection logic from the diff rendering engine so it can…
Author
epriestley
Revisions
D20171: Extract scope line selection logic from the diff rendering engine so it can reasonably be iterated on
Browse Repository
Passed
No Audits

Feb 16 2019

c5e16f9bd996 Give HarbormasterBuildUnitMessage a real Query class
Author
epriestley
Revisions
D20179: Give HarbormasterBuildUnitMessage a real Query class
Browse Repository
Passed
No Audits

Feb 14 2019

5892c7898603 Replace all "setQueryParam()" calls with "remove/replaceQueryParam()"
Author
epriestley
Revisions
D20154: Replace all "setQueryParam()" calls with "remove/replaceQueryParam()"
Browse Repository
Passed
No Audits

Feb 13 2019

a7bf279fd517 Don't try to publish build results to bare diffs
Author
epriestley
Revisions
D20156: Don't try to publish build results to bare diffs
Browse Repository
Passed
No Audits

Feb 12 2019

1fd69f788cee Replace "getQueryParams()" callsites in Phabricator
Author
epriestley
Revisions
D20141: Replace "getQueryParams()" callsites in Phabricator
Browse Repository
Passed
No Audits

Feb 5 2019

b8fe991ba28e Improve description text in the "Create Diff" form
Author
leoluk
Revisions
D20092: Improve description text in the "Create Diff" form
Browse Repository
Passed
No Audits

Feb 1 2019

bc61d09f5553 Allow parent and child revisions to be modified via Conduit
Author
epriestley
Revisions
D20075: Allow parent and child revisions to be modified via Conduit
Browse Repository
Passed
No Audits

Jan 31 2019

6bcfc212ebd4 Allow diff change detection to complete for Mercurial changes which remove a…
Author
epriestley
Revisions
D20056: Allow diff change detection to complete for Mercurial changes which remove a binary file
Browse Repository
Passed
No Audits

Jan 18 2019

c125ab7a42bf Remove "metamta.*.subject-prefix" options
Author
epriestley
Revisions
D19993: Remove "metamta.*.subject-prefix" options
Browse Repository
Passed
No Audits

Jan 16 2019

e3aa043a0272 Allow multiple mail receivers to react to an individual email
Author
epriestley
Revisions
D19952: Allow multiple mail receivers to react to an individual email
Browse Repository
Passed
No Audits

Jan 4 2019

73e3057c52f4 Rename "MetaMTA" mail attachments and add more mail message objects
Author
epriestley
Revisions
D19954: Rename "MetaMTA" mail attachments and add more mail message objects
Browse Repository
Passed
No Audits

dda3ff89e06d Consolidate some application email receiver code in preparation for API changes
Author
epriestley
Revisions
D19950: Consolidate some application email receiver code in preparation for API changes
Browse Repository
Passed
No Audits

Dec 20 2018

11cf8f05b176 Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface
Author
epriestley
Revisions
D19920: Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface
Browse Repository
Passed
No Audits

937e88c399ab Remove obsolete, no-op implementations of "willRenderTimeline()"
Author
epriestley
Revisions
D19919: Remove obsolete, no-op implementations of "willRenderTimeline()"
Browse Repository
Passed
No Audits

6c43d1d52cbd Remove "willRenderTimeline()" from ApplicationTransactionInterface
Author
epriestley
Revisions
D19918: Remove "willRenderTimeline()" from ApplicationTransactionInterface
Browse Repository
Passed
No Audits

Dec 10 2018

46feccdfcf19 Share more inline "Done" code between Differential and Diffusion
Author
epriestley
Revisions
D19858: Share more inline "Done" code between Differential and Diffusion
Browse Repository
Passed
No Audits

1029081b2805 Correct two straggling "%Q" + "implode(...)" callsites in Revision updates
Author
epriestley
Revisions
D19846: Correct two straggling "%Q" + "implode(...)" callsites in Revision updates
Browse Repository
Passed
No Audits

Nov 28 2018

c457d23a1d30 Tailor the "no reviewers on this revision" warnings to handle the case where…
Author
epriestley
Revisions
D19834: Tailor the "no reviewers on this revision" warnings to handle the case where all reviewers have resigned
Browse Repository
Passed
No Audits

2f11001f6e3c Allow "Change Subtype" to be selected from the comment action stack
Author
epriestley
Revisions
D19842: Allow "Change Subtype" to be selected from the comment action stack
Browse Repository
Passed
No Audits

Nov 26 2018

9473f60a362f Allow "Abandoned" revisions to be commandeered
Author
epriestley
Revisions
D19835: Allow "Abandoned" revisions to be commandeered
Browse Repository
Passed
No Audits

bcc90d8c6b8c Fix an off-by-one error affecting mail rendering of inlines on the final line…
Author
epriestley
Revisions
D19838: Fix an off-by-one error affecting mail rendering of inlines on the final line of a file
Browse Repository
Passed
No Audits

97e7ef0f015c When the last rejecting reviewer resigns from a revision, return it to "Needs…
Author
epriestley
Revisions
D19840: When the last rejecting reviewer resigns from a revision, return it to "Needs Review"
Browse Repository
Passed
No Audits

Nov 16 2018

b2e91d220539 Move the "container updated" message for Buildables that build Diffs outside of…
Author
epriestley
Revisions
D19807: Move the "container updated" message for Buildables that build Diffs outside of the transaction
Browse Repository
Passed
No Audits

44c32839a68c When you "Request Review" of a draft revision, change the button text from…
Author
epriestley
Revisions
D19810: When you "Request Review" of a draft revision, change the button text from "Submit Quietly" to "Publish Revision"
Browse Repository
Passed
No Audits