Diffusion Phabricator (master) History

phabricator/src/applications/audit/editor
master

Mar 10 2021

ac2f5a10469a Modernize and clean up "PhabricatorAuditStatusConstants"
Author
epriestley
Revisions
D21599: Modernize and clean up "PhabricatorAuditStatusConstants"
Browse Repository
Passed
No Audits

2636d84d0c24 Remove very old Audit status constants and AuditRequest data
Author
epriestley
Revisions
D21598: Remove very old Audit status constants and AuditRequest data
Browse Repository
Passed
No Audits

May 4 2020

fe501bd7f736 Save drafts for inline comments currently being edited
Author
epriestley
Revisions
D21216: Save drafts for inline comments currently being edited
Browse Repository
Passed
No Audits

468aabd4ef30 When draft inline comments are submitted, disengage the editor
Author
epriestley
Revisions
D21188: When draft inline comments are submitted, disengage the editor
Browse Repository
Passed
No Audits

Apr 28 2020

a7b2327c34ac Fix an issue with "Auditors:" where an edge edit was used as a PHID list
Author
epriestley
Revisions
D21181: Fix an issue with "Auditors:" where an edge edit was used as a PHID list
Browse Repository
Passed
No Audits

Feb 4 2020

4904d7711ea1 When publishing a commit, copy "Related Tasks" from the associated revision (if…
Author
epriestley
Revisions
D20961: When publishing a commit, copy "Related Tasks" from the associated revision (if one exists)
Browse Repository
Passed
No Audits

Jun 18 2019

753828649956 Fix missing link targets for "View Object" header buttons in HTML email
Author
epriestley
Revisions
D20586: Fix missing link targets for "View Object" header buttons in HTML email
Browse Repository
Passed
No Audits

May 30 2019

9a32a563f047 Add a "View Task" button to HTML mail from Maniphest
Author
epriestley
Revisions
D20561: Add a "View Task" button to HTML mail from Maniphest
Browse Repository
Passed
No Audits

May 22 2019

1eff4fdca332 Prevent "Differential Revision: ..." from counting as a mention in commit…
Author
epriestley
Revisions
D20544: Prevent "Differential Revision: ..." from counting as a mention in commit messages
Browse Repository
Passed
No Audits

May 1 2019

a78f141b3fa8 Unify code for parsing "Reverts X" magic, and when something "reverts <hash>"…
Author
epriestley
Browse Repository
Passed
No Audits

Apr 25 2019

c0a4d1de13a8 Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker
Author
epriestley
Revisions
D20467: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker
Browse Repository
Passed
No Audits

Apr 24 2019

8f43c773b832 Remove nearly all remaining references to "Autoclose"
Author
epriestley
Revisions
D20465: Remove nearly all remaining references to "Autoclose"
Browse Repository
Passed
No Audits

Apr 18 2019

1cda1402c7c2 Do not publish/notify about commits which are not reachable from any…
Author
epriestley
Revisions
D20419: Do not publish/notify about commits which are not reachable from any "Autoclose" ref
Browse Repository
Passed
No Audits

Jan 18 2019

c125ab7a42bf Remove "metamta.*.subject-prefix" options
Author
epriestley
Revisions
D19993: Remove "metamta.*.subject-prefix" options
Browse Repository
Passed
No Audits

Jan 4 2019

73e3057c52f4 Rename "MetaMTA" mail attachments and add more mail message objects
Author
epriestley
Revisions
D19954: Rename "MetaMTA" mail attachments and add more mail message objects
Browse Repository
Passed
No Audits

Dec 10 2018

46feccdfcf19 Share more inline "Done" code between Differential and Diffusion
Author
epriestley
Revisions
D19858: Share more inline "Done" code between Differential and Diffusion
Browse Repository
Passed
No Audits

b88a87c43a28 Address a transaction issue with some audit actions not applying correctly
Author
epriestley
Revisions
D19845: Address a transaction issue with some audit actions not applying correctly
Browse Repository
Passed
No Audits

Sep 12 2018

cc3b6d57907b Fix a "withHasTransactions()" typo in AuditEditor
Author
epriestley
Revisions
D19667: Fix a "withHasTransactions()" typo in AuditEditor
Browse Repository
Passed
No Audits

Sep 10 2018

bae8a951143a Continue replacing Commit/Audit status checks with object-based checks
Author
epriestley
Revisions
D19647: Continue replacing Commit/Audit status checks with object-based checks
Browse Repository
Passed
No Audits

Sep 7 2018

16a6fc8341ea Allow reviewers to mark their own inlines as "Done" before they submit them
Author
epriestley
Revisions
D19634: Allow reviewers to mark their own inlines as "Done" before they submit them
Browse Repository
Passed
No Audits

Feb 10 2018

c64aae052ff6 Make sure auditors are attached to commits on new pathways
Author
epriestley
Browse Repository
Passed
Audit Required

Feb 8 2018

1cd3a593784a When users resign from revisions, stop expanding projects/packages to include…
Author
epriestley
Revisions
D19021: When users resign from revisions, stop expanding projects/packages to include them
Browse Repository
Passed
No Audits

f090fa7426e4 Use object PHIDs for "Thread-Topic" headers in mail
Author
epriestley
Revisions
D19012: Use object PHIDs for "Thread-Topic" headers in mail
Browse Repository
Passed
No Audits

Feb 2 2018

032f5b22941f Allow revisions to revert commits and one another, and commits to revert…
Author
epriestley
Revisions
D18978: Allow revisions to revert commits and one another, and commits to revert revisions
Browse Repository
Passed
No Audits

Mar 16 2017

65de9e9f5e7f Ignore "Auditors: author" when inferring auditors from commit messages
Author
epriestley
Revisions
D17507: Ignore "Auditors: author" when inferring auditors from commit messages
Browse Repository
Passed
No Audits

Jan 30 2017

bcbd4035fd18 Remove several pieces of audit-related code
Author
epriestley
Revisions
D17267: Remove several pieces of audit-related code
Browse Repository
Passed
No Audits

bc41c3f5a5b9 Use DifferentialCommitMessageParser and Modular Transactions to implement…
Author
epriestley
Revisions
D17262: Use DifferentialCommitMessageParser and Modular Transactions to implement "Auditors: ..."
Browse Repository
Passed
No Audits

Jan 27 2017

1be3ef022768 Make some Audit status comparisons more lax, so state transactions only post…
Author
epriestley
Revisions
D17258: Make some Audit status comparisons more lax, so state transactions only post once
Browse Repository
Passed
No Audits

Jan 25 2017

97cac83e9b0c Add a "Needs Verification" state to Audit
Author
epriestley
Revisions
D17252: Add a "Needs Verification" state to Audit
Browse Repository
Passed
No Audits

ca182c7f48ca Clean up "Audit Authority" code, at least mostly
Author
epriestley
Revisions
D17251: Clean up "Audit Authority" code, at least mostly
Browse Repository
Passed
No Audits

b3912dd08848 Remove old Audit code "Action" transaction editing code
Author
epriestley
Revisions
D17250: Remove old Audit code "Action" transaction editing code
Browse Repository
Passed
No Audits

ed38642afc43 Give Audit an informational "This commit now requires (something)..."…
Author
epriestley
Revisions
D17243: Give Audit an informational "This commit now requires (something)..." transaction
Browse Repository
Passed
No Audits

Jan 12 2017

11861265fe94 Merge "Audit" more completely into "Diffusion"
Author
epriestley
Revisions
D17186: Merge "Audit" more completely into "Diffusion"
Browse Repository
Passed
No Audits

Jan 11 2017

b5722a99635a Use EditEngine stacked comments in Diffusion
Author
epriestley
Revisions
D17183: Use EditEngine stacked comments in Diffusion
Browse Repository
Passed
No Audits

Sep 9 2016

8d048f06ab51 Fix a Herald issue where testing commits against rules with revision-related…
Author
epriestley
Revisions
D16522: Fix a Herald issue where testing commits against rules with revision-related conditions would fail
Browse Repository
Passed
No Audits

Jun 13 2016

65634781b44f Don't re-mention users for comment edits
Author
epriestley
Revisions
D16108: Don't re-mention users for comment edits
Browse Repository
Passed
No Audits

May 24 2016

74e117ae41dd Don't send mail to "uninteresting" auditors
Author
epriestley
Revisions
D15970: Don't send mail to "uninteresting" auditors
Browse Repository
Passed
No Audits

May 17 2016

de1a30efc740 Improve audit behavior for "uninteresting" auditors
Author
epriestley
Revisions
D15940: Improve audit behavior for "uninteresting" auditors
Browse Repository
Passed
No Audits

Mar 5 2016

0569919eab54 Fix some visibility issues with inline comments in Diffusion
Author
epriestley
Revisions
D15407: Fix some visibility issues with inline comments in Diffusion
Browse Repository
Passed
No Audits

Jan 2 2016

37532a0bf001 Remove various additional calls to getCallsign()
Author
epriestley
Revisions
D14927: Remove various additional calls to getCallsign()
Browse Repository
Passed
No Audits

Nov 28 2015

0d01dab5a375 Partially revert D14511 to fix "INLINE COMMENTS" in mail
Author
epriestley
Revisions
D14589: Partially revert D14511 to fix "INLINE COMMENTS" in mail
Browse Repository
Passed
No Audits

Nov 23 2015

2047483cc046 Render Remarkup in emails
Author
joshuaspence
Revisions
D14511: Render Remarkup in emails
Browse Repository
Passed
No Audits

Aug 22 2015

3ef270b2926e Allow transaction publishers to pass binary data to workers
Author
epriestley
Revisions
D13939: Allow transaction publishers to pass binary data to workers
Browse Repository
No Builds
No Audits

Aug 17 2015

6cfeb9e54014 Further modernize OwnersPackageQuery
Author
epriestley
Revisions
D13922: Further modernize OwnersPackageQuery
Browse Repository
No Builds
No Audits

Aug 8 2015

79f2e81f38be Various linter fixes
Author
joshuaspence
Revisions
D13808: Various linter fixes
Browse Repository
No Builds
No Audits

Aug 3 2015

6f6d88794b25 Modularize the Diffusion "Add Auditors" Herald action
Author
epriestley
Browse Repository
No Builds
Audited

776caa507b15 Modularize the Harbormaster "Run build plan" Herald action
Author
epriestley
Browse Repository
No Builds
Audited

Jun 9 2015

f47e69c01594 Mark some strings for translation
Author
joshuaspence
Revisions
D13200: Mark some strings for translation
Browse Repository
No Builds
No Audits

Jun 8 2015

ab5f7a868e01 Use standard subscribers effects in Herald Adapter for commits
Author
epriestley
Revisions
D13181: Use standard subscribers effects in Herald Adapter for commits
Browse Repository
No Builds
No Audits

Jun 4 2015

04a22a8fa443 Fix slop with previous patch, perhaps
Author
epriestley
Browse Repository
No Builds
Audited

ef43a9844023 Reload commits before publishing mail about them
Author
epriestley
Browse Repository
No Builds
Audited

a9ceebbdb116 Move all ApplicationTransaction publishing to daemons
Author
epriestley
Revisions
D13115: Move all ApplicationTransaction publishing to daemons
Browse Repository
No Builds
No Audits

May 22 2015

36e2d02d6ec5 phtize all the things
Author
joshuaspence
Revisions
D12797: phtize all the things
Browse Repository
No Builds
No Audits

May 19 2015

2154f17b3d7b Transactions - fix bug adding people to projects
Author
btrahan
Revisions
D12940: Transactions - fix bug adding people to projects
Browse Repository
No Builds
No Audits

01a8ba5a9798 Transactions - make TYPE_COMMENT implementation optional
Author
btrahan
Revisions
D12932: Transactions - make TYPE_COMMENT implementation optional
Browse Repository
No Builds
No Audits

18e0ee079132 Transactions - move TYPE_SUBSCRIBERS to require optional implementation
Author
btrahan
Revisions
D12930: Transactions - move TYPE_SUBSCRIBERS to require optional implementation
Browse Repository
No Builds
No Audits

16c8d44c37c9 Transactions - make customization of TYPE_EDGE optional
Author
btrahan
Revisions
D12929: Transactions - make customization of TYPE_EDGE optional
Browse Repository
No Builds
No Audits

May 17 2015

00136f05dd6d Allow adding Auditors with the singular noun.
Author
epriestley
Revisions
D10636: Allow adding Auditors with the singular noun.
Browse Repository
No Builds
No Audits

Apr 12 2015

9a49c8139374 Audit - fix a bug with unloaded repositories
Author
btrahan
Revisions
D12348: Audit - fix a bug with unloaded repositories
Browse Repository
No Builds
No Audits

Apr 6 2015

b16db61a87f3 Allow "send me an email" in personal rules to punch through settings
Author
epriestley
Revisions
D12300: Allow "send me an email" in personal rules to punch through settings
Browse Repository
No Builds
No Audits

Apr 1 2015

eb81fd15628f Expose all application mail receivers
Author
epriestley
Revisions
D12249: Expose all application mail receivers
Browse Repository
No Builds
No Audits

34db543d2774 Remove all application-specific reply handler class overrides
Author
epriestley
Revisions
D12233: Remove all application-specific reply handler class overrides
Browse Repository
No Builds
No Audits

Mar 24 2015

8c053f02a7cf Lift inline state transactions into core (in Diffusion)
Author
epriestley
Revisions
D12129: Lift inline state transactions into core (in Diffusion)
Browse Repository
No Builds
No Audits

cbb5a297d57b Publish "done" inline comment checkbox state in Diffusion
Author
epriestley
Revisions
D12128: Publish "done" inline comment checkbox state in Diffusion
Browse Repository
No Builds
No Audits

Mar 9 2015

2972894a4df9 Write "hasReplies" to database for inline comments
Author
epriestley
Revisions
D12025: Write "hasReplies" to database for inline comments
Browse Repository
No Builds
No Audits

Mar 4 2015

174dd220dfe6 Disable mentions in nonpublishing repositories
Author
epriestley
Revisions
D11966: Disable mentions in nonpublishing repositories
Browse Repository
No Builds
No Audits

Feb 19 2015

8599145b5eec Implement more consistent publishing rules for repositories
Author
epriestley
Revisions
D11826: Implement more consistent publishing rules for repositories
Browse Repository
No Builds
No Audits

Oct 30 2014

1ac84c1b59de Add addLinkSection to MailBody to properly format URIs
Author
chad
Revisions
D10762: Add addLinkSection to MailBody to properly format URIs
Browse Repository
No Builds
No Audits

Oct 21 2014

3bf770cb30f4 Repositories - don't send emails or publish feed stories about commits from…
Author
btrahan
Revisions
D10734: Repositories - don't send emails or publish feed stories about commits from importing repositories
Browse Repository
No Builds
No Audits

Oct 20 2014

ec82ad2d16ed Audit / Herald - make audits added via herald "required"
Author
btrahan
Revisions
D10730: Audit / Herald - make audits added via herald "required"
Browse Repository
No Builds
No Audits

Oct 17 2014

ba2963ecb3bb Diffusion - fix commits not importing fully
Author
btrahan
Revisions
D10723: Diffusion - fix commits not importing fully
Browse Repository
No Builds
No Audits

d9dd098e405b Audit - fix erroneous mentions of tasks, etc via commit message
Author
btrahan
Revisions
D10721: Audit - fix erroneous mentions of tasks, etc via commit message
Browse Repository
No Builds
No Audits

Oct 16 2014

ac83ff706023 Audit - add mail tags
Author
btrahan
Revisions
D10712: Audit - add mail tags
Browse Repository
No Builds
No Audits

Oct 15 2014

3dd92a78ac2a Move audit to application transactions
Author
btrahan
Revisions
D10705: Move audit to application transactions
Browse Repository
No Builds
No Audits

Aug 14 2014

cebbca9e08e4 Add a "USERS" section to audit emails listing commit authors and committers
Author
epriestley
Revisions
D10266: Add a "USERS" section to audit emails listing commit authors and committers
Browse Repository
No Builds
No Audits

Aug 12 2014

f6f9d78f3a07 Modularize mail tags
Author
epriestley
Revisions
D10238: Modularize mail tags
Browse Repository
No Builds
No Audits

Aug 11 2014

d38e89ef6ba5 Fix several issues with application interactions while importing commits
Author
epriestley
Revisions
D10221: Fix several issues with application interactions while importing commits
Browse Repository
No Builds
No Audits

Aug 4 2014

e8d272b0dad1 Use standard infrastructure to attach commits to other objects
Author
epriestley
Revisions
D10138: Use standard infrastructure to attach commits to other objects
Browse Repository
No Builds
No Audits

725e2fa41055 Write a "resign" audit relationship even if actor has no relationship
Author
epriestley
Revisions
D10137: Write a "resign" audit relationship even if actor has no relationship
Browse Repository
No Builds
No Audits

Aug 2 2014

b5750412c75b Apply normal Audit actions directly with Transaction editor
Author
epriestley
Revisions
D10128: Apply normal Audit actions directly with Transaction editor
Browse Repository
No Builds
No Audits

508260e4fef1 Apply `diffusion.createcomment` directly with transaction editor in Audit
Author
epriestley
Revisions
D10126: Apply `diffusion.createcomment` directly with transaction editor in Audit
Browse Repository
No Builds
No Audits

a297450aa97b Apply "accept" and "resign" actions with transactions
Author
epriestley
Revisions
D10125: Apply "accept" and "resign" actions with transactions
Browse Repository
No Builds
No Audits

78e164aea6e0 Use transactions to apply "resign" and "close" Audit actions
Author
epriestley
Revisions
D10124: Use transactions to apply "resign" and "close" Audit actions
Browse Repository
No Builds
No Audits

688f245a95be Use transactions to apply "add auditors" action in Audit
Author
epriestley
Revisions
D10123: Use transactions to apply "add auditors" action in Audit
Browse Repository
No Builds
No Audits

bb022d2376fb Minor, restore Audit getMailThreading method
Author
epriestley
Browse Repository
No Builds
Audited

950eeef4c09d Minor, restore Audit newReplyHandlerForCommit method
Author
epriestley
Browse Repository
No Builds
Audited

49bd5721c5a7 Use standard infrastructure for Feed in Audit
Author
epriestley
Revisions
D10114: Use standard infrastructure for Feed in Audit
Browse Repository
No Builds
No Audits

64736264a62d Use standard infrastructure for Audit email generation
Author
epriestley
Revisions
D10112: Use standard infrastructure for Audit email generation
Browse Repository
No Builds
No Audits

b787d3ef0df7 Use standard infrastructure for Audit search indexing
Author
epriestley
Revisions
D10110: Use standard infrastructure for Audit search indexing
Browse Repository
No Builds
No Audits

5b969fb5b809 Provide a transaction editor to perform Audit row writes
Author
epriestley
Revisions
D10109: Provide a transaction editor to perform Audit row writes
Browse Repository
No Builds
No Audits

89b942c183eb Move Audit to proper Subscriptions
Author
epriestley
Revisions
D10103: Move Audit to proper Subscriptions
Browse Repository
No Builds
No Audits

Jul 30 2014

98c2ad38e564 Fix audit commenting where there are only inlines
Author
btrahan
Revisions
D10078: Fix audit commenting where there are only inlines
Browse Repository
No Builds
No Audits

Jul 28 2014

f965126dc454 Migrate audit comments to transactions
Author
epriestley
Revisions
D10055: Migrate audit comments to transactions
Browse Repository
No Builds
No Audits

608e1d20b48a Write separate comments for every action in Audit
Author
epriestley
Revisions
D10052: Write separate comments for every action in Audit
Browse Repository
No Builds
No Audits

bf397480114d Build separate comments for each inline comment in Audit
Author
epriestley
Revisions
D10023: Build separate comments for each inline comment in Audit
Browse Repository
No Builds
No Audits

Jul 25 2014

970058927987 Allow audit email to generate from multiple transactions
Author
epriestley
Revisions
D10022: Allow audit email to generate from multiple transactions
Browse Repository
No Builds
No Audits

dc5c87f74cda Hide Audit comment table reads behind an API
Author
epriestley
Revisions
D10019: Hide Audit comment table reads behind an API
Browse Repository
No Builds
No Audits

8605a1808d01 Hide direct accesses to Audit inline comment table behind API
Author
epriestley
Revisions
D10016: Hide direct accesses to Audit inline comment table behind API
Browse Repository
No Builds
No Audits

Jun 9 2014

d0128afa2908 Applied various linter fixes.
Author
joshuaspence
Revisions
D9443: Applied various linter fixes.
Browse Repository
No Builds
No Audits

0a62f13464b8 Change double quotes to single quotes.
Author
joshuaspence
Revisions
D9431: Change double quotes to single quotes.
Browse Repository
No Builds
No Audits