Diffusion Phabricator (master) History

phabricator/src/applications
master

May 12 2020

acc1fa165519 Make "View as Document Type..." only show valid options
Author
epriestley
Revisions
D21241: Make "View as Document Type..." only show valid options
Browse Repository
Passed
No Audits

0cca40db3bc6 When creating an inline, save the current document engine
Author
epriestley
Revisions
D21240: When creating an inline, save the current document engine
Browse Repository
Passed
No Audits

May 8 2020

6dc20d1e2e71 Fix an issue where storage inlines are fed to InlineAdjustmentEngine
Author
epriestley
Revisions
D21239: Fix an issue where storage inlines are fed to InlineAdjustmentEngine
Browse Repository
Passed
No Audits

24ba66f106f2 Persist "Show Changeset" and improve path text selection
Author
epriestley
Revisions
D21236: Persist "Show Changeset" and improve path text selection
Browse Repository
Passed
No Audits

fa2d30ee3698 Lift inline comment draft behaviors to "InlineController"
Author
epriestley
Revisions
D21235: Lift inline comment draft behaviors to "InlineController"
Browse Repository
Passed
No Audits

May 7 2020

94a95efa059a Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
Author
epriestley
Revisions
D21234: Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
Browse Repository
Passed
No Audits

79107574a762 Remove "DifferentialInlineCommentQuery"
Author
epriestley
Revisions
D21233: Remove "DifferentialInlineCommentQuery"
Browse Repository
Passed
No Audits

983d77848b4c Move the "Inline List" view to "DiffInlineCommentQuery"
Author
epriestley
Revisions
D21232: Move the "Inline List" view to "DiffInlineCommentQuery"
Browse Repository
Passed
No Audits

af5b94b23473 Lift most "InlineController" querying to the base class
Author
epriestley
Revisions
D21231: Lift most "InlineController" querying to the base class
Browse Repository
Passed
No Audits

949b9163d006 Replace remaining pseudo-query methods on AuditInlineComment
Author
epriestley
Revisions
D21230: Replace remaining pseudo-query methods on AuditInlineComment
Browse Repository
Passed
No Audits

6c59db20a379 Replace "loadDraftComments()" with a Query
Author
epriestley
Revisions
D21229: Replace "loadDraftComments()" with a Query
Browse Repository
Passed
No Audits

d0593a5a788e Replace "loadDraftAndPublishedComments()" with a Query
Author
epriestley
Revisions
D21228: Replace "loadDraftAndPublishedComments()" with a Query
Browse Repository
Passed
No Audits

c1f1345cc053 Make InlineCommentQueries more robust/consistent
Author
epriestley
Revisions
D21227: Make InlineCommentQueries more robust/consistent
Browse Repository
Passed
No Audits

1656a2ff081a Allow inline comment storage objects to generate their own runtime objects
Author
epriestley
Revisions
D21226: Allow inline comment storage objects to generate their own runtime objects
Browse Repository
Passed
No Audits

397648855f8b Make the "attach_inlines" parameter to "differential.createcomment" a no-op
Author
epriestley
Revisions
D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op
Browse Repository
Passed
No Audits

May 6 2020

0067f1a521a0 Remove the obsolete "DiffusionInlineCommentPreviewController"
Author
epriestley
Revisions
D21224: Remove the obsolete "DiffusionInlineCommentPreviewController"
Browse Repository
Passed
No Audits

May 4 2020

a590db28b254 Fix an issue where non-ID changeset state keys were used as changeset IDs
Author
epriestley
Revisions
D21223: Fix an issue where non-ID changeset state keys were used as changeset IDs
Browse Repository
Passed
No Audits

6430d6d638eb Fix an intradiff error when the newer changeset does not exist
Author
epriestley
Revisions
D21220: Fix an intradiff error when the newer changeset does not exist
Browse Repository
Passed
No Audits

7fa47408a3c5 When a user submits "isEditing" inlines and chooses to publish them, publish…
Author
epriestley
Revisions
D21218: When a user submits "isEditing" inlines and chooses to publish them, publish their current draft state as-shown
Browse Repository
Passed
No Audits

fe501bd7f736 Save drafts for inline comments currently being edited
Author
epriestley
Revisions
D21216: Save drafts for inline comments currently being edited
Browse Repository
Passed
No Audits

27b7ba814a5a Don't consider empty inlines when considering whether a revision has draft…
Author
epriestley
Revisions
D21215: Don't consider empty inlines when considering whether a revision has draft comments or not
Browse Repository
Passed
No Audits

9307f57747b2 When rendering changesets, discard empty draft inline comments
Author
epriestley
Revisions
D21214: When rendering changesets, discard empty draft inline comments
Browse Repository
Passed
No Audits

f5ef341c9e35 Don't publish "empty" inline comments
Author
epriestley
Revisions
D21211: Don't publish "empty" inline comments
Browse Repository
Passed
No Audits

67da18e37478 When users submit "editing" inlines, warn them that their inlines will be saved
Author
epriestley
Revisions
D21191: When users submit "editing" inlines, warn them that their inlines will be saved
Browse Repository
Passed
No Audits

468aabd4ef30 When draft inline comments are submitted, disengage the editor
Author
epriestley
Revisions
D21188: When draft inline comments are submitted, disengage the editor
Browse Repository
Passed
No Audits

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Revisions
D21186: Make "editing" state persistent for inline comments
Browse Repository
Passed
No Audits

5ff0ae7d48a7 Add generic "attributes" storage to inline comment tables
Author
epriestley
Revisions
D21184: Add generic "attributes" storage to inline comment tables
Browse Repository
Passed
No Audits

17426a60f00a Fix an issue where text intradiff bodies may not render
Author
epriestley
Revisions
D21210: Fix an issue where text intradiff bodies may not render
Browse Repository
Passed
No Audits

May 3 2020

dade9773070c Provide a hint about how to quote search terms containing literal colons
Author
epriestley
Revisions
D21209: Provide a hint about how to quote search terms containing literal colons
Browse Repository
Passed
No Audits

May 1 2020

b2cfcda114a4 Provide detailed information about reviewer changes in "transaction.search"
Author
epriestley
Revisions
D21207: Provide detailed information about reviewer changes in "transaction.search"
Browse Repository
Passed
No Audits

b89e6c0fa91a Add "idea://" to the upstream editor whitelist
Author
epriestley
Revisions
D21206: Add "idea://" to the upstream editor whitelist
Browse Repository
Passed
No Audits

eab561bb8790 Add "uri" to the API results for File objects
Author
epriestley
Revisions
D21204: Add "uri" to the API results for File objects
Browse Repository
Passed
No Audits

fbbd2e35cb46 Make content more prominent in Files and move some details to the curtain
Author
epriestley
Revisions
D21201: Make content more prominent in Files and move some details to the curtain
Browse Repository
Passed
No Audits

d6928a3c2679 When creating a File storage object for a Paste, try to give it the same name…
Author
epriestley
Revisions
D21197: When creating a File storage object for a Paste, try to give it the same name as the Paste
Browse Repository
Passed
No Audits

3c1f393c812f When a Paste has a useful alternative rendering in Files, provide a hint
Author
epriestley
Revisions
D21196: When a Paste has a useful alternative rendering in Files, provide a hint
Browse Repository
Passed
No Audits

65a2b5e21934 Route hard-coded "/favicon.ico" requests to a favicon resource
Author
epriestley
Revisions
D21195: Route hard-coded "/favicon.ico" requests to a favicon resource
Browse Repository
Passed
No Audits

Apr 30 2020

304467feb2ae Stabilize fatals when a build has a build plan the viewer can't see because of…
Author
epriestley
Revisions
D21194: Stabilize fatals when a build has a build plan the viewer can't see because of policy restrictions
Browse Repository
Passed
No Audits

Apr 29 2020

b648a8584111 Fix an issue where the Maniphest burnup chart was trying to render a non-View…
Author
epriestley
Revisions
D21185: Fix an issue where the Maniphest burnup chart was trying to render a non-View object
Browse Repository
Passed
No Audits

Apr 28 2020

f21f1d8ab9e9 Update the diff table of contents to use hierarchical views and edit distance…
Author
epriestley
Revisions
D21183: Update the diff table of contents to use hierarchical views and edit distance renames
Browse Repository
Passed
No Audits

a7b2327c34ac Fix an issue with "Auditors:" where an edge edit was used as a PHID list
Author
epriestley
Revisions
D21181: Fix an issue with "Auditors:" where an edge edit was used as a PHID list
Browse Repository
Passed
No Audits

befeb17f6ff1 Improve the construction of synthetic "comparison/intradiff" changesets
Author
epriestley
Revisions
D21180: Improve the construction of synthetic "comparison/intradiff" changesets
Browse Repository
Passed
No Audits

Apr 27 2020

aa20faeaa5d1 Fix an invalid index access for synthetic lint inline comments from Harbormaster
Author
epriestley
Revisions
D21178: Fix an invalid index access for synthetic lint inline comments from Harbormaster
Browse Repository
Passed
No Audits

661700536579 Make Conduit "www-form-urlencoded" parsing of "true" and "false" case…
Author
epriestley
Revisions
D21177: Make Conduit "www-form-urlencoded" parsing of "true" and "false" case-insensitive
Browse Repository
Passed
No Audits

b5bed7b0fa87 Make omitting "value" from a transaction description an explicit error
Author
epriestley
Revisions
D21176: Make omitting "value" from a transaction description an explicit error
Browse Repository
Passed
No Audits

604811bfc554 Fix a Diffusion issue where commits that do not show changesets would…
Author
epriestley
Revisions
D21175: Fix a Diffusion issue where commits that do not show changesets would incorrectly try to render changesets
Browse Repository
Passed
No Audits

c12db282519d For changesets that affect binaries, use the new binary file content hash as an…
Author
epriestley
Revisions
D21174: For changesets that affect binaries, use the new binary file content hash as an effect hash
Browse Repository
Passed
No Audits

Apr 26 2020

b0c295e54509 Fix some PHP 7.4 array index access issues
Author
epriestley
Revisions
D21172: Fix some PHP 7.4 array index access issues
Browse Repository
Passed
No Audits

7355bb7f2956 Skip "null" lines when constructing raw documents for DocumentEngine rendering
Author
epriestley
Revisions
D21171: Skip "null" lines when constructing raw documents for DocumentEngine rendering
Browse Repository
Passed
No Audits

Apr 25 2020

a226d7413383 Use "rest/api/3/myself" to retrieve JIRA profile details, not…
Author
epriestley
Revisions
D21170: Use "rest/api/3/myself" to retrieve JIRA profile details, not "rest/auth/1/session"
Browse Repository
Passed
No Audits

40d2346f2965 Add a missing "null" check when rebuilding old/new diff content
Author
epriestley
Revisions
D21169: Add a missing "null" check when rebuilding old/new diff content
Browse Repository
Passed
No Audits

Apr 23 2020

d05d8f655896 Add a very forgiving GC for Differential viewstate information
Author
epriestley
Revisions
D21164: Add a very forgiving GC for Differential viewstate information
Browse Repository
Passed
No Audits

4793bfcb7c49 Don't show the "file tree" view on tablets/phones
Author
epriestley
Revisions
D21162: Don't show the "file tree" view on tablets/phones
Browse Repository
Passed
No Audits

d2572f8b335a Refine more Differential review state behaviors
Author
epriestley
Revisions
D21161: Refine more Differential review state behaviors
Browse Repository
Passed
No Audits

0ede616f314b Update the "View Options" menu for recent filetree changes
Author
epriestley
Revisions
D21160: Update the "View Options" menu for recent filetree changes
Browse Repository
Passed
No Audits

befbea2f00e6 Don't pass "No newline at end of file." annotations to DocumentEngines as…
Author
epriestley
Revisions
D21159: Don't pass "No newline at end of file." annotations to DocumentEngines as literal diff text
Browse Repository
Passed
No Audits

Apr 22 2020

60de1506fe3b Make "hidden" changesets sticky, and show hidden state in the filetree
Author
epriestley
Revisions
D21158: Make "hidden" changesets sticky, and show hidden state in the filetree
Browse Repository
Passed
No Audits

a72a66caa833 Mark "low importance" and "owned" changes in the filetree
Author
epriestley
Revisions
D21157: Mark "low importance" and "owned" changes in the filetree
Browse Repository
Passed
No Audits

ff88eb588eb4 Show change information in file icons in the filetree
Author
epriestley
Revisions
D21156: Show change information in file icons in the filetree
Browse Repository
Passed
No Audits

12eddb18fb78 Entirely replace the old filetree UI with the "flank" UI
Author
epriestley
Revisions
D21154: Entirely replace the old filetree UI with the "flank" UI
Browse Repository
Passed
No Audits

ba8071bbef50 Roughly style the new "flank" paths UI
Author
epriestley
Revisions
D21153: Roughly style the new "flank" paths UI
Browse Repository
Passed
No Audits

8cd1f9a30976 Generate file trees from changesets in the new flank UI
Author
epriestley
Revisions
D21152: Generate file trees from changesets in the new flank UI
Browse Repository
Passed
No Audits

646280972b88 Glue the new FormationView on top of the older Filetree view in Differential
Author
epriestley
Revisions
D21151: Glue the new FormationView on top of the older Filetree view in Differential
Browse Repository
Passed
No Audits

Apr 19 2020

ef69c7969f58 Restore editor behavior to Diffusion and support "\" shortcut
Author
epriestley
Revisions
D21149: Restore editor behavior to Diffusion and support "\" shortcut
Browse Repository
Passed
No Audits

f02024615ad3 Add "short name", "id", and "phid" variables for external editor URIs
Author
epriestley
Revisions
D21147: Add "short name", "id", and "phid" variables for external editor URIs
Browse Repository
Passed
No Audits

c79094d7a8bd Add static errors, supported protocols, and a dynamic function listing to…
Author
epriestley
Revisions
D21146: Add static errors, supported protocols, and a dynamic function listing to external editor settings page
Browse Repository
Passed
No Audits

7a79131bf279 Replace old hard-coded URI-based "changes saved" jank with new overgeneralized…
Author
epriestley
Revisions
D21144: Replace old hard-coded URI-based "changes saved" jank with new overgeneralized cookie-based "changes saved" jank
Browse Repository
Passed
No Audits

3984c14260d3 Tokenize external editor links so they can be safely materialized on the client
Author
epriestley
Revisions
D21143: Tokenize external editor links so they can be safely materialized on the client
Browse Repository
Passed
No Audits

416833561903 Remove the "Edit Multiple Files" external editor setting
Author
epriestley
Revisions
D21142: Remove the "Edit Multiple Files" external editor setting
Browse Repository
Passed
No Audits

8bdc7133521d Make the "Keyboard Shortcuts" dialog in Differential less hideous
Author
epriestley
Revisions
D21141: Make the "Keyboard Shortcuts" dialog in Differential less hideous
Browse Repository
Passed
No Audits

84cd4a385450 Move "External Editor" settings to a separate settings group
Author
epriestley
Revisions
D21140: Move "External Editor" settings to a separate settings group
Browse Repository
Passed
No Audits

c3c55d82ae9d Make "renderer", "engine", and "encoding" sticky across reloads in Differential…
Author
epriestley
Revisions
D21138: Make "renderer", "engine", and "encoding" sticky across reloads in Differential and Diffusion
Browse Repository
Passed
No Audits

8aac55cc57cb Make "Highlight As..." sticky across reloads in Diffusion and Differential
Author
epriestley
Revisions
D21137: Make "Highlight As..." sticky across reloads in Diffusion and Differential
Browse Repository
Passed
No Audits

Apr 17 2020

3adf082002aa When inlines would disable a file shield in a diff, still apply the shield if…
Author
epriestley
Revisions
D21136: When inlines would disable a file shield in a diff, still apply the shield if all the comments are collapsed
Browse Repository
Passed
No Audits

3d966d8a41f1 Add an "Open in External Editor" keystroke to Differential
Author
epriestley
Revisions
D21135: Add an "Open in External Editor" keystroke to Differential
Browse Repository
Passed
No Audits

83eb7447a196 When Owners packages are archived, annotate them in tokenizer results
Author
epriestley
Revisions
D21134: When Owners packages are archived, annotate them in tokenizer results
Browse Repository
Passed
No Audits

Apr 16 2020

ef1340bd3207 Add Ferret support to Paste
Author
amckinley
Revisions
D20650: Add Ferret support to Paste
Browse Repository
Passed
No Audits

2748f83e1225 Modularize Ferret fulltext functions
Author
epriestley
Revisions
D21131: Modularize Ferret fulltext functions
Browse Repository
Passed
No Audits

894d9b658706 Remove Ferret function aliases and overrides
Author
epriestley
Revisions
D21130: Remove Ferret function aliases and overrides
Browse Repository
Passed
No Audits

9bdf477f2fef Combine the two different ngram-splitting algorithms into a single engine
Author
epriestley
Revisions
D21128: Combine the two different ngram-splitting algorithms into a single engine
Browse Repository
Passed
No Audits

fb3f423279b2 Remove broken and unfixable "prefix" ngram behavior
Author
epriestley
Revisions
D21127: Remove broken and unfixable "prefix" ngram behavior
Browse Repository
Passed
No Audits

b1b9c844ac1a Remove unused "getAllFunctionFields()" from Ferret
Author
epriestley
Revisions
D21126: Remove unused "getAllFunctionFields()" from Ferret
Browse Repository
Passed
No Audits

Apr 15 2020

3573170dfacb Compress file downloads if the client sends "Accept-Encoding: gzip" and we…
Author
epriestley
Revisions
D21125: Compress file downloads if the client sends "Accept-Encoding: gzip" and we guess the file might compress alright
Browse Repository
Passed
No Audits

45665dd3b458 Hide "notification.servers" configuration and don't follow redirects from…
Author
epriestley
Revisions
D21123: Hide "notification.servers" configuration and don't follow redirects from Aphlict
Browse Repository
Passed
No Audits

b52fa9623837 Disable automatic decoding of "Content-Encoding" responses during "Accept…
Author
epriestley
Revisions
D21122: Disable automatic decoding of "Content-Encoding" responses during "Accept-Encoding" setup test
Browse Repository
Passed
No Audits

Apr 14 2020

0ea6d131e072 In Conduit responses, assert that Phabricator supports a "gzip" capability
Author
epriestley
Revisions
D21120: In Conduit responses, assert that Phabricator supports a "gzip" capability
Browse Repository
Passed
No Audits

6b05d2be287e Add a setup warning to detect "SetInputFilter DEFLATE" and other "Content…
Author
epriestley
Revisions
D21116: Add a setup warning to detect "SetInputFilter DEFLATE" and other "Content-Encoding" request mangling
Browse Repository
Passed
No Audits

99cbc2077897 Reduce the verbosity of the "Aphlict" log
Author
epriestley
Revisions
D21115: Reduce the verbosity of the "Aphlict" log
Browse Repository
Passed
No Audits

59c855276b0b Provide a "--local" flag to "bin/conduit call" to force in-process execution
Author
epriestley
Revisions
D21114: Provide a "--local" flag to "bin/conduit call" to force in-process execution
Browse Repository
Passed
No Audits

b3a8754013cc Make the Ferret query compiler keep functions sticky across non-initial quoted…
Author
epriestley
Revisions
D21111: Make the Ferret query compiler keep functions sticky across non-initial quoted tokens
Browse Repository
Passed
No Audits

143f86d60b5a Tighten query compiler rules around spaces inside and after operators
Author
epriestley
Revisions
D21109: Tighten query compiler rules around spaces inside and after operators
Browse Repository
Passed
No Audits

8fa8d0e6483c Make Ferret query functions sticky only if their values are not quoted
Author
epriestley
Revisions
D21108: Make Ferret query functions sticky only if their values are not quoted
Browse Repository
Passed
No Audits

f31b9987ba1b Add "absent" and "present" field operators to the Ferret query compiler
Author
epriestley
Revisions
D21107: Add "absent" and "present" field operators to the Ferret query compiler
Browse Repository
Passed
No Audits

5c30a60e305f Tighten Ferret query parsing of empty tokens and empty functions
Author
epriestley
Revisions
D21106: Tighten Ferret query parsing of empty tokens and empty functions
Browse Repository
Passed
No Audits

Apr 13 2020

471e89a8b76d Add "uri" to "paste.search" API output
Author
epriestley
Revisions
D21105: Add "uri" to "paste.search" API output
Browse Repository
Passed
No Audits

19e0abcb27b4 Fix an issue where raw diffs that are not attached to revisions could skip…
Author
epriestley
Revisions
D21103: Fix an issue where raw diffs that are not attached to revisions could skip repository policy checks
Browse Repository
Passed
No Audits

5597f4e6f229 Add "uri" to the fields returned by "differential.revision.search"
Author
epriestley
Revisions
D21102: Add "uri" to the fields returned by "differential.revision.search"
Browse Repository
Passed
No Audits

Apr 10 2020

c3be82fe6e09 Fix an out-of-date API call on the destruction pathway for Pholio mocks
Author
epriestley
Revisions
D21081: Fix an out-of-date API call on the destruction pathway for Pholio mocks
Browse Repository
Passed
No Audits

Apr 6 2020

58fbf64a2786 Refine handling of "@task" attributes in Diviner
Author
epriestley
Revisions
D21062: Refine handling of "@task" attributes in Diviner
Browse Repository
Passed
No Audits

271e104c7ea4 Update DivinerAtomController for a long-ago change to the docblock parser API
Author
epriestley
Revisions
D21061: Update DivinerAtomController for a long-ago change to the docblock parser API
Browse Repository
Passed
No Audits

Apr 5 2020

f1d1ec3d77f1 Add an "isDone" flag to "transaction.search" for Differential inline comments
Author
epriestley
Revisions
D21059: Add an "isDone" flag to "transaction.search" for Differential inline comments
Browse Repository
Passed
No Audits