Diffusion Phabricator (master) History

phabricator/src
master

Apr 23 2020

d05d8f655896 Add a very forgiving GC for Differential viewstate information
Author
epriestley
Revisions
D21164: Add a very forgiving GC for Differential viewstate information
Browse Repository
Passed
No Audits

4793bfcb7c49 Don't show the "file tree" view on tablets/phones
Author
epriestley
Revisions
D21162: Don't show the "file tree" view on tablets/phones
Browse Repository
Passed
No Audits

d2572f8b335a Refine more Differential review state behaviors
Author
epriestley
Revisions
D21161: Refine more Differential review state behaviors
Browse Repository
Passed
No Audits

0ede616f314b Update the "View Options" menu for recent filetree changes
Author
epriestley
Revisions
D21160: Update the "View Options" menu for recent filetree changes
Browse Repository
Passed
No Audits

befbea2f00e6 Don't pass "No newline at end of file." annotations to DocumentEngines as…
Author
epriestley
Revisions
D21159: Don't pass "No newline at end of file." annotations to DocumentEngines as literal diff text
Browse Repository
Passed
No Audits

Apr 22 2020

60de1506fe3b Make "hidden" changesets sticky, and show hidden state in the filetree
Author
epriestley
Revisions
D21158: Make "hidden" changesets sticky, and show hidden state in the filetree
Browse Repository
Passed
No Audits

a72a66caa833 Mark "low importance" and "owned" changes in the filetree
Author
epriestley
Revisions
D21157: Mark "low importance" and "owned" changes in the filetree
Browse Repository
Passed
No Audits

ff88eb588eb4 Show change information in file icons in the filetree
Author
epriestley
Revisions
D21156: Show change information in file icons in the filetree
Browse Repository
Passed
No Audits

12eddb18fb78 Entirely replace the old filetree UI with the "flank" UI
Author
epriestley
Revisions
D21154: Entirely replace the old filetree UI with the "flank" UI
Browse Repository
Passed
No Audits

ba8071bbef50 Roughly style the new "flank" paths UI
Author
epriestley
Revisions
D21153: Roughly style the new "flank" paths UI
Browse Repository
Passed
No Audits

8cd1f9a30976 Generate file trees from changesets in the new flank UI
Author
epriestley
Revisions
D21152: Generate file trees from changesets in the new flank UI
Browse Repository
Passed
No Audits

646280972b88 Glue the new FormationView on top of the older Filetree view in Differential
Author
epriestley
Revisions
D21151: Glue the new FormationView on top of the older Filetree view in Differential
Browse Repository
Passed
No Audits

fef2cdabfe43 Add a "FormationView" to support dynamic flank panels
Author
epriestley
Revisions
D21150: Add a "FormationView" to support dynamic flank panels
Browse Repository
Passed
No Audits

Apr 19 2020

ef69c7969f58 Restore editor behavior to Diffusion and support "\" shortcut
Author
epriestley
Revisions
D21149: Restore editor behavior to Diffusion and support "\" shortcut
Browse Repository
Passed
No Audits

f02024615ad3 Add "short name", "id", and "phid" variables for external editor URIs
Author
epriestley
Revisions
D21147: Add "short name", "id", and "phid" variables for external editor URIs
Browse Repository
Passed
No Audits

c79094d7a8bd Add static errors, supported protocols, and a dynamic function listing to…
Author
epriestley
Revisions
D21146: Add static errors, supported protocols, and a dynamic function listing to external editor settings page
Browse Repository
Passed
No Audits

7a79131bf279 Replace old hard-coded URI-based "changes saved" jank with new overgeneralized…
Author
epriestley
Revisions
D21144: Replace old hard-coded URI-based "changes saved" jank with new overgeneralized cookie-based "changes saved" jank
Browse Repository
Passed
No Audits

3984c14260d3 Tokenize external editor links so they can be safely materialized on the client
Author
epriestley
Revisions
D21143: Tokenize external editor links so they can be safely materialized on the client
Browse Repository
Passed
No Audits

416833561903 Remove the "Edit Multiple Files" external editor setting
Author
epriestley
Revisions
D21142: Remove the "Edit Multiple Files" external editor setting
Browse Repository
Passed
No Audits

8bdc7133521d Make the "Keyboard Shortcuts" dialog in Differential less hideous
Author
epriestley
Revisions
D21141: Make the "Keyboard Shortcuts" dialog in Differential less hideous
Browse Repository
Passed
No Audits

84cd4a385450 Move "External Editor" settings to a separate settings group
Author
epriestley
Revisions
D21140: Move "External Editor" settings to a separate settings group
Browse Repository
Passed
No Audits

c3c55d82ae9d Make "renderer", "engine", and "encoding" sticky across reloads in Differential…
Author
epriestley
Revisions
D21138: Make "renderer", "engine", and "encoding" sticky across reloads in Differential and Diffusion
Browse Repository
Passed
No Audits

8aac55cc57cb Make "Highlight As..." sticky across reloads in Diffusion and Differential
Author
epriestley
Revisions
D21137: Make "Highlight As..." sticky across reloads in Diffusion and Differential
Browse Repository
Passed
No Audits

Apr 17 2020

3adf082002aa When inlines would disable a file shield in a diff, still apply the shield if…
Author
epriestley
Revisions
D21136: When inlines would disable a file shield in a diff, still apply the shield if all the comments are collapsed
Browse Repository
Passed
No Audits

3d966d8a41f1 Add an "Open in External Editor" keystroke to Differential
Author
epriestley
Revisions
D21135: Add an "Open in External Editor" keystroke to Differential
Browse Repository
Passed
No Audits

83eb7447a196 When Owners packages are archived, annotate them in tokenizer results
Author
epriestley
Revisions
D21134: When Owners packages are archived, annotate them in tokenizer results
Browse Repository
Passed
No Audits

Apr 16 2020

ef1340bd3207 Add Ferret support to Paste
Author
amckinley
Revisions
D20650: Add Ferret support to Paste
Browse Repository
Passed
No Audits

2748f83e1225 Modularize Ferret fulltext functions
Author
epriestley
Revisions
D21131: Modularize Ferret fulltext functions
Browse Repository
Passed
No Audits

894d9b658706 Remove Ferret function aliases and overrides
Author
epriestley
Revisions
D21130: Remove Ferret function aliases and overrides
Browse Repository
Passed
No Audits

9bdf477f2fef Combine the two different ngram-splitting algorithms into a single engine
Author
epriestley
Revisions
D21128: Combine the two different ngram-splitting algorithms into a single engine
Browse Repository
Passed
No Audits

fb3f423279b2 Remove broken and unfixable "prefix" ngram behavior
Author
epriestley
Revisions
D21127: Remove broken and unfixable "prefix" ngram behavior
Browse Repository
Passed
No Audits

b1b9c844ac1a Remove unused "getAllFunctionFields()" from Ferret
Author
epriestley
Revisions
D21126: Remove unused "getAllFunctionFields()" from Ferret
Browse Repository
Passed
No Audits

Apr 15 2020

3573170dfacb Compress file downloads if the client sends "Accept-Encoding: gzip" and we…
Author
epriestley
Revisions
D21125: Compress file downloads if the client sends "Accept-Encoding: gzip" and we guess the file might compress alright
Browse Repository
Passed
No Audits

45665dd3b458 Hide "notification.servers" configuration and don't follow redirects from…
Author
epriestley
Revisions
D21123: Hide "notification.servers" configuration and don't follow redirects from Aphlict
Browse Repository
Passed
No Audits

b52fa9623837 Disable automatic decoding of "Content-Encoding" responses during "Accept…
Author
epriestley
Revisions
D21122: Disable automatic decoding of "Content-Encoding" responses during "Accept-Encoding" setup test
Browse Repository
Passed
No Audits

Apr 14 2020

0ea6d131e072 In Conduit responses, assert that Phabricator supports a "gzip" capability
Author
epriestley
Revisions
D21120: In Conduit responses, assert that Phabricator supports a "gzip" capability
Browse Repository
Passed
No Audits

6b05d2be287e Add a setup warning to detect "SetInputFilter DEFLATE" and other "Content…
Author
epriestley
Revisions
D21116: Add a setup warning to detect "SetInputFilter DEFLATE" and other "Content-Encoding" request mangling
Browse Repository
Passed
No Audits

99cbc2077897 Reduce the verbosity of the "Aphlict" log
Author
epriestley
Revisions
D21115: Reduce the verbosity of the "Aphlict" log
Browse Repository
Passed
No Audits

59c855276b0b Provide a "--local" flag to "bin/conduit call" to force in-process execution
Author
epriestley
Revisions
D21114: Provide a "--local" flag to "bin/conduit call" to force in-process execution
Browse Repository
Passed
No Audits

4655a5f059c4 Document the "field present" and "field absent" operators in Ferret
Author
epriestley
Revisions
D21112: Document the "field present" and "field absent" operators in Ferret
Browse Repository
Passed
No Audits

b3a8754013cc Make the Ferret query compiler keep functions sticky across non-initial quoted…
Author
epriestley
Revisions
D21111: Make the Ferret query compiler keep functions sticky across non-initial quoted tokens
Browse Repository
Passed
No Audits

0511b2a0129e Implement the "present" and "absent" operators in the Ferret execution engine
Author
epriestley
Revisions
D21110: Implement the "present" and "absent" operators in the Ferret execution engine
Browse Repository
Passed
No Audits

143f86d60b5a Tighten query compiler rules around spaces inside and after operators
Author
epriestley
Revisions
D21109: Tighten query compiler rules around spaces inside and after operators
Browse Repository
Passed
No Audits

8fa8d0e6483c Make Ferret query functions sticky only if their values are not quoted
Author
epriestley
Revisions
D21108: Make Ferret query functions sticky only if their values are not quoted
Browse Repository
Passed
No Audits

f31b9987ba1b Add "absent" and "present" field operators to the Ferret query compiler
Author
epriestley
Revisions
D21107: Add "absent" and "present" field operators to the Ferret query compiler
Browse Repository
Passed
No Audits

5c30a60e305f Tighten Ferret query parsing of empty tokens and empty functions
Author
epriestley
Revisions
D21106: Tighten Ferret query parsing of empty tokens and empty functions
Browse Repository
Passed
No Audits

Apr 13 2020

471e89a8b76d Add "uri" to "paste.search" API output
Author
epriestley
Revisions
D21105: Add "uri" to "paste.search" API output
Browse Repository
Passed
No Audits

19e0abcb27b4 Fix an issue where raw diffs that are not attached to revisions could skip…
Author
epriestley
Revisions
D21103: Fix an issue where raw diffs that are not attached to revisions could skip repository policy checks
Browse Repository
Passed
No Audits

5597f4e6f229 Add "uri" to the fields returned by "differential.revision.search"
Author
epriestley
Revisions
D21102: Add "uri" to the fields returned by "differential.revision.search"
Browse Repository
Passed
No Audits

Apr 10 2020

c3be82fe6e09 Fix an out-of-date API call on the destruction pathway for Pholio mocks
Author
epriestley
Revisions
D21081: Fix an out-of-date API call on the destruction pathway for Pholio mocks
Browse Repository
Passed
No Audits

Apr 6 2020

58fbf64a2786 Refine handling of "@task" attributes in Diviner
Author
epriestley
Revisions
D21062: Refine handling of "@task" attributes in Diviner
Browse Repository
Passed
No Audits

271e104c7ea4 Update DivinerAtomController for a long-ago change to the docblock parser API
Author
epriestley
Revisions
D21061: Update DivinerAtomController for a long-ago change to the docblock parser API
Browse Repository
Passed
No Audits

Apr 5 2020

f1d1ec3d77f1 Add an "isDone" flag to "transaction.search" for Differential inline comments
Author
epriestley
Revisions
D21059: Add an "isDone" flag to "transaction.search" for Differential inline comments
Browse Repository
Passed
No Audits

Apr 3 2020

33b73d887ae3 If daemon running-as-user setup check fails its query, don't bother with it
Author
epriestley
Revisions
D21057: If daemon running-as-user setup check fails its query, don't bother with it
Browse Repository
Passed
No Audits

1e7cc72cd835 Improve performance when marking commits as unreachable after multiple ref…
Author
epriestley
Revisions
D21056: Improve performance when marking commits as unreachable after multiple ref deletions
Browse Repository
Passed
No Audits

1a59cae743c2 Update some Phabricator behaviors for changes to Futures
Author
epriestley
Revisions
D21054: Update some Phabricator behaviors for changes to Futures
Browse Repository
Passed
No Audits

067b04aaf148 If HTTP response headers are already sent, don't fiddle with "zlib.
Author
epriestley
Revisions
D21055: If HTTP response headers are already sent, don't fiddle with "zlib.output_compression"
Browse Repository
Failed
No Audits

Mar 9 2020

62f5bdbbd2c5 According to Jira Project keys must start with an uppercase letter, followed by…
Author
Arturas Moskvinas arturas@uber.com <arturas@uber.com>
Revisions
D21040: According to Jira Project keys must start with an uppercase letter, followed by one or more uppercase alphanumeric characters
Browse Repository
Passed
No Audits

Feb 24 2020

d0f4554dbeb0 Read both email addresses and Google Account IDs from Google OAuth
Author
epriestley
Revisions
D21028: Read both email addresses and Google Account IDs from Google OAuth
Browse Repository
Passed
No Audits

785f3c98da3a Extract raw commit messages from Git more faithfully across Git versions
Author
epriestley
Revisions
D21027: Extract raw commit messages from Git more faithfully across Git versions
Browse Repository
Passed
No Audits

Feb 23 2020

e58ef418c798 Read both older "key" and newer "accountId" identifiers from JIRA during…
Author
epriestley
Revisions
D21023: Read both older "key" and newer "accountId" identifiers from JIRA during authentication
Browse Repository
Passed
No Audits

802b5aca05cc Remove all readers and writers of "accountID" on "ExternalAccount"
Author
epriestley
Revisions
D21022: Remove all readers and writers of "accountID" on "ExternalAccount"
Browse Repository
Passed
No Audits

84b5ad09e6e2 Remove all readers and all nontrivial writers for "accountType" and…
Author
epriestley
Revisions
D21019: Remove all readers and all nontrivial writers for "accountType" and "accountDomain" on "ExternalAccount"
Browse Repository
Passed
No Audits

b8f0613b30dd Update Asana feed publishing integration for "ExternalAccountIdentifier"
Author
epriestley
Revisions
D21018: Update Asana feed publishing integration for "ExternalAccountIdentifier"
Browse Repository
Passed
No Audits

bcaf60015a47 Write ExternalAccountIdentifiers when interacting with external authentication…
Author
epriestley
Revisions
D21016: Write ExternalAccountIdentifiers when interacting with external authentication providers
Browse Repository
Passed
No Audits

0872051bfa28 Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all…
Author
epriestley
Revisions
D21015: Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible
Browse Repository
Passed
No Audits

05eb16d6de51 Update unusual handling of external accounts in "Password" auth provider
Author
epriestley
Revisions
D21014: Update unusual handling of external accounts in "Password" auth provider
Browse Repository
Passed
No Audits

e43ecad8afc4 Make external account identifier APIs return multiple identifiers
Author
epriestley
Revisions
D21013: Make external account identifier APIs return multiple identifiers
Browse Repository
Passed
No Audits

40946248280e Remove an ancient no-op check for duplicated external accounts
Author
epriestley
Revisions
D21012: Remove an ancient no-op check for duplicated external accounts
Browse Repository
Passed
No Audits

70845a2d13fc Add an "ExternalAccountIdentifier" table
Author
epriestley
Revisions
D21011: Add an "ExternalAccountIdentifier" table
Browse Repository
Passed
No Audits

fbf050167e25 Stop exposing raw "accountID" values directly in the web UI
Author
epriestley
Revisions
D21010: Stop exposing raw "accountID" values directly in the web UI
Browse Repository
Passed
No Audits

Feb 20 2020

149155ee20e8 Whitelist "vscode://" as an allowed Editor protocol
Author
epriestley
Revisions
D21009: Whitelist "vscode://" as an allowed Editor protocol
Browse Repository
Passed
No Audits

29923cc71a46 Remove old code for sending email to external users who create objects via…
Author
epriestley
Revisions
D21007: Remove old code for sending email to external users who create objects via inbound mail
Browse Repository
Passed
No Audits

Feb 15 2020

64cc4fe91515 Add a test to verify that all routing maps are plausibly valid, and remove some…
Author
epriestley
Revisions
D21000: Add a test to verify that all routing maps are plausibly valid, and remove some dead routes
Browse Repository
Passed
No Audits

Feb 14 2020

4790a3d94be6 Stop trying to version-check libphutil in "Config"
Author
epriestley
Revisions
D20995: Stop trying to version-check libphutil in "Config"
Browse Repository
Passed
No Audits

Feb 13 2020

dc35ce79e484 Unprototype "Draft" mode in Differential
Author
epriestley
Revisions
D20983: Unprototype "Draft" mode in Differential
Browse Repository
Passed
No Audits

Feb 12 2020

35a18146a28f Merge a small amount of remaining "libphutil/" code with Phabricator, break…
Author
epriestley
Revisions
D20981: Merge a small amount of remaining "libphutil/" code with Phabricator, break libphutil dependency
Browse Repository
Failed
No Audits

f9b3e3360b0c Continue moving classes with no callers in libphutil or Arcanist to Phabricator
Author
epriestley
Revisions
D20977: Continue moving classes with no callers in libphutil or Arcanist to Phabricator
Browse Repository
Passed
No Audits

8cc6fe465c53 Fix diffusion.branchquery returning dictionary instead of array when branches…
Author
Arturas Moskvinas arturas@uber.com <arturas@uber.com>
Revisions
D20973: Fix diffusion.branchquery returning dictionary instead of array when branches are filtered out
Browse Repository
Passed
No Audits

af84f215f9b8 Move lingering "Aphront" classes to Phabricator
Author
epriestley
Revisions
D20975: Move lingering "Aphront" classes to Phabricator
Browse Repository
Passed
No Audits

Feb 6 2020

2327578adc94 Respect linebreaks in full HTML tables in Remarkup
Author
epriestley
Revisions
D20971: Respect linebreaks in full HTML tables in Remarkup
Browse Repository
Passed
No Audits

Feb 5 2020

9d1af762d518 In summary interfaces, don't render very large inline remarkup details for unit…
Author
epriestley
Revisions
D20970: In summary interfaces, don't render very large inline remarkup details for unit test messages
Browse Repository
Passed
No Audits

Feb 4 2020

fd46c597aec5 When sorting subscriber references for display in the curtain UI, sort without…
Author
epriestley
Revisions
D20969: When sorting subscriber references for display in the curtain UI, sort without case sensitivity
Browse Repository
Passed
No Audits

fdbe9ba149b6 Improve Remarkup parsing performance for certain large input blocks
Author
epriestley
Revisions
D20968: Improve Remarkup parsing performance for certain large input blocks
Browse Repository
Passed
No Audits

0e82bd024a8c Use the new "CurtainObjectRefList" UI element for subscribers
Author
epriestley
Revisions
D20967: Use the new "CurtainObjectRefList" UI element for subscribers
Browse Repository
Passed
No Audits

2a92fef8798d Improve wrapping and overflow behavior for curtain panels containing long…
Author
epriestley
Revisions
D20966: Improve wrapping and overflow behavior for curtain panels containing long usernames
Browse Repository
Passed
No Audits

84fd5cd5bb4e Fix an issue where intracontent empty lines were incorrectly trimmed in quoted…
Author
epriestley
Revisions
D20965: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks
Browse Repository
Passed
No Audits

0f1acb6cef1d Update GitHub API calls to use "Authorization" header instead of "access_token"…
Author
epriestley
Revisions
D20964: Update GitHub API calls to use "Authorization" header instead of "access_token" URI parameter
Browse Repository
Passed
No Audits

6d4c6924d6d9 Update Herald rule creation workflow to use more modern UI elements
Author
epriestley
Revisions
D20956: Update Herald rule creation workflow to use more modern UI elements
Browse Repository
Passed
No Audits

4904d7711ea1 When publishing a commit, copy "Related Tasks" from the associated revision (if…
Author
epriestley
Revisions
D20961: When publishing a commit, copy "Related Tasks" from the associated revision (if one exists)
Browse Repository
Passed
No Audits

530145ba3be6 Give "Config" a full-width, hierarchical layout
Author
epriestley
Revisions
D20934: Give "Config" a full-width, hierarchical layout
Browse Repository
Passed
No Audits

26c2a1ba68b1 Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView"
Author
epriestley
Revisions
D20933: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView"
Browse Repository
Passed
No Audits

cb481f36c54b Carve out a separate "Services" section of Config
Author
epriestley
Revisions
D20931: Carve out a separate "Services" section of Config
Browse Repository
Passed
No Audits

a72ade94757a Carve out a separate "Modules/Extensions" section of Config
Author
epriestley
Revisions
D20930: Carve out a separate "Modules/Extensions" section of Config
Browse Repository
Passed
No Audits

Feb 3 2020

c42c5983aa6a Fix an issue where loading a mangled project graph could fail too abruptly
Author
epriestley
Revisions
D20963: Fix an issue where loading a mangled project graph could fail too abruptly
Browse Repository
Passed
No Audits

42e46bbe5a91 Fix an issue where Herald rules could fail to evaluate at post-commit time
Author
epriestley
Revisions
D20962: Fix an issue where Herald rules could fail to evaluate at post-commit time
Browse Repository
Passed
No Audits

Jan 30 2020

ccf28a81121e Fix an issue where the last line of block-based diffs could be incorrectly…
Author
epriestley
Revisions
D20959: Fix an issue where the last line of block-based diffs could be incorrectly hidden
Browse Repository
Passed
No Audits

12c337098872 When issuing a "no-op" MFA token because no MFA is configured, don't give the…
Author
epriestley
Revisions
D20958: When issuing a "no-op" MFA token because no MFA is configured, don't give the timeline story a badge
Browse Repository
Passed
No Audits

Jan 29 2020

c99485e8a00d Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and…
Author
epriestley
Revisions
D20957: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and Hooks
Browse Repository
Passed
No Audits

6628cd2b4f7b In Herald "Commit" rules, use repository identities to identify authors and…
Author
epriestley
Revisions
D20955: In Herald "Commit" rules, use repository identities to identify authors and committers
Browse Repository
Passed
No Audits