Diffusion Phabricator (legacy-2019) History

phabricator/src
legacy-2019

Oct 2 2019

7badec23a7d0 Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized…
Author
epriestley
Revisions
D20854: Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized command lines
Browse Repository
Passed
No Audits

6d74736a7ec8 When a large number of commits need to be marked as published, issue the lookup…
Author
epriestley
Revisions
D20853: When a large number of commits need to be marked as published, issue the lookup query in chunks
Browse Repository
Passed
No Audits

960c447aab7f Support more than 9 portals
Author
artms
Revisions
D20852: Support more than 9 portals
Browse Repository
Passed
No Audits

344a2e39bed7 In Jupyter notebooks, apply intraline diffing to source code lines
Author
epriestley
Revisions
D20851: In Jupyter notebooks, apply intraline diffing to source code lines
Browse Repository
Passed
No Audits

7c83076fb68e (stable) Fix an issue where any diff which could possibly be rendered as…
Author
epriestley
Revisions
D20850: Fix an issue where any diff which could possibly be rendered as Jupyter decided to render as Jupyter
Browse Repository
Passed
No Audits

9f7aaa8ee4cb Fix an issue where any diff which could possibly be rendered as Jupyter decided…
Author
epriestley
Revisions
D20850: Fix an issue where any diff which could possibly be rendered as Jupyter decided to render as Jupyter
Browse Repository
Passed
No Audits

Sep 30 2019

256507a14e0d (stable) Promote 2019 Week 39
Author
epriestley
Browse Repository
Passed
Audit Required

76d9912932bc Force unified abstract block diffs into roughly usable shape
Author
epriestley
Revisions
D20848: Force unified abstract block diffs into roughly usable shape
Browse Repository
Passed
No Audits

d9515e82a3ec Perform basic block interdiffs when diffing abstract blocks, and interdiff…
Author
epriestley
Revisions
D20845: Perform basic block interdiffs when diffing abstract blocks, and interdiff markdown in Jupyter notebooks
Browse Repository
Passed
No Audits

5afdc620db59 Make basic Juypter notebook rendering improvements and roughly support folding…
Author
epriestley
Revisions
D20844: Make basic Juypter notebook rendering improvements and roughly support folding unchanged context
Browse Repository
Passed
No Audits

a7f3316aa3df Improve sequencing of various content/header checks in abstract block diffs
Author
epriestley
Revisions
D20843: Improve sequencing of various content/header checks in abstract block diffs
Browse Repository
Passed
No Audits

9944b669ade9 Make HTTP/403 say "Yikes!"
Author
epriestley
Revisions
D20847: Make HTTP/403 say "Yikes!"
Browse Repository
Passed
No Audits

Sep 27 2019

f004b76465fe Add a "Subtype" tag to the task graph view in Maniphest
Author
epriestley
Revisions
D20842: Add a "Subtype" tag to the task graph view in Maniphest
Browse Repository
Passed
No Audits

Sep 26 2019

7a0090f4d070 Fix an issue where the "viewer" is not passed to Bulk Edit controls properly
Author
epriestley
Revisions
D20841: Fix an issue where the "viewer" is not passed to Bulk Edit controls properly
Browse Repository
Passed
No Audits

2c06815edb0f When rendering Jupyter notebook diffs, split code inputs into individual blocks
Author
epriestley
Revisions
D20840: When rendering Jupyter notebook diffs, split code inputs into individual blocks
Browse Repository
Passed
No Audits

Sep 25 2019

884cd74cc4a5 In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale better
Author
epriestley
Revisions
D20839: In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale better
Browse Repository
Passed
No Audits

9d884f144f01 Add "PhutilProseDiff" classes to "phabricator/"
Author
epriestley
Revisions
D20838: Add "PhutilProseDiff" classes to "phabricator/"
Browse Repository
Passed
No Audits

281598d65cfc Use a hash-and-diff strategy to produce a diff layout for block-based documents
Author
epriestley
Revisions
D20836: Use a hash-and-diff strategy to produce a diff layout for block-based documents
Browse Repository
Passed
No Audits

932d829af339 Improve behavior of inline comment highlight reticle for block diffs
Author
epriestley
Revisions
D20835: Improve behavior of inline comment highlight reticle for block diffs
Browse Repository
Passed
No Audits

a09b298d85d7 Correct DOM node metadata to let inline comments work against block-based diffs
Author
epriestley
Revisions
D20834: Correct DOM node metadata to let inline comments work against block-based diffs
Browse Repository
Passed
No Audits

1c4450d39f9b Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as…
Author
epriestley
Revisions
D20833: Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as blocks
Browse Repository
Passed
No Audits

7ae711ed3e0b Add a "View as..." option to diff dropdowns for selecting between document…
Author
epriestley
Revisions
D20832: Add a "View as..." option to diff dropdowns for selecting between document engines
Browse Repository
Passed
No Audits

bb71ef6ad6cd Render image diffs as abstract blocks diffs via DocumentEngine
Author
epriestley
Revisions
D20831: Render image diffs as abstract blocks diffs via DocumentEngine
Browse Repository
Passed
No Audits

a73f592d7d08 Allow DocumentEngine to elect into diff construction
Author
epriestley
Revisions
D20830: Allow DocumentEngine to elect into diff construction
Browse Repository
Passed
No Audits

06edcf270921 Fix an issue where ancestors of permanent refs might not be published during…
Author
epriestley
Revisions
D20829: Fix an issue where ancestors of permanent refs might not be published during import or if a branch is later made permanent
Browse Repository
Passed
No Audits

Sep 24 2019

6af776f84a66 Allow installs to provide "Request a Username Change" instructions
Author
epriestley
Revisions
D20828: Allow installs to provide "Request a Username Change" instructions
Browse Repository
Passed
No Audits

0c331458a88b When non-administrators click "Change Username", explain why they can't continue
Author
epriestley
Revisions
D20827: When non-administrators click "Change Username", explain why they can't continue
Browse Repository
Passed
No Audits

058b7ae9450d Update "Change Username" instructions to be less foreboding
Author
epriestley
Revisions
D20826: Update "Change Username" instructions to be less foreboding
Browse Repository
Passed
No Audits

b1d4d5c00ce1 Add an "{anchor #xyz}" rule to Remarkup
Author
epriestley
Revisions
D20825: Add an "{anchor #xyz}" rule to Remarkup
Browse Repository
Passed
No Audits

bff72ce3b582 Generate more friendly anchor names for header sections in Remarkup
Author
epriestley
Revisions
D20821: Generate more friendly anchor names for header sections in Remarkup
Browse Repository
Passed
No Audits

be2a0f873368 Fix a cursor paging issue in Conduit call logs
Author
epriestley
Revisions
D20823: Fix a cursor paging issue in Conduit call logs
Browse Repository
Passed
No Audits

Sep 23 2019

f0f352ffd083 (stable) Promote 2019 Week 38
Author
epriestley
Browse Repository
Passed
Audit Required

09d86c2d2031 Unprototype "Facts" to clear Maniphest/chart fatals
Author
epriestley
Revisions
D20822: Unprototype "Facts" to clear Maniphest/chart fatals
Browse Repository
Passed
No Audits

Sep 17 2019

16de9151c7c1 Give "Burndown" charts a more straightforward definition and move all the event…
Author
epriestley
Revisions
D20819: Give "Burndown" charts a more straightforward definition and move all the event stuff into "Activity" charts
Browse Repository
Passed
No Audits

c06dd4818b53 Support explicit stacking configuration in stacked area charts
Author
epriestley
Revisions
D20818: Support explicit stacking configuration in stacked area charts
Browse Repository
Passed
No Audits

d4ed5d0428ec Make various UX improvements to charts so they're closer to making visual sense
Author
epriestley
Revisions
D20817: Make various UX improvements to charts so they're closer to making visual sense
Browse Repository
Passed
No Audits

080e132aa740 Track chart datapoints from their sources and provide a tabular view of chart…
Author
epriestley
Revisions
D20816: Track chart datapoints from their sources and provide a tabular view of chart data
Browse Repository
Passed
No Audits

769e745a3f27 In charts, make "min" and "max" into pure functions and formally mark pure…
Author
epriestley
Revisions
D20815: In charts, make "min" and "max" into pure functions and formally mark pure functions as pure
Browse Repository
Passed
No Audits

f529abf90065 In stacked area charts, group nearby points so they don't overlap
Author
epriestley
Revisions
D20814: In stacked area charts, group nearby points so they don't overlap
Browse Repository
Passed
No Audits

Sep 16 2019

c5a4dea8cf7c Fix a typo in preamble X-Forwarded-For psuedocode
Author
epriestley
Revisions
D20813: Fix a typo in preamble X-Forwarded-For psuedocode
Browse Repository
Passed
No Audits

Sep 13 2019

80d17ad7804e (stable) Promote 2019 Week 37
Author
epriestley
Browse Repository
Passed
Audit Required

f87ec6a5dff9 (stable) Don't offer personal saved queries in global "Search Scope" settings…
Author
epriestley
Revisions
D20793: Don't offer personal saved queries in global "Search Scope" settings dropdown
Browse Repository
Passed
No Audits

Sep 12 2019

3f6620336216 Fix a straggling callsite to "renderApplicationPolicy()"
Author
epriestley
Revisions
D20811: Fix a straggling callsite to "renderApplicationPolicy()"
Browse Repository
Passed
No Audits

41f0b8b0a3a1 Allow subtypes to specify "mutations", to control the behavior of the "Change…
Author
epriestley
Revisions
D20810: Allow subtypes to specify "mutations", to control the behavior of the "Change Subtype" action
Browse Repository
Passed
No Audits

3e6012803725 Support "Subtype" in Herald
Author
epriestley
Revisions
D20809: Support "Subtype" in Herald
Browse Repository
Passed
No Audits

d60d4e6a0521 Don't present users with Herald fields/actions for uninstalled applications…
Author
epriestley
Revisions
D20808: Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them
Browse Repository
Passed
No Audits

4f845d8f8c77 When users encounter a policy exception for a non-view capability with a custom…
Author
epriestley
Revisions
D20807: When users encounter a policy exception for a non-view capability with a custom policy, inline the policy rules
Browse Repository
Passed
No Audits

0c7ea8c94215 When users fail a "CAN_SEE" check, give them an "opaque" policy explanation
Author
epriestley
Revisions
D20806: When users fail a "CAN_SEE" check, give them an "opaque" policy explanation
Browse Repository
Passed
No Audits

9a36e6931cf7 Inline custom policy rules inside policy capability explanation dialogs
Author
epriestley
Revisions
D20805: Inline custom policy rules inside policy capability explanation dialogs
Browse Repository
Passed
No Audits

506f93b4a390 Give policy name rendering explicit "text name", "capability link", and…
Author
epriestley
Revisions
D20804: Give policy name rendering explicit "text name", "capability link", and "transaction link" pathways
Browse Repository
Passed
No Audits

c9b0d107f079 Remove unused "icon" parameter from policy name rendering
Author
epriestley
Revisions
D20803: Remove unused "icon" parameter from policy name rendering
Browse Repository
Passed
No Audits

9c6969e81022 Remove "Editable By" description fields in Passphrase, Phame, and Spaces
Author
epriestley
Revisions
D20802: Remove "Editable By" description fields in Passphrase, Phame, and Spaces
Browse Repository
Passed
No Audits

a35d7c3c218a Update rendering of policy edit transactions in Applications
Author
epriestley
Revisions
D20801: Update rendering of policy edit transactions in Applications
Browse Repository
Passed
No Audits

a0ade503e166 Remove "Moved Document from ..." notice in Phriction
Author
epriestley
Revisions
D20800: Remove "Moved Document from ..." notice in Phriction
Browse Repository
Passed
No Audits

Sep 10 2019

984e253d41e7 (stable) Fix global search scope fatal on 404 page (or other pages with no…
Author
epriestley
Revisions
D20792: Fix global search scope fatal on 404 page (or other pages with no Application)
Browse Repository
Passed
No Audits

Sep 9 2019

d2e1c4163a3b When a project has a custom icon, use that icon to label the project policy in…
Author
epriestley
Revisions
D20799: When a project has a custom icon, use that icon to label the project policy in the policy dropown
Browse Repository
Passed
No Audits

1d1a60fdda88 Improve rendering of Herald rules in "Another Herald rule..." field
Author
epriestley
Revisions
D20798: Improve rendering of Herald rules in "Another Herald rule..." field
Browse Repository
Passed
No Audits

7593a265d593 When Herald changes object subscribers, always hide the feed story
Author
epriestley
Revisions
D20797: When Herald changes object subscribers, always hide the feed story
Browse Repository
Passed
No Audits

454771446306 Add a "Remove flag" action to Herald
Author
epriestley
Revisions
D20796: Add a "Remove flag" action to Herald
Browse Repository
Passed
No Audits

d965d9a669b5 Index Herald fields, not just actions, when identifying objects related to a…
Author
epriestley
Revisions
D20795: Index Herald fields, not just actions, when identifying objects related to a particular Herald rule
Browse Repository
Passed
No Audits

aaaea5759133 Fix fatal during redirection safety check for searching for Phabricator base…
Author
epriestley
Revisions
D20794: Fix fatal during redirection safety check for searching for Phabricator base-uri with no trailing slash
Browse Repository
Passed
No Audits

278092974f2f Don't offer personal saved queries in global "Search Scope" settings dropdown
Author
epriestley
Revisions
D20793: Don't offer personal saved queries in global "Search Scope" settings dropdown
Browse Repository
Passed
No Audits

ec931b93848f (stable) Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the…
Author
epriestley
Revisions
D20791: Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the setup key for "STRICT_ALL_TABLES"
Browse Repository
Passed
No Audits

63c7302af130 Fix global search scope fatal on 404 page (or other pages with no Application)
Author
epriestley
Revisions
D20792: Fix global search scope fatal on 404 page (or other pages with no Application)
Browse Repository
Passed
No Audits

535c8e6bdc1e Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the setup key…
Author
epriestley
Revisions
D20791: Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the setup key for "STRICT_ALL_TABLES"
Browse Repository
Passed
No Audits

f16365ed0778 Weaken the guidance recommending that installs enable "STRICT_ALL_TABLES"
Author
epriestley
Revisions
D20790: Weaken the guidance recommending that installs enable "STRICT_ALL_TABLES"
Browse Repository
Passed
No Audits

19af9d74f8c3 (stable) Promote 2019 Week 36
Author
epriestley
Browse Repository
Passed
Audit Required

Sep 8 2019

caccbb69d20b When users try to log out with no providers configured, warn them of the…
Author
epriestley
Revisions
D20789: When users try to log out with no providers configured, warn them of the consequences
Browse Repository
Passed
No Audits

318e8ebdac95 Allow bin/config to create config file
Author
avivey
Revisions
D20788: Allow bin/config to create config file
Browse Repository
Passed
No Audits

Sep 6 2019

7e2bec92807d Add a global setting for controlling the default main menu search scope
Author
epriestley
Revisions
D20787: Add a global setting for controlling the default main menu search scope
Browse Repository
Passed
No Audits

Sep 5 2019

adc2002d2870 Make it easier to parse "X-Forwarded-For" with one or more load balancers
Author
epriestley
Revisions
D20785: Make it easier to parse "X-Forwarded-For" with one or more load balancers
Browse Repository
Passed
No Audits

Sep 4 2019

764db4869cb0 Make "bin/storage destroy" target individual hosts in database cluster mode
Author
epriestley
Revisions
D20784: Make "bin/storage destroy" target individual hosts in database cluster mode
Browse Repository
Passed
No Audits

0c3f59fd688a (stable) Update a straggling "getAuthorities()" call in Fund
Author
epriestley
Revisions
D20783: Update a straggling "getAuthorities()" call in Fund
Browse Repository
Failed
No Audits

f7290bbbf220 Update a straggling "getAuthorities()" call in Fund
Author
epriestley
Revisions
D20783: Update a straggling "getAuthorities()" call in Fund
Browse Repository
Passed
No Audits

Sep 3 2019

22b075df9716 Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries
Author
epriestley
Revisions
D20782: Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries
Browse Repository
Passed
No Audits

e0d6994adb1c Use the "@" operator to silence connection retry messages if initializing the…
Author
epriestley
Revisions
D20781: Use the "@" operator to silence connection retry messages if initializing the stack with database config optional
Browse Repository
Passed
No Audits

f8eec38c9419 When "mysqli->real_connect()" fails without setting an error code, recover more…
Author
epriestley
Revisions
D20780: When "mysqli->real_connect()" fails without setting an error code, recover more gracefully
Browse Repository
Passed
No Audits

d9badba14786 Give "bin/config" a friendlier error message if "local.json" is not writable
Author
epriestley
Revisions
D20779: Give "bin/config" a friendlier error message if "local.json" is not writable
Browse Repository
Passed
No Audits

8ff3a133c4d7 Generalize repository proxy retry logic to writes
Author
epriestley
Revisions
D20778: Generalize repository proxy retry logic to writes
Browse Repository
Passed
No Audits

ff3d1769b475 Instead of retrying safe reads 3 times, retry each eligible service once
Author
epriestley
Revisions
D20777: Instead of retrying safe reads 3 times, retry each eligible service once
Browse Repository
Passed
No Audits

95fb237ab393 On Git cluster read failure, retry safe requests
Author
epriestley
Revisions
D20776: On Git cluster read failure, retry safe requests
Browse Repository
Passed
No Audits

b6420e0f0ad8 Allow repository service lookups to return an ordered list of service refs
Author
epriestley
Revisions
D20775: Allow repository service lookups to return an ordered list of service refs
Browse Repository
Passed
No Audits

Sep 2 2019

9316cbf7fd27 Move web application classes into "phabricator/"
Author
epriestley
Revisions
D20774: Move web application classes into "phabricator/"
Browse Repository
Passed
No Audits

Aug 31 2019

24dbff241be1 (stable) Clean up two straggling UI issues in Phortune
Author
epriestley
Browse Repository
Passed
Audit Required

b2b17485b957 Clean up two straggling UI issues in Phortune
Author
epriestley
Browse Repository
Passed
Audit Required

4fca51c75cd6 (stable) Promote 2019 Week 35
Author
epriestley
Browse Repository
Passed
Audit Required

Aug 30 2019

533a5535b6f0 Remove the "grant authority" mechanism from users
Author
epriestley
Revisions
D20754: Remove the "grant authority" mechanism from users
Browse Repository
Passed
No Audits

Aug 29 2019

3c26e384872a Provide a simple read-only maintenance mode for repositories
Author
epriestley
Revisions
D20748: Provide a simple read-only maintenance mode for repositories
Browse Repository
Passed
No Audits

Aug 28 2019

c6642213d57f Straighten out replication/cache behavior in "bin/storage dump"
Author
epriestley
Revisions
D20743: Straighten out replication/cache behavior in "bin/storage dump"
Browse Repository
Passed
No Audits

0943561dcb78 Fix incorrect construction of subtype map when validating "subtype"…
Author
epriestley
Revisions
D20741: Fix incorrect construction of subtype map when validating "subtype" transactions against non-subtypable objects
Browse Repository
Passed
No Audits

Aug 27 2019

7198bd7db784 When "utf8mb4" is available, use it as the default client charset when invoking…
Author
epriestley
Revisions
D20742: When "utf8mb4" is available, use it as the default client charset when invoking standalone "mysql" commands
Browse Repository
Passed
No Audits

3e02f3c89c41 (stable) Promote 2019 Week 34
Author
epriestley
Browse Repository
Passed
Audit Required

Aug 26 2019

97a4a59cf2c7 Give the Phortune external portal an order view
Author
epriestley
Revisions
D20740: Give the Phortune external portal an order view
Browse Repository
Passed
No Audits

a0a38797127f In Phortune, send order email to account external addresses
Author
epriestley
Revisions
D20739: In Phortune, send order email to account external addresses
Browse Repository
Passed
No Audits

4e13551e8546 Add credential rotation and statuses (disabled, unsubscribed) to Phortune…
Author
epriestley
Revisions
D20738: Add credential rotation and statuses (disabled, unsubscribed) to Phortune external email
Browse Repository
Passed
No Audits

8f6a1ab01594 Roughly support external/email user views of Phortune recipts and invoices
Author
epriestley
Revisions
D20737: Roughly support external/email user views of Phortune recipts and invoices
Browse Repository
Passed
No Audits

Aug 23 2019

a39a37fc0e37 Update the Phortune cart/invoice workflow for policy changes
Author
epriestley
Revisions
D20735: Update the Phortune cart/invoice workflow for policy changes
Browse Repository
Passed
No Audits

b3f8045b873e Make minor flavor updates
Author
epriestley
Revisions
D20734: Make minor flavor updates
Browse Repository
Passed
No Audits

9bcd683c084a Update Phortune Merchant UI to bring it in line with Account UI
Author
epriestley
Revisions
D20733: Update Phortune Merchant UI to bring it in line with Account UI
Browse Repository
Passed
No Audits

c93ac91dc6da Update Charge and Cart policies in Phortune, and make URIs more consistent
Author
epriestley
Revisions
D20732: Update Charge and Cart policies in Phortune, and make URIs more consistent
Browse Repository
Passed
No Audits