(stable) Promote 2018 Week 14
Audit Requiredfba35975e766
Actions

Description

(stable) Promote 2018 Week 14

Details

Group Auditors

Provenance

epriestley	Authored on Apr 8 2018, 12:28 AM
epriestley	Pushed on Apr 8 2018, 12:28 AM

Parents

rPf01c2e36948b: Remove "Large Changes" documentation and make some minor behavioral improvements
rP0fef964d86de: (stable) Fix a commit hook issue where pushing dangerous changes would fatal…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 20013
Build 27137: Run Core Tests

Event Timeline

epriestley committed rPfba35975e766: (stable) Promote 2018 Week 14 (authored by epriestley).Apr 8 2018, 12:28 AM

Herald added an auditor: Cowboy Commits. · View Herald TranscriptApr 8 2018, 12:28 AM

This commit now requires audit.Apr 8 2018, 12:28 AM

Harbormaster completed building B20013: rPfba35975e766: (stable) Promote 2018 Week 14.Apr 8 2018, 12:29 AM

Merged Changes

f01c2e36948b Remove "Large Changes" documentation and make some minor behavioral improvements
Author
epriestley
Revisions
D19298: Remove "Large Changes" documentation and make some minor behavioral improvements
Browse Repository
Passed
No Audits
1b363a831e7c When a revision changes more than 1,000 files, don't show the changes on the…
Author
epriestley
Revisions
D19296: When a revision changes more than 1,000 files, don't show the changes on the main page
Browse Repository
Passed
No Audits
8c8e7f07b575 Add a standalone view for browsing changesets of very large revisions
Author
epriestley
Revisions
D19295: Add a standalone view for browsing changesets of very large revisions
Browse Repository
Passed
No Audits
3de002c8414a Fix a commit hook issue where pushing dangerous changes would fatal before…
Author
epriestley
Revisions
D19297: Fix a commit hook issue where pushing dangerous changes would fatal before hitting the dragon bureaucrats
Browse Repository
Passed
No Audits
e70c9f72a48e Show revision sizes using a perplexing, inexplicable symbol code
Author
epriestley
Revisions
D19294: Show revision sizes using a perplexing, inexplicable symbol code
Browse Repository
Passed
No Audits
e40aec0210dc When a revision has more than 7 reviewers, render only the first 7 in the list…
Author
epriestley
Revisions
D19293: When a revision has more than 7 reviewers, render only the first 7 in the list view
Browse Repository
Passed
No Audits
592d72e00688 Move PhabricatorModularTransaction slightly closer to having "final" methods…
Author
epriestley
Revisions
D19291: Move PhabricatorModularTransaction slightly closer to having "final" methods again
Browse Repository
Passed
No Audits
6f520e053462 Clean up an old transaction state flag
Author
epriestley
Revisions
D19290: Clean up an old transaction state flag
Browse Repository
Passed
No Audits
804f9817c3e2 When a draft's builds fail and it demotes to "Changes Planned + Draft", notify…
Author
epriestley
Revisions
D19289: When a draft's builds fail and it demotes to "Changes Planned + Draft", notify the author (only) via email
Browse Repository
Passed
No Audits
f4f33113124f When reclaiming an "Abandoned + Draft" revision, return it to "Draft", not…
Author
epriestley
Revisions
D19288: When reclaiming an "Abandoned + Draft" revision, return it to "Draft", not "Needs Review"
Browse Repository
Passed
No Audits
adf8fdef0e89 When remote builds fail, demote revisions to "Changes Planned + But, Still A…
Author
epriestley
Revisions
D19287: When remote builds fail, demote revisions to "Changes Planned + But, Still A Draft"
Browse Repository
Passed
No Audits
d9bd36039fd1 When a non-broadcasting revision is updated, put it in "Draft", not "Needs…
Author
epriestley
Revisions
D19286: When a non-broadcasting revision is updated, put it in "Draft", not "Needs Review"
Browse Repository
Passed
No Audits
615d27c8e97f Show an additional "Draft" tag on non-broadcasting revisions in a non-draft…
Author
epriestley
Revisions
D19285: Show an additional "Draft" tag on non-broadcasting revisions in a non-draft state
Browse Repository
Passed
No Audits
38e788c99a78 Partially decouple revision broadcasting from revision draft state
Author
epriestley
Revisions
D19284: Partially decouple revision broadcasting from revision draft state
Browse Repository
Passed
No Audits
3b5a7d1c88c4 Rename the Differential "hasBroadcast" flag to "shouldBroadcast"
Author
epriestley
Revisions
D19283: Rename the Differential "hasBroadcast" flag to "shouldBroadcast"
Browse Repository
Passed
No Audits
f350b9e4646b Explicitly condition Differential draft promotion on only "impactful" builds
Author
epriestley
Revisions
D19282: Explicitly condition Differential draft promotion on only "impactful" builds
Browse Repository
Passed
No Audits
51461f18c15b When publishing buildables in Differential, ignore autobuilds (local lint and…
Author
epriestley
Revisions
D19281: When publishing buildables in Differential, ignore autobuilds (local lint and unit)
Browse Repository
Passed
No Audits
ada0c9126cf0 Provide a modular buildable transaction in Diffusion
Author
epriestley
Revisions
D19280: Provide a modular buildable transaction in Diffusion
Browse Repository
Passed
No Audits
c20b4e365b76 Move structural build publishing logic to BuildEngine, provide…
Author
epriestley
Revisions
D19279: Move structural build publishing logic to BuildEngine, provide "bin/harbormaster publish"
Browse Repository
Passed
No Audits
95c9d403f4a3 Make objects implementing BuildableInterface produce a BuildableEngine
Author
epriestley
Revisions
D19278: Make objects implementing BuildableInterface produce a BuildableEngine
Browse Repository
Passed
No Audits
651f91cd544c Fix YouTube remarkup rule being blocked by Content-Security-Policy header
Author
epriestley
Revisions
D19277: Fix YouTube remarkup rule being blocked by Content-Security-Policy header
Browse Repository
Passed
No Audits

Changes (46)

Path

Size

resources/

celerity/

map.php

sql/

autopatches/

20180403.draft.01.broadcast.php

src/

__phutil_library_map__.php

applications/

differential/

application/

PhabricatorDifferentialApplication.php

conduit/

DifferentialCreateRawDiffConduitAPIMethod.php

controller/

DifferentialChangesetListController.php

DifferentialRevisionViewController.php

customfield/

DifferentialDraftField.php

editor/

DifferentialTransactionEditor.php

harbormaster

DifferentialBuildableEngine.php

query/

DifferentialChangesetQuery.php

DifferentialChangesetSearchEngine.php

DifferentialRevisionSearchEngine.php

storage/

DifferentialDiff.php

DifferentialRevision.php

view/

DifferentialRevisionListView.php

xaction/

DifferentialRevisionActionTransaction.php

DifferentialRevisionBuildableTransaction.php

DifferentialRevisionPlanChangesTransaction.php

DifferentialRevisionReclaimTransaction.php

DifferentialRevisionRequestReviewTransaction.php

DifferentialRevisionUpdateTransaction.php

diffusion/

controller/

DiffusionBrowseController.php

harbormaster

DiffusionBuildableEngine.php

xaction/

DiffusionCommitBuildableTransaction.php

harbormaster/

constants/

HarbormasterBuildableStatus.php

engine/

HarbormasterBuildEngine.php

HarbormasterBuildableEngine.php

interface/

HarbormasterBuildableInterface.php

management/

HarbormasterManagementPublishWorkflow.php

storage/

HarbormasterBuildable.php

people/

controller/

PhabricatorPeopleProfileRevisionsController.php

repository/

storage/

PhabricatorRepositoryCommit.php

transactions/

constants/

PhabricatorTransactions.php

editor/

PhabricatorApplicationTransactionEditor.php

storage/

PhabricatorApplicationTransaction.php

PhabricatorModularTransaction.php

PhabricatorModularTransactionType.php

docs/

flavor/

writing_reviewable_code.diviner

user/

userguide/

differential.diviner

differential_large_changes.diviner

infrastructure/

markup/

rule/

PhabricatorYoutubeRemarkupRule.php

webroot/

rsrc/

css/

phui/

object-item/

phui-oi-list-view.css

phui-icon.css

rPfba35975e766

View Options

resources/celerity/map.php

View Options

resources/sql/autopatches/20180403.draft.01.broadcast.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/application/PhabricatorDifferentialApplication.php

View Options

src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php

View Options

src/applications/differential/controller/DifferentialChangesetListController.php

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

View Options

src/applications/differential/customfield/DifferentialDraftField.php

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

View Options

src/applications/differential/harbormaster/DifferentialBuildableEngine.php

View Options

src/applications/differential/query/DifferentialChangesetQuery.php

View Options

src/applications/differential/query/DifferentialChangesetSearchEngine.php

View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

View Options

src/applications/differential/storage/DifferentialDiff.php

View Options

src/applications/differential/storage/DifferentialRevision.php

View Options

src/applications/differential/view/DifferentialRevisionListView.php

View Options

src/applications/differential/xaction/DifferentialRevisionActionTransaction.php

View Options

src/applications/differential/xaction/DifferentialRevisionBuildableTransaction.php

View Options

src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php

View Options

src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php

View Options

src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php

View Options

src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

View Options

src/applications/diffusion/harbormaster/DiffusionBuildableEngine.php

View Options

src/applications/diffusion/xaction/DiffusionCommitBuildableTransaction.php

View Options

src/applications/harbormaster/constants/HarbormasterBuildableStatus.php

View Options

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

View Options

src/applications/harbormaster/engine/HarbormasterBuildableEngine.php

View Options

src/applications/harbormaster/interface/HarbormasterBuildableInterface.php

View Options

src/applications/harbormaster/management/HarbormasterManagementPublishWorkflow.php

View Options

src/applications/harbormaster/storage/HarbormasterBuildable.php

View Options

src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

View Options

src/applications/transactions/constants/PhabricatorTransactions.php

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

View Options

src/applications/transactions/storage/PhabricatorModularTransaction.php

View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

View Options

src/docs/flavor/writing_reviewable_code.diviner

View Options

src/docs/user/userguide/differential.diviner

View Options

src/docs/user/userguide/differential_large_changes.diviner

View Options

src/infrastructure/markup/rule/PhabricatorYoutubeRemarkupRule.php

View Options

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

View Options

webroot/rsrc/css/phui/phui-icon.css

(stable) Promote 2018 Week 14Audit Requiredfba35975e766Actions

Description

Details

Event Timeline

Merged Changes

Changes (46)

rPfba35975e766

resources/celerity/map.php

resources/sql/autopatches/20180403.draft.01.broadcast.php

src/__phutil_library_map__.php

src/applications/differential/application/PhabricatorDifferentialApplication.php

src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php

src/applications/differential/controller/DifferentialChangesetListController.php

src/applications/differential/controller/DifferentialRevisionViewController.php

src/applications/differential/customfield/DifferentialDraftField.php

src/applications/differential/editor/DifferentialTransactionEditor.php

src/applications/differential/harbormaster/DifferentialBuildableEngine.php

src/applications/differential/query/DifferentialChangesetQuery.php

src/applications/differential/query/DifferentialChangesetSearchEngine.php

src/applications/differential/query/DifferentialRevisionSearchEngine.php

src/applications/differential/storage/DifferentialDiff.php

src/applications/differential/storage/DifferentialRevision.php

src/applications/differential/view/DifferentialRevisionListView.php

src/applications/differential/xaction/DifferentialRevisionActionTransaction.php

src/applications/differential/xaction/DifferentialRevisionBuildableTransaction.php

src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php

src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php

src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php

src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php

src/applications/diffusion/controller/DiffusionBrowseController.php

src/applications/diffusion/harbormaster/DiffusionBuildableEngine.php

src/applications/diffusion/xaction/DiffusionCommitBuildableTransaction.php

src/applications/harbormaster/constants/HarbormasterBuildableStatus.php

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

src/applications/harbormaster/engine/HarbormasterBuildableEngine.php

src/applications/harbormaster/interface/HarbormasterBuildableInterface.php

src/applications/harbormaster/management/HarbormasterManagementPublishWorkflow.php

src/applications/harbormaster/storage/HarbormasterBuildable.php

src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php

src/applications/repository/storage/PhabricatorRepositoryCommit.php

src/applications/transactions/constants/PhabricatorTransactions.php

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

src/applications/transactions/storage/PhabricatorModularTransaction.php

src/applications/transactions/storage/PhabricatorModularTransactionType.php

src/docs/flavor/writing_reviewable_code.diviner

src/docs/user/userguide/differential.diviner

src/docs/user/userguide/differential_large_changes.diviner

src/infrastructure/markup/rule/PhabricatorYoutubeRemarkupRule.php

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

webroot/rsrc/css/phui/phui-icon.css

(stable) Promote 2018 Week 14
Audit Requiredfba35975e766
Actions