HomePhabricator

Expose xhpast via Conduit

Description

Expose xhpast via Conduit

Summary:
Create phpast.{version,getast} methods for calling xhpast
with --version and with source code as input, respectively.

Test Plan:
Run arc call-conduit a bunch of times; delete xhpast; run
it a bunch more times.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1534

Differential Revision: https://secure.phabricator.com/D3289

Details

Auditors
epriestley
Provenance
alanhAuthored on
Reviewer
epriestley
Differential Revision
Restricted Differential Revision
Parents
rPd5aaa54d0b8f: Allow installs to configure an arbitrary block of HTML to show on the login…
Branches
Unknown
Tags
Unknown

Event Timeline

I'll make lint detect this, I've been meaning to for a while.

/src/applications/conduit/method/phpast/ConduitAPI_phpast_getast_Method.php
46

This is a syntax error in PHP 5.2.

Gah! Sorry. Now that you mention it, that bu^H^Hfeature does look familiar...

(By "this" I mean closing the commit when I am not you. Apparently yes.)

Yeah, it seemed easier than adding a state like "request verification of satisfactory resolution" or whatever.

@epriestley I think the auditor should be the one who can close a commit. ;) and it should really be their responsibility to remember, rather than committer's responsibility to request it.