HomePhabricator

Use subtler highlighting for copied and moved code
cd63d9b2ce26Unpublished

Unpublished Commit · Learn More

No further details are available.

Description

Use subtler highlighting for copied and moved code

Summary:
The highlighting is distracting according to Nick Shrock and others.
Real designer, Lee Byron, helped me with this.

It also gives us unagressive target for jumping to the source line in future.

Another feature I will probably implement is highlighting also the source of copies/moves.
I will use the right side of the left column for it.

Test Plan:
Hover copied notifier.
Hover coverage notifier.

I've also checked that this doesn't break our super-flaky old/new code JavaScript detector.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Koolvin, leebyron, schrockn

Differential Revision: https://secure.phabricator.com/D2403

Details

Provenance
vranaAuthored on
Reviewer
epriestley
Differential Revision
Restricted Differential Revision
Parents
rP1c5412ebe66b: Unhighlight bright code in coverage
Branches
Unknown
Tags
Unknown

Event Timeline