Paths

Table of Contentst

Diffusion Phabricator 9ba4f24e9304

Send 403 for admin pages without being admin
9ba4f24e9304Unpublished
Actions

Unpublished Commit · Learn More

No further details are available.

Description

Send 403 for admin pages without being admin

Summary: I've also moved the response generation for 404 from

AphrontDefaultApplicationConfiguration `to` buildResponseString()

Test Plan:
Visit /
Visit /mail/
Visit /x/

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley, vrana

Differential Revision: https://secure.phabricator.com/D1406

Details

Provenance

vrana

Authored on

Reviewer

epriestley

Differential Revision

Restricted Differential Revision

Parents

rPd8bbf559592f: Improve behavior when user submits a no-op action in Differential

Branches

Unknown

Tags

Unknown

Event Timeline

Changes (16)

Path

Size

src/

__phutil_library_map__.php

aphront/

default/

configuration/

AphrontDefaultApplicationConfiguration.php

__init__.php

response/

403

	403/
	400/

	Aphront403Response.php
	Aphront400Response.php

404/

Aphront404Response.php

__init__.php

	response/	403/
	default/	controller/

__init__.php

applications/

base/

controller/

base/

PhabricatorController.php

__init__.php

countdown/

controller/

delete/

PhabricatorCountdownDeleteController.php

__init__.php

edit/

PhabricatorCountdownEditController.php

__init__.php

files/

controller/

altview/

PhabricatorFileAltViewController.php

__init__.php

rP9ba4f24e9304

View Options

src/__phutil_library_map__.php

View Options

src/aphront/default/configuration/AphrontDefaultApplicationConfiguration.php

View Options

src/aphront/default/configuration/init.php

View Options

src/aphront/response/403/Aphront403Response.php

View Options

src/aphront/response/403/init.php

View Options

src/aphront/response/404/Aphront404Response.php

View Options

src/aphront/response/404/init.php

View Options

src/applications/base/controller/base/PhabricatorController.php

View Options

src/applications/base/controller/base/init.php

View Options

src/applications/countdown/controller/delete/PhabricatorCountdownDeleteController.php

View Options

src/applications/countdown/controller/delete/init.php

View Options

src/applications/countdown/controller/edit/PhabricatorCountdownEditController.php

View Options

src/applications/countdown/controller/edit/init.php

View Options

src/applications/files/controller/altview/PhabricatorFileAltViewController.php

View Options

src/applications/files/controller/altview/init.php

Send 403 for admin pages without being admin9ba4f24e9304UnpublishedActions

Unpublished Commit · Learn More

Description

AphrontDefaultApplicationConfiguration to buildResponseString()

Details

Event Timeline

Changes (16)

rP9ba4f24e9304

src/__phutil_library_map__.php

src/aphront/default/configuration/AphrontDefaultApplicationConfiguration.php

src/aphront/default/configuration/__init__.php

src/aphront/response/403/Aphront403Response.php

src/aphront/response/403/__init__.php

src/aphront/response/404/Aphront404Response.php

src/aphront/response/404/__init__.php

src/applications/base/controller/base/PhabricatorController.php

src/applications/base/controller/base/__init__.php

src/applications/countdown/controller/delete/PhabricatorCountdownDeleteController.php

src/applications/countdown/controller/delete/__init__.php

src/applications/countdown/controller/edit/PhabricatorCountdownEditController.php

src/applications/countdown/controller/edit/__init__.php

src/applications/files/controller/altview/PhabricatorFileAltViewController.php

src/applications/files/controller/altview/__init__.php

Send 403 for admin pages without being admin
9ba4f24e9304Unpublished
Actions

AphrontDefaultApplicationConfiguration `to` buildResponseString()

src/aphront/default/configuration/init.php

src/aphront/response/403/init.php

src/aphront/response/404/init.php

src/applications/base/controller/base/init.php

src/applications/countdown/controller/delete/init.php

src/applications/countdown/controller/edit/init.php

src/applications/files/controller/altview/init.php