diff --git a/src/applications/project/order/PhabricatorProjectColumnCreatedOrder.php b/src/applications/project/order/PhabricatorProjectColumnCreatedOrder.php index 9fd2145886..5652a96731 100644 --- a/src/applications/project/order/PhabricatorProjectColumnCreatedOrder.php +++ b/src/applications/project/order/PhabricatorProjectColumnCreatedOrder.php @@ -1,35 +1,35 @@ getDateCreated(), - -(int)$object->getID(), + -1 * (int)$object->getDateCreated(), + -1 * (int)$object->getID(), ); } } diff --git a/src/applications/project/order/PhabricatorProjectColumnPointsOrder.php b/src/applications/project/order/PhabricatorProjectColumnPointsOrder.php index ad75f6135b..3cf758cbc8 100644 --- a/src/applications/project/order/PhabricatorProjectColumnPointsOrder.php +++ b/src/applications/project/order/PhabricatorProjectColumnPointsOrder.php @@ -1,50 +1,50 @@ getPoints(); // Put cards with no points on top. $has_points = ($points !== null); if (!$has_points) { $overall_order = 0; } else { $overall_order = 1; } return array( $overall_order, - -(double)$points, - -(int)$object->getID(), + -1.0 * (double)$points, + -1 * (int)$object->getID(), ); } } diff --git a/src/applications/project/order/PhabricatorProjectColumnPriorityOrder.php b/src/applications/project/order/PhabricatorProjectColumnPriorityOrder.php index 1a73145148..10fcafad76 100644 --- a/src/applications/project/order/PhabricatorProjectColumnPriorityOrder.php +++ b/src/applications/project/order/PhabricatorProjectColumnPriorityOrder.php @@ -1,103 +1,103 @@ newHeaderKeyForPriority($object->getPriority()); } private function newHeaderKeyForPriority($priority) { return sprintf('priority(%d)', $priority); } protected function newSortVectorForObject($object) { return $this->newSortVectorForPriority($object->getPriority()); } private function newSortVectorForPriority($priority) { return array( - -(int)$priority, + -1 * (int)$priority, ); } protected function newHeadersForObjects(array $objects) { $priorities = ManiphestTaskPriority::getTaskPriorityMap(); // It's possible for tasks to have an invalid/unknown priority in the // database. We still want to generate a header for these tasks so we // don't break the workboard. $priorities = $priorities + mpull($objects, null, 'getPriority'); $priorities = array_keys($priorities); $headers = array(); foreach ($priorities as $priority) { $header_key = $this->newHeaderKeyForPriority($priority); $sort_vector = $this->newSortVectorForPriority($priority); $priority_name = ManiphestTaskPriority::getTaskPriorityName($priority); $priority_color = ManiphestTaskPriority::getTaskPriorityColor($priority); $priority_icon = ManiphestTaskPriority::getTaskPriorityIcon($priority); $icon_view = id(new PHUIIconView()) ->setIcon($priority_icon, $priority_color); $header = $this->newHeader() ->setHeaderKey($header_key) ->setSortVector($sort_vector) ->setName($priority_name) ->setIcon($icon_view) ->setEditProperties( array( 'value' => (int)$priority, )); $headers[] = $header; } return $headers; } protected function newColumnTransactions($object, array $header) { $new_priority = idx($header, 'value'); if ($object->getPriority() === $new_priority) { return null; } $keyword_map = ManiphestTaskPriority::getTaskPriorityKeywordsMap(); $keyword = head(idx($keyword_map, $new_priority)); $xactions = array(); $xactions[] = $this->newTransaction($object) ->setTransactionType(ManiphestTaskPriorityTransaction::TRANSACTIONTYPE) ->setNewValue($keyword); return $xactions; } }