HomePhabricator

Minor, fix an issue with PhabricatorMenuView and default null keys.

Description

Minor, fix an issue with PhabricatorMenuView and default null keys.

This is kind of gross, but breaking some menus right now which end up with double-'' keys. The current meaning of setKey(null) is different from not calling it (it means setKey('')).

This should be fixed more reasonably but there's a lot of legacy cruft in PhabricatorSideNavFilterView.

Auditors: btrahan

Details

Auditors
btrahan
Group Auditors
Cowboy Commits
Provenance
epriestleyAuthored on
Parents
rP57c001f52244: Select portions from mock
Branches
Unknown
Tags
Unknown

Event Timeline

Thanks and sorry about that

100% my bad, this API is super surprising. I think we can eventually get it behaving sanely, though.

/src/view/layout/PhabricatorMenuView.php
32

whoops - key should be item here. haha, I totally missed it. i'll cowboy commit up a fix.