HomePhabricator

Make X-Herald-Rules header sticky
8370f9304860Unpublished

Unpublished Commit · Learn More

No further details are available.

Description

Make X-Herald-Rules header sticky

Summary:
This isn't terribly elegant but it solves the problem without loss of
generality. We can pursue a more finessed solution later if it seems prudent.

Test Plan:
Created a revision matched by a blanket herald rule, and then commented on it.
Comment email had X-Herald-Rules header in it.

Reviewed By: aran
Reviewers: aran, tuomaspelkonen, jungejason
CC: aran
Differential Revision: 218

Details

Provenance
epriestleyAuthored on
Reviewer
aran
Differential Revision
Restricted Differential Revision
Parents
rP8c031db32baf: Added a link from a diff view to diff's revision if there is one.
Branches
Unknown
Tags
Unknown

Event Timeline