(stable) Promote 2019 Week 37
Audit Required80d17ad7804e
Actions

Description

(stable) Promote 2019 Week 37

Details

Group Auditors

Provenance

epriestley	Authored on Sep 13 2019, 7:34 PM
epriestley	Pushed on Sep 13 2019, 7:34 PM

Parents

rPf87ec6a5dff9: (stable) Don't offer personal saved queries in global "Search Scope" settings…
rP3dcb4a7b5036: Work around rendering engine freeze in Chrome 77 affecting workboards

Branches

Unknown

Tags

Unknown

Build Status

Buildable 23448
Build 32215: Run Core Tests

Event Timeline

epriestley committed rP80d17ad7804e: (stable) Promote 2019 Week 37 (authored by epriestley).Sep 13 2019, 7:34 PM

Herald added an auditor: Cowboy Commits. · View Herald TranscriptSep 13 2019, 7:35 PM

This commit now requires audit.Sep 13 2019, 7:35 PM

Harbormaster completed building B23448: rP80d17ad7804e: (stable) Promote 2019 Week 37.Sep 13 2019, 7:36 PM

Merged Changes

3dcb4a7b5036 Work around rendering engine freeze in Chrome 77 affecting workboards
Author
epriestley
Revisions
D20812: Work around rendering engine freeze in Chrome 77 affecting workboards
Browse Repository
Passed
No Audits
3f6620336216 Fix a straggling callsite to "renderApplicationPolicy()"
Author
epriestley
Revisions
D20811: Fix a straggling callsite to "renderApplicationPolicy()"
Browse Repository
Passed
No Audits
41f0b8b0a3a1 Allow subtypes to specify "mutations", to control the behavior of the "Change…
Author
epriestley
Revisions
D20810: Allow subtypes to specify "mutations", to control the behavior of the "Change Subtype" action
Browse Repository
Passed
No Audits
3e6012803725 Support "Subtype" in Herald
Author
epriestley
Revisions
D20809: Support "Subtype" in Herald
Browse Repository
Passed
No Audits
d60d4e6a0521 Don't present users with Herald fields/actions for uninstalled applications…
Author
epriestley
Revisions
D20808: Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them
Browse Repository
Passed
No Audits
4f845d8f8c77 When users encounter a policy exception for a non-view capability with a custom…
Author
epriestley
Revisions
D20807: When users encounter a policy exception for a non-view capability with a custom policy, inline the policy rules
Browse Repository
Passed
No Audits
0c7ea8c94215 When users fail a "CAN_SEE" check, give them an "opaque" policy explanation
Author
epriestley
Revisions
D20806: When users fail a "CAN_SEE" check, give them an "opaque" policy explanation
Browse Repository
Passed
No Audits
9a36e6931cf7 Inline custom policy rules inside policy capability explanation dialogs
Author
epriestley
Revisions
D20805: Inline custom policy rules inside policy capability explanation dialogs
Browse Repository
Passed
No Audits
506f93b4a390 Give policy name rendering explicit "text name", "capability link", and…
Author
epriestley
Revisions
D20804: Give policy name rendering explicit "text name", "capability link", and "transaction link" pathways
Browse Repository
Passed
No Audits
c9b0d107f079 Remove unused "icon" parameter from policy name rendering
Author
epriestley
Revisions
D20803: Remove unused "icon" parameter from policy name rendering
Browse Repository
Passed
No Audits
9c6969e81022 Remove "Editable By" description fields in Passphrase, Phame, and Spaces
Author
epriestley
Revisions
D20802: Remove "Editable By" description fields in Passphrase, Phame, and Spaces
Browse Repository
Passed
No Audits
a35d7c3c218a Update rendering of policy edit transactions in Applications
Author
epriestley
Revisions
D20801: Update rendering of policy edit transactions in Applications
Browse Repository
Passed
No Audits
a0ade503e166 Remove "Moved Document from ..." notice in Phriction
Author
epriestley
Revisions
D20800: Remove "Moved Document from ..." notice in Phriction
Browse Repository
Passed
No Audits
d2e1c4163a3b When a project has a custom icon, use that icon to label the project policy in…
Author
epriestley
Revisions
D20799: When a project has a custom icon, use that icon to label the project policy in the policy dropown
Browse Repository
Passed
No Audits
1d1a60fdda88 Improve rendering of Herald rules in "Another Herald rule..." field
Author
epriestley
Revisions
D20798: Improve rendering of Herald rules in "Another Herald rule..." field
Browse Repository
Passed
No Audits
7593a265d593 When Herald changes object subscribers, always hide the feed story
Author
epriestley
Revisions
D20797: When Herald changes object subscribers, always hide the feed story
Browse Repository
Passed
No Audits
454771446306 Add a "Remove flag" action to Herald
Author
epriestley
Revisions
D20796: Add a "Remove flag" action to Herald
Browse Repository
Passed
No Audits
d965d9a669b5 Index Herald fields, not just actions, when identifying objects related to a…
Author
epriestley
Revisions
D20795: Index Herald fields, not just actions, when identifying objects related to a particular Herald rule
Browse Repository
Passed
No Audits
aaaea5759133 Fix fatal during redirection safety check for searching for Phabricator base…
Author
epriestley
Revisions
D20794: Fix fatal during redirection safety check for searching for Phabricator base-uri with no trailing slash
Browse Repository
Passed
No Audits
278092974f2f Don't offer personal saved queries in global "Search Scope" settings dropdown
Author
epriestley
Revisions
D20793: Don't offer personal saved queries in global "Search Scope" settings dropdown
Browse Repository
Passed
No Audits
63c7302af130 Fix global search scope fatal on 404 page (or other pages with no Application)
Author
epriestley
Revisions
D20792: Fix global search scope fatal on 404 page (or other pages with no Application)
Browse Repository
Passed
No Audits
535c8e6bdc1e Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the setup key…
Author
epriestley
Revisions
D20791: Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the setup key for "STRICT_ALL_TABLES"
Browse Repository
Passed
No Audits
f16365ed0778 Weaken the guidance recommending that installs enable "STRICT_ALL_TABLES"
Author
epriestley
Revisions
D20790: Weaken the guidance recommending that installs enable "STRICT_ALL_TABLES"
Browse Repository
Passed
No Audits

Changes (46)

Path

Size

resources/

celerity/

map.php

sql/

autopatches/

20190909.herald.01.rebuild.php

src/

__phutil_library_map__.php

applications/

config/

check/

PhabricatorMySQLSetupCheck.php

flag/

herald/

PhabricatorFlagAddFlagHeraldAction.php

PhabricatorFlagHeraldAction.php

PhabricatorFlagRemoveFlagHeraldAction.php

harbormaster/

herald/

HarbormasterRunBuildPlansHeraldAction.php

herald/

action/

HeraldAction.php

adapter/

HeraldAdapter.php

controller/

HeraldRuleController.php

engineextension/

HeraldRuleIndexEngineExtension.php

field/

HeraldField.php

storage/

HeraldRule.php

legalpad/

herald/

LegalpadRequireSignatureHeraldAction.php

maniphest/

config/

PhabricatorManiphestConfigOptions.php

storage/

ManiphestTask.php

meta/

engineextension/

PhabricatorDatasourceURIEngineExtension.php

xactions/

PhabricatorApplicationPolicyChangeTransaction.php

passphrase/

controller/

PassphraseCredentialViewController.php

phame/

controller/

blog/

PhameBlogManageController.php

phriction/

controller/

PhrictionDocumentController.php

xaction/

PhrictionDocumentMoveToTransaction.php

policy/

controller/

PhabricatorPolicyExplainController.php

filter/

PhabricatorPolicyFilter.php

management/

PhabricatorPolicyManagementShowWorkflow.php

query/

PhabricatorPolicyQuery.php

storage/

PhabricatorPolicy.php

view/

PHUIPolicySectionView.php

PhabricatorPolicyRef.php

PhabricatorPolicyRulesView.php

project/

storage/

PhabricatorProject.php

spaces/

controller/

PhabricatorSpacesViewController.php

transactions/

controller/

PhabricatorApplicationTransactionValueController.php

editengine/

PhabricatorEditEngineSubtype.php

PhabricatorEditEngineSubtypeMap.php

engineextension/

PhabricatorSubtypeEditEngineExtension.php

herald

PhabricatorEditEngineSubtypeHeraldField.php

storage/

PhabricatorApplicationTransaction.php

PhabricatorModularTransactionType.php

docs/

user/

userguide/

unlocking.diviner

webroot/

rsrc/

css/

phui/

phui-header-view.css

phui-policy-section-view.css

workboards/

phui-workcard.css

js/

application/

herald/

HeraldRuleEditor.js

rP80d17ad7804e

View Options

resources/celerity/map.php

View Options

resources/sql/autopatches/20190909.herald.01.rebuild.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/config/check/PhabricatorMySQLSetupCheck.php

View Options

src/applications/flag/herald/PhabricatorFlagAddFlagHeraldAction.php

View Options

src/applications/flag/herald/PhabricatorFlagHeraldAction.php

View Options

src/applications/flag/herald/PhabricatorFlagRemoveFlagHeraldAction.php

View Options

src/applications/harbormaster/herald/HarbormasterRunBuildPlansHeraldAction.php

View Options

src/applications/herald/action/HeraldAction.php

View Options

src/applications/herald/adapter/HeraldAdapter.php

View Options

src/applications/herald/controller/HeraldRuleController.php

View Options

src/applications/herald/engineextension/HeraldRuleIndexEngineExtension.php

View Options

src/applications/herald/field/HeraldField.php

View Options

src/applications/herald/storage/HeraldRule.php

View Options

src/applications/legalpad/herald/LegalpadRequireSignatureHeraldAction.php

View Options

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

View Options

src/applications/maniphest/storage/ManiphestTask.php

View Options

src/applications/meta/engineextension/PhabricatorDatasourceURIEngineExtension.php

View Options

src/applications/meta/xactions/PhabricatorApplicationPolicyChangeTransaction.php

View Options

src/applications/passphrase/controller/PassphraseCredentialViewController.php

View Options

src/applications/phame/controller/blog/PhameBlogManageController.php

View Options

src/applications/phriction/controller/PhrictionDocumentController.php

View Options

src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php

View Options

src/applications/policy/controller/PhabricatorPolicyExplainController.php

View Options

src/applications/policy/filter/PhabricatorPolicyFilter.php

View Options

src/applications/policy/management/PhabricatorPolicyManagementShowWorkflow.php

View Options

src/applications/policy/query/PhabricatorPolicyQuery.php

View Options

src/applications/policy/storage/PhabricatorPolicy.php

View Options

src/applications/policy/view/PHUIPolicySectionView.php

View Options

src/applications/policy/view/PhabricatorPolicyRef.php

View Options

src/applications/policy/view/PhabricatorPolicyRulesView.php

View Options

src/applications/project/storage/PhabricatorProject.php

View Options

src/applications/spaces/controller/PhabricatorSpacesViewController.php

View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngineSubtypeMap.php

View Options

src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php

View Options

src/applications/transactions/herald/PhabricatorEditEngineSubtypeHeraldField.php

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

View Options

src/docs/user/userguide/unlocking.diviner

View Options

webroot/rsrc/css/phui/phui-header-view.css

View Options

webroot/rsrc/css/phui/phui-policy-section-view.css

View Options

webroot/rsrc/css/phui/workboards/phui-workcard.css

View Options

webroot/rsrc/js/application/herald/HeraldRuleEditor.js

(stable) Promote 2019 Week 37Audit Required80d17ad7804eActions

Description

Details

Event Timeline

Merged Changes

Changes (46)

rP80d17ad7804e

resources/celerity/map.php

resources/sql/autopatches/20190909.herald.01.rebuild.php

src/__phutil_library_map__.php

src/applications/config/check/PhabricatorMySQLSetupCheck.php

src/applications/flag/herald/PhabricatorFlagAddFlagHeraldAction.php

src/applications/flag/herald/PhabricatorFlagHeraldAction.php

src/applications/flag/herald/PhabricatorFlagRemoveFlagHeraldAction.php

src/applications/harbormaster/herald/HarbormasterRunBuildPlansHeraldAction.php

src/applications/herald/action/HeraldAction.php

src/applications/herald/adapter/HeraldAdapter.php

src/applications/herald/controller/HeraldRuleController.php

src/applications/herald/engineextension/HeraldRuleIndexEngineExtension.php

src/applications/herald/field/HeraldField.php

src/applications/herald/storage/HeraldRule.php

src/applications/legalpad/herald/LegalpadRequireSignatureHeraldAction.php

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

src/applications/maniphest/storage/ManiphestTask.php

src/applications/meta/engineextension/PhabricatorDatasourceURIEngineExtension.php

src/applications/meta/xactions/PhabricatorApplicationPolicyChangeTransaction.php

src/applications/passphrase/controller/PassphraseCredentialViewController.php

src/applications/phame/controller/blog/PhameBlogManageController.php

src/applications/phriction/controller/PhrictionDocumentController.php

src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php

src/applications/policy/controller/PhabricatorPolicyExplainController.php

src/applications/policy/filter/PhabricatorPolicyFilter.php

src/applications/policy/management/PhabricatorPolicyManagementShowWorkflow.php

src/applications/policy/query/PhabricatorPolicyQuery.php

src/applications/policy/storage/PhabricatorPolicy.php

src/applications/policy/view/PHUIPolicySectionView.php

src/applications/policy/view/PhabricatorPolicyRef.php

src/applications/policy/view/PhabricatorPolicyRulesView.php

src/applications/project/storage/PhabricatorProject.php

src/applications/spaces/controller/PhabricatorSpacesViewController.php

src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php

src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php

src/applications/transactions/editengine/PhabricatorEditEngineSubtypeMap.php

src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php

src/applications/transactions/herald/PhabricatorEditEngineSubtypeHeraldField.php

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

src/applications/transactions/storage/PhabricatorModularTransactionType.php

src/docs/user/userguide/unlocking.diviner

webroot/rsrc/css/phui/phui-header-view.css

webroot/rsrc/css/phui/phui-policy-section-view.css

webroot/rsrc/css/phui/workboards/phui-workcard.css

webroot/rsrc/js/application/herald/HeraldRuleEditor.js

(stable) Promote 2019 Week 37
Audit Required80d17ad7804e
Actions