HomePhabricator

Simplify and demuddle MetaMTA send pathways
6bec3d2e4fc2Unpublished

Tags
None
Subscribers
None
Tokens
"Heartbreak" token, awarded by tanvirsobhanwe.

Unpublished Commit · Learn More

No further details are available.

Description

Simplify and demuddle MetaMTA send pathways

Summary:
I pretty shortsightedly made sending a side effect of save() in the case that a
server is configured for immediate sending. Move this out, make it explicit, and
get rid of all the tangles surrounding it.

The web tool now ignores the server setting and only repsects the checkbox,
which makes far more sense.

Test Plan:
Sent mails from Maniphest, Differential, and the web console. Also ran all the
unit tests. Verified headers from Maniphest.

Reviewed By: rm
Reviewers: aran, rm
CC: tuomaspelkonen, rm, jungejason, aran
Differential Revision: 200

Details

Provenance
epriestleyAuthored on
Reviewer
rm
Differential Revision
Restricted Differential Revision
Parents
rP91d009664b08: Update standards documentation
Branches
Unknown
Tags
Unknown