diff --git a/src/applications/diffusion/herald/DiffusionAuditorsHeraldAction.php b/src/applications/diffusion/herald/DiffusionAuditorsHeraldAction.php index 3c34876995..2ca2ee2b6b 100644 --- a/src/applications/diffusion/herald/DiffusionAuditorsHeraldAction.php +++ b/src/applications/diffusion/herald/DiffusionAuditorsHeraldAction.php @@ -1,81 +1,74 @@ getAdapter(); $object = $adapter->getObject(); $auditors = $object->getAudits(); $current = array(); foreach ($auditors as $auditor) { if ($auditor->isInteresting()) { $current[] = $auditor->getAuditorPHID(); } } $allowed_types = array( PhabricatorPeopleUserPHIDType::TYPECONST, PhabricatorProjectProjectPHIDType::TYPECONST, PhabricatorOwnersPackagePHIDType::TYPECONST, ); $targets = $this->loadStandardTargets($phids, $allowed_types, $current); if (!$targets) { return; } $phids = array_fuse(array_keys($targets)); - // TODO: Convert this to be translatable, structured data eventually. - $reason_map = array(); - foreach ($phids as $phid) { - $reason_map[$phid][] = pht('%s Triggered Audit', $rule->getMonogram()); - } - $xaction = $adapter->newTransaction() - ->setTransactionType(PhabricatorAuditActionConstants::ADD_AUDITORS) - ->setNewValue($phids) - ->setMetadataValue( - 'auditStatus', - PhabricatorAuditStatusConstants::AUDIT_REQUIRED) - ->setMetadataValue('auditReasonMap', $reason_map); + ->setTransactionType(DiffusionCommitAuditorsTransaction::TRANSACTIONTYPE) + ->setNewValue( + array( + '+' => $phids, + )); $adapter->queueTransaction($xaction); $this->logEffect(self::DO_ADD_AUDITORS, $phids); } protected function getActionEffectMap() { return array( self::DO_ADD_AUDITORS => array( 'icon' => 'fa-user', 'color' => 'green', 'name' => pht('Added Auditors'), ), ); } protected function renderActionEffectDescription($type, $data) { switch ($type) { case self::DO_ADD_AUDITORS: return pht( 'Added %s auditor(s): %s.', phutil_count($data), $this->renderHandleList($data)); } } }