HomePhabricator

Drop the `metamta_mailinglist` table

Description

Drop the metamta_mailinglist table

Summary: We haven't seen any issues here, remove the table and schema spec.

Test Plan: Not yet tested.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14067

Details

Auditors
tycho.tatitscheff
Provenance
joshuaspenceAuthored on
industryPushed on Oct 31 2015, 11:21 AM
Reviewer
Blessed Reviewers
Differential Revision
D14067: Drop the `metamta_mailinglist` table
Parents
rP4626fb4ef00f: Update "should not run as root" message
Branches
Unknown
Tags
Unknown
Build Status
Buildable 8510
Build 9812: Run Core Tests

Event Timeline

Did you arc liberate ?? Running storage upgrade before arc liberating it produces :

[2015-10-31 18:00:22] EXCEPTION: (PhutilBootloaderException) Include of '/opt/phabricator/src/applications/mailinglists/storage/PhabricatorMetaMTAMailingList.php' failed! at [<phutil>/src/moduleutils/PhutilBootloader.php:218]
arcanist(head=master, ref.master=baf5eb8a8795), phabricator(head=master, ref.master=3a046384e97e), phutil(head=master, ref.master=59f5a8d2bb82), sprint(head=master, ref.master=b1992b712ef4)
  #0 PhutilBootloader::loadLibrarySource(string, string) called at [<phutil>/src/symbols/PhutilSymbolLoader.php:381]
  #1 PhutilSymbolLoader::loadSymbol(array) called at [<phutil>/src/symbols/PhutilSymbolLoader.php:256]
  #2 PhutilSymbolLoader::selectAndLoadSymbols() called at [<phutil>/src/symbols/PhutilSymbolLoader.php:324]
  #3 PhutilSymbolLoader::loadObjects() called at [<phutil>/src/symbols/PhutilClassMapQuery.php:228]
  #4 PhutilClassMapQuery::loadMap() called at [<phutil>/src/symbols/PhutilClassMapQuery.php:179]
  #5 PhutilClassMapQuery::execute() called at [<phabricator>/src/applications/config/schema/PhabricatorConfigCoreSchemaSpec.php:14]
  #6 PhabricatorConfigCoreSchemaSpec::buildSchemata(PhabricatorConfigServerSchema) called at [<phabricator>/src/applications/config/schema/PhabricatorConfigSchemaQuery.php:172]
  #7 PhabricatorConfigSchemaQuery::loadExpectedSchema() called at [<phabricator>/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php:33]
  #8 PhabricatorStorageManagementWorkflow::loadSchemata() called at [<phabricator>/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php:352]
  #9 PhabricatorStorageManagementWorkflow::findAdjustments() called at [<phabricator>/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php:46]
  #10 PhabricatorStorageManagementWorkflow::adjustSchemata(boolean, boolean, boolean) called at [<phabricator>/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementUpgradeWorkflow.php:226]
  #11 PhabricatorStorageManagementUpgradeWorkflow::execute(PhutilArgumentParser) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:406]
  #12 PhutilArgumentParser::parseWorkflowsFull(array) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:301]
  #13 PhutilArgumentParser::parseWorkflows(array) called at [<phabricator>/scripts/sql/manage_storage.php:176]

seem's to work with :

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 81b8d55..398d212 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -2410,7 +2410,6 @@ phutil_register_library_map(array(
     'PhabricatorMetaMTAMailableDatasource' => 'applications/metamta/typeahead/PhabricatorMetaMTAMailableDatasource.php',
     'PhabricatorMetaMTAMailableFunctionDatasource' => 'applications/metamta/typeahead/PhabricatorMetaMTAMailableFunctionDatasource.php',
     'PhabricatorMetaMTAMailgunReceiveController' => 'applications/metamta/controller/PhabricatorMetaMTAMailgunReceiveController.php',
-    'PhabricatorMetaMTAMailingList' => 'applications/mailinglists/storage/PhabricatorMetaMTAMailingList.php',
     'PhabricatorMetaMTAMemberQuery' => 'applications/metamta/query/PhabricatorMetaMTAMemberQuery.php',
     'PhabricatorMetaMTAPermanentFailureException' => 'applications/metamta/exception/PhabricatorMetaMTAPermanentFailureException.php',
     'PhabricatorMetaMTAReceivedMail' => 'applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php',
@@ -6470,7 +6469,6 @@ phutil_register_library_map(array(
     'PhabricatorMetaMTAMailableDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
     'PhabricatorMetaMTAMailableFunctionDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
     'PhabricatorMetaMTAMailgunReceiveController' => 'PhabricatorMetaMTAController',
-    'PhabricatorMetaMTAMailingList' => 'PhabricatorMetaMTADAO',
     'PhabricatorMetaMTAMemberQuery' => 'PhabricatorQuery',
     'PhabricatorMetaMTAPermanentFailureException' => 'Exception',
     'PhabricatorMetaMTAReceivedMail' => 'PhabricatorMetaMTADAO',