HomePhabricator

Prevent Phabot from spinning out of control
39adae9aa85eUnpublished

Unpublished Commit · Learn More

No further details are available.

Description

Prevent Phabot from spinning out of control

Summary: When the remote closes the connection, phabot goes into a busy loop
because of PHP's "nothing should ever be an error" semantics. Instead, detect
connection termination.
Test Plan: Disabled the "PONG" response in the protocol handler and let freenode
disconnect phabot. It spun out of control before, now it detects the issue and
exits to await automatic restart.
Reviewed By: jungejason
Reviewers: codeblock, jungejason, aran, tuomaspelkonen
CC: aran, jungejason
Differential Revision: 582

Details

Provenance
epriestleyAuthored on
Reviewer
jungejason
Differential Revision
Restricted Differential Revision
Parents
rPcd47271cf5e7: Handle the case when a repository was deleted
Branches
Unknown
Tags
Unknown

Event Timeline