HomePhabricator

Prevent file download without POST + CSRF
355b753df70cUnpublished

Unpublished Commit · Learn More

No further details are available.

Description

Prevent file download without POST + CSRF

Summary: This prevents <applet /> attacks unless the attacker can upload an
applet which has a viewable MIME type as detected by file. I'm not sure if
this is possible or not. It should, at least, narrow the attack window. There
are no real tradeoffs here, this is probably a strictly better application
behavior regardless of the security issues.
Test Plan:

  • Tried to download a file via GET, got redirected to info.
  • Downloaded a file via POST + CSRF from the info page.

Reviewers: andrewjcg, erling, aran, jungejason, tuomaspelkonen
CC: aran
Differential Revision: 759

Details

Provenance
epriestleyAuthored on
Differential Revision
Restricted Differential Revision
Parents
rP3aa17c74436e: Prevent CSRF uploads via /file/dropupload/
Branches
Unknown
Tags
Unknown

Event Timeline