diff --git a/src/applications/differential/customfield/DifferentialManiphestTasksField.php b/src/applications/differential/customfield/DifferentialManiphestTasksField.php index 0f34c12ab8..b13cfcc304 100644 --- a/src/applications/differential/customfield/DifferentialManiphestTasksField.php +++ b/src/applications/differential/customfield/DifferentialManiphestTasksField.php @@ -1,114 +1,114 @@ getFieldName(); } - public function readValueFromRevision(DifferentialRevision $revision) { + protected function readValueFromRevision(DifferentialRevision $revision) { if (!$revision->getPHID()) { return array(); } return PhabricatorEdgeQuery::loadDestinationPHIDs( $revision->getPHID(), DifferentialRevisionHasTaskEdgeType::EDGECONST); } public function getApplicationTransactionType() { return PhabricatorTransactions::TYPE_EDGE; } public function getApplicationTransactionMetadata() { return array( 'edge:type' => DifferentialRevisionHasTaskEdgeType::EDGECONST, ); } public function getNewValueForApplicationTransactions() { $edges = array(); foreach ($this->getValue() as $phid) { $edges[$phid] = $phid; } return array('=' => $edges); } public function getRequiredHandlePHIDsForPropertyView() { return $this->getValue(); } public function renderPropertyViewValue(array $handles) { return $this->renderHandleList($handles); } public function shouldAppearInCommitMessage() { return true; } public function shouldAllowEditInCommitMessage() { return true; } public function getCommitMessageLabels() { return array( 'Maniphest Task', 'Maniphest Tasks', ); } public function parseValueFromCommitMessage($value) { return $this->parseObjectList( $value, array( ManiphestTaskPHIDType::TYPECONST, )); } public function getRequiredHandlePHIDsForCommitMessage() { return $this->getRequiredHandlePHIDsForPropertyView(); } public function renderCommitMessageValue(array $handles) { return $this->renderObjectList($handles); } public function getProTips() { return array( pht( 'Write "Fixes T123" in your summary to automatically close the '. 'corresponding task when this change lands.'), ); } }