HomePhabricator

Migrate all Differential reviewer data to edges

Authored by epriestley.

Description

Migrate all Differential reviewer data to edges

Summary:
Ref T1279. @champo did a lot of this work already; we've been doing double writes for a long time.

Add "double reads" (reading the edge table as both the "relationship" table and as the "reviewer status" table), and migrate all the data.

I'm not bothering to try to recover old reviewer status (e.g., we could infer from transactions who accepted old revisions) because it wold be very complicated and doesn't seem too valuable.

Test Plan:

  • Without doing the migration, used Differential. Verified that reads and writes worked. Most of the data was there anyway since we've been double-writing.
  • Performed the migration. Verified that everything was still unchanged.
  • Dropped the edge table, verified all reviweer data vanished.
  • Migrated again, verified the reviewer stuff was restored.
  • Did various cc/reviewer/subscriber queries, got consistent results.

Reviewers: btrahan

Reviewed By: btrahan

CC: champo, aran

Maniphest Tasks: T1279

Differential Revision: https://secure.phabricator.com/D7227

Details

Committed
epriestleyOct 5 2013, 8:48 PM
Reviewer
btrahan
Differential Revision
Restricted Differential Revision
Tasks
T1279: Show per-reviewer status in Differential revision reviewer list
This commit no longer exists in the repository. It may have been part of a branch which was deleted.

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.