HomePhabricator

Provide basic keyboard navigation support for Differential.
17306b7a92bbUnpublished

Unpublished Commit · Learn More

No further details are available.

Description

Provide basic keyboard navigation support for Differential.

Summary:
ReviewBoard has a fancier version of this feature that's more granular -- the
keyboard can focus on individual changes. I think that's good and intend to
implement something similar, but this gets us a step closer and gets rid of some
of the bookkeeping stuff like making shortcuts discoverable.

(I have another brnach with Maniphest merging which also uses fatcow icons,
which is why the README seems a little out of context.)

Test Plan:
Used "j" and "k" to jump between changesets. Pressed "?" and got a list of
available shortcuts.

Reviewed By: tuomaspelkonen
Reviewers: aran, jungejason, tuomaspelkonen
CC: moskov, aran, epriestley, tuomaspelkonen
Differential Revision: 412

Details

Provenance
epriestleyAuthored on
Reviewer
tuomaspelkonen
Differential Revision
Restricted Differential Revision
Parents
rP1e5fd3a3864f: Fix Herald exception when updating a diff that has carryover CCs
Branches
Unknown
Tags
Unknown

Event Timeline