HomePhabricator
Diffusion Phabricator 11cccb98c2be

Add "final" to more classes
11cccb98c2beUnpublished
Actions

Unpublished Commit ยท Learn More

No further details are available.

Description

Add "final" to more classes

Summary: No big surprises here, delted the unused "DarkConsole" class.

Test Plan: Ran 'testEverythingImplemented' to verify I wasn't finalizing anything we extend.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T795

Differential Revision: https://secure.phabricator.com/D1876

Details

Provenance
epriestleyAuthored on
Reviewer
btrahan
Differential Revision
Restricted Differential Revision
Parents
rP49366559af53: Various minor Audit UI improvements
Branches
Unknown
Tags
Unknown

Event Timeline

Changes (127)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.
PathSize
src/
aphront/
console/
plugin/
config/
errorlog/
api/
event/
api/
request/
services/
xhprof/
exception/
base/
csrf/
redirect/
request/
__tests__/
response/
304/
400/
403/
404/
file/
plaintext/
redirect/
reload/
webpage/
applications/
audit/
storage/
auditcomment/
auth/
oauth/
provider/
facebook/
github/
google/
view/
oauthfailure/
conduit/
method/
arcanist/
projectinfo/
conduit/
connect/
getcertificate/
ping/
daemon/
launched/
log/
differential/
createcomment/
creatediff/
createrevision/
find/
getalldiffs/
getcommitmessage/
getcommitpaths/
getdiff/
getrevision/
getrevisioncomments/
getrevisionfeedback/
markcommitted/
parsecommitmessage/
query/
setdiffproperty/
updaterevision/
updatetaskrevisionassoc/
updateunitresults/
diffusion/
findsymbols/
getcommits/
getrecentcommitsbypath/
feed/
publish/
file/
download/
info/
upload/
maniphest/
gettasktransactions/
paste/
create/
info/
path/
getowners/
phriction/
edit/
history/
info/
slowvote/
info/
protocol/
exception/
request/
response/
storage/
connectionlog/
token/
countdown/
storage/
timer/
differential/
data/
revisionlist/
editor/
comment/
revision/
field/
exception/
validation/
mail/
ccwelcome/
comment/
diffcontent/
exception/
newdiff/
parser/
changeset/
replyhandler/
storage/
changeset/
comment/
diff/
diffproperty/
hunk/
inlinecomment/
revision/
view/
changesetdetailview/
changesetlistview/
diffusion/
query/
pathchange/
base/
request/
base/
git/
mercurial/
svn/
directory/
storage/
category/
item/
draft/
storage/
base/
draft/
drydock/
blueprint/
ec2host/
remotehost/
storage/
base/
lease/
resource/
feed/
storage/
base/
story/
storyreference/
story/
differential/
maniphest/
phriction/
project/
status/
unknown/
view/
story/
files/
storage/
base/
file/
imagemacro/
proxyimage/
storageblob/
transformed/
phriction/
controller/
diff/

rP11cccb98c2be

View Options

src/__phutil_library_map__.php

View Options

src/aphront/console/api

View Options

src/aphront/console/api/DarkConsole.php

View Options

src/aphront/console/api/__init__.php

View Options

src/aphront/console/plugin/config/DarkConsoleConfigPlugin.php

View Options

src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPlugin.php

View Options

src/aphront/console/plugin/errorlog/api/DarkConsoleErrorLogPluginAPI.php

View Options

src/aphront/console/plugin/event/DarkConsoleEventPlugin.php

View Options

src/aphront/console/plugin/event/api/DarkConsoleEventPluginAPI.php

View Options

src/aphront/console/plugin/request/DarkConsoleRequestPlugin.php

View Options

src/aphront/console/plugin/services/DarkConsoleServicesPlugin.php

View Options

src/aphront/console/plugin/xhprof/DarkConsoleXHProfPlugin.php

View Options

src/aphront/exception/base/AphrontException.php

View Options

src/aphront/exception/csrf/AphrontCSRFException.php

View Options

src/aphront/exception/redirect/AphrontRedirectException.php

View Options

src/aphront/request/AphrontRequest.php

View Options

src/aphront/request/__tests__/AphrontRequestTestCase.php

View Options

src/aphront/response/304/Aphront304Response.php

View Options

src/aphront/response/400/Aphront400Response.php

View Options

src/aphront/response/403/Aphront403Response.php

View Options

src/aphront/response/404/Aphront404Response.php

View Options

src/aphront/response/file/AphrontFileResponse.php

View Options

src/aphront/response/plaintext/AphrontPlainTextResponse.php

View Options

src/aphront/response/redirect/AphrontRedirectResponse.php

View Options

src/aphront/response/reload/AphrontReloadResponse.php

View Options

src/aphront/response/webpage/AphrontWebpageResponse.php

View Options

src/applications/audit/storage/auditcomment/PhabricatorAuditComment.php

View Options

src/applications/auth/oauth/provider/facebook/PhabricatorOAuthProviderFacebook.php

View Options

src/applications/auth/oauth/provider/github/PhabricatorOAuthProviderGitHub.php

View Options

src/applications/auth/oauth/provider/google/PhabricatorOAuthProviderGoogle.php

View Options

src/applications/auth/view/oauthfailure/PhabricatorOAuthFailureView.php

View Options

src/applications/conduit/method/arcanist/projectinfo/ConduitAPI_arcanist_projectinfo_Method.php

View Options

src/applications/conduit/method/conduit/connect/ConduitAPI_conduit_connect_Method.php

View Options

src/applications/conduit/method/conduit/getcertificate/ConduitAPI_conduit_getcertificate_Method.php

View Options

src/applications/conduit/method/conduit/ping/ConduitAPI_conduit_ping_Method.php

View Options

src/applications/conduit/method/daemon/launched/ConduitAPI_daemon_launched_Method.php

View Options

src/applications/conduit/method/daemon/log/ConduitAPI_daemon_log_Method.php

View Options

src/applications/conduit/method/differential/createcomment/ConduitAPI_differential_createcomment_Method.php

View Options

src/applications/conduit/method/differential/creatediff/ConduitAPI_differential_creatediff_Method.php

View Options

src/applications/conduit/method/differential/createrevision/ConduitAPI_differential_createrevision_Method.php

View Options

src/applications/conduit/method/differential/find/ConduitAPI_differential_find_Method.php

View Options

src/applications/conduit/method/differential/getalldiffs/ConduitAPI_differential_getalldiffs_Method.php

View Options

src/applications/conduit/method/differential/getcommitmessage/ConduitAPI_differential_getcommitmessage_Method.php

View Options

src/applications/conduit/method/differential/getcommitpaths/ConduitAPI_differential_getcommitpaths_Method.php

View Options

src/applications/conduit/method/differential/getdiff/ConduitAPI_differential_getdiff_Method.php

View Options

src/applications/conduit/method/differential/getrevision/ConduitAPI_differential_getrevision_Method.php

View Options

src/applications/conduit/method/differential/getrevisioncomments/ConduitAPI_differential_getrevisioncomments_Method.php

View Options

src/applications/conduit/method/differential/getrevisionfeedback/ConduitAPI_differential_getrevisionfeedback_Method.php

View Options

src/applications/conduit/method/differential/markcommitted/ConduitAPI_differential_markcommitted_Method.php

View Options

src/applications/conduit/method/differential/parsecommitmessage/ConduitAPI_differential_parsecommitmessage_Method.php

View Options

src/applications/conduit/method/differential/query/ConduitAPI_differential_query_Method.php

View Options

src/applications/conduit/method/differential/setdiffproperty/ConduitAPI_differential_setdiffproperty_Method.php

View Options

src/applications/conduit/method/differential/updaterevision/ConduitAPI_differential_updaterevision_Method.php

View Options

src/applications/conduit/method/differential/updatetaskrevisionassoc/ConduitAPI_differential_updatetaskrevisionassoc_Method.php

View Options

src/applications/conduit/method/differential/updateunitresults/ConduitAPI_differential_updateunitresults_Method.php

View Options

src/applications/conduit/method/diffusion/findsymbols/ConduitAPI_diffusion_findsymbols_Method.php

View Options

src/applications/conduit/method/diffusion/getcommits/ConduitAPI_diffusion_getcommits_Method.php

View Options

src/applications/conduit/method/diffusion/getrecentcommitsbypath/ConduitAPI_diffusion_getrecentcommitsbypath_Method.php

View Options

src/applications/conduit/method/feed/publish/ConduitAPI_feed_publish_Method.php

View Options

src/applications/conduit/method/file/download/ConduitAPI_file_download_Method.php

View Options

src/applications/conduit/method/file/info/ConduitAPI_file_info_Method.php

View Options

src/applications/conduit/method/file/upload/ConduitAPI_file_upload_Method.php

View Options

src/applications/conduit/method/maniphest/gettasktransactions/ConduitAPI_maniphest_gettasktransactions_Method.php

View Options

src/applications/conduit/method/paste/create/ConduitAPI_paste_create_Method.php

View Options

src/applications/conduit/method/paste/info/ConduitAPI_paste_info_Method.php

View Options

src/applications/conduit/method/path/getowners/ConduitAPI_path_getowners_Method.php

View Options

src/applications/conduit/method/phriction/edit/ConduitAPI_phriction_edit_Method.php

View Options

src/applications/conduit/method/phriction/history/ConduitAPI_phriction_history_Method.php

View Options

src/applications/conduit/method/phriction/info/ConduitAPI_phriction_info_Method.php

View Options

src/applications/conduit/method/slowvote/info/ConduitAPI_slowvote_info_Method.php

View Options

src/applications/conduit/protocol/exception/ConduitException.php

View Options

src/applications/conduit/protocol/request/ConduitAPIRequest.php

View Options

src/applications/conduit/protocol/response/ConduitAPIResponse.php

View Options

src/applications/conduit/storage/connectionlog/PhabricatorConduitConnectionLog.php

View Options

src/applications/conduit/storage/token/PhabricatorConduitCertificateToken.php

View Options

src/applications/countdown/storage/timer/PhabricatorTimer.php

View Options

src/applications/differential/data/revisionlist/DifferentialRevisionListData.php

View Options

src/applications/differential/editor/comment/DifferentialCommentEditor.php

View Options

src/applications/differential/editor/revision/DifferentialRevisionEditor.php

View Options

src/applications/differential/field/exception/validation/DifferentialFieldValidationException.php

View Options

src/applications/differential/mail/ccwelcome/DifferentialCCWelcomeMail.php

View Options

src/applications/differential/mail/comment/DifferentialCommentMail.php

View Options

src/applications/differential/mail/diffcontent/DifferentialDiffContentMail.php

View Options

src/applications/differential/mail/exception/DifferentialExceptionMail.php

View Options

src/applications/differential/mail/newdiff/DifferentialNewDiffMail.php

View Options

src/applications/differential/parser/changeset/DifferentialChangesetParser.php

View Options

src/applications/differential/replyhandler/DifferentialReplyHandler.php

View Options

src/applications/differential/storage/changeset/DifferentialChangeset.php

View Options

src/applications/differential/storage/comment/DifferentialComment.php

View Options

src/applications/differential/storage/diff/DifferentialDiff.php

View Options

src/applications/differential/storage/diffproperty/DifferentialDiffProperty.php

View Options

src/applications/differential/storage/hunk/DifferentialHunk.php

View Options

src/applications/differential/storage/inlinecomment/DifferentialInlineComment.php

View Options

src/applications/differential/storage/revision/DifferentialRevision.php

View Options

src/applications/differential/view/changesetdetailview/DifferentialChangesetDetailView.php

View Options

src/applications/differential/view/changesetlistview/DifferentialChangesetListView.php

View Options

src/applications/diffusion/query/pathchange/base/DiffusionPathChangeQuery.php

View Options

src/applications/diffusion/request/base/DiffusionRequest.php

View Options

src/applications/diffusion/request/git/DiffusionGitRequest.php

View Options

src/applications/diffusion/request/mercurial/DiffusionMercurialRequest.php

View Options

src/applications/diffusion/request/svn/DiffusionSvnRequest.php

View Options

src/applications/directory/storage/category/PhabricatorDirectoryCategory.php

View Options

src/applications/directory/storage/item/PhabricatorDirectoryItem.php

View Options

src/applications/draft/storage/base/PhabricatorDraftDAO.php

View Options

src/applications/draft/storage/draft/PhabricatorDraft.php

View Options

src/applications/drydock/blueprint/ec2host/DrydockEC2HostBlueprint.php

View Options

src/applications/drydock/blueprint/remotehost/DrydockRemoteHostBlueprint.php

View Options

src/applications/drydock/storage/base/DrydockDAO.php

View Options

src/applications/drydock/storage/lease/DrydockLease.php

View Options

src/applications/drydock/storage/resource/DrydockResource.php

View Options

src/applications/feed/storage/base/PhabricatorFeedDAO.php

View Options

src/applications/feed/storage/story/PhabricatorFeedStoryData.php

View Options

src/applications/feed/storage/storyreference/PhabricatorFeedStoryReference.php

View Options

src/applications/feed/story/differential/PhabricatorFeedStoryDifferential.php

View Options

src/applications/feed/story/maniphest/PhabricatorFeedStoryManiphest.php

View Options

src/applications/feed/story/phriction/PhabricatorFeedStoryPhriction.php

View Options

src/applications/feed/story/project/PhabricatorFeedStoryProject.php

View Options

src/applications/feed/story/status/PhabricatorFeedStoryStatus.php

View Options

src/applications/feed/story/unknown/PhabricatorFeedStoryUnknown.php

View Options

src/applications/feed/view/story/PhabricatorFeedStoryView.php

View Options

src/applications/files/storage/base/PhabricatorFileDAO.php

View Options

src/applications/files/storage/file/PhabricatorFile.php

View Options

src/applications/files/storage/imagemacro/PhabricatorFileImageMacro.php

View Options

src/applications/files/storage/proxyimage/PhabricatorFileProxyImage.php

View Options

src/applications/files/storage/storageblob/PhabricatorFileStorageBlob.php

View Options

src/applications/files/storage/transformed/PhabricatorTransformedFile.php

View Options

src/applications/phriction/controller/diff/__init__.php

Phabricator ยท Built by Phacility