HomePhabricator

Validate inline comment changeset IDs and revision IDs
112346ee6190Unpublished

Unpublished Commit · Learn More

No further details are available.

Description

Validate inline comment changeset IDs and revision IDs

Summary:
Historically, we had a bug at some point which caused inline comments to get
associated with changeset 0. Prevent that explicitly. See T108.

Test Plan:
Set "$changeset = 0" in the endpoint and got an exception.

Reviewed By: aran
Reviewers: aran
CC: aran
Differential Revision: 374

Details

Provenance
epriestleyAuthored on
Reviewer
aran
Differential Revision
Restricted Differential Revision
Parents
rP9284c85876f0: Display property changes on files
Branches
Unknown
Tags
Unknown

Event Timeline