HomePhabricator

Fix PhabricatorJavelinLinter regex issue caused by D2023
108f51d9b426Unpublished

Unpublished Commit · Learn More

No further details are available.

Description

Fix PhabricatorJavelinLinter regex issue caused by D2023

Summary: D2023 adds a new '*' token to javelinsymbols (indicating that a behavior is 'installed'). This fixes a sanity-check regex in PhabricatorJavelinLinter that validates the output of javelinsymbols so that it is aware of this new token type.

Test Plan:
Patched javelinsymbols.cpp from D2023 to externals/javelin/support/javelinsymbols, build the new javelinsymbols binary, then ran

arc lint --lintall webroot/rsrc/js/application/core/behavior-drag-and-drop-textarea.js

(before this diff, that throws an error -- after it works with no lint)

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2025

Details

Provenance
jeffmoAuthored on
Reviewer
epriestley
Differential Revision
Restricted Differential Revision
Parents
rP3bacba7e9fe6: Show parent commits in Diffusion
Branches
Unknown
Tags
Unknown

Event Timeline