HomePhabricator

Fix ArcanistBundle to generate disjoint, minimal hunks
8c70ee38775fUnpublished

Unpublished Commit · Learn More

No further details are available.

Description

Fix ArcanistBundle to generate disjoint, minimal hunks

Summary: 'patch' chokes on hunks with too much trailing stuff. 'git apply'
chokes on overlapping hunks. Make them both happy. Write some test cases so I
stop breaking this stuff.

Test Plan:

  • Applied a previously-failing patch via SVN.
  • Applied a previously-failing-then-succeeding patch via Git.
  • Ran unit tests.

Reviewers: jungejason, btrahan, nh, tuomaspelkonen, aran

Reviewed By: jungejason

CC: aran, jungejason

Differential Revision: 1099

Details

Provenance
epriestleyAuthored on
Reviewer
jungejason
Differential Revision
Restricted Differential Revision
Parents
rARC2a78b2bffa2d: bash completion: work around PHP CLI readline in command substitution
Branches
Unknown
Tags
Unknown

Event Timeline