HomePhabricator

Fix issue with svn-hook-pre-commit when resolving .arcconfig for nested…
61e16d9cc359Unpublished

Unpublished Commit · Learn More

No further details are available.

Description

Fix issue with svn-hook-pre-commit when resolving .arcconfig for nested directories

Summary:
If you had changes to a directory covered by a .arcconfig residing
inside another directory also covered by an .arcconfig, the hook would
incorrectly attribute the first file it attempted to resolve to the topmost
.arcconfig because it failed to break out of the loop after resolving it.

All other files would be correctly attributed, because they'd hit the cache.

Test Plan:
Created an svn repository and checked it out locally. Created a
structure like this:

.arcconfig
shallow
a/
 b/
  c/
   .arcconfig
   d/
    deep
    deep2
    deep3

Made modifications to "deep", "deep2", and "deep3". Received an error message
about multiple .arcconfig changes, attributing one file to the topmost
arcconfig and the other two to the deeper one.

Applied patch.

Commit now goes through. Made a commit affecting 'shallow' and 'deep' and
'deep2', commit was correctly blocked and files were attributed to the
corresponding .arcconfigs.

Reviewed By: mroch
Reviewers: mroch
CC: mroch
Differential Revision: 50

Details

Provenance
epriestleyAuthored on
Reviewer
mroch
Differential Revision
Restricted Differential Revision
Parents
rARC0a0aa6d71874: Restore the --edit workflow somewhat properly. (2)
Branches
Unknown
Tags
Unknown

Event Timeline