Page MenuHomePhabricator
Files F15461319

D8682.id20588.diff
No OneTemporary
Actions

D8682.id20588.diff
View Options

diff --git a/src/applications/maniphest/controller/ManiphestTaskEditController.php b/src/applications/maniphest/controller/ManiphestTaskEditController.php
--- a/src/applications/maniphest/controller/ManiphestTaskEditController.php
+++ b/src/applications/maniphest/controller/ManiphestTaskEditController.php
@@ -45,6 +45,11 @@
} else {
$task = ManiphestTask::initializeNewTask($user);
+ // We currently do not allow you to set the task status when creating
+ // a new task, although now that statuses are custom it might make
+ // sense.
+ $can_edit_status = false;
+
// These allow task creation with defaults.
if (!$request->isFormPost()) {
$task->setTitle($request->getStr('title'));
@@ -178,8 +183,13 @@
$changes[ManiphestTransaction::TYPE_TITLE] = $new_title;
$changes[ManiphestTransaction::TYPE_DESCRIPTION] = $new_desc;
+
if ($can_edit_status) {
$changes[ManiphestTransaction::TYPE_STATUS] = $new_status;
+ } else if (!$task->getID()) {
+ // Create an initial status transaction for the burndown chart.
+ // TODO: We can probably remove this once Facts comes online.
+ $changes[ManiphestTransaction::TYPE_STATUS] = $task->getStatus();
}
$owner_tokenizer = $request->getArr('assigned_to');
@@ -589,10 +599,7 @@
->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_SHORT)
->setValue($task->getTitle()));
- if ($task->getID() && $can_edit_status) {
- // Only show this in "edit" mode, not "create" mode, since creating a
- // non-open task is kind of silly and it would just clutter up the
- // "create" interface.
+ if ($can_edit_status) {
$form
->appendChild(
id(new AphrontFormSelectControl())

File Metadata

Mime Type
text/plain
Expires
Wed, Apr 2, 7:24 AM (6 d, 12 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7714620
Default Alt Text
D8682.id20588.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility