Page MenuHomePhabricator
Files F18902367

D9859.largetrue.diff
No OneTemporary
Actions

D9859.largetrue.diff
View Options

This file is larger than 256 KB, so syntax highlighting was skipped.
diff --git a/conf/default.conf.php b/conf/default.conf.php
--- a/conf/default.conf.php
+++ b/conf/default.conf.php
@@ -798,7 +798,7 @@
// '#/autobuilt/#',
),
- // If you set this to true, users can accept their own revisions. This action
+ // If you set this to true, users can accept their own revisions. This action
// is disabled by default because it's most likely not a behavior you want,
// but it proves useful if you are working alone on a project and want to make
// use of all of differential's features.
@@ -817,7 +817,7 @@
// If you set this to true, any user can reopen a revision so long as it has
// been closed. This can be useful if a revision is accidentally closed or
- // if a developer changes his or her mind after closing a revision. If it is
+ // if a developer changes his or her mind after closing a revision. If it is
// false, reopening is not allowed.
'differential.allow-reopen' => false,
diff --git a/externals/balanced-php/tests/Balanced/SuiteTest.php b/externals/balanced-php/tests/Balanced/SuiteTest.php
--- a/externals/balanced-php/tests/Balanced/SuiteTest.php
+++ b/externals/balanced-php/tests/Balanced/SuiteTest.php
@@ -27,8 +27,6 @@
* <li>$BALANCED_URL_ROOT If set applies to \Balanced\Settings::$url_root.
* <li>$BALANCED_API_KEY If set applies to \Balanced\Settings::$api_key.
* </ul>
- *
- * @group suite
*/
class SuiteTest extends \PHPUnit_Framework_TestCase
{
@@ -784,17 +782,17 @@
}
function testEvents() {
- $prev_num_events = Marketplace::mine()->events->total();
- $account = self::_createBuyer();
- $account->debit(123);
- $cur_num_events = Marketplace::mine()->events->total();
- $count = 0;
+ $prev_num_events = Marketplace::mine()->events->total();
+ $account = self::_createBuyer();
+ $account->debit(123);
+ $cur_num_events = Marketplace::mine()->events->total();
+ $count = 0;
while ($cur_num_events == $prev_num_events && $count < 10) {
printf("waiting for events - %d, %d == %d\n", $count + 1, $cur_num_events, $prev_num_events);
sleep(2); // 2 seconds
- $cur_num_events = Marketplace::mine()->events->total();
- $count += 1;
- }
+ $cur_num_events = Marketplace::mine()->events->total();
+ $count += 1;
+ }
$this->assertTrue($cur_num_events > $prev_num_events);
}
}
diff --git a/src/aphront/AphrontController.php b/src/aphront/AphrontController.php
--- a/src/aphront/AphrontController.php
+++ b/src/aphront/AphrontController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group aphront
- */
abstract class AphrontController extends Phobject {
private $request;
diff --git a/src/aphront/AphrontURIMapper.php b/src/aphront/AphrontURIMapper.php
--- a/src/aphront/AphrontURIMapper.php
+++ b/src/aphront/AphrontURIMapper.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group aphront
- */
final class AphrontURIMapper {
private $map;
@@ -49,4 +46,5 @@
return array(null, null);
}
+
}
diff --git a/src/aphront/configuration/AphrontApplicationConfiguration.php b/src/aphront/configuration/AphrontApplicationConfiguration.php
--- a/src/aphront/configuration/AphrontApplicationConfiguration.php
+++ b/src/aphront/configuration/AphrontApplicationConfiguration.php
@@ -2,7 +2,6 @@
/**
* @task routing URI Routing
- * @group aphront
*/
abstract class AphrontApplicationConfiguration {
@@ -228,4 +227,5 @@
return array($controller, $uri_data);
}
+
}
diff --git a/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php b/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
--- a/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
+++ b/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
@@ -4,7 +4,6 @@
* NOTE: Do not extend this!
*
* @concrete-extensible
- * @group aphront
*/
class AphrontDefaultApplicationConfiguration
extends AphrontApplicationConfiguration {
diff --git a/src/aphront/console/DarkConsoleController.php b/src/aphront/console/DarkConsoleController.php
--- a/src/aphront/console/DarkConsoleController.php
+++ b/src/aphront/console/DarkConsoleController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group console
- */
final class DarkConsoleController extends PhabricatorController {
protected $op;
diff --git a/src/aphront/console/DarkConsoleCore.php b/src/aphront/console/DarkConsoleCore.php
--- a/src/aphront/console/DarkConsoleCore.php
+++ b/src/aphront/console/DarkConsoleCore.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group console
- */
final class DarkConsoleCore {
private $plugins = array();
diff --git a/src/aphront/console/DarkConsoleDataController.php b/src/aphront/console/DarkConsoleDataController.php
--- a/src/aphront/console/DarkConsoleDataController.php
+++ b/src/aphront/console/DarkConsoleDataController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group console
- */
final class DarkConsoleDataController extends PhabricatorController {
private $key;
diff --git a/src/aphront/console/plugin/DarkConsoleErrorLogPlugin.php b/src/aphront/console/plugin/DarkConsoleErrorLogPlugin.php
--- a/src/aphront/console/plugin/DarkConsoleErrorLogPlugin.php
+++ b/src/aphront/console/plugin/DarkConsoleErrorLogPlugin.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group console
- */
final class DarkConsoleErrorLogPlugin extends DarkConsolePlugin {
public function getName() {
@@ -98,4 +95,5 @@
phutil_tag('pre', array('class' => 'PhabricatorMonospaced'), $details),
));
}
+
}
diff --git a/src/aphront/console/plugin/DarkConsoleEventPlugin.php b/src/aphront/console/plugin/DarkConsoleEventPlugin.php
--- a/src/aphront/console/plugin/DarkConsoleEventPlugin.php
+++ b/src/aphront/console/plugin/DarkConsoleEventPlugin.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group console
- */
final class DarkConsoleEventPlugin extends DarkConsolePlugin {
public function getName() {
@@ -14,7 +11,6 @@
}
public function generateData() {
-
$listeners = PhutilEventEngine::getInstance()->getAllListeners();
foreach ($listeners as $key => $listener) {
$listeners[$key] = array(
@@ -95,4 +91,5 @@
return phutil_implode_html("\n", $out);
}
+
}
diff --git a/src/aphront/console/plugin/DarkConsolePlugin.php b/src/aphront/console/plugin/DarkConsolePlugin.php
--- a/src/aphront/console/plugin/DarkConsolePlugin.php
+++ b/src/aphront/console/plugin/DarkConsolePlugin.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group console
- */
abstract class DarkConsolePlugin {
private $data;
@@ -13,9 +10,7 @@
abstract public function getDescription();
abstract public function renderPanel();
- public function __construct() {
-
- }
+ public function __construct() {}
public function getColor() {
return null;
diff --git a/src/aphront/console/plugin/DarkConsoleRequestPlugin.php b/src/aphront/console/plugin/DarkConsoleRequestPlugin.php
--- a/src/aphront/console/plugin/DarkConsoleRequestPlugin.php
+++ b/src/aphront/console/plugin/DarkConsoleRequestPlugin.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group console
- */
final class DarkConsoleRequestPlugin extends DarkConsolePlugin {
public function getName() {
diff --git a/src/aphront/console/plugin/DarkConsoleServicesPlugin.php b/src/aphront/console/plugin/DarkConsoleServicesPlugin.php
--- a/src/aphront/console/plugin/DarkConsoleServicesPlugin.php
+++ b/src/aphront/console/plugin/DarkConsoleServicesPlugin.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group console
- */
final class DarkConsoleServicesPlugin extends DarkConsolePlugin {
protected $observations;
@@ -36,7 +33,6 @@
* @phutil-external-symbol class PhabricatorStartup
*/
public function generateData() {
-
$should_analyze = self::isQueryAnalyzerRequested();
$log = PhutilServiceProfiler::getInstance()->getServiceCallLog();
diff --git a/src/aphront/console/plugin/DarkConsoleXHProfPlugin.php b/src/aphront/console/plugin/DarkConsoleXHProfPlugin.php
--- a/src/aphront/console/plugin/DarkConsoleXHProfPlugin.php
+++ b/src/aphront/console/plugin/DarkConsoleXHProfPlugin.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group console
- */
final class DarkConsoleXHProfPlugin extends DarkConsolePlugin {
protected $profileFilePHID;
diff --git a/src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php b/src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php
--- a/src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php
+++ b/src/aphront/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group console
- */
final class DarkConsoleErrorLogPluginAPI {
private static $errors = array();
diff --git a/src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php b/src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php
--- a/src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php
+++ b/src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group console
- */
final class DarkConsoleEventPluginAPI extends PhabricatorEventListener {
private static $events = array();
diff --git a/src/aphront/console/plugin/xhprof/DarkConsoleXHProfPluginAPI.php b/src/aphront/console/plugin/xhprof/DarkConsoleXHProfPluginAPI.php
--- a/src/aphront/console/plugin/xhprof/DarkConsoleXHProfPluginAPI.php
+++ b/src/aphront/console/plugin/xhprof/DarkConsoleXHProfPluginAPI.php
@@ -1,7 +1,6 @@
<?php
/**
- * @group console
* @phutil-external-symbol function xhprof_enable
* @phutil-external-symbol function xhprof_disable
*/
diff --git a/src/aphront/response/Aphront304Response.php b/src/aphront/response/Aphront304Response.php
--- a/src/aphront/response/Aphront304Response.php
+++ b/src/aphront/response/Aphront304Response.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group aphront
- */
final class Aphront304Response extends AphrontResponse {
public function getHTTPResponseCode() {
diff --git a/src/aphront/response/Aphront400Response.php b/src/aphront/response/Aphront400Response.php
--- a/src/aphront/response/Aphront400Response.php
+++ b/src/aphront/response/Aphront400Response.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group aphront
- */
final class Aphront400Response extends AphrontResponse {
public function getHTTPResponseCode() {
diff --git a/src/aphront/response/Aphront403Response.php b/src/aphront/response/Aphront403Response.php
--- a/src/aphront/response/Aphront403Response.php
+++ b/src/aphront/response/Aphront403Response.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group aphront
- */
final class Aphront403Response extends AphrontHTMLResponse {
private $forbiddenText;
diff --git a/src/aphront/response/Aphront404Response.php b/src/aphront/response/Aphront404Response.php
--- a/src/aphront/response/Aphront404Response.php
+++ b/src/aphront/response/Aphront404Response.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group aphront
- */
final class Aphront404Response extends AphrontHTMLResponse {
public function getHTTPResponseCode() {
diff --git a/src/aphront/response/AphrontAjaxResponse.php b/src/aphront/response/AphrontAjaxResponse.php
--- a/src/aphront/response/AphrontAjaxResponse.php
+++ b/src/aphront/response/AphrontAjaxResponse.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group aphront
- */
final class AphrontAjaxResponse extends AphrontResponse {
private $content;
diff --git a/src/aphront/response/AphrontDialogResponse.php b/src/aphront/response/AphrontDialogResponse.php
--- a/src/aphront/response/AphrontDialogResponse.php
+++ b/src/aphront/response/AphrontDialogResponse.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group aphront
- */
final class AphrontDialogResponse extends AphrontResponse {
private $dialog;
diff --git a/src/aphront/response/AphrontFileResponse.php b/src/aphront/response/AphrontFileResponse.php
--- a/src/aphront/response/AphrontFileResponse.php
+++ b/src/aphront/response/AphrontFileResponse.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group aphront
- */
final class AphrontFileResponse extends AphrontResponse {
private $content;
diff --git a/src/aphront/response/AphrontHTMLResponse.php b/src/aphront/response/AphrontHTMLResponse.php
--- a/src/aphront/response/AphrontHTMLResponse.php
+++ b/src/aphront/response/AphrontHTMLResponse.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group aphront
- */
abstract class AphrontHTMLResponse extends AphrontResponse {
public function getHeaders() {
diff --git a/src/aphront/response/AphrontJSONResponse.php b/src/aphront/response/AphrontJSONResponse.php
--- a/src/aphront/response/AphrontJSONResponse.php
+++ b/src/aphront/response/AphrontJSONResponse.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group aphront
- */
final class AphrontJSONResponse extends AphrontResponse {
private $content;
@@ -40,4 +37,5 @@
$headers = array_merge(parent::getHeaders(), $headers);
return $headers;
}
+
}
diff --git a/src/aphront/response/AphrontPlainTextResponse.php b/src/aphront/response/AphrontPlainTextResponse.php
--- a/src/aphront/response/AphrontPlainTextResponse.php
+++ b/src/aphront/response/AphrontPlainTextResponse.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group aphront
- */
final class AphrontPlainTextResponse extends AphrontResponse {
public function setContent($content) {
diff --git a/src/aphront/response/AphrontProxyResponse.php b/src/aphront/response/AphrontProxyResponse.php
--- a/src/aphront/response/AphrontProxyResponse.php
+++ b/src/aphront/response/AphrontProxyResponse.php
@@ -7,8 +7,6 @@
* instantiating an @{class:AphrontAjaxResponse} in @{method:buildProxy}, and
* then constructing a real @{class:AphrontAjaxResponse} in
* @{method:reduceProxyResponse}.
- *
- * @group aphront
*/
abstract class AphrontProxyResponse extends AphrontResponse {
@@ -70,5 +68,4 @@
'AphrontProxyResponse must implement reduceProxyResponse().');
}
-
}
diff --git a/src/aphront/response/AphrontRedirectResponse.php b/src/aphront/response/AphrontRedirectResponse.php
--- a/src/aphront/response/AphrontRedirectResponse.php
+++ b/src/aphront/response/AphrontRedirectResponse.php
@@ -2,8 +2,6 @@
/**
* TODO: Should be final but isn't because of AphrontReloadResponse.
- *
- * @group aphront
*/
class AphrontRedirectResponse extends AphrontResponse {
diff --git a/src/aphront/response/AphrontReloadResponse.php b/src/aphront/response/AphrontReloadResponse.php
--- a/src/aphront/response/AphrontReloadResponse.php
+++ b/src/aphront/response/AphrontReloadResponse.php
@@ -5,8 +5,6 @@
* if the action is javascript-driven but redirect if it isn't. This preserves
* query parameters in the javascript case. A reload response behaves like
* a redirect response but causes a page reload when received via workflow.
- *
- * @group aphront
*/
final class AphrontReloadResponse extends AphrontRedirectResponse {
diff --git a/src/aphront/response/AphrontResponse.php b/src/aphront/response/AphrontResponse.php
--- a/src/aphront/response/AphrontResponse.php
+++ b/src/aphront/response/AphrontResponse.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group aphront
- */
abstract class AphrontResponse {
private $request;
@@ -94,7 +91,6 @@
}
protected function addJSONShield($json_response) {
-
// Add a shield to prevent "JSON Hijacking" attacks where an attacker
// requests a JSON response using a normal <script /> tag and then uses
// Object.prototype.__defineSetter__() or similar to read response data.
diff --git a/src/aphront/response/AphrontWebpageResponse.php b/src/aphront/response/AphrontWebpageResponse.php
--- a/src/aphront/response/AphrontWebpageResponse.php
+++ b/src/aphront/response/AphrontWebpageResponse.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group aphront
- */
final class AphrontWebpageResponse extends AphrontHTMLResponse {
private $content;
diff --git a/src/aphront/sink/AphrontHTTPSink.php b/src/aphront/sink/AphrontHTTPSink.php
--- a/src/aphront/sink/AphrontHTTPSink.php
+++ b/src/aphront/sink/AphrontHTTPSink.php
@@ -10,8 +10,6 @@
*
* @task write Writing Response Components
* @task emit Emitting the Response
- *
- * @group aphront
*/
abstract class AphrontHTTPSink {
@@ -117,4 +115,5 @@
abstract protected function emitHTTPStatus($code, $message = '');
abstract protected function emitHeader($name, $value);
abstract protected function emitData($data);
+
}
diff --git a/src/aphront/sink/AphrontIsolatedHTTPSink.php b/src/aphront/sink/AphrontIsolatedHTTPSink.php
--- a/src/aphront/sink/AphrontIsolatedHTTPSink.php
+++ b/src/aphront/sink/AphrontIsolatedHTTPSink.php
@@ -2,8 +2,6 @@
/**
* Isolated HTTP sink for testing.
- *
- * @group aphront
*/
final class AphrontIsolatedHTTPSink extends AphrontHTTPSink {
diff --git a/src/aphront/sink/AphrontPHPHTTPSink.php b/src/aphront/sink/AphrontPHPHTTPSink.php
--- a/src/aphront/sink/AphrontPHPHTTPSink.php
+++ b/src/aphront/sink/AphrontPHPHTTPSink.php
@@ -2,8 +2,6 @@
/**
* Concrete HTTP sink which uses "echo" and "header()" to emit data.
- *
- * @group aphront
*/
final class AphrontPHPHTTPSink extends AphrontHTTPSink {
diff --git a/src/applications/arcanist/conduit/ConduitAPI_arcanist_Method.php b/src/applications/arcanist/conduit/ConduitAPI_arcanist_Method.php
--- a/src/applications/arcanist/conduit/ConduitAPI_arcanist_Method.php
+++ b/src/applications/arcanist/conduit/ConduitAPI_arcanist_Method.php
@@ -1,8 +1,3 @@
<?php
-/**
- * @group conduit
- */
-abstract class ConduitAPI_arcanist_Method extends ConduitAPIMethod {
-
-}
+abstract class ConduitAPI_arcanist_Method extends ConduitAPIMethod {}
diff --git a/src/applications/arcanist/conduit/ConduitAPI_arcanist_projectinfo_Method.php b/src/applications/arcanist/conduit/ConduitAPI_arcanist_projectinfo_Method.php
--- a/src/applications/arcanist/conduit/ConduitAPI_arcanist_projectinfo_Method.php
+++ b/src/applications/arcanist/conduit/ConduitAPI_arcanist_projectinfo_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_arcanist_projectinfo_Method
extends ConduitAPI_arcanist_Method {
diff --git a/src/applications/audit/conduit/ConduitAPI_audit_Method.php b/src/applications/audit/conduit/ConduitAPI_audit_Method.php
--- a/src/applications/audit/conduit/ConduitAPI_audit_Method.php
+++ b/src/applications/audit/conduit/ConduitAPI_audit_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_audit_Method extends ConduitAPIMethod {
public function getApplication() {
diff --git a/src/applications/audit/conduit/ConduitAPI_audit_query_Method.php b/src/applications/audit/conduit/ConduitAPI_audit_query_Method.php
--- a/src/applications/audit/conduit/ConduitAPI_audit_query_Method.php
+++ b/src/applications/audit/conduit/ConduitAPI_audit_query_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_audit_query_Method extends ConduitAPI_audit_Method {
public function getMethodDescription() {
@@ -76,5 +73,4 @@
return $results;
}
-
}
diff --git a/src/applications/base/PhabricatorApplication.php b/src/applications/base/PhabricatorApplication.php
--- a/src/applications/base/PhabricatorApplication.php
+++ b/src/applications/base/PhabricatorApplication.php
@@ -6,10 +6,8 @@
* @task uri URI Routing
* @task fact Fact Integration
* @task meta Application Management
- * @group apps
*/
-abstract class PhabricatorApplication
- implements PhabricatorPolicyInterface {
+abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
const GROUP_CORE = 'core';
const GROUP_UTILITIES = 'util';
diff --git a/src/applications/calendar/constants/CalendarColors.php b/src/applications/calendar/constants/CalendarColors.php
--- a/src/applications/calendar/constants/CalendarColors.php
+++ b/src/applications/calendar/constants/CalendarColors.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group calendar
- */
final class CalendarColors extends CalendarConstants {
const COLOR_RED = 'red';
diff --git a/src/applications/calendar/constants/CalendarConstants.php b/src/applications/calendar/constants/CalendarConstants.php
--- a/src/applications/calendar/constants/CalendarConstants.php
+++ b/src/applications/calendar/constants/CalendarConstants.php
@@ -1,8 +1,3 @@
<?php
-/**
- * @group calendar
- */
-abstract class CalendarConstants {
-
-}
+abstract class CalendarConstants {}
diff --git a/src/applications/chatlog/conduit/ConduitAPI_chatlog_Method.php b/src/applications/chatlog/conduit/ConduitAPI_chatlog_Method.php
--- a/src/applications/chatlog/conduit/ConduitAPI_chatlog_Method.php
+++ b/src/applications/chatlog/conduit/ConduitAPI_chatlog_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_chatlog_Method extends ConduitAPIMethod {
public function getApplication() {
diff --git a/src/applications/chatlog/conduit/ConduitAPI_chatlog_query_Method.php b/src/applications/chatlog/conduit/ConduitAPI_chatlog_query_Method.php
--- a/src/applications/chatlog/conduit/ConduitAPI_chatlog_query_Method.php
+++ b/src/applications/chatlog/conduit/ConduitAPI_chatlog_query_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_chatlog_query_Method
- extends ConduitAPI_chatlog_Method {
+final class ConduitAPI_chatlog_query_Method extends ConduitAPI_chatlog_Method {
public function getMethodStatus() {
return self::METHOD_STATUS_UNSTABLE;
@@ -30,7 +26,6 @@
}
protected function execute(ConduitAPIRequest $request) {
-
$query = new PhabricatorChatLogQuery();
$channel_ids = $request->getValue('channelIDs');
diff --git a/src/applications/chatlog/conduit/ConduitAPI_chatlog_record_Method.php b/src/applications/chatlog/conduit/ConduitAPI_chatlog_record_Method.php
--- a/src/applications/chatlog/conduit/ConduitAPI_chatlog_record_Method.php
+++ b/src/applications/chatlog/conduit/ConduitAPI_chatlog_record_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_chatlog_record_Method
- extends ConduitAPI_chatlog_Method {
+final class ConduitAPI_chatlog_record_Method extends ConduitAPI_chatlog_Method {
public function getMethodStatus() {
return self::METHOD_STATUS_UNSTABLE;
@@ -25,8 +21,7 @@
}
public function defineErrorTypes() {
- return array(
- );
+ return array();
}
protected function execute(ConduitAPIRequest $request) {
diff --git a/src/applications/conduit/controller/PhabricatorConduitAPIController.php b/src/applications/conduit/controller/PhabricatorConduitAPIController.php
--- a/src/applications/conduit/controller/PhabricatorConduitAPIController.php
+++ b/src/applications/conduit/controller/PhabricatorConduitAPIController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class PhabricatorConduitAPIController
extends PhabricatorConduitController {
@@ -467,4 +464,5 @@
return $params;
}
+
}
diff --git a/src/applications/conduit/controller/PhabricatorConduitController.php b/src/applications/conduit/controller/PhabricatorConduitController.php
--- a/src/applications/conduit/controller/PhabricatorConduitController.php
+++ b/src/applications/conduit/controller/PhabricatorConduitController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class PhabricatorConduitController extends PhabricatorController {
protected function buildSideNavView() {
@@ -27,5 +24,4 @@
return $this->buildSideNavView()->getMenu();
}
-
}
diff --git a/src/applications/conduit/controller/PhabricatorConduitLogController.php b/src/applications/conduit/controller/PhabricatorConduitLogController.php
--- a/src/applications/conduit/controller/PhabricatorConduitLogController.php
+++ b/src/applications/conduit/controller/PhabricatorConduitLogController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class PhabricatorConduitLogController
extends PhabricatorConduitController {
diff --git a/src/applications/conduit/controller/PhabricatorConduitTokenController.php b/src/applications/conduit/controller/PhabricatorConduitTokenController.php
--- a/src/applications/conduit/controller/PhabricatorConduitTokenController.php
+++ b/src/applications/conduit/controller/PhabricatorConduitTokenController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class PhabricatorConduitTokenController
extends PhabricatorConduitController {
@@ -72,4 +69,5 @@
'title' => pht('Certificate Install Token'),
));
}
+
}
diff --git a/src/applications/conduit/method/ConduitAPI_conduit_connect_Method.php b/src/applications/conduit/method/ConduitAPI_conduit_connect_Method.php
--- a/src/applications/conduit/method/ConduitAPI_conduit_connect_Method.php
+++ b/src/applications/conduit/method/ConduitAPI_conduit_connect_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_conduit_connect_Method extends ConduitAPIMethod {
public function shouldRequireAuthentication() {
@@ -55,7 +52,6 @@
}
protected function execute(ConduitAPIRequest $request) {
-
$client = $request->getValue('client');
$client_version = (int)$request->getValue('clientVersion');
$client_description = (string)$request->getValue('clientDescription');
@@ -109,9 +105,7 @@
$token = $request->getValue('authToken');
$signature = $request->getValue('authSignature');
- $user = id(new PhabricatorUser())->loadOneWhere(
- 'username = %s',
- $username);
+ $user = id(new PhabricatorUser())->loadOneWhere('username = %s', $username);
if (!$user) {
throw new ConduitException('ERR-INVALID-USER');
}
diff --git a/src/applications/conduit/method/ConduitAPI_conduit_getcertificate_Method.php b/src/applications/conduit/method/ConduitAPI_conduit_getcertificate_Method.php
--- a/src/applications/conduit/method/ConduitAPI_conduit_getcertificate_Method.php
+++ b/src/applications/conduit/method/ConduitAPI_conduit_getcertificate_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_conduit_getcertificate_Method extends ConduitAPIMethod {
public function shouldRequireAuthentication() {
@@ -78,8 +75,8 @@
}
private function logFailure(
- ConduitAPIRequest $request,
- PhabricatorConduitCertificateToken $info = null) {
+ ConduitAPIRequest $request,
+ PhabricatorConduitCertificateToken $info = null) {
$log = PhabricatorUserLog::initializeNewLog(
$request->getUser(),
diff --git a/src/applications/conduit/method/ConduitAPI_conduit_ping_Method.php b/src/applications/conduit/method/ConduitAPI_conduit_ping_Method.php
--- a/src/applications/conduit/method/ConduitAPI_conduit_ping_Method.php
+++ b/src/applications/conduit/method/ConduitAPI_conduit_ping_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_conduit_ping_Method extends ConduitAPIMethod {
public function shouldRequireAuthentication() {
@@ -28,4 +25,5 @@
protected function execute(ConduitAPIRequest $request) {
return php_uname('n');
}
+
}
diff --git a/src/applications/conduit/method/ConduitAPI_conduit_query_Method.php b/src/applications/conduit/method/ConduitAPI_conduit_query_Method.php
--- a/src/applications/conduit/method/ConduitAPI_conduit_query_Method.php
+++ b/src/applications/conduit/method/ConduitAPI_conduit_query_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_conduit_query_Method extends ConduitAPIMethod {
public function getMethodDescription() {
diff --git a/src/applications/conduit/protocol/ConduitAPIRequest.php b/src/applications/conduit/protocol/ConduitAPIRequest.php
--- a/src/applications/conduit/protocol/ConduitAPIRequest.php
+++ b/src/applications/conduit/protocol/ConduitAPIRequest.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPIRequest {
protected $params;
diff --git a/src/applications/conduit/protocol/ConduitAPIResponse.php b/src/applications/conduit/protocol/ConduitAPIResponse.php
--- a/src/applications/conduit/protocol/ConduitAPIResponse.php
+++ b/src/applications/conduit/protocol/ConduitAPIResponse.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPIResponse {
private $result;
@@ -13,6 +10,7 @@
$this->result = $result;
return $this;
}
+
public function getResult() {
return $this->result;
}
@@ -21,6 +19,7 @@
$this->errorCode = $error_code;
return $this;
}
+
public function getErrorCode() {
return $this->errorCode;
}
@@ -40,4 +39,5 @@
'error_info' => $this->getErrorInfo(),
);
}
+
}
diff --git a/src/applications/conduit/protocol/ConduitException.php b/src/applications/conduit/protocol/ConduitException.php
--- a/src/applications/conduit/protocol/ConduitException.php
+++ b/src/applications/conduit/protocol/ConduitException.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitException extends Exception {
private $errorDescription;
diff --git a/src/applications/conduit/storage/PhabricatorConduitCertificateToken.php b/src/applications/conduit/storage/PhabricatorConduitCertificateToken.php
--- a/src/applications/conduit/storage/PhabricatorConduitCertificateToken.php
+++ b/src/applications/conduit/storage/PhabricatorConduitCertificateToken.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class PhabricatorConduitCertificateToken extends PhabricatorConduitDAO {
protected $userPHID;
diff --git a/src/applications/conduit/storage/PhabricatorConduitConnectionLog.php b/src/applications/conduit/storage/PhabricatorConduitConnectionLog.php
--- a/src/applications/conduit/storage/PhabricatorConduitConnectionLog.php
+++ b/src/applications/conduit/storage/PhabricatorConduitConnectionLog.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class PhabricatorConduitConnectionLog extends PhabricatorConduitDAO {
protected $client;
diff --git a/src/applications/conduit/storage/PhabricatorConduitDAO.php b/src/applications/conduit/storage/PhabricatorConduitDAO.php
--- a/src/applications/conduit/storage/PhabricatorConduitDAO.php
+++ b/src/applications/conduit/storage/PhabricatorConduitDAO.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class PhabricatorConduitDAO extends PhabricatorLiskDAO {
public function getApplicationName() {
diff --git a/src/applications/conduit/storage/PhabricatorConduitMethodCallLog.php b/src/applications/conduit/storage/PhabricatorConduitMethodCallLog.php
--- a/src/applications/conduit/storage/PhabricatorConduitMethodCallLog.php
+++ b/src/applications/conduit/storage/PhabricatorConduitMethodCallLog.php
@@ -1,9 +1,7 @@
<?php
-/**
- * @group conduit
- */
-final class PhabricatorConduitMethodCallLog extends PhabricatorConduitDAO
+final class PhabricatorConduitMethodCallLog
+ extends PhabricatorConduitDAO
implements PhabricatorPolicyInterface {
protected $callerPHID;
diff --git a/src/applications/conpherence/conduit/ConduitAPI_conpherence_Method.php b/src/applications/conpherence/conduit/ConduitAPI_conpherence_Method.php
--- a/src/applications/conpherence/conduit/ConduitAPI_conpherence_Method.php
+++ b/src/applications/conpherence/conduit/ConduitAPI_conpherence_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-abstract class ConduitAPI_conpherence_Method
- extends ConduitAPIMethod {
+abstract class ConduitAPI_conpherence_Method extends ConduitAPIMethod {
public function getApplication() {
return PhabricatorApplication::getByClass(
diff --git a/src/applications/conpherence/conduit/ConduitAPI_conpherence_createthread_Method.php b/src/applications/conpherence/conduit/ConduitAPI_conpherence_createthread_Method.php
--- a/src/applications/conpherence/conduit/ConduitAPI_conpherence_createthread_Method.php
+++ b/src/applications/conpherence/conduit/ConduitAPI_conpherence_createthread_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_conpherence_createthread_Method
extends ConduitAPI_conpherence_Method {
@@ -32,7 +29,6 @@
}
protected function execute(ConduitAPIRequest $request) {
-
$participant_phids = $request->getValue('participantPHIDs', array());
$message = $request->getValue('message');
$title = $request->getValue('title');
@@ -60,6 +56,8 @@
return array(
'conpherenceID' => $conpherence->getID(),
'conpherencePHID' => $conpherence->getPHID(),
- 'conpherenceURI' => $this->getConpherenceURI($conpherence));
+ 'conpherenceURI' => $this->getConpherenceURI($conpherence),
+ );
}
+
}
diff --git a/src/applications/conpherence/conduit/ConduitAPI_conpherence_querythread_Method.php b/src/applications/conpherence/conduit/ConduitAPI_conpherence_querythread_Method.php
--- a/src/applications/conpherence/conduit/ConduitAPI_conpherence_querythread_Method.php
+++ b/src/applications/conpherence/conduit/ConduitAPI_conpherence_querythread_Method.php
@@ -1,12 +1,8 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_conpherence_querythread_Method
extends ConduitAPI_conpherence_Method {
-
public function getMethodDescription() {
return pht(
'Query for conpherence threads for the logged in user. '.
@@ -82,4 +78,5 @@
}
return $data;
}
+
}
diff --git a/src/applications/conpherence/conduit/ConduitAPI_conpherence_querytransaction_Method.php b/src/applications/conpherence/conduit/ConduitAPI_conpherence_querytransaction_Method.php
--- a/src/applications/conpherence/conduit/ConduitAPI_conpherence_querytransaction_Method.php
+++ b/src/applications/conpherence/conduit/ConduitAPI_conpherence_querytransaction_Method.php
@@ -1,12 +1,8 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_conpherence_querytransaction_Method
extends ConduitAPI_conpherence_Method {
-
public function getMethodDescription() {
return pht(
'Query for transactions for the logged in user within a specific '.
@@ -92,4 +88,5 @@
}
return $data;
}
+
}
diff --git a/src/applications/conpherence/conduit/ConduitAPI_conpherence_updatethread_Method.php b/src/applications/conpherence/conduit/ConduitAPI_conpherence_updatethread_Method.php
--- a/src/applications/conpherence/conduit/ConduitAPI_conpherence_updatethread_Method.php
+++ b/src/applications/conpherence/conduit/ConduitAPI_conpherence_updatethread_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_conpherence_updatethread_Method
extends ConduitAPI_conpherence_Method {
@@ -104,4 +101,5 @@
return true;
}
+
}
diff --git a/src/applications/conpherence/constants/ConpherenceConstants.php b/src/applications/conpherence/constants/ConpherenceConstants.php
--- a/src/applications/conpherence/constants/ConpherenceConstants.php
+++ b/src/applications/conpherence/constants/ConpherenceConstants.php
@@ -1,8 +1,3 @@
<?php
-/**
- * @group conpherence
- */
-abstract class ConpherenceConstants {
-
-}
+abstract class ConpherenceConstants {}
diff --git a/src/applications/conpherence/constants/ConpherenceTransactionType.php b/src/applications/conpherence/constants/ConpherenceTransactionType.php
--- a/src/applications/conpherence/constants/ConpherenceTransactionType.php
+++ b/src/applications/conpherence/constants/ConpherenceTransactionType.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
final class ConpherenceTransactionType extends ConpherenceConstants {
const TYPE_FILES = 'files';
diff --git a/src/applications/conpherence/controller/ConpherenceController.php b/src/applications/conpherence/controller/ConpherenceController.php
--- a/src/applications/conpherence/controller/ConpherenceController.php
+++ b/src/applications/conpherence/controller/ConpherenceController.php
@@ -1,9 +1,7 @@
<?php
-/**
- * @group conpherence
- */
abstract class ConpherenceController extends PhabricatorController {
+
private $conpherences;
public function buildApplicationMenu() {
@@ -149,8 +147,8 @@
return array(
'transactions' => $rendered_transactions,
'latest_transaction_id' => $latest_transaction_id,
- 'oldest_transaction_id' => $oldest_transaction_id
+ 'oldest_transaction_id' => $oldest_transaction_id,
);
-
}
+
}
diff --git a/src/applications/conpherence/controller/ConpherenceListController.php b/src/applications/conpherence/controller/ConpherenceListController.php
--- a/src/applications/conpherence/controller/ConpherenceListController.php
+++ b/src/applications/conpherence/controller/ConpherenceListController.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conpherence
- */
-final class ConpherenceListController
- extends ConpherenceController {
+final class ConpherenceListController extends ConpherenceController {
const SELECTED_MODE = 'selected';
const UNSELECTED_MODE = 'unselected';
@@ -227,7 +223,8 @@
return array(
'scroll_up_participant' => $scroll_up_participant,
'scroll_down_participant' => $scroll_down_participant,
- 'participation' => $participation);
+ 'participation' => $participation,
+ );
}
private function loadConpherenceThreadData($participation) {
diff --git a/src/applications/conpherence/controller/ConpherenceNewController.php b/src/applications/conpherence/controller/ConpherenceNewController.php
--- a/src/applications/conpherence/controller/ConpherenceNewController.php
+++ b/src/applications/conpherence/controller/ConpherenceNewController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
final class ConpherenceNewController extends ConpherenceController {
public function processRequest() {
@@ -99,4 +96,5 @@
return id(new AphrontDialogResponse())->setDialog($dialog);
}
+
}
diff --git a/src/applications/conpherence/controller/ConpherenceNotificationPanelController.php b/src/applications/conpherence/controller/ConpherenceNotificationPanelController.php
--- a/src/applications/conpherence/controller/ConpherenceNotificationPanelController.php
+++ b/src/applications/conpherence/controller/ConpherenceNotificationPanelController.php
@@ -1,13 +1,9 @@
<?php
-/**
- * @group conpherence
- */
final class ConpherenceNotificationPanelController
extends ConpherenceController {
public function processRequest() {
-
$request = $this->getRequest();
$user = $request->getUser();
$conpherences = array();
@@ -108,4 +104,5 @@
return id(new AphrontAjaxResponse())->setContent($json);
}
+
}
diff --git a/src/applications/conpherence/controller/ConpherenceWidgetController.php b/src/applications/conpherence/controller/ConpherenceWidgetController.php
--- a/src/applications/conpherence/controller/ConpherenceWidgetController.php
+++ b/src/applications/conpherence/controller/ConpherenceWidgetController.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conpherence
- */
-final class ConpherenceWidgetController extends
- ConpherenceController {
+final class ConpherenceWidgetController extends ConpherenceController {
private $conpherenceID;
private $conpherence;
@@ -14,6 +10,7 @@
$this->userPreferences = $pref;
return $this;
}
+
public function getUserPreferences() {
return $this->userPreferences;
}
@@ -22,6 +19,7 @@
$this->conpherence = $conpherence;
return $this;
}
+
public function getConpherence() {
return $this->conpherence;
}
@@ -30,6 +28,7 @@
$this->conpherenceID = $conpherence_id;
return $this;
}
+
public function getConpherenceID() {
return $this->conpherenceID;
}
diff --git a/src/applications/conpherence/editor/ConpherenceEditor.php b/src/applications/conpherence/editor/ConpherenceEditor.php
--- a/src/applications/conpherence/editor/ConpherenceEditor.php
+++ b/src/applications/conpherence/editor/ConpherenceEditor.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
final class ConpherenceEditor extends PhabricatorApplicationTransactionEditor {
const ERROR_EMPTY_PARTICIPANTS = 'error-empty-participants';
@@ -421,4 +418,5 @@
protected function supportsSearch() {
return false;
}
+
}
diff --git a/src/applications/conpherence/phid/PhabricatorConpherencePHIDTypeThread.php b/src/applications/conpherence/phid/PhabricatorConpherencePHIDTypeThread.php
--- a/src/applications/conpherence/phid/PhabricatorConpherencePHIDTypeThread.php
+++ b/src/applications/conpherence/phid/PhabricatorConpherencePHIDTypeThread.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
final class PhabricatorConpherencePHIDTypeThread extends PhabricatorPHIDType {
const TYPECONST = 'CONP';
diff --git a/src/applications/conpherence/query/ConpherenceParticipantCountQuery.php b/src/applications/conpherence/query/ConpherenceParticipantCountQuery.php
--- a/src/applications/conpherence/query/ConpherenceParticipantCountQuery.php
+++ b/src/applications/conpherence/query/ConpherenceParticipantCountQuery.php
@@ -9,8 +9,6 @@
* ->withParticipantPHIDs(array($my_phid))
* ->withParticipationStatus(ConpherenceParticipationStatus::BEHIND)
* ->execute();
- *
- * @group conpherence
*/
final class ConpherenceParticipantCountQuery
extends PhabricatorOffsetPagedQuery {
@@ -65,7 +63,6 @@
}
private function buildGroupByClause(AphrontDatabaseConnection $conn_r) {
-
$group_by = qsprintf(
$conn_r,
'GROUP BY participantPHID');
diff --git a/src/applications/conpherence/query/ConpherenceParticipantQuery.php b/src/applications/conpherence/query/ConpherenceParticipantQuery.php
--- a/src/applications/conpherence/query/ConpherenceParticipantQuery.php
+++ b/src/applications/conpherence/query/ConpherenceParticipantQuery.php
@@ -30,11 +30,8 @@
*
* For counts of read, un-read, or all conpherences by participant, see
* @{class:ConpherenceParticipantCountQuery}.
- *
- * @group conpherence
*/
-final class ConpherenceParticipantQuery
- extends PhabricatorOffsetPagedQuery {
+final class ConpherenceParticipantQuery extends PhabricatorOffsetPagedQuery {
const LIMIT = 100;
const ORDER_NEWER = 'newer';
@@ -116,7 +113,6 @@
}
private function buildOrderClause(AphrontDatabaseConnection $conn_r) {
-
$order_word = ($this->order == self::ORDER_OLDER) ? 'DESC' : 'ASC';
// if these are different direction we won't get as efficient a query
// see http://dev.mysql.com/doc/refman/5.5/en/order-by-optimization.html
diff --git a/src/applications/conpherence/query/ConpherenceThreadQuery.php b/src/applications/conpherence/query/ConpherenceThreadQuery.php
--- a/src/applications/conpherence/query/ConpherenceThreadQuery.php
+++ b/src/applications/conpherence/query/ConpherenceThreadQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
final class ConpherenceThreadQuery
extends PhabricatorCursorPagedPolicyAwareQuery {
diff --git a/src/applications/conpherence/query/ConpherenceTransactionQuery.php b/src/applications/conpherence/query/ConpherenceTransactionQuery.php
--- a/src/applications/conpherence/query/ConpherenceTransactionQuery.php
+++ b/src/applications/conpherence/query/ConpherenceTransactionQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
final class ConpherenceTransactionQuery
extends PhabricatorApplicationTransactionQuery {
@@ -14,5 +11,4 @@
return false;
}
-
}
diff --git a/src/applications/conpherence/storage/ConpherenceDAO.php b/src/applications/conpherence/storage/ConpherenceDAO.php
--- a/src/applications/conpherence/storage/ConpherenceDAO.php
+++ b/src/applications/conpherence/storage/ConpherenceDAO.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
abstract class ConpherenceDAO extends PhabricatorLiskDAO {
public function getApplicationName() {
diff --git a/src/applications/conpherence/storage/ConpherenceParticipant.php b/src/applications/conpherence/storage/ConpherenceParticipant.php
--- a/src/applications/conpherence/storage/ConpherenceParticipant.php
+++ b/src/applications/conpherence/storage/ConpherenceParticipant.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
final class ConpherenceParticipant extends ConpherenceDAO {
protected $participantPHID;
diff --git a/src/applications/conpherence/storage/ConpherenceThread.php b/src/applications/conpherence/storage/ConpherenceThread.php
--- a/src/applications/conpherence/storage/ConpherenceThread.php
+++ b/src/applications/conpherence/storage/ConpherenceThread.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
final class ConpherenceThread extends ConpherenceDAO
implements PhabricatorPolicyInterface {
diff --git a/src/applications/conpherence/storage/ConpherenceTransaction.php b/src/applications/conpherence/storage/ConpherenceTransaction.php
--- a/src/applications/conpherence/storage/ConpherenceTransaction.php
+++ b/src/applications/conpherence/storage/ConpherenceTransaction.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
final class ConpherenceTransaction extends PhabricatorApplicationTransaction {
public function getApplicationName() {
diff --git a/src/applications/conpherence/storage/ConpherenceTransactionComment.php b/src/applications/conpherence/storage/ConpherenceTransactionComment.php
--- a/src/applications/conpherence/storage/ConpherenceTransactionComment.php
+++ b/src/applications/conpherence/storage/ConpherenceTransactionComment.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
final class ConpherenceTransactionComment
extends PhabricatorApplicationTransactionComment {
diff --git a/src/applications/conpherence/view/ConpherenceFileWidgetView.php b/src/applications/conpherence/view/ConpherenceFileWidgetView.php
--- a/src/applications/conpherence/view/ConpherenceFileWidgetView.php
+++ b/src/applications/conpherence/view/ConpherenceFileWidgetView.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
final class ConpherenceFileWidgetView extends ConpherenceWidgetView {
public function render() {
diff --git a/src/applications/conpherence/view/ConpherenceMenuItemView.php b/src/applications/conpherence/view/ConpherenceMenuItemView.php
--- a/src/applications/conpherence/view/ConpherenceMenuItemView.php
+++ b/src/applications/conpherence/view/ConpherenceMenuItemView.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
final class ConpherenceMenuItemView extends AphrontTagView {
private $title;
@@ -119,4 +116,5 @@
$unread_count,
);
}
+
}
diff --git a/src/applications/conpherence/view/ConpherencePeopleWidgetView.php b/src/applications/conpherence/view/ConpherencePeopleWidgetView.php
--- a/src/applications/conpherence/view/ConpherencePeopleWidgetView.php
+++ b/src/applications/conpherence/view/ConpherencePeopleWidgetView.php
@@ -1,7 +1,5 @@
<?php
-/**
- * @group conpherence
- */
+
final class ConpherencePeopleWidgetView extends ConpherenceWidgetView {
public function render() {
@@ -54,4 +52,5 @@
return $body;
}
+
}
diff --git a/src/applications/conpherence/view/ConpherenceTransactionView.php b/src/applications/conpherence/view/ConpherenceTransactionView.php
--- a/src/applications/conpherence/view/ConpherenceTransactionView.php
+++ b/src/applications/conpherence/view/ConpherenceTransactionView.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
final class ConpherenceTransactionView extends AphrontView {
private $conpherenceTransaction;
@@ -19,6 +16,7 @@
$this->handles = $handles;
return $this;
}
+
public function getHandles() {
return $this->handles;
}
@@ -27,6 +25,7 @@
$this->conpherenceTransaction = $tx;
return $this;
}
+
private function getConpherenceTransaction() {
return $this->conpherenceTransaction;
}
@@ -99,4 +98,5 @@
return $transaction_view->render();
}
+
}
diff --git a/src/applications/conpherence/view/ConpherenceWidgetView.php b/src/applications/conpherence/view/ConpherenceWidgetView.php
--- a/src/applications/conpherence/view/ConpherenceWidgetView.php
+++ b/src/applications/conpherence/view/ConpherenceWidgetView.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conpherence
- */
abstract class ConpherenceWidgetView extends AphrontView {
private $conpherence;
@@ -23,4 +20,5 @@
public function getConpherence() {
return $this->conpherence;
}
+
}
diff --git a/src/applications/countdown/controller/PhabricatorCountdownController.php b/src/applications/countdown/controller/PhabricatorCountdownController.php
--- a/src/applications/countdown/controller/PhabricatorCountdownController.php
+++ b/src/applications/countdown/controller/PhabricatorCountdownController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group countdown
- */
abstract class PhabricatorCountdownController extends PhabricatorController {
public function buildSideNavView($for_app = false) {
@@ -39,4 +36,5 @@
return $crumbs;
}
+
}
diff --git a/src/applications/countdown/controller/PhabricatorCountdownDeleteController.php b/src/applications/countdown/controller/PhabricatorCountdownDeleteController.php
--- a/src/applications/countdown/controller/PhabricatorCountdownDeleteController.php
+++ b/src/applications/countdown/controller/PhabricatorCountdownDeleteController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group countdown
- */
final class PhabricatorCountdownDeleteController
extends PhabricatorCountdownController {
@@ -13,7 +10,6 @@
}
public function processRequest() {
-
$request = $this->getRequest();
$user = $request->getUser();
diff --git a/src/applications/countdown/controller/PhabricatorCountdownEditController.php b/src/applications/countdown/controller/PhabricatorCountdownEditController.php
--- a/src/applications/countdown/controller/PhabricatorCountdownEditController.php
+++ b/src/applications/countdown/controller/PhabricatorCountdownEditController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group countdown
- */
final class PhabricatorCountdownEditController
extends PhabricatorCountdownController {
@@ -127,4 +124,5 @@
'title' => $page_title,
));
}
+
}
diff --git a/src/applications/countdown/query/PhabricatorCountdownQuery.php b/src/applications/countdown/query/PhabricatorCountdownQuery.php
--- a/src/applications/countdown/query/PhabricatorCountdownQuery.php
+++ b/src/applications/countdown/query/PhabricatorCountdownQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group countdown
- */
final class PhabricatorCountdownQuery
extends PhabricatorCursorPagedPolicyAwareQuery {
@@ -45,7 +42,6 @@
$countdowns = $table->loadAllFromArray($data);
-
return $countdowns;
}
diff --git a/src/applications/countdown/remarkup/PhabricatorCountdownRemarkupRule.php b/src/applications/countdown/remarkup/PhabricatorCountdownRemarkupRule.php
--- a/src/applications/countdown/remarkup/PhabricatorCountdownRemarkupRule.php
+++ b/src/applications/countdown/remarkup/PhabricatorCountdownRemarkupRule.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group countdown
- */
final class PhabricatorCountdownRemarkupRule
extends PhabricatorRemarkupRuleObject {
diff --git a/src/applications/countdown/storage/PhabricatorCountdownDAO.php b/src/applications/countdown/storage/PhabricatorCountdownDAO.php
--- a/src/applications/countdown/storage/PhabricatorCountdownDAO.php
+++ b/src/applications/countdown/storage/PhabricatorCountdownDAO.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group countdown
- */
abstract class PhabricatorCountdownDAO extends PhabricatorLiskDAO {
public function getApplicationName() {
diff --git a/src/applications/differential/conduit/ConduitAPI_differential_finishpostponedlinters_Method.php b/src/applications/differential/conduit/ConduitAPI_differential_finishpostponedlinters_Method.php
--- a/src/applications/differential/conduit/ConduitAPI_differential_finishpostponedlinters_Method.php
+++ b/src/applications/differential/conduit/ConduitAPI_differential_finishpostponedlinters_Method.php
@@ -71,7 +71,7 @@
}
}
- // Load the lint messages currenty attached to the diff. If this
+ // Load the lint messages currenty attached to the diff. If this
// diff property doesn't exist, create it.
$messages_property = id(new DifferentialDiffProperty())->loadOneWhere(
'diffID = %d AND name = %s',
diff --git a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
--- a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
+++ b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
@@ -146,7 +146,7 @@
->setSummary(pht('Allows users to accept their own revisions.'))
->setDescription(
pht(
- "If you set this to true, users can accept their own revisions. ".
+ "If you set this to true, users can accept their own revisions. ".
"This action is disabled by default because it's most likely not ".
"a behavior you want, but it proves useful if you are working ".
"alone on a project and want to make use of all of ".
@@ -186,9 +186,9 @@
->setSummary(pht('Allows any user to reopen a closed revision.'))
->setDescription(
pht('If you set this to true, any user can reopen a revision so '.
- 'long as it has been closed. This can be useful if a revision '.
+ 'long as it has been closed. This can be useful if a revision '.
'is accidentally closed or if a developer changes his or her '.
- 'mind after closing a revision. If it is false, reopening '.
+ 'mind after closing a revision. If it is false, reopening '.
'is not allowed.')),
$this->newOption('differential.close-on-accept', 'bool', false)
->setBoolOptions(
diff --git a/src/applications/differential/parser/DifferentialChangesetParser.php b/src/applications/differential/parser/DifferentialChangesetParser.php
--- a/src/applications/differential/parser/DifferentialChangesetParser.php
+++ b/src/applications/differential/parser/DifferentialChangesetParser.php
@@ -598,7 +598,7 @@
if ($changetype == DifferentialChangeType::TYPE_MOVE_AWAY) {
// sometimes we show moved files as unchanged, sometimes deleted,
// and sometimes inconsistent with what actually happened at the
- // destination of the move. Rather than make a false claim,
+ // destination of the move. Rather than make a false claim,
// omit the 'not changed' notice if this is the source of a move
$unchanged = false;
}
diff --git a/src/applications/differential/remarkup/DifferentialRemarkupRule.php b/src/applications/differential/remarkup/DifferentialRemarkupRule.php
--- a/src/applications/differential/remarkup/DifferentialRemarkupRule.php
+++ b/src/applications/differential/remarkup/DifferentialRemarkupRule.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group differential
- */
-final class DifferentialRemarkupRule
- extends PhabricatorRemarkupRuleObject {
+final class DifferentialRemarkupRule extends PhabricatorRemarkupRuleObject {
protected function getObjectNamePrefix() {
return 'D';
diff --git a/src/applications/differential/storage/DifferentialAffectedPath.php b/src/applications/differential/storage/DifferentialAffectedPath.php
--- a/src/applications/differential/storage/DifferentialAffectedPath.php
+++ b/src/applications/differential/storage/DifferentialAffectedPath.php
@@ -3,8 +3,6 @@
/**
* Denormalized index table which stores relationships between revisions in
* Differential and paths in Diffusion.
- *
- * @group differential
*/
final class DifferentialAffectedPath extends DifferentialDAO {
@@ -18,4 +16,5 @@
self::CONFIG_TIMESTAMPS => false,
) + parent::getConfiguration();
}
+
}
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-abstract class ConduitAPI_diffusion_Method
- extends ConduitAPIMethod {
+abstract class ConduitAPI_diffusion_Method extends ConduitAPIMethod {
public function getApplication() {
return PhabricatorApplication::getByClass(
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_abstractquery_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_abstractquery_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_abstractquery_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_abstractquery_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_diffusion_abstractquery_Method
extends ConduitAPI_diffusion_Method {
@@ -47,6 +44,7 @@
'ERR-UNSUPPORTED-VCS' =>
pht('VCS is not supported for this method.'));
}
+
/**
* Subclasses should override this to specify custom error types.
*/
@@ -61,6 +59,7 @@
'branch' => 'optional string',
);
}
+
/**
* Subclasses should override this to specify custom param types.
*/
@@ -129,4 +128,5 @@
}
return $result;
}
+
}
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_browsequery_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_browsequery_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_browsequery_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_browsequery_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_diffusion_browsequery_Method
extends ConduitAPI_diffusion_abstractquery_Method {
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_commitparentsquery_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_commitparentsquery_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_commitparentsquery_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_commitparentsquery_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_diffusion_commitparentsquery_Method
extends ConduitAPI_diffusion_abstractquery_Method {
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_createcomment_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_createcomment_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_createcomment_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_createcomment_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- *@group conduit
- */
final class ConduitAPI_diffusion_createcomment_Method
extends ConduitAPI_diffusion_Method {
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_diffquery_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_diffquery_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_diffquery_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_diffquery_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_diffusion_diffquery_Method
extends ConduitAPI_diffusion_abstractquery_Method {
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_existsquery_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_existsquery_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_existsquery_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_existsquery_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_diffusion_existsquery_Method
extends ConduitAPI_diffusion_abstractquery_Method {
@@ -52,4 +49,5 @@
$commit);
return !$err;
}
+
}
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_filecontentquery_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_filecontentquery_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_filecontentquery_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_filecontentquery_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_diffusion_filecontentquery_Method
extends ConduitAPI_diffusion_abstractquery_Method {
@@ -42,4 +39,5 @@
->setTextList($text_list);
return $file_content->toDictionary();
}
+
}
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_findsymbols_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_findsymbols_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_findsymbols_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_findsymbols_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_diffusion_findsymbols_Method
extends ConduitAPI_diffusion_Method {
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_getcommits_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_getcommits_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_getcommits_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_getcommits_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_diffusion_getcommits_Method
extends ConduitAPI_diffusion_Method {
@@ -29,12 +26,10 @@
}
public function defineErrorTypes() {
- return array(
- );
+ return array();
}
protected function execute(ConduitAPIRequest $request) {
-
$results = array();
$commits = $request->getValue('commits');
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_getlintmessages_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_getlintmessages_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_getlintmessages_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_getlintmessages_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_diffusion_getlintmessages_Method
extends ConduitAPI_diffusion_Method {
@@ -28,8 +25,7 @@
}
public function defineErrorTypes() {
- return array(
- );
+ return array();
}
protected function execute(ConduitAPIRequest $request) {
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_getrecentcommitsbypath_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_getrecentcommitsbypath_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_getrecentcommitsbypath_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_getrecentcommitsbypath_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_diffusion_getrecentcommitsbypath_Method
extends ConduitAPI_diffusion_Method {
@@ -64,4 +61,5 @@
}
return $result;
}
+
}
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_historyquery_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_historyquery_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_historyquery_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_historyquery_Method.php
@@ -1,10 +1,7 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_diffusion_historyquery_Method
-extends ConduitAPI_diffusion_abstractquery_Method {
+ extends ConduitAPI_diffusion_abstractquery_Method {
private $parents = array();
@@ -33,7 +30,8 @@
return array(
'pathChanges' => mpull($path_changes, 'toDictionary'),
- 'parents' => $this->parents);
+ 'parents' => $this->parents,
+ );
}
protected function getGitResult(ConduitAPIRequest $request) {
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_mergedcommitsquery_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_mergedcommitsquery_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_mergedcommitsquery_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_mergedcommitsquery_Method.php
@@ -1,10 +1,7 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_diffusion_mergedcommitsquery_Method
-extends ConduitAPI_diffusion_abstractquery_Method {
+ extends ConduitAPI_diffusion_abstractquery_Method {
public function getMethodDescription() {
return
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_rawdiffquery_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_rawdiffquery_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_rawdiffquery_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_rawdiffquery_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_diffusion_rawdiffquery_Method
extends ConduitAPI_diffusion_abstractquery_Method {
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_refsquery_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_refsquery_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_refsquery_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_refsquery_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_diffusion_refsquery_Method
extends ConduitAPI_diffusion_abstractquery_Method {
diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_searchquery_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_searchquery_Method.php
--- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_searchquery_Method.php
+++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_searchquery_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_diffusion_searchquery_Method
extends ConduitAPI_diffusion_abstractquery_Method {
@@ -112,4 +109,5 @@
return $results;
}
+
}
diff --git a/src/applications/diffusion/query/DiffusionSymbolQuery.php b/src/applications/diffusion/query/DiffusionSymbolQuery.php
--- a/src/applications/diffusion/query/DiffusionSymbolQuery.php
+++ b/src/applications/diffusion/query/DiffusionSymbolQuery.php
@@ -8,8 +8,6 @@
* @task config Configuring the Query
* @task exec Executing the Query
* @task internal Internals
- *
- * @group diffusion
*/
final class DiffusionSymbolQuery extends PhabricatorOffsetPagedQuery {
@@ -283,5 +281,4 @@
}
}
-
}
diff --git a/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php b/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php
--- a/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php
+++ b/src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php
@@ -79,8 +79,8 @@
if ($v_platform !== 'windows') {
$cmd->execx('mkdir %s', $full_path);
} else {
- // Windows is terrible. The mkdir command doesn't even support putting
- // the path in quotes. IN QUOTES. ARGUHRGHUGHHGG!! Do some terribly
+ // Windows is terrible. The mkdir command doesn't even support putting
+ // the path in quotes. IN QUOTES. ARGUHRGHUGHHGG!! Do some terribly
// inaccurate sanity checking since we can't safely escape the path.
if (preg_match('/^[A-Z]\\:\\\\[a-zA-Z0-9\\\\\\ ]/', $full_path) === 0) {
throw new Exception(
diff --git a/src/applications/feed/conduit/ConduitAPI_feed_Method.php b/src/applications/feed/conduit/ConduitAPI_feed_Method.php
--- a/src/applications/feed/conduit/ConduitAPI_feed_Method.php
+++ b/src/applications/feed/conduit/ConduitAPI_feed_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_feed_Method extends ConduitAPIMethod {
public function getApplication() {
diff --git a/src/applications/feed/conduit/ConduitAPI_feed_publish_Method.php b/src/applications/feed/conduit/ConduitAPI_feed_publish_Method.php
--- a/src/applications/feed/conduit/ConduitAPI_feed_publish_Method.php
+++ b/src/applications/feed/conduit/ConduitAPI_feed_publish_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_feed_publish_Method
- extends ConduitAPI_feed_Method {
+final class ConduitAPI_feed_publish_Method extends ConduitAPI_feed_Method {
public function getMethodStatus() {
return self::METHOD_STATUS_UNSTABLE;
diff --git a/src/applications/feed/conduit/ConduitAPI_feed_query_Method.php b/src/applications/feed/conduit/ConduitAPI_feed_query_Method.php
--- a/src/applications/feed/conduit/ConduitAPI_feed_query_Method.php
+++ b/src/applications/feed/conduit/ConduitAPI_feed_query_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_feed_query_Method
- extends ConduitAPI_feed_Method {
+final class ConduitAPI_feed_query_Method extends ConduitAPI_feed_Method {
public function getMethodStatus() {
return self::METHOD_STATUS_UNSTABLE;
@@ -44,7 +40,7 @@
return array(
'ERR-UNKNOWN-TYPE' =>
- 'Unsupported view type, possibles are: '.$view_types
+ 'Unsupported view type, possibles are: '.$view_types,
);
}
@@ -53,7 +49,6 @@
}
protected function execute(ConduitAPIRequest $request) {
-
$results = array();
$user = $request->getUser();
diff --git a/src/applications/files/conduit/ConduitAPI_file_Method.php b/src/applications/files/conduit/ConduitAPI_file_Method.php
--- a/src/applications/files/conduit/ConduitAPI_file_Method.php
+++ b/src/applications/files/conduit/ConduitAPI_file_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_file_Method extends ConduitAPIMethod {
public function getApplication() {
diff --git a/src/applications/files/conduit/ConduitAPI_file_download_Method.php b/src/applications/files/conduit/ConduitAPI_file_download_Method.php
--- a/src/applications/files/conduit/ConduitAPI_file_download_Method.php
+++ b/src/applications/files/conduit/ConduitAPI_file_download_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_file_download_Method
- extends ConduitAPI_file_Method {
+final class ConduitAPI_file_download_Method extends ConduitAPI_file_Method {
public function getMethodDescription() {
return 'Download a file from the server.';
diff --git a/src/applications/files/conduit/ConduitAPI_file_info_Method.php b/src/applications/files/conduit/ConduitAPI_file_info_Method.php
--- a/src/applications/files/conduit/ConduitAPI_file_info_Method.php
+++ b/src/applications/files/conduit/ConduitAPI_file_info_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_file_info_Method extends ConduitAPI_file_Method {
public function getMethodDescription() {
diff --git a/src/applications/files/conduit/ConduitAPI_file_upload_Method.php b/src/applications/files/conduit/ConduitAPI_file_upload_Method.php
--- a/src/applications/files/conduit/ConduitAPI_file_upload_Method.php
+++ b/src/applications/files/conduit/ConduitAPI_file_upload_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_file_upload_Method extends ConduitAPI_file_Method {
public function getMethodDescription() {
diff --git a/src/applications/files/conduit/ConduitAPI_file_uploadhash_Method.php b/src/applications/files/conduit/ConduitAPI_file_uploadhash_Method.php
--- a/src/applications/files/conduit/ConduitAPI_file_uploadhash_Method.php
+++ b/src/applications/files/conduit/ConduitAPI_file_uploadhash_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_file_uploadhash_Method extends ConduitAPI_file_Method {
public function getMethodDescription() {
@@ -42,4 +39,5 @@
}
return $file;
}
+
}
diff --git a/src/applications/files/config/PhabricatorFilesConfigOptions.php b/src/applications/files/config/PhabricatorFilesConfigOptions.php
--- a/src/applications/files/config/PhabricatorFilesConfigOptions.php
+++ b/src/applications/files/config/PhabricatorFilesConfigOptions.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group file
- */
final class PhabricatorFilesConfigOptions
extends PhabricatorApplicationConfigOptions {
@@ -15,7 +12,6 @@
}
public function getOptions() {
-
$viewable_default = array(
'image/jpeg' => 'image/jpeg',
'image/jpg' => 'image/jpg',
diff --git a/src/applications/files/controller/PhabricatorFileCommentController.php b/src/applications/files/controller/PhabricatorFileCommentController.php
--- a/src/applications/files/controller/PhabricatorFileCommentController.php
+++ b/src/applications/files/controller/PhabricatorFileCommentController.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group file
- */
-final class PhabricatorFileCommentController
- extends PhabricatorFileController {
+final class PhabricatorFileCommentController extends PhabricatorFileController {
private $id;
diff --git a/src/applications/files/editor/PhabricatorFileEditor.php b/src/applications/files/editor/PhabricatorFileEditor.php
--- a/src/applications/files/editor/PhabricatorFileEditor.php
+++ b/src/applications/files/editor/PhabricatorFileEditor.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group file
- */
final class PhabricatorFileEditor
extends PhabricatorApplicationTransactionEditor {
diff --git a/src/applications/files/engine/PhabricatorFileStorageEngine.php b/src/applications/files/engine/PhabricatorFileStorageEngine.php
--- a/src/applications/files/engine/PhabricatorFileStorageEngine.php
+++ b/src/applications/files/engine/PhabricatorFileStorageEngine.php
@@ -12,7 +12,6 @@
* @task construct Constructing an Engine
* @task meta Engine Metadata
* @task file Managing File Data
- * @group filestorage
*/
abstract class PhabricatorFileStorageEngine {
diff --git a/src/applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php b/src/applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php
--- a/src/applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php
+++ b/src/applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php
@@ -6,7 +6,6 @@
*
* @task impl Implementation
* @task internal Internals
- * @group filestorage
*/
final class PhabricatorLocalDiskFileStorageEngine
extends PhabricatorFileStorageEngine {
@@ -30,7 +29,6 @@
* @task impl
*/
public function writeFile($data, array $params) {
-
$root = $this->getLocalDiskFileStorageRoot();
// Generate a random, unique file path like "ab/29/1f918a9ac39201ff". We
diff --git a/src/applications/files/engine/PhabricatorMySQLFileStorageEngine.php b/src/applications/files/engine/PhabricatorMySQLFileStorageEngine.php
--- a/src/applications/files/engine/PhabricatorMySQLFileStorageEngine.php
+++ b/src/applications/files/engine/PhabricatorMySQLFileStorageEngine.php
@@ -9,7 +9,6 @@
*
* @task impl Implementation
* @task internal Internals
- * @group filestorage
*/
final class PhabricatorMySQLFileStorageEngine
extends PhabricatorFileStorageEngine {
diff --git a/src/applications/files/engine/PhabricatorTestStorageEngine.php b/src/applications/files/engine/PhabricatorTestStorageEngine.php
--- a/src/applications/files/engine/PhabricatorTestStorageEngine.php
+++ b/src/applications/files/engine/PhabricatorTestStorageEngine.php
@@ -2,8 +2,6 @@
/**
* Test storage engine. Does not actually store files. Used for unit tests.
- *
- * @group filestorage
*/
final class PhabricatorTestStorageEngine
extends PhabricatorFileStorageEngine {
diff --git a/src/applications/files/engineselector/PhabricatorDefaultFileStorageEngineSelector.php b/src/applications/files/engineselector/PhabricatorDefaultFileStorageEngineSelector.php
--- a/src/applications/files/engineselector/PhabricatorDefaultFileStorageEngineSelector.php
+++ b/src/applications/files/engineselector/PhabricatorDefaultFileStorageEngineSelector.php
@@ -4,8 +4,6 @@
* Default storage engine selector. See
* @{class:PhabricatorFileStorageEngineSelector} and @{article:File Storage
* Technical Documentation} for more information.
- *
- * @group filestorage
*/
final class PhabricatorDefaultFileStorageEngineSelector
extends PhabricatorFileStorageEngineSelector {
diff --git a/src/applications/files/engineselector/PhabricatorFileStorageEngineSelector.php b/src/applications/files/engineselector/PhabricatorFileStorageEngineSelector.php
--- a/src/applications/files/engineselector/PhabricatorFileStorageEngineSelector.php
+++ b/src/applications/files/engineselector/PhabricatorFileStorageEngineSelector.php
@@ -6,7 +6,6 @@
* of suitable @{class:PhabricatorFileStorageEngine}s. For more information,
* see @{article:File Storage Technical Documentation}.
*
- * @group filestorage
* @task select Selecting Storage Engines
*/
abstract class PhabricatorFileStorageEngineSelector {
diff --git a/src/applications/files/exception/PhabricatorFileStorageConfigurationException.php b/src/applications/files/exception/PhabricatorFileStorageConfigurationException.php
--- a/src/applications/files/exception/PhabricatorFileStorageConfigurationException.php
+++ b/src/applications/files/exception/PhabricatorFileStorageConfigurationException.php
@@ -4,9 +4,5 @@
* Thrown by storage engines to indicate an configuration error which should
* abort the storage attempt, as opposed to a transient storage error which
* should be retried on other engines.
- *
- * @group files
*/
-final class PhabricatorFileStorageConfigurationException extends Exception {
-
-}
+final class PhabricatorFileStorageConfigurationException extends Exception {}
diff --git a/src/applications/files/mail/FileCreateMailReceiver.php b/src/applications/files/mail/FileCreateMailReceiver.php
--- a/src/applications/files/mail/FileCreateMailReceiver.php
+++ b/src/applications/files/mail/FileCreateMailReceiver.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group files
- */
-final class FileCreateMailReceiver
- extends PhabricatorMailReceiver {
+final class FileCreateMailReceiver extends PhabricatorMailReceiver {
public function isEnabled() {
$app_class = 'PhabricatorApplicationFiles';
diff --git a/src/applications/files/mail/FileMailReceiver.php b/src/applications/files/mail/FileMailReceiver.php
--- a/src/applications/files/mail/FileMailReceiver.php
+++ b/src/applications/files/mail/FileMailReceiver.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group file
- */
final class FileMailReceiver extends PhabricatorObjectMailReceiver {
public function isEnabled() {
diff --git a/src/applications/files/mail/FileReplyHandler.php b/src/applications/files/mail/FileReplyHandler.php
--- a/src/applications/files/mail/FileReplyHandler.php
+++ b/src/applications/files/mail/FileReplyHandler.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group file
- */
final class FileReplyHandler extends PhabricatorMailReplyHandler {
public function validateMailReceiver($mail_receiver) {
@@ -75,7 +72,6 @@
$head_xaction = head($xactions);
return $head_xaction->getID();
-
}
}
diff --git a/src/applications/files/query/PhabricatorFileQuery.php b/src/applications/files/query/PhabricatorFileQuery.php
--- a/src/applications/files/query/PhabricatorFileQuery.php
+++ b/src/applications/files/query/PhabricatorFileQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group file
- */
final class PhabricatorFileQuery
extends PhabricatorCursorPagedPolicyAwareQuery {
diff --git a/src/applications/files/query/PhabricatorFileTransactionQuery.php b/src/applications/files/query/PhabricatorFileTransactionQuery.php
--- a/src/applications/files/query/PhabricatorFileTransactionQuery.php
+++ b/src/applications/files/query/PhabricatorFileTransactionQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group file
- */
final class PhabricatorFileTransactionQuery
extends PhabricatorApplicationTransactionQuery {
diff --git a/src/applications/files/storage/PhabricatorFile.php b/src/applications/files/storage/PhabricatorFile.php
--- a/src/applications/files/storage/PhabricatorFile.php
+++ b/src/applications/files/storage/PhabricatorFile.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group file
- */
final class PhabricatorFile extends PhabricatorFileDAO
implements
PhabricatorTokenReceiverInterface,
@@ -157,7 +154,6 @@
}
public static function newFileFromContentHash($hash, $params) {
-
// Check to see if a file with same contentHash exist
$file = id(new PhabricatorFile())->loadOneWhere(
'contentHash = %s LIMIT 1', $hash);
@@ -413,7 +409,6 @@
}
public function delete() {
-
// We want to delete all the rows which mark this file as the transformation
// of some other file (since we're getting rid of it). We also delete all
// the transformations of this file, so that a user who deletes an image
@@ -587,7 +582,6 @@
}
public function isTransformableImage() {
-
// NOTE: The way the 'gd' extension works in PHP is that you can install it
// with support for only some file types, so it might be able to handle
// PNG but not JPEG. Try to generate thumbnails for whatever we can. Setup
diff --git a/src/applications/files/storage/PhabricatorFileDAO.php b/src/applications/files/storage/PhabricatorFileDAO.php
--- a/src/applications/files/storage/PhabricatorFileDAO.php
+++ b/src/applications/files/storage/PhabricatorFileDAO.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group file
- */
abstract class PhabricatorFileDAO extends PhabricatorLiskDAO {
public function getApplicationName() {
diff --git a/src/applications/files/storage/PhabricatorFileTransaction.php b/src/applications/files/storage/PhabricatorFileTransaction.php
--- a/src/applications/files/storage/PhabricatorFileTransaction.php
+++ b/src/applications/files/storage/PhabricatorFileTransaction.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group file
- */
final class PhabricatorFileTransaction
extends PhabricatorApplicationTransaction {
diff --git a/src/applications/files/storage/PhabricatorFileTransactionComment.php b/src/applications/files/storage/PhabricatorFileTransactionComment.php
--- a/src/applications/files/storage/PhabricatorFileTransactionComment.php
+++ b/src/applications/files/storage/PhabricatorFileTransactionComment.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group file
- */
final class PhabricatorFileTransactionComment
extends PhabricatorApplicationTransactionComment {
@@ -14,4 +11,5 @@
// Only cache submitted comments.
return ($this->getTransactionPHID() != null);
}
+
}
diff --git a/src/applications/files/storage/PhabricatorTransformedFile.php b/src/applications/files/storage/PhabricatorTransformedFile.php
--- a/src/applications/files/storage/PhabricatorTransformedFile.php
+++ b/src/applications/files/storage/PhabricatorTransformedFile.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group file
- */
final class PhabricatorTransformedFile extends PhabricatorFileDAO {
protected $originalPHID;
diff --git a/src/applications/files/storage/__tests__/PhabricatorFileTestCase.php b/src/applications/files/storage/__tests__/PhabricatorFileTestCase.php
--- a/src/applications/files/storage/__tests__/PhabricatorFileTestCase.php
+++ b/src/applications/files/storage/__tests__/PhabricatorFileTestCase.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group file
- */
final class PhabricatorFileTestCase extends PhabricatorTestCase {
public function getPhabricatorTestCaseConfiguration() {
@@ -59,7 +56,6 @@
$this->assertTrue($first_handle != $second_handle);
}
-
public function testFileStorageUploadSameFile() {
$engine = new PhabricatorTestStorageEngine();
diff --git a/src/applications/flag/conduit/ConduitAPI_flag_Method.php b/src/applications/flag/conduit/ConduitAPI_flag_Method.php
--- a/src/applications/flag/conduit/ConduitAPI_flag_Method.php
+++ b/src/applications/flag/conduit/ConduitAPI_flag_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_flag_Method extends ConduitAPIMethod {
public function getApplication() {
diff --git a/src/applications/flag/conduit/ConduitAPI_flag_delete_Method.php b/src/applications/flag/conduit/ConduitAPI_flag_delete_Method.php
--- a/src/applications/flag/conduit/ConduitAPI_flag_delete_Method.php
+++ b/src/applications/flag/conduit/ConduitAPI_flag_delete_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_flag_delete_Method extends ConduitAPI_flag_Method {
public function getMethodDescription() {
diff --git a/src/applications/flag/conduit/ConduitAPI_flag_edit_Method.php b/src/applications/flag/conduit/ConduitAPI_flag_edit_Method.php
--- a/src/applications/flag/conduit/ConduitAPI_flag_edit_Method.php
+++ b/src/applications/flag/conduit/ConduitAPI_flag_edit_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_flag_edit_Method extends ConduitAPI_flag_Method {
public function getMethodDescription() {
diff --git a/src/applications/flag/conduit/ConduitAPI_flag_query_Method.php b/src/applications/flag/conduit/ConduitAPI_flag_query_Method.php
--- a/src/applications/flag/conduit/ConduitAPI_flag_query_Method.php
+++ b/src/applications/flag/conduit/ConduitAPI_flag_query_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_flag_query_Method extends ConduitAPI_flag_Method {
public function getMethodDescription() {
@@ -30,7 +27,6 @@
}
protected function execute(ConduitAPIRequest $request) {
-
$query = new PhabricatorFlagQuery();
$query->setViewer($request->getUser());
diff --git a/src/applications/harbormaster/controller/HarbormasterPlanViewController.php b/src/applications/harbormaster/controller/HarbormasterPlanViewController.php
--- a/src/applications/harbormaster/controller/HarbormasterPlanViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterPlanViewController.php
@@ -106,7 +106,7 @@
try {
$implementation = $step->getStepImplementation();
} catch (Exception $ex) {
- // We can't initialize the implementation. This might be because
+ // We can't initialize the implementation. This might be because
// it's been renamed or no longer exists.
$item = id(new PHUIObjectItemView())
->setObjectName(pht('Step %d', $i++))
diff --git a/src/applications/harbormaster/query/HarbormasterBuildTransactionQuery.php b/src/applications/harbormaster/query/HarbormasterBuildTransactionQuery.php
--- a/src/applications/harbormaster/query/HarbormasterBuildTransactionQuery.php
+++ b/src/applications/harbormaster/query/HarbormasterBuildTransactionQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group harbormaster
- */
final class HarbormasterBuildTransactionQuery
extends PhabricatorApplicationTransactionQuery {
diff --git a/src/applications/harbormaster/query/HarbormasterBuildableTransactionQuery.php b/src/applications/harbormaster/query/HarbormasterBuildableTransactionQuery.php
--- a/src/applications/harbormaster/query/HarbormasterBuildableTransactionQuery.php
+++ b/src/applications/harbormaster/query/HarbormasterBuildableTransactionQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group harbormaster
- */
final class HarbormasterBuildableTransactionQuery
extends PhabricatorApplicationTransactionQuery {
diff --git a/src/applications/harbormaster/storage/build/HarbormasterBuildLog.php b/src/applications/harbormaster/storage/build/HarbormasterBuildLog.php
--- a/src/applications/harbormaster/storage/build/HarbormasterBuildLog.php
+++ b/src/applications/harbormaster/storage/build/HarbormasterBuildLog.php
@@ -71,7 +71,7 @@
}
// If the length of the content is greater than the chunk size limit,
- // then we can never fit the content in a single record. We need to
+ // then we can never fit the content in a single record. We need to
// split our content out and call append on it for as many parts as there
// are to the content.
if (strlen($content) > self::CHUNK_BYTE_LIMIT) {
@@ -85,7 +85,7 @@
return;
}
- // Retrieve the size of last chunk from the DB for this log. If the
+ // Retrieve the size of last chunk from the DB for this log. If the
// chunk is over 500K, then we need to create a new log entry.
$conn = $this->establishConnection('w');
$result = queryfx_all(
@@ -142,7 +142,7 @@
public function getLogText() {
// TODO: This won't cope very well if we're pulling like a 700MB
- // log file out of the DB. We should probably implement some sort
+ // log file out of the DB. We should probably implement some sort
// of optional limit parameter so that when we're rendering out only
// 25 lines in the UI, we don't wastefully read in the whole log.
diff --git a/src/applications/herald/adapter/HeraldCommitAdapter.php b/src/applications/herald/adapter/HeraldCommitAdapter.php
--- a/src/applications/herald/adapter/HeraldCommitAdapter.php
+++ b/src/applications/herald/adapter/HeraldCommitAdapter.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group herald
- */
final class HeraldCommitAdapter extends HeraldAdapter {
const FIELD_NEED_AUDIT_FOR_PACKAGE = 'need-audit-for-package';
@@ -559,4 +556,5 @@
}
return $result;
}
+
}
diff --git a/src/applications/legalpad/config/PhabricatorLegalpadConfigOptions.php b/src/applications/legalpad/config/PhabricatorLegalpadConfigOptions.php
--- a/src/applications/legalpad/config/PhabricatorLegalpadConfigOptions.php
+++ b/src/applications/legalpad/config/PhabricatorLegalpadConfigOptions.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group legalpad
- */
final class PhabricatorLegalpadConfigOptions
extends PhabricatorApplicationConfigOptions {
diff --git a/src/applications/legalpad/constants/LegalpadConstants.php b/src/applications/legalpad/constants/LegalpadConstants.php
--- a/src/applications/legalpad/constants/LegalpadConstants.php
+++ b/src/applications/legalpad/constants/LegalpadConstants.php
@@ -1,8 +1,3 @@
<?php
-/**
- * @group legalpad
- */
-abstract class LegalpadConstants {
-
-}
+abstract class LegalpadConstants {}
diff --git a/src/applications/legalpad/controller/LegalpadController.php b/src/applications/legalpad/controller/LegalpadController.php
--- a/src/applications/legalpad/controller/LegalpadController.php
+++ b/src/applications/legalpad/controller/LegalpadController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group legalpad
- */
abstract class LegalpadController extends PhabricatorController {
public function buildSideNav($for_app = false) {
diff --git a/src/applications/legalpad/controller/LegalpadDocumentCommentController.php b/src/applications/legalpad/controller/LegalpadDocumentCommentController.php
--- a/src/applications/legalpad/controller/LegalpadDocumentCommentController.php
+++ b/src/applications/legalpad/controller/LegalpadDocumentCommentController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group legalpad
- */
final class LegalpadDocumentCommentController extends LegalpadController {
private $id;
diff --git a/src/applications/legalpad/editor/LegalpadDocumentEditor.php b/src/applications/legalpad/editor/LegalpadDocumentEditor.php
--- a/src/applications/legalpad/editor/LegalpadDocumentEditor.php
+++ b/src/applications/legalpad/editor/LegalpadDocumentEditor.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group legalpad
- */
final class LegalpadDocumentEditor
extends PhabricatorApplicationTransactionEditor {
diff --git a/src/applications/legalpad/mail/LegalpadReplyHandler.php b/src/applications/legalpad/mail/LegalpadReplyHandler.php
--- a/src/applications/legalpad/mail/LegalpadReplyHandler.php
+++ b/src/applications/legalpad/mail/LegalpadReplyHandler.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group legalpad
- */
final class LegalpadReplyHandler extends PhabricatorMailReplyHandler {
public function validateMailReceiver($mail_receiver) {
diff --git a/src/applications/legalpad/phid/PhabricatorLegalpadPHIDTypeDocument.php b/src/applications/legalpad/phid/PhabricatorLegalpadPHIDTypeDocument.php
--- a/src/applications/legalpad/phid/PhabricatorLegalpadPHIDTypeDocument.php
+++ b/src/applications/legalpad/phid/PhabricatorLegalpadPHIDTypeDocument.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group legalpad
- */
final class PhabricatorLegalpadPHIDTypeDocument extends PhabricatorPHIDType {
const TYPECONST = 'LEGD';
diff --git a/src/applications/legalpad/query/LegalpadTransactionQuery.php b/src/applications/legalpad/query/LegalpadTransactionQuery.php
--- a/src/applications/legalpad/query/LegalpadTransactionQuery.php
+++ b/src/applications/legalpad/query/LegalpadTransactionQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group legalpad
- */
final class LegalpadTransactionQuery
extends PhabricatorApplicationTransactionQuery {
diff --git a/src/applications/legalpad/storage/LegalpadDAO.php b/src/applications/legalpad/storage/LegalpadDAO.php
--- a/src/applications/legalpad/storage/LegalpadDAO.php
+++ b/src/applications/legalpad/storage/LegalpadDAO.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group legalpad
- */
abstract class LegalpadDAO extends PhabricatorLiskDAO {
public function getApplicationName() {
diff --git a/src/applications/legalpad/storage/LegalpadDocumentBody.php b/src/applications/legalpad/storage/LegalpadDocumentBody.php
--- a/src/applications/legalpad/storage/LegalpadDocumentBody.php
+++ b/src/applications/legalpad/storage/LegalpadDocumentBody.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group legalpad
- */
final class LegalpadDocumentBody extends LegalpadDAO
implements
PhabricatorMarkupInterface {
@@ -69,5 +66,4 @@
return (bool)$this->getID();
}
-
}
diff --git a/src/applications/legalpad/storage/LegalpadTransaction.php b/src/applications/legalpad/storage/LegalpadTransaction.php
--- a/src/applications/legalpad/storage/LegalpadTransaction.php
+++ b/src/applications/legalpad/storage/LegalpadTransaction.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group legalpad
- */
final class LegalpadTransaction extends PhabricatorApplicationTransaction {
public function getApplicationName() {
diff --git a/src/applications/legalpad/storage/LegalpadTransactionComment.php b/src/applications/legalpad/storage/LegalpadTransactionComment.php
--- a/src/applications/legalpad/storage/LegalpadTransactionComment.php
+++ b/src/applications/legalpad/storage/LegalpadTransactionComment.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group legalpad
- */
final class LegalpadTransactionComment
extends PhabricatorApplicationTransactionComment {
@@ -21,4 +18,5 @@
// Only cache submitted comments.
return ($this->getTransactionPHID() != null);
}
+
}
diff --git a/src/applications/legalpad/view/LegalpadTransactionView.php b/src/applications/legalpad/view/LegalpadTransactionView.php
--- a/src/applications/legalpad/view/LegalpadTransactionView.php
+++ b/src/applications/legalpad/view/LegalpadTransactionView.php
@@ -1,9 +1,4 @@
<?php
-/**
- * @group legalpad
- */
final class LegalpadTransactionView
- extends PhabricatorApplicationTransactionView {
-
-}
+ extends PhabricatorApplicationTransactionView {}
diff --git a/src/applications/macro/conduit/ConduitAPI_macro_Method.php b/src/applications/macro/conduit/ConduitAPI_macro_Method.php
--- a/src/applications/macro/conduit/ConduitAPI_macro_Method.php
+++ b/src/applications/macro/conduit/ConduitAPI_macro_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_macro_Method extends ConduitAPIMethod {
public function getApplication() {
@@ -10,5 +7,4 @@
'PhabricatorApplicationMacro');
}
-
}
diff --git a/src/applications/macro/conduit/ConduitAPI_macro_creatememe_Method.php b/src/applications/macro/conduit/ConduitAPI_macro_creatememe_Method.php
--- a/src/applications/macro/conduit/ConduitAPI_macro_creatememe_Method.php
+++ b/src/applications/macro/conduit/ConduitAPI_macro_creatememe_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_macro_creatememe_Method
- extends ConduitAPI_macro_Method {
+final class ConduitAPI_macro_creatememe_Method extends ConduitAPI_macro_Method {
public function getMethodStatus() {
return self::METHOD_STATUS_UNSTABLE;
diff --git a/src/applications/macro/conduit/ConduitAPI_macro_query_Method.php b/src/applications/macro/conduit/ConduitAPI_macro_query_Method.php
--- a/src/applications/macro/conduit/ConduitAPI_macro_query_Method.php
+++ b/src/applications/macro/conduit/ConduitAPI_macro_query_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_macro_query_Method extends ConduitAPI_macro_Method {
public function getMethodDescription() {
diff --git a/src/applications/macro/query/PhabricatorMacroQuery.php b/src/applications/macro/query/PhabricatorMacroQuery.php
--- a/src/applications/macro/query/PhabricatorMacroQuery.php
+++ b/src/applications/macro/query/PhabricatorMacroQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phriction
- */
final class PhabricatorMacroQuery
extends PhabricatorCursorPagedPolicyAwareQuery {
@@ -29,7 +26,6 @@
}
public static function getFlagColorsOptions() {
-
$options = array(
'-1' => pht('(No Filtering)'),
'-2' => pht('(Marked With Any Flag)'),
diff --git a/src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php b/src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php
--- a/src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php
+++ b/src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group markup
- */
-final class PhabricatorRemarkupRuleImageMacro
- extends PhutilRemarkupRule {
+final class PhabricatorRemarkupRuleImageMacro extends PhutilRemarkupRule {
private $macros;
diff --git a/src/applications/macro/remarkup/PhabricatorRemarkupRuleMeme.php b/src/applications/macro/remarkup/PhabricatorRemarkupRuleMeme.php
--- a/src/applications/macro/remarkup/PhabricatorRemarkupRuleMeme.php
+++ b/src/applications/macro/remarkup/PhabricatorRemarkupRuleMeme.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group markup
- */
-final class PhabricatorRemarkupRuleMeme
- extends PhutilRemarkupRule {
+final class PhabricatorRemarkupRuleMeme extends PhutilRemarkupRule {
private $images;
diff --git a/src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php b/src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php
--- a/src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php
+++ b/src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_maniphest_Method extends ConduitAPIMethod {
public function getApplication() {
@@ -103,25 +100,28 @@
$owner_phid = $request->getValue('ownerPHID');
if ($owner_phid !== null) {
- $this->validatePHIDList(array($owner_phid),
- PhabricatorPeoplePHIDTypeUser::TYPECONST,
- 'ownerPHID');
+ $this->validatePHIDList(
+ array($owner_phid),
+ PhabricatorPeoplePHIDTypeUser::TYPECONST,
+ 'ownerPHID');
$changes[ManiphestTransaction::TYPE_OWNER] = $owner_phid;
}
$ccs = $request->getValue('ccPHIDs');
if ($ccs !== null) {
- $this->validatePHIDList($ccs,
- PhabricatorPeoplePHIDTypeUser::TYPECONST,
- 'ccPHIDS');
+ $this->validatePHIDList(
+ $ccs,
+ PhabricatorPeoplePHIDTypeUser::TYPECONST,
+ 'ccPHIDS');
$changes[ManiphestTransaction::TYPE_CCS] = $ccs;
}
$project_phids = $request->getValue('projectPHIDs');
if ($project_phids !== null) {
- $this->validatePHIDList($project_phids,
- PhabricatorProjectPHIDTypeProject::TYPECONST,
- 'projectPHIDS');
+ $this->validatePHIDList(
+ $project_phids,
+ PhabricatorProjectPHIDTypeProject::TYPECONST,
+ 'projectPHIDS');
$changes[ManiphestTransaction::TYPE_PROJECTS] = $project_phids;
}
@@ -207,7 +207,6 @@
$event->setUser($request->getUser());
$event->setConduitRequest($request);
PhutilEventEngine::dispatchEvent($event);
-
}
protected function buildTaskInfoDictionaries(array $tasks) {
diff --git a/src/applications/maniphest/conduit/ConduitAPI_maniphest_createtask_Method.php b/src/applications/maniphest/conduit/ConduitAPI_maniphest_createtask_Method.php
--- a/src/applications/maniphest/conduit/ConduitAPI_maniphest_createtask_Method.php
+++ b/src/applications/maniphest/conduit/ConduitAPI_maniphest_createtask_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_maniphest_createtask_Method
extends ConduitAPI_maniphest_Method {
diff --git a/src/applications/maniphest/conduit/ConduitAPI_maniphest_find_Method.php b/src/applications/maniphest/conduit/ConduitAPI_maniphest_find_Method.php
--- a/src/applications/maniphest/conduit/ConduitAPI_maniphest_find_Method.php
+++ b/src/applications/maniphest/conduit/ConduitAPI_maniphest_find_Method.php
@@ -1,8 +1,6 @@
<?php
/**
- * @group conduit
- *
* @concrete-extensible
*/
final class ConduitAPI_maniphest_find_Method
diff --git a/src/applications/maniphest/conduit/ConduitAPI_maniphest_gettasktransactions_Method.php b/src/applications/maniphest/conduit/ConduitAPI_maniphest_gettasktransactions_Method.php
--- a/src/applications/maniphest/conduit/ConduitAPI_maniphest_gettasktransactions_Method.php
+++ b/src/applications/maniphest/conduit/ConduitAPI_maniphest_gettasktransactions_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group maniphest
- */
final class ConduitAPI_maniphest_gettasktransactions_Method
extends ConduitAPI_maniphest_Method {
@@ -74,4 +71,5 @@
return $results;
}
+
}
diff --git a/src/applications/maniphest/conduit/ConduitAPI_maniphest_info_Method.php b/src/applications/maniphest/conduit/ConduitAPI_maniphest_info_Method.php
--- a/src/applications/maniphest/conduit/ConduitAPI_maniphest_info_Method.php
+++ b/src/applications/maniphest/conduit/ConduitAPI_maniphest_info_Method.php
@@ -1,12 +1,8 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_maniphest_info_Method
extends ConduitAPI_maniphest_Method {
-
public function getMethodDescription() {
return 'Retrieve information about a Maniphest task, given its id.';
}
diff --git a/src/applications/maniphest/conduit/ConduitAPI_maniphest_query_Method.php b/src/applications/maniphest/conduit/ConduitAPI_maniphest_query_Method.php
--- a/src/applications/maniphest/conduit/ConduitAPI_maniphest_query_Method.php
+++ b/src/applications/maniphest/conduit/ConduitAPI_maniphest_query_Method.php
@@ -1,22 +1,17 @@
<?php
/**
- * @group conduit
- *
* TODO: Remove maniphest.find, then make this final.
*
* @concrete-extensible
*/
-class ConduitAPI_maniphest_query_Method
- extends ConduitAPI_maniphest_Method {
-
+class ConduitAPI_maniphest_query_Method extends ConduitAPI_maniphest_Method {
public function getMethodDescription() {
return 'Execute complex searches for Maniphest tasks.';
}
public function defineParamTypes() {
-
$statuses = array(
ManiphestTaskQuery::STATUS_ANY,
ManiphestTaskQuery::STATUS_OPEN,
@@ -58,8 +53,7 @@
}
public function defineErrorTypes() {
- return array(
- );
+ return array();
}
protected function execute(ConduitAPIRequest $request) {
diff --git a/src/applications/maniphest/conduit/ConduitAPI_maniphest_update_Method.php b/src/applications/maniphest/conduit/ConduitAPI_maniphest_update_Method.php
--- a/src/applications/maniphest/conduit/ConduitAPI_maniphest_update_Method.php
+++ b/src/applications/maniphest/conduit/ConduitAPI_maniphest_update_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_maniphest_update_Method
extends ConduitAPI_maniphest_Method {
diff --git a/src/applications/maniphest/constants/ManiphestConstants.php b/src/applications/maniphest/constants/ManiphestConstants.php
--- a/src/applications/maniphest/constants/ManiphestConstants.php
+++ b/src/applications/maniphest/constants/ManiphestConstants.php
@@ -1,8 +1,3 @@
<?php
-/**
- * @group maniphest
- */
-abstract class ManiphestConstants {
-
-}
+abstract class ManiphestConstants {}
diff --git a/src/applications/maniphest/constants/ManiphestTaskOwner.php b/src/applications/maniphest/constants/ManiphestTaskOwner.php
--- a/src/applications/maniphest/constants/ManiphestTaskOwner.php
+++ b/src/applications/maniphest/constants/ManiphestTaskOwner.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group maniphest
- */
final class ManiphestTaskOwner extends ManiphestConstants {
const OWNER_UP_FOR_GRABS = 'PHID-!!!!-UP-FOR-GRABS';
diff --git a/src/applications/maniphest/controller/ManiphestBatchEditController.php b/src/applications/maniphest/controller/ManiphestBatchEditController.php
--- a/src/applications/maniphest/controller/ManiphestBatchEditController.php
+++ b/src/applications/maniphest/controller/ManiphestBatchEditController.php
@@ -1,12 +1,8 @@
<?php
-/**
- * @group maniphest
- */
final class ManiphestBatchEditController extends ManiphestController {
public function processRequest() {
-
$this->requireApplicationCapability(
ManiphestCapabilityBulkEdit::CAPABILITY);
diff --git a/src/applications/maniphest/controller/ManiphestExportController.php b/src/applications/maniphest/controller/ManiphestExportController.php
--- a/src/applications/maniphest/controller/ManiphestExportController.php
+++ b/src/applications/maniphest/controller/ManiphestExportController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group maniphest
- */
final class ManiphestExportController extends ManiphestController {
private $key;
diff --git a/src/applications/maniphest/controller/ManiphestSubpriorityController.php b/src/applications/maniphest/controller/ManiphestSubpriorityController.php
--- a/src/applications/maniphest/controller/ManiphestSubpriorityController.php
+++ b/src/applications/maniphest/controller/ManiphestSubpriorityController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group maniphest
- */
final class ManiphestSubpriorityController extends ManiphestController {
public function processRequest() {
diff --git a/src/applications/maniphest/controller/ManiphestTaskDescriptionPreviewController.php b/src/applications/maniphest/controller/ManiphestTaskDescriptionPreviewController.php
--- a/src/applications/maniphest/controller/ManiphestTaskDescriptionPreviewController.php
+++ b/src/applications/maniphest/controller/ManiphestTaskDescriptionPreviewController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group maniphest
- */
final class ManiphestTaskDescriptionPreviewController
extends ManiphestController {
@@ -23,4 +20,5 @@
return id(new AphrontAjaxResponse())
->setContent($content);
}
+
}
diff --git a/src/applications/maniphest/controller/ManiphestTransactionPreviewController.php b/src/applications/maniphest/controller/ManiphestTransactionPreviewController.php
--- a/src/applications/maniphest/controller/ManiphestTransactionPreviewController.php
+++ b/src/applications/maniphest/controller/ManiphestTransactionPreviewController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group maniphest
- */
final class ManiphestTransactionPreviewController extends ManiphestController {
private $id;
diff --git a/src/applications/maniphest/event/ManiphestEdgeEventListener.php b/src/applications/maniphest/event/ManiphestEdgeEventListener.php
--- a/src/applications/maniphest/event/ManiphestEdgeEventListener.php
+++ b/src/applications/maniphest/event/ManiphestEdgeEventListener.php
@@ -3,9 +3,7 @@
/**
* Listener for Maniphest Task edge events. When some workflow causes task
* edges to be added or removed, we consider the edge edit authoritative but
- * duplicate the information into a ManiphestTansaction for display.
- *
- * @group maniphest
+ * duplicate the information into a @{class:ManiphestTansaction} for display.
*/
final class ManiphestEdgeEventListener extends PhabricatorEventListener {
diff --git a/src/applications/maniphest/export/ManiphestExcelDefaultFormat.php b/src/applications/maniphest/export/ManiphestExcelDefaultFormat.php
--- a/src/applications/maniphest/export/ManiphestExcelDefaultFormat.php
+++ b/src/applications/maniphest/export/ManiphestExcelDefaultFormat.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group maniphest
- */
final class ManiphestExcelDefaultFormat extends ManiphestExcelFormat {
public function getName() {
@@ -134,7 +131,6 @@
}
}
-
private function col($n) {
return chr(ord('A') + $n);
}
diff --git a/src/applications/maniphest/export/ManiphestExcelFormat.php b/src/applications/maniphest/export/ManiphestExcelFormat.php
--- a/src/applications/maniphest/export/ManiphestExcelFormat.php
+++ b/src/applications/maniphest/export/ManiphestExcelFormat.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group maniphest
- */
abstract class ManiphestExcelFormat {
final public static function loadAllFormats() {
diff --git a/src/applications/maniphest/mail/ManiphestReplyHandler.php b/src/applications/maniphest/mail/ManiphestReplyHandler.php
--- a/src/applications/maniphest/mail/ManiphestReplyHandler.php
+++ b/src/applications/maniphest/mail/ManiphestReplyHandler.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group maniphest
- */
final class ManiphestReplyHandler extends PhabricatorMailReplyHandler {
public function validateMailReceiver($mail_receiver) {
@@ -36,7 +33,6 @@
}
protected function receiveEmail(PhabricatorMetaMTAReceivedMail $mail) {
-
// NOTE: We'll drop in here on both the "reply to a task" and "create a
// new task" workflows! Make sure you test both if you make changes!
@@ -134,7 +130,6 @@
->setContent($body));
$xactions[] = $xaction;
}
-
}
$ccs = $mail->loadCCPHIDs();
@@ -184,7 +179,6 @@
));
$event->setUser($user);
PhutilEventEngine::dispatchEvent($event);
-
}
}
diff --git a/src/applications/maniphest/query/ManiphestTaskQuery.php b/src/applications/maniphest/query/ManiphestTaskQuery.php
--- a/src/applications/maniphest/query/ManiphestTaskQuery.php
+++ b/src/applications/maniphest/query/ManiphestTaskQuery.php
@@ -3,11 +3,8 @@
/**
* Query tasks by specific criteria. This class uses the higher-performance
* but less-general Maniphest indexes to satisfy queries.
- *
- * @group maniphest
*/
-final class ManiphestTaskQuery
- extends PhabricatorCursorPagedPolicyAwareQuery {
+final class ManiphestTaskQuery extends PhabricatorCursorPagedPolicyAwareQuery {
private $taskIDs = array();
private $taskPHIDs = array();
@@ -182,7 +179,6 @@
}
public function loadPage() {
-
// TODO: (T603) It is possible for a user to find the PHID of a project
// they can't see, then query for tasks in that project and deduce the
// identity of unknown/invisible projects. Before we allow the user to
@@ -358,7 +354,6 @@
}
private function buildStatusWhereClause(AphrontDatabaseConnection $conn) {
-
static $map = array(
self::STATUS_RESOLVED => ManiphestTaskStatus::STATUS_CLOSED_RESOLVED,
self::STATUS_WONTFIX => ManiphestTaskStatus::STATUS_CLOSED_WONTFIX,
@@ -413,7 +408,6 @@
return null;
}
-
private function buildAuthorWhereClause(AphrontDatabaseConnection $conn) {
if (!$this->authorPHIDs) {
return null;
@@ -941,7 +935,6 @@
return 'task.phid';
}
-
public function getQueryApplicationClass() {
return 'PhabricatorApplicationManiphest';
}
diff --git a/src/applications/maniphest/remarkup/ManiphestRemarkupRule.php b/src/applications/maniphest/remarkup/ManiphestRemarkupRule.php
--- a/src/applications/maniphest/remarkup/ManiphestRemarkupRule.php
+++ b/src/applications/maniphest/remarkup/ManiphestRemarkupRule.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group maniphest
- */
-final class ManiphestRemarkupRule
- extends PhabricatorRemarkupRuleObject {
+final class ManiphestRemarkupRule extends PhabricatorRemarkupRuleObject {
protected function getObjectNamePrefix() {
return 'T';
diff --git a/src/applications/maniphest/search/ManiphestSearchIndexer.php b/src/applications/maniphest/search/ManiphestSearchIndexer.php
--- a/src/applications/maniphest/search/ManiphestSearchIndexer.php
+++ b/src/applications/maniphest/search/ManiphestSearchIndexer.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group maniphest
- */
-final class ManiphestSearchIndexer
- extends PhabricatorSearchDocumentIndexer {
+final class ManiphestSearchIndexer extends PhabricatorSearchDocumentIndexer {
public function getIndexableObject() {
return new ManiphestTask();
@@ -83,4 +79,5 @@
return $doc;
}
+
}
diff --git a/src/applications/maniphest/storage/ManiphestDAO.php b/src/applications/maniphest/storage/ManiphestDAO.php
--- a/src/applications/maniphest/storage/ManiphestDAO.php
+++ b/src/applications/maniphest/storage/ManiphestDAO.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group maniphest
- */
abstract class ManiphestDAO extends PhabricatorLiskDAO {
public function getApplicationName() {
diff --git a/src/applications/maniphest/storage/ManiphestTaskProject.php b/src/applications/maniphest/storage/ManiphestTaskProject.php
--- a/src/applications/maniphest/storage/ManiphestTaskProject.php
+++ b/src/applications/maniphest/storage/ManiphestTaskProject.php
@@ -6,8 +6,6 @@
* efficiently queried. This table is not authoritative; the projectPHIDs field
* of ManiphestTask is. The rows in this table are regenerated when transactions
* are applied to tasks which affected their associated projects.
- *
- * @group maniphest
*/
final class ManiphestTaskProject extends ManiphestDAO {
diff --git a/src/applications/maniphest/storage/ManiphestTaskSubscriber.php b/src/applications/maniphest/storage/ManiphestTaskSubscriber.php
--- a/src/applications/maniphest/storage/ManiphestTaskSubscriber.php
+++ b/src/applications/maniphest/storage/ManiphestTaskSubscriber.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group maniphest
- */
final class ManiphestTaskSubscriber extends ManiphestDAO {
protected $taskPHID;
diff --git a/src/applications/maniphest/view/ManiphestTaskListView.php b/src/applications/maniphest/view/ManiphestTaskListView.php
--- a/src/applications/maniphest/view/ManiphestTaskListView.php
+++ b/src/applications/maniphest/view/ManiphestTaskListView.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group maniphest
- */
final class ManiphestTaskListView extends ManiphestView {
private $tasks;
diff --git a/src/applications/metamta/view/PhabricatorMetaMTAMailBody.php b/src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
--- a/src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
+++ b/src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
@@ -5,7 +5,6 @@
*
* @task compose Composition
* @task render Rendering
- * @group metamta
*/
final class PhabricatorMetaMTAMailBody {
diff --git a/src/applications/metamta/view/__tests__/PhabricatorMetaMTAMailBodyTestCase.php b/src/applications/metamta/view/__tests__/PhabricatorMetaMTAMailBodyTestCase.php
--- a/src/applications/metamta/view/__tests__/PhabricatorMetaMTAMailBodyTestCase.php
+++ b/src/applications/metamta/view/__tests__/PhabricatorMetaMTAMailBodyTestCase.php
@@ -1,11 +1,7 @@
<?php
-/**
- * @group metamta
- */
final class PhabricatorMetaMTAMailBodyTestCase extends PhabricatorTestCase {
-
public function testBodyRender() {
$expect = <<<EOTEXT
salmon
@@ -25,7 +21,6 @@
$this->assertEmail($expect, true, true);
}
-
public function testBodyRenderNoHerald() {
$expect = <<<EOTEXT
salmon
@@ -74,5 +69,4 @@
$this->assertEqual($expect, $body->render());
}
-
}
diff --git a/src/applications/nuance/conduit/ConduitAPI_nuance_Method.php b/src/applications/nuance/conduit/ConduitAPI_nuance_Method.php
--- a/src/applications/nuance/conduit/ConduitAPI_nuance_Method.php
+++ b/src/applications/nuance/conduit/ConduitAPI_nuance_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_nuance_Method extends ConduitAPIMethod {
public function getApplication() {
diff --git a/src/applications/nuance/conduit/ConduitAPI_nuance_createitem_Method.php b/src/applications/nuance/conduit/ConduitAPI_nuance_createitem_Method.php
--- a/src/applications/nuance/conduit/ConduitAPI_nuance_createitem_Method.php
+++ b/src/applications/nuance/conduit/ConduitAPI_nuance_createitem_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_nuance_createitem_Method
extends ConduitAPI_nuance_Method {
diff --git a/src/applications/oauthserver/PhabricatorOAuthResponse.php b/src/applications/oauthserver/PhabricatorOAuthResponse.php
--- a/src/applications/oauthserver/PhabricatorOAuthResponse.php
+++ b/src/applications/oauthserver/PhabricatorOAuthResponse.php
@@ -1,8 +1,5 @@
<?php
-/*
-* @group oauthserver
-*/
final class PhabricatorOAuthResponse extends AphrontResponse {
private $state;
@@ -47,6 +44,7 @@
private function getError() {
return $this->error;
}
+
public function setError($error) {
// errors sometimes redirect to the client (302) but otherwise
// the spec says all code 400
@@ -60,6 +58,7 @@
private function getErrorDescription() {
return $this->errorDescription;
}
+
public function setErrorDescription($error_description) {
$this->errorDescription = $error_description;
return $this;
@@ -104,4 +103,5 @@
public function buildResponseString() {
return $this->encodeJSONForHTTPResponse($this->buildResponseDict());
}
+
}
diff --git a/src/applications/oauthserver/PhabricatorOAuthServer.php b/src/applications/oauthserver/PhabricatorOAuthServer.php
--- a/src/applications/oauthserver/PhabricatorOAuthServer.php
+++ b/src/applications/oauthserver/PhabricatorOAuthServer.php
@@ -12,12 +12,12 @@
* For an OAuth 2.0 server, there are two main steps:
*
* 1) Authorization - the user authorizes a given client to access the data
- * the OAuth 2.0 server protects. Once this is achieved / if it has
+ * the OAuth 2.0 server protects. Once this is achieved / if it has
* been achived already, the OAuth server sends the client an authorization
* code.
* 2) Access Token - the client should send the authorization code received in
* step 1 along with its id and secret to the OAuth server to receive an
- * access token. This access token can later be used to access Phabricator
+ * access token. This access token can later be used to access Phabricator
* data on behalf of the user.
*
* @task auth Authorizing @{class:PhabricatorOAuthServerClient}s and
@@ -25,8 +25,6 @@
* @task token Validating @{class:PhabricatorOAuthServerAuthorizationCode}s
* and generating @{class:PhabricatorOAuthServerAccessToken}s
* @task internal Internals
- *
- * @group oauthserver
*/
final class PhabricatorOAuthServer {
@@ -36,9 +34,6 @@
private $user;
private $client;
- /**
- * @group internal
- */
private function getUser() {
if (!$this->user) {
throw new Exception('You must setUser before you can getUser!');
@@ -51,9 +46,6 @@
return $this;
}
- /**
- * @group internal
- */
private function getClient() {
if (!$this->client) {
throw new Exception('You must setClient before you can getClient!');
diff --git a/src/applications/oauthserver/PhabricatorOAuthServerScope.php b/src/applications/oauthserver/PhabricatorOAuthServerScope.php
--- a/src/applications/oauthserver/PhabricatorOAuthServerScope.php
+++ b/src/applications/oauthserver/PhabricatorOAuthServerScope.php
@@ -63,7 +63,7 @@
/**
* A scopes list is considered valid if each scope is a known scope
- * and each scope is seen only once. Otherwise, the list is invalid.
+ * and each scope is seen only once. Otherwise, the list is invalid.
*/
static public function validateScopesList($scope_list) {
$scopes = explode(' ', $scope_list);
diff --git a/src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php b/src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php
--- a/src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php
+++ b/src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php
@@ -1,10 +1,7 @@
<?php
-/**
- * @group oauthserver
- */
final class PhabricatorOAuthServerAuthController
-extends PhabricatorAuthController {
+ extends PhabricatorAuthController {
public function shouldRequireLogin() {
return true;
diff --git a/src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php b/src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php
--- a/src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php
+++ b/src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php
@@ -1,10 +1,7 @@
<?php
-/**
- * @group oauthserver
- */
final class PhabricatorOAuthServerTokenController
-extends PhabricatorAuthController {
+ extends PhabricatorAuthController {
public function shouldRequireLogin() {
return false;
@@ -137,4 +134,5 @@
return $response;
}
}
+
}
diff --git a/src/applications/oauthserver/storage/PhabricatorOAuthServerAccessToken.php b/src/applications/oauthserver/storage/PhabricatorOAuthServerAccessToken.php
--- a/src/applications/oauthserver/storage/PhabricatorOAuthServerAccessToken.php
+++ b/src/applications/oauthserver/storage/PhabricatorOAuthServerAccessToken.php
@@ -1,10 +1,8 @@
<?php
-/**
- * @group oauthserver
- */
final class PhabricatorOAuthServerAccessToken
-extends PhabricatorOAuthServerDAO {
+ extends PhabricatorOAuthServerDAO {
+
protected $id;
protected $token;
protected $userPHID;
diff --git a/src/applications/oauthserver/storage/PhabricatorOAuthServerAuthorizationCode.php b/src/applications/oauthserver/storage/PhabricatorOAuthServerAuthorizationCode.php
--- a/src/applications/oauthserver/storage/PhabricatorOAuthServerAuthorizationCode.php
+++ b/src/applications/oauthserver/storage/PhabricatorOAuthServerAuthorizationCode.php
@@ -1,10 +1,7 @@
<?php
-/**
- * @group oauthserver
- */
final class PhabricatorOAuthServerAuthorizationCode
-extends PhabricatorOAuthServerDAO {
+ extends PhabricatorOAuthServerDAO {
protected $id;
protected $code;
diff --git a/src/applications/oauthserver/storage/PhabricatorOAuthServerDAO.php b/src/applications/oauthserver/storage/PhabricatorOAuthServerDAO.php
--- a/src/applications/oauthserver/storage/PhabricatorOAuthServerDAO.php
+++ b/src/applications/oauthserver/storage/PhabricatorOAuthServerDAO.php
@@ -1,10 +1,9 @@
<?php
-/**
- * @group oauthserver
- */
abstract class PhabricatorOAuthServerDAO extends PhabricatorLiskDAO {
+
public function getApplicationName() {
return 'oauth_server';
}
+
}
diff --git a/src/applications/owners/conduit/ConduitAPI_owners_query_Method.php b/src/applications/owners/conduit/ConduitAPI_owners_query_Method.php
--- a/src/applications/owners/conduit/ConduitAPI_owners_query_Method.php
+++ b/src/applications/owners/conduit/ConduitAPI_owners_query_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_owners_query_Method
- extends ConduitAPI_owners_Method {
+final class ConduitAPI_owners_query_Method extends ConduitAPI_owners_Method {
public function getMethodDescription() {
return 'Query for packages by one of the following: repository/path, '.
@@ -21,7 +17,6 @@
'repositoryCallsign' => 'optional string',
'path' => 'optional string',
);
-
}
public function defineReturnType() {
@@ -120,8 +115,7 @@
$request->getValue('projectOwner')) ?
1 : 0;
- $is_affiliated_query = $request->getValue('userAffiliated') ?
- 1 : 0;
+ $is_affiliated_query = $request->getValue('userAffiliated') ? 1 : 0;
$repo = $request->getValue('repositoryCallsign');
$path = $request->getValue('path');
@@ -155,4 +149,5 @@
return self::buildPackageInformationDictionaries($packages);
}
+
}
diff --git a/src/applications/paste/conduit/ConduitAPI_paste_Method.php b/src/applications/paste/conduit/ConduitAPI_paste_Method.php
--- a/src/applications/paste/conduit/ConduitAPI_paste_Method.php
+++ b/src/applications/paste/conduit/ConduitAPI_paste_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_paste_Method extends ConduitAPIMethod {
public function getApplication() {
diff --git a/src/applications/paste/conduit/ConduitAPI_paste_create_Method.php b/src/applications/paste/conduit/ConduitAPI_paste_create_Method.php
--- a/src/applications/paste/conduit/ConduitAPI_paste_create_Method.php
+++ b/src/applications/paste/conduit/ConduitAPI_paste_create_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_paste_create_Method extends ConduitAPI_paste_Method {
public function getMethodDescription() {
diff --git a/src/applications/paste/conduit/ConduitAPI_paste_info_Method.php b/src/applications/paste/conduit/ConduitAPI_paste_info_Method.php
--- a/src/applications/paste/conduit/ConduitAPI_paste_info_Method.php
+++ b/src/applications/paste/conduit/ConduitAPI_paste_info_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_paste_info_Method extends ConduitAPI_paste_Method {
public function getMethodStatus() {
diff --git a/src/applications/paste/conduit/ConduitAPI_paste_query_Method.php b/src/applications/paste/conduit/ConduitAPI_paste_query_Method.php
--- a/src/applications/paste/conduit/ConduitAPI_paste_query_Method.php
+++ b/src/applications/paste/conduit/ConduitAPI_paste_query_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_paste_query_Method extends ConduitAPI_paste_Method {
public function getMethodDescription() {
diff --git a/src/applications/paste/config/PhabricatorPasteConfigOptions.php b/src/applications/paste/config/PhabricatorPasteConfigOptions.php
--- a/src/applications/paste/config/PhabricatorPasteConfigOptions.php
+++ b/src/applications/paste/config/PhabricatorPasteConfigOptions.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group paste
- */
final class PhabricatorPasteConfigOptions
extends PhabricatorApplicationConfigOptions {
diff --git a/src/applications/paste/controller/PhabricatorPasteCommentController.php b/src/applications/paste/controller/PhabricatorPasteCommentController.php
--- a/src/applications/paste/controller/PhabricatorPasteCommentController.php
+++ b/src/applications/paste/controller/PhabricatorPasteCommentController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group paste
- */
final class PhabricatorPasteCommentController
extends PhabricatorPasteController {
diff --git a/src/applications/paste/controller/PhabricatorPasteController.php b/src/applications/paste/controller/PhabricatorPasteController.php
--- a/src/applications/paste/controller/PhabricatorPasteController.php
+++ b/src/applications/paste/controller/PhabricatorPasteController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group paste
- */
abstract class PhabricatorPasteController extends PhabricatorController {
public function buildSideNavView($for_app = false) {
diff --git a/src/applications/paste/controller/PhabricatorPasteEditController.php b/src/applications/paste/controller/PhabricatorPasteEditController.php
--- a/src/applications/paste/controller/PhabricatorPasteEditController.php
+++ b/src/applications/paste/controller/PhabricatorPasteEditController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group paste
- */
final class PhabricatorPasteEditController extends PhabricatorPasteController {
private $id;
@@ -11,7 +8,6 @@
$this->id = idx($data, 'id');
}
-
public function processRequest() {
$request = $this->getRequest();
$user = $request->getUser();
diff --git a/src/applications/paste/mail/PasteCreateMailReceiver.php b/src/applications/paste/mail/PasteCreateMailReceiver.php
--- a/src/applications/paste/mail/PasteCreateMailReceiver.php
+++ b/src/applications/paste/mail/PasteCreateMailReceiver.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group paste
- */
-final class PasteCreateMailReceiver
- extends PhabricatorMailReceiver {
+final class PasteCreateMailReceiver extends PhabricatorMailReceiver {
public function isEnabled() {
$app_class = 'PhabricatorApplicationPaste';
@@ -87,7 +83,6 @@
->setRelatedPHID($paste->getPHID())
->setBody($body->render())
->saveAndSend();
-
}
}
diff --git a/src/applications/paste/mail/PasteMockMailReceiver.php b/src/applications/paste/mail/PasteMockMailReceiver.php
--- a/src/applications/paste/mail/PasteMockMailReceiver.php
+++ b/src/applications/paste/mail/PasteMockMailReceiver.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group paste
- */
final class PasteMockMailReceiver extends PhabricatorObjectMailReceiver {
public function isEnabled() {
diff --git a/src/applications/paste/mail/PasteReplyHandler.php b/src/applications/paste/mail/PasteReplyHandler.php
--- a/src/applications/paste/mail/PasteReplyHandler.php
+++ b/src/applications/paste/mail/PasteReplyHandler.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group paste
- */
final class PasteReplyHandler extends PhabricatorMailReplyHandler {
public function validateMailReceiver($mail_receiver) {
@@ -78,7 +75,6 @@
$head_xaction = head($xactions);
return $head_xaction->getID();
-
}
}
diff --git a/src/applications/paste/query/PhabricatorPasteQuery.php b/src/applications/paste/query/PhabricatorPasteQuery.php
--- a/src/applications/paste/query/PhabricatorPasteQuery.php
+++ b/src/applications/paste/query/PhabricatorPasteQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group paste
- */
final class PhabricatorPasteQuery
extends PhabricatorCursorPagedPolicyAwareQuery {
@@ -239,7 +236,6 @@
return $results;
}
-
private function buildContent(PhabricatorPaste $paste) {
$language = $paste->getLanguage();
$source = $paste->getRawContent();
@@ -255,7 +251,6 @@
}
}
-
public function getQueryApplicationClass() {
return 'PhabricatorApplicationPaste';
}
diff --git a/src/applications/paste/query/PhabricatorPasteTransactionQuery.php b/src/applications/paste/query/PhabricatorPasteTransactionQuery.php
--- a/src/applications/paste/query/PhabricatorPasteTransactionQuery.php
+++ b/src/applications/paste/query/PhabricatorPasteTransactionQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group paste
- */
final class PhabricatorPasteTransactionQuery
extends PhabricatorApplicationTransactionQuery {
diff --git a/src/applications/paste/remarkup/PhabricatorPasteRemarkupRule.php b/src/applications/paste/remarkup/PhabricatorPasteRemarkupRule.php
--- a/src/applications/paste/remarkup/PhabricatorPasteRemarkupRule.php
+++ b/src/applications/paste/remarkup/PhabricatorPasteRemarkupRule.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group markup
- */
-final class PhabricatorPasteRemarkupRule
- extends PhabricatorRemarkupRuleObject {
+final class PhabricatorPasteRemarkupRule extends PhabricatorRemarkupRuleObject {
protected function getObjectNamePrefix() {
return 'P';
@@ -56,4 +52,5 @@
return $embed_paste;
}
+
}
diff --git a/src/applications/paste/storage/PhabricatorPasteTransactionComment.php b/src/applications/paste/storage/PhabricatorPasteTransactionComment.php
--- a/src/applications/paste/storage/PhabricatorPasteTransactionComment.php
+++ b/src/applications/paste/storage/PhabricatorPasteTransactionComment.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group paste
- */
final class PhabricatorPasteTransactionComment
extends PhabricatorApplicationTransactionComment {
@@ -17,4 +14,5 @@
// Only cache submitted comments.
return ($this->getTransactionPHID() != null);
}
+
}
diff --git a/src/applications/people/conduit/ConduitAPI_user_disable_Method.php b/src/applications/people/conduit/ConduitAPI_user_disable_Method.php
--- a/src/applications/people/conduit/ConduitAPI_user_disable_Method.php
+++ b/src/applications/people/conduit/ConduitAPI_user_disable_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_user_disable_Method
- extends ConduitAPI_user_Method {
+final class ConduitAPI_user_disable_Method extends ConduitAPI_user_Method {
public function getMethodDescription() {
return 'Permanently disable specified users (admin only).';
diff --git a/src/applications/people/conduit/ConduitAPI_user_enable_Method.php b/src/applications/people/conduit/ConduitAPI_user_enable_Method.php
--- a/src/applications/people/conduit/ConduitAPI_user_enable_Method.php
+++ b/src/applications/people/conduit/ConduitAPI_user_enable_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_user_enable_Method
- extends ConduitAPI_user_Method {
+final class ConduitAPI_user_enable_Method extends ConduitAPI_user_Method {
public function getMethodDescription() {
return 'Re-enable specified users (admin only).';
diff --git a/src/applications/people/conduit/ConduitAPI_user_info_Method.php b/src/applications/people/conduit/ConduitAPI_user_info_Method.php
--- a/src/applications/people/conduit/ConduitAPI_user_info_Method.php
+++ b/src/applications/people/conduit/ConduitAPI_user_info_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_user_info_Method
- extends ConduitAPI_user_Method {
+final class ConduitAPI_user_info_Method extends ConduitAPI_user_Method {
public function getMethodStatus() {
return self::METHOD_STATUS_DEPRECATED;
@@ -35,7 +31,6 @@
}
protected function execute(ConduitAPIRequest $request) {
-
$user = id(new PhabricatorUser())->loadOneWhere(
'phid = %s',
$request->getValue('phid'));
diff --git a/src/applications/people/conduit/ConduitAPI_user_query_Method.php b/src/applications/people/conduit/ConduitAPI_user_query_Method.php
--- a/src/applications/people/conduit/ConduitAPI_user_query_Method.php
+++ b/src/applications/people/conduit/ConduitAPI_user_query_Method.php
@@ -1,17 +1,12 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_user_query_Method
- extends ConduitAPI_user_Method {
+final class ConduitAPI_user_query_Method extends ConduitAPI_user_Method {
public function getMethodDescription() {
return 'Query users.';
}
public function defineParamTypes() {
-
return array(
'usernames' => 'optional list<string>',
'emails' => 'optional list<string>',
@@ -80,4 +75,5 @@
}
return $results;
}
+
}
diff --git a/src/applications/people/conduit/ConduitAPI_user_whoami_Method.php b/src/applications/people/conduit/ConduitAPI_user_whoami_Method.php
--- a/src/applications/people/conduit/ConduitAPI_user_whoami_Method.php
+++ b/src/applications/people/conduit/ConduitAPI_user_whoami_Method.php
@@ -1,18 +1,13 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_user_whoami_Method
- extends ConduitAPI_user_Method {
+final class ConduitAPI_user_whoami_Method extends ConduitAPI_user_Method {
public function getMethodDescription() {
return 'Retrieve information about the logged-in user.';
}
public function defineParamTypes() {
- return array(
- );
+ return array();
}
public function defineReturnType() {
@@ -20,8 +15,7 @@
}
public function defineErrorTypes() {
- return array(
- );
+ return array();
}
public function getRequiredScope() {
diff --git a/src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php b/src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php
--- a/src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php
+++ b/src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group markup
- */
-final class PhabricatorRemarkupRuleMention
- extends PhutilRemarkupRule {
+final class PhabricatorRemarkupRuleMention extends PhutilRemarkupRule {
const KEY_RULE_MENTION = 'rule.mention';
const KEY_RULE_MENTION_ORIGINAL = 'rule.mention.original';
diff --git a/src/applications/phame/conduit/ConduitAPI_phame_Method.php b/src/applications/phame/conduit/ConduitAPI_phame_Method.php
--- a/src/applications/phame/conduit/ConduitAPI_phame_Method.php
+++ b/src/applications/phame/conduit/ConduitAPI_phame_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_phame_Method extends ConduitAPIMethod {
public function getApplication() {
diff --git a/src/applications/phame/conduit/ConduitAPI_phame_query_Method.php b/src/applications/phame/conduit/ConduitAPI_phame_query_Method.php
--- a/src/applications/phame/conduit/ConduitAPI_phame_query_Method.php
+++ b/src/applications/phame/conduit/ConduitAPI_phame_query_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_phame_query_Method extends ConduitAPI_phame_Method {
public function getMethodDescription() {
@@ -28,12 +25,10 @@
}
public function defineErrorTypes() {
- return array(
- );
+ return array();
}
protected function execute(ConduitAPIRequest $request) {
-
$query = new PhameBlogQuery();
$query->setViewer($request->getUser());
@@ -80,5 +75,4 @@
return $results;
}
-
}
diff --git a/src/applications/phame/conduit/ConduitAPI_phame_queryposts_Method.php b/src/applications/phame/conduit/ConduitAPI_phame_queryposts_Method.php
--- a/src/applications/phame/conduit/ConduitAPI_phame_queryposts_Method.php
+++ b/src/applications/phame/conduit/ConduitAPI_phame_queryposts_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_phame_queryposts_Method extends ConduitAPI_phame_Method {
public function getMethodDescription() {
@@ -38,7 +35,6 @@
}
protected function execute(ConduitAPIRequest $request) {
-
$query = new PhamePostQuery();
$query->setViewer($request->getUser());
@@ -105,5 +101,4 @@
return $results;
}
-
}
diff --git a/src/applications/phame/controller/PhameResourceController.php b/src/applications/phame/controller/PhameResourceController.php
--- a/src/applications/phame/controller/PhameResourceController.php
+++ b/src/applications/phame/controller/PhameResourceController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhameResourceController extends CelerityResourceController {
private $id;
diff --git a/src/applications/phame/controller/blog/PhameBlogDeleteController.php b/src/applications/phame/controller/blog/PhameBlogDeleteController.php
--- a/src/applications/phame/controller/blog/PhameBlogDeleteController.php
+++ b/src/applications/phame/controller/blog/PhameBlogDeleteController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhameBlogDeleteController extends PhameController {
private $id;
@@ -47,4 +44,5 @@
return id(new AphrontDialogResponse())->setDialog($dialog);
}
+
}
diff --git a/src/applications/phame/controller/blog/PhameBlogFeedController.php b/src/applications/phame/controller/blog/PhameBlogFeedController.php
--- a/src/applications/phame/controller/blog/PhameBlogFeedController.php
+++ b/src/applications/phame/controller/blog/PhameBlogFeedController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhameBlogFeedController extends PhameController {
private $id;
diff --git a/src/applications/phame/controller/blog/PhameBlogListController.php b/src/applications/phame/controller/blog/PhameBlogListController.php
--- a/src/applications/phame/controller/blog/PhameBlogListController.php
+++ b/src/applications/phame/controller/blog/PhameBlogListController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhameBlogListController extends PhameController {
private $filter;
diff --git a/src/applications/phame/controller/blog/PhameBlogLiveController.php b/src/applications/phame/controller/blog/PhameBlogLiveController.php
--- a/src/applications/phame/controller/blog/PhameBlogLiveController.php
+++ b/src/applications/phame/controller/blog/PhameBlogLiveController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhameBlogLiveController extends PhameController {
private $id;
diff --git a/src/applications/phame/controller/blog/PhameBlogViewController.php b/src/applications/phame/controller/blog/PhameBlogViewController.php
--- a/src/applications/phame/controller/blog/PhameBlogViewController.php
+++ b/src/applications/phame/controller/blog/PhameBlogViewController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhameBlogViewController extends PhameController {
private $id;
@@ -141,7 +138,6 @@
}
private function renderActions(PhameBlog $blog, PhabricatorUser $user) {
-
$actions = id(new PhabricatorActionListView())
->setObject($blog)
->setObjectURI($this->getRequest()->getRequestURI())
diff --git a/src/applications/phame/controller/post/PhamePostDeleteController.php b/src/applications/phame/controller/post/PhamePostDeleteController.php
--- a/src/applications/phame/controller/post/PhamePostDeleteController.php
+++ b/src/applications/phame/controller/post/PhamePostDeleteController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhamePostDeleteController extends PhameController {
private $id;
@@ -47,4 +44,5 @@
return id(new AphrontDialogResponse())->setDialog($dialog);
}
+
}
diff --git a/src/applications/phame/controller/post/PhamePostEditController.php b/src/applications/phame/controller/post/PhamePostEditController.php
--- a/src/applications/phame/controller/post/PhamePostEditController.php
+++ b/src/applications/phame/controller/post/PhamePostEditController.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group phame
- */
-final class PhamePostEditController
- extends PhameController {
+final class PhamePostEditController extends PhameController {
private $id;
diff --git a/src/applications/phame/controller/post/PhamePostFramedController.php b/src/applications/phame/controller/post/PhamePostFramedController.php
--- a/src/applications/phame/controller/post/PhamePostFramedController.php
+++ b/src/applications/phame/controller/post/PhamePostFramedController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhamePostFramedController extends PhameController {
private $id;
@@ -44,4 +41,5 @@
$response->setFrameable(true);
return $response;
}
+
}
diff --git a/src/applications/phame/controller/post/PhamePostListController.php b/src/applications/phame/controller/post/PhamePostListController.php
--- a/src/applications/phame/controller/post/PhamePostListController.php
+++ b/src/applications/phame/controller/post/PhamePostListController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhamePostListController extends PhameController {
private $bloggername;
@@ -93,5 +90,4 @@
));
}
-
}
diff --git a/src/applications/phame/controller/post/PhamePostNewController.php b/src/applications/phame/controller/post/PhamePostNewController.php
--- a/src/applications/phame/controller/post/PhamePostNewController.php
+++ b/src/applications/phame/controller/post/PhamePostNewController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhamePostNewController extends PhameController {
private $id;
@@ -127,4 +124,5 @@
'title' => $title,
));
}
+
}
diff --git a/src/applications/phame/controller/post/PhamePostNotLiveController.php b/src/applications/phame/controller/post/PhamePostNotLiveController.php
--- a/src/applications/phame/controller/post/PhamePostNotLiveController.php
+++ b/src/applications/phame/controller/post/PhamePostNotLiveController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhamePostNotLiveController extends PhameController {
private $id;
@@ -57,4 +54,5 @@
$live_uri = $post->getViewURI();
return id(new AphrontRedirectResponse())->setURI($live_uri);
}
+
}
diff --git a/src/applications/phame/controller/post/PhamePostPreviewController.php b/src/applications/phame/controller/post/PhamePostPreviewController.php
--- a/src/applications/phame/controller/post/PhamePostPreviewController.php
+++ b/src/applications/phame/controller/post/PhamePostPreviewController.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group phame
- */
-final class PhamePostPreviewController
-extends PhameController {
+final class PhamePostPreviewController extends PhameController {
protected function getSideNavFilter() {
return null;
@@ -27,4 +23,5 @@
return id(new AphrontAjaxResponse())->setContent($content);
}
+
}
diff --git a/src/applications/phame/controller/post/PhamePostPublishController.php b/src/applications/phame/controller/post/PhamePostPublishController.php
--- a/src/applications/phame/controller/post/PhamePostPublishController.php
+++ b/src/applications/phame/controller/post/PhamePostPublishController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhamePostPublishController extends PhameController {
private $id;
@@ -86,4 +83,5 @@
),
''));
}
+
}
diff --git a/src/applications/phame/controller/post/PhamePostUnpublishController.php b/src/applications/phame/controller/post/PhamePostUnpublishController.php
--- a/src/applications/phame/controller/post/PhamePostUnpublishController.php
+++ b/src/applications/phame/controller/post/PhamePostUnpublishController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhamePostUnpublishController extends PhameController {
private $id;
@@ -51,4 +48,5 @@
return id(new AphrontDialogResponse())->setDialog($dialog);
}
+
}
diff --git a/src/applications/phame/controller/post/PhamePostViewController.php b/src/applications/phame/controller/post/PhamePostViewController.php
--- a/src/applications/phame/controller/post/PhamePostViewController.php
+++ b/src/applications/phame/controller/post/PhamePostViewController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhamePostViewController extends PhameController {
private $id;
@@ -203,4 +200,5 @@
return $properties;
}
+
}
diff --git a/src/applications/phame/phid/PhabricatorPhamePHIDTypeBlog.php b/src/applications/phame/phid/PhabricatorPhamePHIDTypeBlog.php
--- a/src/applications/phame/phid/PhabricatorPhamePHIDTypeBlog.php
+++ b/src/applications/phame/phid/PhabricatorPhamePHIDTypeBlog.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhabricatorPhamePHIDTypeBlog extends PhabricatorPHIDType {
const TYPECONST = 'BLOG';
diff --git a/src/applications/phame/phid/PhabricatorPhamePHIDTypePost.php b/src/applications/phame/phid/PhabricatorPhamePHIDTypePost.php
--- a/src/applications/phame/phid/PhabricatorPhamePHIDTypePost.php
+++ b/src/applications/phame/phid/PhabricatorPhamePHIDTypePost.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhabricatorPhamePHIDTypePost extends PhabricatorPHIDType {
const TYPECONST = 'POST';
diff --git a/src/applications/phame/query/PhameBlogQuery.php b/src/applications/phame/query/PhameBlogQuery.php
--- a/src/applications/phame/query/PhameBlogQuery.php
+++ b/src/applications/phame/query/PhameBlogQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhameBlogQuery extends PhabricatorCursorPagedPolicyAwareQuery {
private $ids;
diff --git a/src/applications/phame/query/PhamePostQuery.php b/src/applications/phame/query/PhamePostQuery.php
--- a/src/applications/phame/query/PhamePostQuery.php
+++ b/src/applications/phame/query/PhamePostQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhamePostQuery extends PhabricatorCursorPagedPolicyAwareQuery {
private $ids;
diff --git a/src/applications/phame/skins/PhameBasicBlogSkin.php b/src/applications/phame/skins/PhameBasicBlogSkin.php
--- a/src/applications/phame/skins/PhameBasicBlogSkin.php
+++ b/src/applications/phame/skins/PhameBasicBlogSkin.php
@@ -3,7 +3,6 @@
/**
* @task paging Paging
* @task internal Internals
- * @group phame
*/
abstract class PhameBasicBlogSkin extends PhameBlogSkin {
diff --git a/src/applications/phame/skins/PhameBasicTemplateBlogSkin.php b/src/applications/phame/skins/PhameBasicTemplateBlogSkin.php
--- a/src/applications/phame/skins/PhameBasicTemplateBlogSkin.php
+++ b/src/applications/phame/skins/PhameBasicTemplateBlogSkin.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhameBasicTemplateBlogSkin extends PhameBasicBlogSkin {
private $cssResources;
diff --git a/src/applications/phame/skins/PhameBlogSkin.php b/src/applications/phame/skins/PhameBlogSkin.php
--- a/src/applications/phame/skins/PhameBlogSkin.php
+++ b/src/applications/phame/skins/PhameBlogSkin.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
abstract class PhameBlogSkin extends PhabricatorController {
private $blog;
diff --git a/src/applications/phame/skins/PhameSkinSpecification.php b/src/applications/phame/skins/PhameSkinSpecification.php
--- a/src/applications/phame/skins/PhameSkinSpecification.php
+++ b/src/applications/phame/skins/PhameSkinSpecification.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhameSkinSpecification {
const TYPE_ADVANCED = 'advanced';
@@ -16,7 +13,6 @@
private $config;
public static function loadAllSkinSpecifications() {
-
static $specs;
if ($specs === null) {
diff --git a/src/applications/phame/storage/PhameDAO.php b/src/applications/phame/storage/PhameDAO.php
--- a/src/applications/phame/storage/PhameDAO.php
+++ b/src/applications/phame/storage/PhameDAO.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
abstract class PhameDAO extends PhabricatorLiskDAO {
public function getApplicationName() {
diff --git a/src/applications/phame/view/PhamePostView.php b/src/applications/phame/view/PhamePostView.php
--- a/src/applications/phame/view/PhamePostView.php
+++ b/src/applications/phame/view/PhamePostView.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phame
- */
final class PhamePostView extends AphrontView {
private $post;
diff --git a/src/applications/phid/conduit/ConduitAPI_phid_Method.php b/src/applications/phid/conduit/ConduitAPI_phid_Method.php
--- a/src/applications/phid/conduit/ConduitAPI_phid_Method.php
+++ b/src/applications/phid/conduit/ConduitAPI_phid_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_phid_Method extends ConduitAPIMethod {
protected function buildHandleInformationDictionary(
diff --git a/src/applications/phid/conduit/ConduitAPI_phid_info_Method.php b/src/applications/phid/conduit/ConduitAPI_phid_info_Method.php
--- a/src/applications/phid/conduit/ConduitAPI_phid_info_Method.php
+++ b/src/applications/phid/conduit/ConduitAPI_phid_info_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_phid_info_Method
- extends ConduitAPI_phid_Method {
+final class ConduitAPI_phid_info_Method extends ConduitAPI_phid_Method {
public function getMethodStatus() {
return self::METHOD_STATUS_DEPRECATED;
@@ -35,7 +31,6 @@
}
protected function execute(ConduitAPIRequest $request) {
-
$phid = $request->getValue('phid');
$handle = id(new PhabricatorHandleQuery())
diff --git a/src/applications/phid/conduit/ConduitAPI_phid_lookup_Method.php b/src/applications/phid/conduit/ConduitAPI_phid_lookup_Method.php
--- a/src/applications/phid/conduit/ConduitAPI_phid_lookup_Method.php
+++ b/src/applications/phid/conduit/ConduitAPI_phid_lookup_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_phid_lookup_Method
- extends ConduitAPI_phid_Method {
+final class ConduitAPI_phid_lookup_Method extends ConduitAPI_phid_Method {
public function getMethodDescription() {
return 'Look up objects by name.';
diff --git a/src/applications/phid/conduit/ConduitAPI_phid_query_Method.php b/src/applications/phid/conduit/ConduitAPI_phid_query_Method.php
--- a/src/applications/phid/conduit/ConduitAPI_phid_query_Method.php
+++ b/src/applications/phid/conduit/ConduitAPI_phid_query_Method.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group conduit
- */
-final class ConduitAPI_phid_query_Method
- extends ConduitAPI_phid_Method {
+final class ConduitAPI_phid_query_Method extends ConduitAPI_phid_Method {
public function getMethodDescription() {
return 'Retrieve information about arbitrary PHIDs.';
@@ -25,7 +21,6 @@
}
protected function execute(ConduitAPIRequest $request) {
-
$phids = $request->getValue('phids');
$handles = id(new PhabricatorHandleQuery())
diff --git a/src/applications/phid/handle/view/render.php b/src/applications/phid/handle/view/render.php
--- a/src/applications/phid/handle/view/render.php
+++ b/src/applications/phid/handle/view/render.php
@@ -4,7 +4,6 @@
* Implodes selected handles from a pool of handles. Useful if you load handles
* for various phids, but only render a few of them at a time.
*
- * @group handle
* @return PhutilSafeHTML
*/
function implode_selected_handle_links($glue, array $handles, array $phids) {
diff --git a/src/applications/pholio/config/PhabricatorPholioConfigOptions.php b/src/applications/pholio/config/PhabricatorPholioConfigOptions.php
--- a/src/applications/pholio/config/PhabricatorPholioConfigOptions.php
+++ b/src/applications/pholio/config/PhabricatorPholioConfigOptions.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PhabricatorPholioConfigOptions
extends PhabricatorApplicationConfigOptions {
diff --git a/src/applications/pholio/constants/PholioConstants.php b/src/applications/pholio/constants/PholioConstants.php
--- a/src/applications/pholio/constants/PholioConstants.php
+++ b/src/applications/pholio/constants/PholioConstants.php
@@ -1,8 +1,3 @@
<?php
-/**
- * @group pholio
- */
-abstract class PholioConstants {
-
-}
+abstract class PholioConstants {}
diff --git a/src/applications/pholio/constants/PholioTransactionType.php b/src/applications/pholio/constants/PholioTransactionType.php
--- a/src/applications/pholio/constants/PholioTransactionType.php
+++ b/src/applications/pholio/constants/PholioTransactionType.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioTransactionType extends PholioConstants {
/* edits to the high level mock */
@@ -19,4 +16,5 @@
/* your witty commentary at the mock : image : x,y level */
const TYPE_INLINE = 'inline';
+
}
diff --git a/src/applications/pholio/controller/PholioController.php b/src/applications/pholio/controller/PholioController.php
--- a/src/applications/pholio/controller/PholioController.php
+++ b/src/applications/pholio/controller/PholioController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
abstract class PholioController extends PhabricatorController {
public function buildSideNavView($for_app = false) {
@@ -40,6 +37,4 @@
return $this->buildSideNavView(true)->getMenu();
}
-
-
}
diff --git a/src/applications/pholio/controller/PholioImageUploadController.php b/src/applications/pholio/controller/PholioImageUploadController.php
--- a/src/applications/pholio/controller/PholioImageUploadController.php
+++ b/src/applications/pholio/controller/PholioImageUploadController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioImageUploadController extends PholioController {
public function processRequest() {
diff --git a/src/applications/pholio/controller/PholioInlineThumbController.php b/src/applications/pholio/controller/PholioInlineThumbController.php
--- a/src/applications/pholio/controller/PholioInlineThumbController.php
+++ b/src/applications/pholio/controller/PholioInlineThumbController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioInlineThumbController extends PholioController {
private $imageid;
diff --git a/src/applications/pholio/controller/PholioMockCommentController.php b/src/applications/pholio/controller/PholioMockCommentController.php
--- a/src/applications/pholio/controller/PholioMockCommentController.php
+++ b/src/applications/pholio/controller/PholioMockCommentController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioMockCommentController extends PholioController {
private $id;
diff --git a/src/applications/pholio/controller/PholioMockEditController.php b/src/applications/pholio/controller/PholioMockEditController.php
--- a/src/applications/pholio/controller/PholioMockEditController.php
+++ b/src/applications/pholio/controller/PholioMockEditController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioMockEditController extends PholioController {
private $id;
diff --git a/src/applications/pholio/editor/PholioMockEditor.php b/src/applications/pholio/editor/PholioMockEditor.php
--- a/src/applications/pholio/editor/PholioMockEditor.php
+++ b/src/applications/pholio/editor/PholioMockEditor.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioMockEditor extends PhabricatorApplicationTransactionEditor {
private $newImages = array();
diff --git a/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php b/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php
--- a/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php
+++ b/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PhabricatorPholioMockTestDataGenerator
extends PhabricatorTestDataGenerator {
@@ -107,5 +104,4 @@
return $rand_images;
}
-
}
diff --git a/src/applications/pholio/mail/PholioMockMailReceiver.php b/src/applications/pholio/mail/PholioMockMailReceiver.php
--- a/src/applications/pholio/mail/PholioMockMailReceiver.php
+++ b/src/applications/pholio/mail/PholioMockMailReceiver.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioMockMailReceiver extends PhabricatorObjectMailReceiver {
public function isEnabled() {
@@ -29,8 +26,6 @@
PhabricatorUser $sender) {
// TODO: For now, we just drop this mail on the floor.
-
}
-
}
diff --git a/src/applications/pholio/mail/PholioReplyHandler.php b/src/applications/pholio/mail/PholioReplyHandler.php
--- a/src/applications/pholio/mail/PholioReplyHandler.php
+++ b/src/applications/pholio/mail/PholioReplyHandler.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioReplyHandler extends PhabricatorMailReplyHandler {
public function validateMailReceiver($mail_receiver) {
diff --git a/src/applications/pholio/query/PholioMockQuery.php b/src/applications/pholio/query/PholioMockQuery.php
--- a/src/applications/pholio/query/PholioMockQuery.php
+++ b/src/applications/pholio/query/PholioMockQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioMockQuery
extends PhabricatorCursorPagedPolicyAwareQuery {
diff --git a/src/applications/pholio/query/PholioTransactionQuery.php b/src/applications/pholio/query/PholioTransactionQuery.php
--- a/src/applications/pholio/query/PholioTransactionQuery.php
+++ b/src/applications/pholio/query/PholioTransactionQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioTransactionQuery
extends PhabricatorApplicationTransactionQuery {
diff --git a/src/applications/pholio/search/PholioSearchIndexer.php b/src/applications/pholio/search/PholioSearchIndexer.php
--- a/src/applications/pholio/search/PholioSearchIndexer.php
+++ b/src/applications/pholio/search/PholioSearchIndexer.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioSearchIndexer extends PhabricatorSearchDocumentIndexer {
public function getIndexableObject() {
@@ -34,4 +31,5 @@
return $doc;
}
+
}
diff --git a/src/applications/pholio/storage/PholioDAO.php b/src/applications/pholio/storage/PholioDAO.php
--- a/src/applications/pholio/storage/PholioDAO.php
+++ b/src/applications/pholio/storage/PholioDAO.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
abstract class PholioDAO extends PhabricatorLiskDAO {
public function getApplicationName() {
diff --git a/src/applications/pholio/storage/PholioImage.php b/src/applications/pholio/storage/PholioImage.php
--- a/src/applications/pholio/storage/PholioImage.php
+++ b/src/applications/pholio/storage/PholioImage.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioImage extends PholioDAO
implements
PhabricatorMarkupInterface,
diff --git a/src/applications/pholio/storage/PholioTransactionComment.php b/src/applications/pholio/storage/PholioTransactionComment.php
--- a/src/applications/pholio/storage/PholioTransactionComment.php
+++ b/src/applications/pholio/storage/PholioTransactionComment.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioTransactionComment
extends PhabricatorApplicationTransactionComment {
@@ -33,4 +30,5 @@
// Only cache submitted comments.
return ($this->getTransactionPHID() != null);
}
+
}
diff --git a/src/applications/pholio/view/PholioMockEmbedView.php b/src/applications/pholio/view/PholioMockEmbedView.php
--- a/src/applications/pholio/view/PholioMockEmbedView.php
+++ b/src/applications/pholio/view/PholioMockEmbedView.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioMockEmbedView extends AphrontView {
private $mock;
@@ -53,4 +50,5 @@
return $item;
}
+
}
diff --git a/src/applications/pholio/view/PholioMockImagesView.php b/src/applications/pholio/view/PholioMockImagesView.php
--- a/src/applications/pholio/view/PholioMockImagesView.php
+++ b/src/applications/pholio/view/PholioMockImagesView.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioMockImagesView extends AphrontView {
private $mock;
diff --git a/src/applications/pholio/view/PholioTransactionView.php b/src/applications/pholio/view/PholioTransactionView.php
--- a/src/applications/pholio/view/PholioTransactionView.php
+++ b/src/applications/pholio/view/PholioTransactionView.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioTransactionView
extends PhabricatorApplicationTransactionView {
diff --git a/src/applications/pholio/view/PholioUploadedImageView.php b/src/applications/pholio/view/PholioUploadedImageView.php
--- a/src/applications/pholio/view/PholioUploadedImageView.php
+++ b/src/applications/pholio/view/PholioUploadedImageView.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group pholio
- */
final class PholioUploadedImageView extends AphrontView {
private $image;
diff --git a/src/applications/phragment/conduit/ConduitAPI_phragment_Method.php b/src/applications/phragment/conduit/ConduitAPI_phragment_Method.php
--- a/src/applications/phragment/conduit/ConduitAPI_phragment_Method.php
+++ b/src/applications/phragment/conduit/ConduitAPI_phragment_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_phragment_Method extends ConduitAPIMethod {
public function getApplication() {
diff --git a/src/applications/phragment/conduit/ConduitAPI_phragment_getpatch_Method.php b/src/applications/phragment/conduit/ConduitAPI_phragment_getpatch_Method.php
--- a/src/applications/phragment/conduit/ConduitAPI_phragment_getpatch_Method.php
+++ b/src/applications/phragment/conduit/ConduitAPI_phragment_getpatch_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_phragment_getpatch_Method
extends ConduitAPI_phragment_Method {
@@ -99,7 +96,7 @@
} else {
// If $mappings[$path] does not exist, then the user has a file,
// and we have absolutely no record of it what-so-ever (we haven't
- // even recorded a deletion). Assuming most applications will store
+ // even recorded a deletion). Assuming most applications will store
// some form of data near their own files, this is probably a data
// file relevant for the application that is not versioned, so we
// don't tell the client to do anything with it.
@@ -115,7 +112,7 @@
$file_phid = $mappings[$path]->getLatestVersion()->getFilePHID();
if ($file_phid !== null) {
// If the file PHID is present, then this is a new file that
- // we know about, but the caller does not. We need to tell
+ // we know about, but the caller does not. We need to tell
// the caller to create the file.
$hash_current = $files[$file_phid]->getContentHash();
$patches[] = array(
diff --git a/src/applications/phragment/conduit/ConduitAPI_phragment_queryfragments_Method.php b/src/applications/phragment/conduit/ConduitAPI_phragment_queryfragments_Method.php
--- a/src/applications/phragment/conduit/ConduitAPI_phragment_queryfragments_Method.php
+++ b/src/applications/phragment/conduit/ConduitAPI_phragment_queryfragments_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_phragment_queryfragments_Method
extends ConduitAPI_phragment_Method {
diff --git a/src/applications/phragment/controller/PhragmentController.php b/src/applications/phragment/controller/PhragmentController.php
--- a/src/applications/phragment/controller/PhragmentController.php
+++ b/src/applications/phragment/controller/PhragmentController.php
@@ -210,7 +210,7 @@
->appendChild(phutil_tag('p', array(), pht(
'Because Phragment generates files (such as ZIP archives and '.
'patches) as they are requested, it requires that you configure '.
- 'the `security.alterate-file-domain` option. This option on it\'s '.
+ 'the `security.alterate-file-domain` option. This option on it\'s '.
'own will also provide additional security when serving files '.
'across Phabricator.')));
}
@@ -219,7 +219,7 @@
/**
* We use this to disable the download links if the alternate domain is
- * not configured correctly. Although the download links will mostly work
+ * not configured correctly. Although the download links will mostly work
* for logged in users without an alternate domain, the behaviour is
* reasonably non-consistent and will deny public users, even if policies
* are configured otherwise (because the Files app does not support showing
diff --git a/src/applications/phragment/controller/PhragmentRevertController.php b/src/applications/phragment/controller/PhragmentRevertController.php
--- a/src/applications/phragment/controller/PhragmentRevertController.php
+++ b/src/applications/phragment/controller/PhragmentRevertController.php
@@ -78,7 +78,7 @@
->addCancelButton(pht('Cancel'))
->appendParagraph(pht(
'Reverting this fragment to version %d will create a new version of '.
- 'the fragment. It will not delete any version history.',
+ 'the fragment. It will not delete any version history.',
$version->getSequence(),
$version->getSequence()));
return id(new AphrontDialogResponse())->setDialog($dialog);
diff --git a/src/applications/phragment/controller/PhragmentSnapshotDeleteController.php b/src/applications/phragment/controller/PhragmentSnapshotDeleteController.php
--- a/src/applications/phragment/controller/PhragmentSnapshotDeleteController.php
+++ b/src/applications/phragment/controller/PhragmentSnapshotDeleteController.php
@@ -45,7 +45,7 @@
->addSubmitButton(pht('Delete'))
->addCancelButton(pht('Cancel'))
->appendParagraph(pht(
- 'Deleting this snapshot is a permanent operation. You can not '.
+ 'Deleting this snapshot is a permanent operation. You can not '.
'recover the state of the snapshot.'));
return id(new AphrontDialogResponse())->setDialog($dialog);
}
diff --git a/src/applications/phragment/controller/PhragmentSnapshotPromoteController.php b/src/applications/phragment/controller/PhragmentSnapshotPromoteController.php
--- a/src/applications/phragment/controller/PhragmentSnapshotPromoteController.php
+++ b/src/applications/phragment/controller/PhragmentSnapshotPromoteController.php
@@ -130,7 +130,7 @@
->save();
}
} else {
- // The user is promoting the snapshot to another snapshot. We just
+ // The user is promoting the snapshot to another snapshot. We just
// copy the other snapshot's child entries and change the snapshot
// PHID to make it identical.
$children = id(new PhragmentSnapshotChildQuery())
diff --git a/src/applications/phragment/storage/PhragmentFragment.php b/src/applications/phragment/storage/PhragmentFragment.php
--- a/src/applications/phragment/storage/PhragmentFragment.php
+++ b/src/applications/phragment/storage/PhragmentFragment.php
@@ -158,7 +158,7 @@
$path = trim($zip->getNameIndex($i), '/');
$stream = $zip->getStream($path);
$data = null;
- // If the stream is false, then it is a directory entry. We leave
+ // If the stream is false, then it is a directory entry. We leave
// $data set to null for directories so we know not to create a
// version entry for them.
if ($stream !== false) {
@@ -169,7 +169,7 @@
}
// We need to detect any directories that are in the ZIP folder that
- // aren't explicitly noted in the ZIP. This can happen if the file
+ // aren't explicitly noted in the ZIP. This can happen if the file
// entries in the ZIP look like:
//
// * something/blah.png
@@ -204,7 +204,7 @@
}
// FIXME: What happens when a child exists, but the current user
- // can't see it. We're going to create a new child with the exact
+ // can't see it. We're going to create a new child with the exact
// same path and then bad things will happen.
$children = id(new PhragmentFragmentQuery())
->setViewer($viewer)
@@ -237,7 +237,7 @@
// Iterate over the mappings to find new files.
foreach ($mappings as $path => $data) {
if (!array_key_exists($base_path.'/'.$path, $children)) {
- // The file is being created. If the data is null,
+ // The file is being created. If the data is null,
// then this is explicitly a directory being created.
$file = null;
if ($mappings[$path] !== null) {
diff --git a/src/applications/phrequent/storage/PhrequentDAO.php b/src/applications/phrequent/storage/PhrequentDAO.php
--- a/src/applications/phrequent/storage/PhrequentDAO.php
+++ b/src/applications/phrequent/storage/PhrequentDAO.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phrequent
- */
abstract class PhrequentDAO extends PhabricatorLiskDAO {
public function getApplicationName() {
diff --git a/src/applications/phriction/conduit/ConduitAPI_phriction_Method.php b/src/applications/phriction/conduit/ConduitAPI_phriction_Method.php
--- a/src/applications/phriction/conduit/ConduitAPI_phriction_Method.php
+++ b/src/applications/phriction/conduit/ConduitAPI_phriction_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_phriction_Method extends ConduitAPIMethod {
public function getApplication() {
diff --git a/src/applications/phriction/constants/PhrictionActionConstants.php b/src/applications/phriction/constants/PhrictionActionConstants.php
--- a/src/applications/phriction/constants/PhrictionActionConstants.php
+++ b/src/applications/phriction/constants/PhrictionActionConstants.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phriction
- */
final class PhrictionActionConstants extends PhrictionConstants {
const ACTION_CREATE = 'create';
diff --git a/src/applications/phriction/constants/PhrictionChangeType.php b/src/applications/phriction/constants/PhrictionChangeType.php
--- a/src/applications/phriction/constants/PhrictionChangeType.php
+++ b/src/applications/phriction/constants/PhrictionChangeType.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phriction
- */
final class PhrictionChangeType extends PhrictionConstants {
const CHANGE_EDIT = 0;
diff --git a/src/applications/phriction/constants/PhrictionConstants.php b/src/applications/phriction/constants/PhrictionConstants.php
--- a/src/applications/phriction/constants/PhrictionConstants.php
+++ b/src/applications/phriction/constants/PhrictionConstants.php
@@ -1,8 +1,3 @@
<?php
-/**
- * @group phriction
- */
-abstract class PhrictionConstants {
-
-}
+abstract class PhrictionConstants {}
diff --git a/src/applications/phriction/constants/PhrictionDocumentStatus.php b/src/applications/phriction/constants/PhrictionDocumentStatus.php
--- a/src/applications/phriction/constants/PhrictionDocumentStatus.php
+++ b/src/applications/phriction/constants/PhrictionDocumentStatus.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phriction
- */
final class PhrictionDocumentStatus extends PhrictionConstants {
const STATUS_EXISTS = 0;
diff --git a/src/applications/phriction/controller/PhrictionController.php b/src/applications/phriction/controller/PhrictionController.php
--- a/src/applications/phriction/controller/PhrictionController.php
+++ b/src/applications/phriction/controller/PhrictionController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phriction
- */
abstract class PhrictionController extends PhabricatorController {
public function buildSideNavView($for_app = false) {
diff --git a/src/applications/phriction/controller/PhrictionDiffController.php b/src/applications/phriction/controller/PhrictionDiffController.php
--- a/src/applications/phriction/controller/PhrictionDiffController.php
+++ b/src/applications/phriction/controller/PhrictionDiffController.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group phriction
- */
-final class PhrictionDiffController
- extends PhrictionController {
+final class PhrictionDiffController extends PhrictionController {
private $id;
diff --git a/src/applications/phriction/controller/PhrictionDocumentPreviewController.php b/src/applications/phriction/controller/PhrictionDocumentPreviewController.php
--- a/src/applications/phriction/controller/PhrictionDocumentPreviewController.php
+++ b/src/applications/phriction/controller/PhrictionDocumentPreviewController.php
@@ -1,13 +1,9 @@
<?php
-/**
- * @group phriction
- */
final class PhrictionDocumentPreviewController
extends PhrictionController {
public function processRequest() {
-
$request = $this->getRequest();
$document = $request->getStr('document');
@@ -26,4 +22,5 @@
return id(new AphrontAjaxResponse())->setContent($content);
}
+
}
diff --git a/src/applications/phriction/controller/PhrictionMoveController.php b/src/applications/phriction/controller/PhrictionMoveController.php
--- a/src/applications/phriction/controller/PhrictionMoveController.php
+++ b/src/applications/phriction/controller/PhrictionMoveController.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group phriction
- */
-final class PhrictionMoveController
- extends PhrictionController {
+final class PhrictionMoveController extends PhrictionController {
private $id;
@@ -161,4 +157,5 @@
return id(new AphrontDialogResponse())->setDialog($dialog);
}
+
}
diff --git a/src/applications/phriction/editor/PhrictionDocumentEditor.php b/src/applications/phriction/editor/PhrictionDocumentEditor.php
--- a/src/applications/phriction/editor/PhrictionDocumentEditor.php
+++ b/src/applications/phriction/editor/PhrictionDocumentEditor.php
@@ -2,8 +2,6 @@
/**
* Create or update Phriction documents.
- *
- * @group phriction
*/
final class PhrictionDocumentEditor extends PhabricatorEditor {
diff --git a/src/applications/phriction/remarkup/PhrictionRemarkupRule.php b/src/applications/phriction/remarkup/PhrictionRemarkupRule.php
--- a/src/applications/phriction/remarkup/PhrictionRemarkupRule.php
+++ b/src/applications/phriction/remarkup/PhrictionRemarkupRule.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group markup
- */
-final class PhrictionRemarkupRule
- extends PhutilRemarkupRule {
+final class PhrictionRemarkupRule extends PhutilRemarkupRule {
public function getPriority() {
return 350.0;
diff --git a/src/applications/phriction/storage/PhrictionContent.php b/src/applications/phriction/storage/PhrictionContent.php
--- a/src/applications/phriction/storage/PhrictionContent.php
+++ b/src/applications/phriction/storage/PhrictionContent.php
@@ -2,8 +2,6 @@
/**
* @task markup Markup Interface
- *
- * @group phriction
*/
final class PhrictionContent extends PhrictionDAO
implements PhabricatorMarkupInterface {
diff --git a/src/applications/phriction/storage/PhrictionDAO.php b/src/applications/phriction/storage/PhrictionDAO.php
--- a/src/applications/phriction/storage/PhrictionDAO.php
+++ b/src/applications/phriction/storage/PhrictionDAO.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phriction
- */
abstract class PhrictionDAO extends PhabricatorLiskDAO {
public function getApplicationName() {
diff --git a/src/applications/phriction/storage/__tests__/PhrictionDocumentTestCase.php b/src/applications/phriction/storage/__tests__/PhrictionDocumentTestCase.php
--- a/src/applications/phriction/storage/__tests__/PhrictionDocumentTestCase.php
+++ b/src/applications/phriction/storage/__tests__/PhrictionDocumentTestCase.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group phriction
- */
final class PhrictionDocumentTestCase extends PhabricatorTestCase {
public function testProjectSlugs() {
diff --git a/src/applications/ponder/constants/PonderQuestionStatus.php b/src/applications/ponder/constants/PonderQuestionStatus.php
--- a/src/applications/ponder/constants/PonderQuestionStatus.php
+++ b/src/applications/ponder/constants/PonderQuestionStatus.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group ponder
- */
final class PonderQuestionStatus extends PonderConstants {
const STATUS_OPEN = 0;
diff --git a/src/applications/ponder/constants/PonderVote.php b/src/applications/ponder/constants/PonderVote.php
--- a/src/applications/ponder/constants/PonderVote.php
+++ b/src/applications/ponder/constants/PonderVote.php
@@ -1,7 +1,5 @@
<?php
-/**
- * @group ponder
- */
+
final class PonderVote extends PonderConstants {
const VOTE_UP = 1;
diff --git a/src/applications/project/conduit/ConduitAPI_project_Method.php b/src/applications/project/conduit/ConduitAPI_project_Method.php
--- a/src/applications/project/conduit/ConduitAPI_project_Method.php
+++ b/src/applications/project/conduit/ConduitAPI_project_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_project_Method extends ConduitAPIMethod {
public function getApplication() {
diff --git a/src/applications/project/conduit/ConduitAPI_project_query_Method.php b/src/applications/project/conduit/ConduitAPI_project_query_Method.php
--- a/src/applications/project/conduit/ConduitAPI_project_query_Method.php
+++ b/src/applications/project/conduit/ConduitAPI_project_query_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_project_query_Method extends ConduitAPI_project_Method {
public function getMethodDescription() {
diff --git a/src/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranchcommitmessage_Method.php b/src/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranchcommitmessage_Method.php
--- a/src/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranchcommitmessage_Method.php
+++ b/src/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranchcommitmessage_Method.php
@@ -53,7 +53,7 @@
$h_branch = $handles[$branch->getPHID()];
$h_project = $handles[$project->getPHID()];
- // Not as customizable as a ReleephRequest's commit message. It doesn't
+ // Not as customizable as a ReleephRequest's commit message. It doesn't
// really need to be.
// TODO: Yes it does, see FB-specific stuff below.
$commit_message = array();
diff --git a/src/applications/releeph/conduit/work/ConduitAPI_releephwork_nextrequest_Method.php b/src/applications/releeph/conduit/work/ConduitAPI_releephwork_nextrequest_Method.php
--- a/src/applications/releeph/conduit/work/ConduitAPI_releephwork_nextrequest_Method.php
+++ b/src/applications/releeph/conduit/work/ConduitAPI_releephwork_nextrequest_Method.php
@@ -75,7 +75,7 @@
* discovered by Phabricator (using the `id` column to perform that
* ordering).
*
- * This is easy for $needs_pick as the ordinal is stored. It is hard for
+ * This is easy for $needs_pick as the ordinal is stored. It is hard for
* reverts, as we have to look that information up.
*/
$needs_pick = $this->sortPicks($needs_pick);
diff --git a/src/applications/releeph/conduit/work/ConduitAPI_releephwork_record_Method.php b/src/applications/releeph/conduit/work/ConduitAPI_releephwork_record_Method.php
--- a/src/applications/releeph/conduit/work/ConduitAPI_releephwork_record_Method.php
+++ b/src/applications/releeph/conduit/work/ConduitAPI_releephwork_record_Method.php
@@ -16,7 +16,7 @@
*
* When the daemons discover this commit in the repository with
* DifferentialReleephRequestFieldSpecification, we'll be able to record the
- * commit's PHID as well. That process is slow though, and we don't want to
+ * commit's PHID as well. That process is slow though, and we don't want to
* wait a whole minute before marking something as cleanly picked or
* reverted.
*/
diff --git a/src/applications/releeph/config/PhabricatorApplicationReleephConfigOptions.php b/src/applications/releeph/config/PhabricatorApplicationReleephConfigOptions.php
--- a/src/applications/releeph/config/PhabricatorApplicationReleephConfigOptions.php
+++ b/src/applications/releeph/config/PhabricatorApplicationReleephConfigOptions.php
@@ -65,7 +65,7 @@
->setDescription(
pht(
'The default branch template for new branches in unconfigured '.
- 'Releeph projects. This is also configurable on a per-project '.
+ 'Releeph projects. This is also configurable on a per-project '.
'basis.')),
);
}
diff --git a/src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php b/src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php
--- a/src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php
+++ b/src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php
@@ -70,7 +70,7 @@
$dialog->appendChild(
pht('This differential revision changes code that is associated '.
- 'with multiple Releeph branches. '.
+ 'with multiple Releeph branches. '.
'Please select the branch where you would like this code to be picked.'));
foreach ($branch_groups as $project_id => $branches) {
diff --git a/src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php b/src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php
--- a/src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php
+++ b/src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php
@@ -141,8 +141,8 @@
* Reviewers: user1
*
* Some of these fields are recognized by Differential (e.g. "Requested
- * By"). They are folded up into the "Releeph" field, parsed by this
- * class. As such $value includes more than just the first-line:
+ * By"). They are folded up into the "Releeph" field, parsed by this
+ * class. As such $value includes more than just the first-line:
*
* "picks RQ1\n\nRequested By: edward\n\nApproved By: edward (requestor)"
*
diff --git a/src/applications/releeph/field/specification/ReleephFieldSpecification.php b/src/applications/releeph/field/specification/ReleephFieldSpecification.php
--- a/src/applications/releeph/field/specification/ReleephFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephFieldSpecification.php
@@ -210,10 +210,10 @@
private $engine;
/**
- * ReleephFieldSpecification implements much of PhabricatorMarkupInterface
- * for you. If you return true from `shouldMarkup()`, and implement
- * `getMarkupText()` then your text will be rendered through the Phabricator
- * markup pipeline.
+ * @{class:ReleephFieldSpecification} implements much of
+ * @{interface:PhabricatorMarkupInterface} for you. If you return true from
+ * `shouldMarkup()`, and implement `getMarkupText()` then your text will be
+ * rendered through the Phabricator markup pipeline.
*
* Output is retrievable with `getMarkupEngineOutput()`.
*/
diff --git a/src/applications/releeph/storage/ReleephBranch.php b/src/applications/releeph/storage/ReleephBranch.php
--- a/src/applications/releeph/storage/ReleephBranch.php
+++ b/src/applications/releeph/storage/ReleephBranch.php
@@ -49,7 +49,7 @@
// If symbolicName is omitted, set it to the basename.
//
// This means that we can enforce symbolicName as a UNIQUE column in the
- // DB. We'll interpret symbolicName === basename as meaning "no symbolic
+ // DB. We'll interpret symbolicName === basename as meaning "no symbolic
// name".
//
// SYMBOLIC_NAME_NOTE
diff --git a/src/applications/releeph/storage/ReleephProject.php b/src/applications/releeph/storage/ReleephProject.php
--- a/src/applications/releeph/storage/ReleephProject.php
+++ b/src/applications/releeph/storage/ReleephProject.php
@@ -9,7 +9,7 @@
protected $name;
// Specifying the place to pick from is a requirement for svn, though not
- // for git. It's always useful though for reasoning about what revs have
+ // for git. It's always useful though for reasoning about what revs have
// been picked and which haven't.
protected $trunkBranch;
diff --git a/src/applications/releeph/storage/ReleephRequest.php b/src/applications/releeph/storage/ReleephRequest.php
--- a/src/applications/releeph/storage/ReleephRequest.php
+++ b/src/applications/releeph/storage/ReleephRequest.php
@@ -50,7 +50,7 @@
$this->getPusherIntent() == self::INTENT_WANT &&
/**
* We use "!= pass" instead of "== want" in case the requestor intent is
- * not present. In other words, only revert if the requestor explicitly
+ * not present. In other words, only revert if the requestor explicitly
* passed.
*/
$this->getRequestorIntent() != self::INTENT_PASS;
diff --git a/src/applications/releeph/storage/ReleephRequestTransaction.php b/src/applications/releeph/storage/ReleephRequestTransaction.php
--- a/src/applications/releeph/storage/ReleephRequestTransaction.php
+++ b/src/applications/releeph/storage/ReleephRequestTransaction.php
@@ -254,7 +254,7 @@
}
// ReleephSummaryFieldSpecification is usually blank when an RQ is created,
- // creating a transaction change from null to "". Hide these!
+ // creating a transaction change from null to "". Hide these!
if ($type === ReleephRequestTransaction::TYPE_EDIT_FIELD) {
if ($this->getOldValue() === null && $this->getNewValue() === '') {
return true;
diff --git a/src/applications/repository/PhabricatorRepositoryConfigOptions.php b/src/applications/repository/PhabricatorRepositoryConfigOptions.php
--- a/src/applications/repository/PhabricatorRepositoryConfigOptions.php
+++ b/src/applications/repository/PhabricatorRepositoryConfigOptions.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group repository
- */
final class PhabricatorRepositoryConfigOptions
extends PhabricatorApplicationConfigOptions {
diff --git a/src/applications/repository/application/PhabricatorApplicationRepositories.php b/src/applications/repository/application/PhabricatorApplicationRepositories.php
--- a/src/applications/repository/application/PhabricatorApplicationRepositories.php
+++ b/src/applications/repository/application/PhabricatorApplicationRepositories.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group repository
- */
final class PhabricatorApplicationRepositories extends PhabricatorApplication {
public function getBaseURI() {
diff --git a/src/applications/repository/conduit/ConduitAPI_repository_Method.php b/src/applications/repository/conduit/ConduitAPI_repository_Method.php
--- a/src/applications/repository/conduit/ConduitAPI_repository_Method.php
+++ b/src/applications/repository/conduit/ConduitAPI_repository_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_repository_Method extends ConduitAPIMethod {
public function getApplication() {
diff --git a/src/applications/repository/conduit/ConduitAPI_repository_create_Method.php b/src/applications/repository/conduit/ConduitAPI_repository_create_Method.php
--- a/src/applications/repository/conduit/ConduitAPI_repository_create_Method.php
+++ b/src/applications/repository/conduit/ConduitAPI_repository_create_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_repository_create_Method
extends ConduitAPI_repository_Method {
@@ -133,5 +130,4 @@
return $repository->toDictionary();
}
-
}
diff --git a/src/applications/repository/phid/PhabricatorRepositoryPHIDTypeArcanistProject.php b/src/applications/repository/phid/PhabricatorRepositoryPHIDTypeArcanistProject.php
--- a/src/applications/repository/phid/PhabricatorRepositoryPHIDTypeArcanistProject.php
+++ b/src/applications/repository/phid/PhabricatorRepositoryPHIDTypeArcanistProject.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group repository
- */
final class PhabricatorRepositoryPHIDTypeArcanistProject
extends PhabricatorPHIDType {
diff --git a/src/applications/repository/query/PhabricatorRepositoryArcanistProjectQuery.php b/src/applications/repository/query/PhabricatorRepositoryArcanistProjectQuery.php
--- a/src/applications/repository/query/PhabricatorRepositoryArcanistProjectQuery.php
+++ b/src/applications/repository/query/PhabricatorRepositoryArcanistProjectQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group repository
- */
final class PhabricatorRepositoryArcanistProjectQuery
extends PhabricatorCursorPagedPolicyAwareQuery {
diff --git a/src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php b/src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php
--- a/src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php
+++ b/src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group repository
- */
final class PhabricatorRepositoryArcanistProject
extends PhabricatorRepositoryDAO
implements PhabricatorPolicyInterface,
diff --git a/src/applications/repository/storage/PhabricatorRepositorySymbol.php b/src/applications/repository/storage/PhabricatorRepositorySymbol.php
--- a/src/applications/repository/storage/PhabricatorRepositorySymbol.php
+++ b/src/applications/repository/storage/PhabricatorRepositorySymbol.php
@@ -5,8 +5,6 @@
* and functions are defined.
*
* Query symbols with @{class:DiffusionSymbolQuery}.
- *
- * @group diffusion
*/
final class PhabricatorRepositorySymbol extends PhabricatorRepositoryDAO {
diff --git a/src/applications/search/constants/PhabricatorSearchField.php b/src/applications/search/constants/PhabricatorSearchField.php
--- a/src/applications/search/constants/PhabricatorSearchField.php
+++ b/src/applications/search/constants/PhabricatorSearchField.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorSearchField {
const FIELD_TITLE = 'titl';
diff --git a/src/applications/search/constants/PhabricatorSearchRelationship.php b/src/applications/search/constants/PhabricatorSearchRelationship.php
--- a/src/applications/search/constants/PhabricatorSearchRelationship.php
+++ b/src/applications/search/constants/PhabricatorSearchRelationship.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorSearchRelationship {
const RELATIONSHIP_AUTHOR = 'auth';
diff --git a/src/applications/search/controller/PhabricatorSearchAttachController.php b/src/applications/search/controller/PhabricatorSearchAttachController.php
--- a/src/applications/search/controller/PhabricatorSearchAttachController.php
+++ b/src/applications/search/controller/PhabricatorSearchAttachController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorSearchAttachController
extends PhabricatorSearchBaseController {
diff --git a/src/applications/search/controller/PhabricatorSearchBaseController.php b/src/applications/search/controller/PhabricatorSearchBaseController.php
--- a/src/applications/search/controller/PhabricatorSearchBaseController.php
+++ b/src/applications/search/controller/PhabricatorSearchBaseController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
abstract class PhabricatorSearchBaseController extends PhabricatorController {
public function buildStandardPageResponse($view, array $data) {
diff --git a/src/applications/search/controller/PhabricatorSearchDeleteController.php b/src/applications/search/controller/PhabricatorSearchDeleteController.php
--- a/src/applications/search/controller/PhabricatorSearchDeleteController.php
+++ b/src/applications/search/controller/PhabricatorSearchDeleteController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorSearchDeleteController
extends PhabricatorSearchBaseController {
diff --git a/src/applications/search/controller/PhabricatorSearchEditController.php b/src/applications/search/controller/PhabricatorSearchEditController.php
--- a/src/applications/search/controller/PhabricatorSearchEditController.php
+++ b/src/applications/search/controller/PhabricatorSearchEditController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorSearchEditController
extends PhabricatorSearchBaseController {
@@ -105,5 +102,4 @@
));
}
-
}
diff --git a/src/applications/search/controller/PhabricatorSearchHovercardController.php b/src/applications/search/controller/PhabricatorSearchHovercardController.php
--- a/src/applications/search/controller/PhabricatorSearchHovercardController.php
+++ b/src/applications/search/controller/PhabricatorSearchHovercardController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorSearchHovercardController
extends PhabricatorSearchBaseController {
diff --git a/src/applications/search/controller/PhabricatorSearchOrderController.php b/src/applications/search/controller/PhabricatorSearchOrderController.php
--- a/src/applications/search/controller/PhabricatorSearchOrderController.php
+++ b/src/applications/search/controller/PhabricatorSearchOrderController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorSearchOrderController
extends PhabricatorSearchBaseController {
diff --git a/src/applications/search/controller/PhabricatorSearchSelectController.php b/src/applications/search/controller/PhabricatorSearchSelectController.php
--- a/src/applications/search/controller/PhabricatorSearchSelectController.php
+++ b/src/applications/search/controller/PhabricatorSearchSelectController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorSearchSelectController
extends PhabricatorSearchBaseController {
diff --git a/src/applications/search/engine/PhabricatorApplicationSearchEngine.php b/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
--- a/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
+++ b/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
@@ -12,8 +12,6 @@
* @task read Reading Utilities
* @task exec Paging and Executing Queries
* @task render Rendering Results
- *
- * @group search
*/
abstract class PhabricatorApplicationSearchEngine {
diff --git a/src/applications/search/engine/PhabricatorSearchEngineMySQL.php b/src/applications/search/engine/PhabricatorSearchEngineMySQL.php
--- a/src/applications/search/engine/PhabricatorSearchEngineMySQL.php
+++ b/src/applications/search/engine/PhabricatorSearchEngineMySQL.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorSearchEngineMySQL extends PhabricatorSearchEngine {
public function reindexAbstractDocument(
@@ -143,7 +140,6 @@
}
public function executeSearch(PhabricatorSavedQuery $query) {
-
$where = array();
$join = array();
$order = 'ORDER BY documentCreated DESC';
@@ -335,5 +331,4 @@
return $sql;
}
-
}
diff --git a/src/applications/search/index/PhabricatorSearchDocumentIndexer.php b/src/applications/search/index/PhabricatorSearchDocumentIndexer.php
--- a/src/applications/search/index/PhabricatorSearchDocumentIndexer.php
+++ b/src/applications/search/index/PhabricatorSearchDocumentIndexer.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
abstract class PhabricatorSearchDocumentIndexer {
abstract public function getIndexableObject();
diff --git a/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php b/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
--- a/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
+++ b/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorSearchManagementIndexWorkflow
extends PhabricatorSearchManagementWorkflow {
diff --git a/src/applications/search/query/PhabricatorNamedQueryQuery.php b/src/applications/search/query/PhabricatorNamedQueryQuery.php
--- a/src/applications/search/query/PhabricatorNamedQueryQuery.php
+++ b/src/applications/search/query/PhabricatorNamedQueryQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorNamedQueryQuery
extends PhabricatorCursorPagedPolicyAwareQuery {
diff --git a/src/applications/search/selector/PhabricatorDefaultSearchEngineSelector.php b/src/applications/search/selector/PhabricatorDefaultSearchEngineSelector.php
--- a/src/applications/search/selector/PhabricatorDefaultSearchEngineSelector.php
+++ b/src/applications/search/selector/PhabricatorDefaultSearchEngineSelector.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorDefaultSearchEngineSelector
extends PhabricatorSearchEngineSelector {
diff --git a/src/applications/search/selector/PhabricatorSearchEngineSelector.php b/src/applications/search/selector/PhabricatorSearchEngineSelector.php
--- a/src/applications/search/selector/PhabricatorSearchEngineSelector.php
+++ b/src/applications/search/selector/PhabricatorSearchEngineSelector.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
abstract class PhabricatorSearchEngineSelector {
final public function __construct() {
diff --git a/src/applications/search/storage/PhabricatorNamedQuery.php b/src/applications/search/storage/PhabricatorNamedQuery.php
--- a/src/applications/search/storage/PhabricatorNamedQuery.php
+++ b/src/applications/search/storage/PhabricatorNamedQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorNamedQuery extends PhabricatorSearchDAO
implements PhabricatorPolicyInterface {
@@ -45,5 +42,4 @@
'them.');
}
-
}
diff --git a/src/applications/search/storage/PhabricatorSavedQuery.php b/src/applications/search/storage/PhabricatorSavedQuery.php
--- a/src/applications/search/storage/PhabricatorSavedQuery.php
+++ b/src/applications/search/storage/PhabricatorSavedQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorSavedQuery extends PhabricatorSearchDAO
implements PhabricatorPolicyInterface {
diff --git a/src/applications/search/storage/PhabricatorSearchDAO.php b/src/applications/search/storage/PhabricatorSearchDAO.php
--- a/src/applications/search/storage/PhabricatorSearchDAO.php
+++ b/src/applications/search/storage/PhabricatorSearchDAO.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
abstract class PhabricatorSearchDAO extends PhabricatorLiskDAO {
public function getApplicationName() {
diff --git a/src/applications/search/storage/document/PhabricatorSearchDocument.php b/src/applications/search/storage/document/PhabricatorSearchDocument.php
--- a/src/applications/search/storage/document/PhabricatorSearchDocument.php
+++ b/src/applications/search/storage/document/PhabricatorSearchDocument.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorSearchDocument extends PhabricatorSearchDAO {
protected $phid;
diff --git a/src/applications/search/storage/document/PhabricatorSearchDocumentField.php b/src/applications/search/storage/document/PhabricatorSearchDocumentField.php
--- a/src/applications/search/storage/document/PhabricatorSearchDocumentField.php
+++ b/src/applications/search/storage/document/PhabricatorSearchDocumentField.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorSearchDocumentField extends PhabricatorSearchDAO {
protected $phid;
diff --git a/src/applications/search/storage/document/PhabricatorSearchDocumentRelationship.php b/src/applications/search/storage/document/PhabricatorSearchDocumentRelationship.php
--- a/src/applications/search/storage/document/PhabricatorSearchDocumentRelationship.php
+++ b/src/applications/search/storage/document/PhabricatorSearchDocumentRelationship.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group search
- */
final class PhabricatorSearchDocumentRelationship extends PhabricatorSearchDAO {
protected $phid;
diff --git a/src/applications/slowvote/conduit/ConduitAPI_slowvote_Method.php b/src/applications/slowvote/conduit/ConduitAPI_slowvote_Method.php
--- a/src/applications/slowvote/conduit/ConduitAPI_slowvote_Method.php
+++ b/src/applications/slowvote/conduit/ConduitAPI_slowvote_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
abstract class ConduitAPI_slowvote_Method extends ConduitAPIMethod {
public function getApplication() {
diff --git a/src/applications/slowvote/conduit/ConduitAPI_slowvote_info_Method.php b/src/applications/slowvote/conduit/ConduitAPI_slowvote_info_Method.php
--- a/src/applications/slowvote/conduit/ConduitAPI_slowvote_info_Method.php
+++ b/src/applications/slowvote/conduit/ConduitAPI_slowvote_info_Method.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group conduit
- */
final class ConduitAPI_slowvote_info_Method
extends ConduitAPI_slowvote_Method {
diff --git a/src/applications/slowvote/controller/PhabricatorSlowvoteController.php b/src/applications/slowvote/controller/PhabricatorSlowvoteController.php
--- a/src/applications/slowvote/controller/PhabricatorSlowvoteController.php
+++ b/src/applications/slowvote/controller/PhabricatorSlowvoteController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group slowvote
- */
abstract class PhabricatorSlowvoteController extends PhabricatorController {
public function buildSideNavView($for_app = false) {
diff --git a/src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php b/src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php
--- a/src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php
+++ b/src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group slowvote
- */
final class PhabricatorSlowvoteEditController
extends PhabricatorSlowvoteController {
diff --git a/src/applications/slowvote/controller/PhabricatorSlowvotePollController.php b/src/applications/slowvote/controller/PhabricatorSlowvotePollController.php
--- a/src/applications/slowvote/controller/PhabricatorSlowvotePollController.php
+++ b/src/applications/slowvote/controller/PhabricatorSlowvotePollController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group slowvote
- */
final class PhabricatorSlowvotePollController
extends PhabricatorSlowvoteController {
@@ -189,7 +186,6 @@
->setHeaderText($add_comment_header)
->setAction($this->getApplicationURI('/comment/'.$poll->getID().'/'))
->setSubmitButtonName(pht('Add Comment'));
-
}
}
diff --git a/src/applications/slowvote/controller/PhabricatorSlowvoteVoteController.php b/src/applications/slowvote/controller/PhabricatorSlowvoteVoteController.php
--- a/src/applications/slowvote/controller/PhabricatorSlowvoteVoteController.php
+++ b/src/applications/slowvote/controller/PhabricatorSlowvoteVoteController.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group slowvote
- */
final class PhabricatorSlowvoteVoteController
extends PhabricatorSlowvoteController {
@@ -81,11 +78,9 @@
$this->updateVotes($user, $poll, $old_votes, $votes);
return id(new AphrontRedirectResponse())->setURI('/V'.$poll->getID());
-
}
private function updateVotes($user, $poll, $old_votes, $votes) {
-
if (!empty($votes) && count($votes) > 1 &&
$poll->getMethod() == PhabricatorSlowvotePoll::METHOD_PLURALITY) {
return id(new Aphront400Response());
@@ -108,8 +103,6 @@
->setOptionID($vote)
->save();
}
-
}
-
}
diff --git a/src/applications/slowvote/query/PhabricatorSlowvoteQuery.php b/src/applications/slowvote/query/PhabricatorSlowvoteQuery.php
--- a/src/applications/slowvote/query/PhabricatorSlowvoteQuery.php
+++ b/src/applications/slowvote/query/PhabricatorSlowvoteQuery.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group slowvote
- */
final class PhabricatorSlowvoteQuery
extends PhabricatorCursorPagedPolicyAwareQuery {
diff --git a/src/applications/slowvote/remarkup/SlowvoteRemarkupRule.php b/src/applications/slowvote/remarkup/SlowvoteRemarkupRule.php
--- a/src/applications/slowvote/remarkup/SlowvoteRemarkupRule.php
+++ b/src/applications/slowvote/remarkup/SlowvoteRemarkupRule.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group slowvote
- */
-final class SlowvoteRemarkupRule
- extends PhabricatorRemarkupRuleObject {
+final class SlowvoteRemarkupRule extends PhabricatorRemarkupRuleObject {
protected function getObjectNamePrefix() {
return 'V';
diff --git a/src/applications/slowvote/storage/PhabricatorSlowvoteChoice.php b/src/applications/slowvote/storage/PhabricatorSlowvoteChoice.php
--- a/src/applications/slowvote/storage/PhabricatorSlowvoteChoice.php
+++ b/src/applications/slowvote/storage/PhabricatorSlowvoteChoice.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group slowvote
- */
final class PhabricatorSlowvoteChoice extends PhabricatorSlowvoteDAO {
protected $pollID;
diff --git a/src/applications/slowvote/storage/PhabricatorSlowvoteComment.php b/src/applications/slowvote/storage/PhabricatorSlowvoteComment.php
--- a/src/applications/slowvote/storage/PhabricatorSlowvoteComment.php
+++ b/src/applications/slowvote/storage/PhabricatorSlowvoteComment.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group slowvote
- */
final class PhabricatorSlowvoteComment extends PhabricatorSlowvoteDAO {
protected $pollID;
diff --git a/src/applications/slowvote/storage/PhabricatorSlowvoteDAO.php b/src/applications/slowvote/storage/PhabricatorSlowvoteDAO.php
--- a/src/applications/slowvote/storage/PhabricatorSlowvoteDAO.php
+++ b/src/applications/slowvote/storage/PhabricatorSlowvoteDAO.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group slowvote
- */
abstract class PhabricatorSlowvoteDAO extends PhabricatorLiskDAO {
public function getApplicationName() {
diff --git a/src/applications/slowvote/storage/PhabricatorSlowvoteOption.php b/src/applications/slowvote/storage/PhabricatorSlowvoteOption.php
--- a/src/applications/slowvote/storage/PhabricatorSlowvoteOption.php
+++ b/src/applications/slowvote/storage/PhabricatorSlowvoteOption.php
@@ -1,12 +1,8 @@
<?php
-/**
- * @group slowvote
- */
final class PhabricatorSlowvoteOption extends PhabricatorSlowvoteDAO {
protected $pollID;
protected $name;
-
}
diff --git a/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php b/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php
--- a/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php
+++ b/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group slowvote
- */
final class PhabricatorSlowvotePoll extends PhabricatorSlowvoteDAO
implements
PhabricatorPolicyInterface,
diff --git a/src/applications/slowvote/view/SlowvoteEmbedView.php b/src/applications/slowvote/view/SlowvoteEmbedView.php
--- a/src/applications/slowvote/view/SlowvoteEmbedView.php
+++ b/src/applications/slowvote/view/SlowvoteEmbedView.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group slowvote
- */
final class SlowvoteEmbedView extends AphrontView {
private $poll;
diff --git a/src/docs/contributor/css_coding_standards.diviner b/src/docs/contributor/css_coding_standards.diviner
--- a/src/docs/contributor/css_coding_standards.diviner
+++ b/src/docs/contributor/css_coding_standards.diviner
@@ -53,14 +53,14 @@
}
}
-The former will activate when users look at the printable versions of pages,
-by adding `__print__` to the URI. The latter will be activated in print contexts
+The former will activate when users look at the printable versions of pages, by
+adding `__print__` to the URI. The latter will be activated in print contexts
by the media query.
= Device Rules =
-Phabricator's environment defines several device classes which can be used
-to adjust behavior responsively. In particular:
+Phabricator's environment defines several device classes which can be used to
+adjust behavior responsively. In particular:
lang=css
.device-phone {
diff --git a/src/docs/contributor/darkconsole.diviner b/src/docs/contributor/darkconsole.diviner
--- a/src/docs/contributor/darkconsole.diviner
+++ b/src/docs/contributor/darkconsole.diviner
@@ -10,9 +10,9 @@
understand and resolve bugs and performance problems in Phabricator
applications.
-DarkConsole was originally implemented as part of the Facebook Lite site;
-its name is a bit of play on that (and a reference to the dark color palette
-its design uses).
+DarkConsole was originally implemented as part of the Facebook Lite site; its
+name is a bit of play on that (and a reference to the dark color palette its
+design uses).
= Warning =
@@ -24,8 +24,8 @@
= Enabling DarkConsole =
You enable DarkConsole in your configuration, by setting `darkconsole.enabled`
-to `true`, and then turning it on in `Settings` -> `Display Preferences`.
-Once DarkConsole is enabled, you can show or hide it by pressing ##`## on your
+to `true`, and then turning it on in `Settings` -> `Display Preferences`. Once
+DarkConsole is enabled, you can show or hide it by pressing ##`## on your
keyboard.
Since the setting is not available to logged-out users, you can also set
diff --git a/src/docs/contributor/database.diviner b/src/docs/contributor/database.diviner
--- a/src/docs/contributor/database.diviner
+++ b/src/docs/contributor/database.diviner
@@ -118,8 +118,8 @@
a homogenous way.
For example, the concept of "subscribers" is more powerfully done with PHIDs
-because we could theoretically have users, projects, teams, and more all
-as "subscribers" of other objects. Using an ID column we would need to add a
+because we could theoretically have users, projects, teams, and more all as
+"subscribers" of other objects. Using an ID column we would need to add a
"type" column to avoid ID collision; using PHIDs does not require this
additional column.
@@ -148,14 +148,14 @@
There are three simple steps to update the schema:
# Create a `.sql` file in `resources/sql/patches/`. This file should:
- - Contain the approprate MySQL commands to update the schema.
- - Be named as `YYYYMMDD.patchname.ext`. For example, `20130217.example.sql`.
- - Use `${NAMESPACE}` rather than `phabricator` for database names.
- - Use `COLLATE utf8_bin` for any columns that are to be used as identifiers,
-such as PHID columns. Otherwise, use `COLLATE utf8_general_ci`.
- - Name all indexes so it is possible to delete them later.
+ - Contain the approprate MySQL commands to update the schema.
+ - Be named as `YYYYMMDD.patchname.ext`. For example, `20130217.example.sql`.
+ - Use `${NAMESPACE}` rather than `phabricator` for database names.
+ - Use `COLLATE utf8_bin` for any columns that are to be used as identifiers,
+ such as PHID columns. Otherwise, use `COLLATE utf8_general_ci`.
+ - Name all indexes so it is possible to delete them later.
# Edit `src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php` and
-add your patch to @{method@phabricator:PhabricatorBuiltinPatchList::getPatches}.
+ add your patch to @{method@phabricator:PhabricatorBuiltinPatchList::getPatches}.
# Run `bin/storage upgrade`.
It is also possible to create more complex patches in PHP for data migration
diff --git a/src/docs/contributor/phabricator_code_layout.diviner b/src/docs/contributor/phabricator_code_layout.diviner
--- a/src/docs/contributor/phabricator_code_layout.diviner
+++ b/src/docs/contributor/phabricator_code_layout.diviner
@@ -71,7 +71,7 @@
complicated edits and should be used pragmatically versus Storage objects.
- **DerpException**: exceptions used in the ##Derp## application.
- **DerpQuery**: query one or more storage objects for pertinent ##Derp##
- application data. @{class:PhabricatorOffsetPagedQuery} is particularly
+ application data. @{class:PhabricatorOffsetPagedQuery} is particularly
handy for pagination and works well with @{class:AphrontPagerView}.
- **DerpReplyHandler**: business logic from any configured email interactions
users can have with the ##Derp## application.
diff --git a/src/docs/contributor/using_edges.diviner b/src/docs/contributor/using_edges.diviner
--- a/src/docs/contributor/using_edges.diviner
+++ b/src/docs/contributor/using_edges.diviner
@@ -5,9 +5,9 @@
= Overview =
-Edges are a generic way of storing a relationship between two objects (like
-a Task and its attached files). If you are familiar with the Facebook
-associations framework, Phabricator Edges are substantially similar.
+Edges are a generic way of storing a relationship between two objects (like a
+Task and its attached files). If you are familiar with the Facebook associations
+framework, Phabricator Edges are substantially similar.
An edge is defined by a source PHID (the edge origin), a destination PHID
(the edge destination) and an edge type (which describes the relationship,
diff --git a/src/docs/flavor/things_you_should_do_soon.diviner b/src/docs/flavor/things_you_should_do_soon.diviner
--- a/src/docs/flavor/things_you_should_do_soon.diviner
+++ b/src/docs/flavor/things_you_should_do_soon.diviner
@@ -1,8 +1,8 @@
@title Things You Should Do Soon
@group sundry
-Describes things you should start thinking about soon, because scaling will
-be easier if you put a plan in place.
+Describes things you should start thinking about soon, because scaling will be
+easier if you put a plan in place.
= Overview =
diff --git a/src/docs/tech/celerity.diviner b/src/docs/tech/celerity.diviner
--- a/src/docs/tech/celerity.diviner
+++ b/src/docs/tech/celerity.diviner
@@ -54,9 +54,8 @@
neessary preprocessing. It uses @{class:CelerityResourceMap} to locate resources
and read packaging rules.
-The dependency and packaging maps are generated by
-##bin/celerity map##, which updates
-##resources/celerity/map.php##..
+The dependency and packaging maps are generated by ##bin/celerity map##,
+which updates ##resources/celerity/map.php##.
@{class:CelerityStaticResourceResponse} also manages some Javelin information,
and @{function:celerity_generate_unique_node_id} uses this metadata to provide
diff --git a/src/docs/user/userguide/events.diviner b/src/docs/user/userguide/events.diviner
--- a/src/docs/user/userguide/events.diviner
+++ b/src/docs/user/userguide/events.diviner
@@ -188,7 +188,7 @@
`PhabricatorEventType::TYPE_DIFFERENTIAL_WILLMARKGENERATED`.
This event is dispatched before Differential decides if a file is generated (and
-doesn't need to be reviewed) or not. Data available on this event:
+doesn't need to be reviewed) or not. Data available on this event:
- ##corpus## Body of the file.
- ##is_generated## Boolean indicating if this file should be treated as
diff --git a/src/docs/user/userguide/jump.diviner b/src/docs/user/userguide/jump.diviner
--- a/src/docs/user/userguide/jump.diviner
+++ b/src/docs/user/userguide/jump.diviner
@@ -24,6 +24,5 @@
- **p** - Jump to Project
- **p Some Project** - Jump to Project: Some Project
- **s SymbolName** - Jump to Symbol SymbolName
- - **task: (new title)** - Jumps to Task Creation Page with pre-filled
- title.
+ - **task: (new title)** - Jumps to Task Creation Page with pre-filled title.
- **(default)** - Search for input.
diff --git a/src/docs/user/userguide/owners.diviner b/src/docs/user/userguide/owners.diviner
--- a/src/docs/user/userguide/owners.diviner
+++ b/src/docs/user/userguide/owners.diviner
@@ -24,7 +24,7 @@
- no revision found for the commit,
- the commit author is not recognized, or
- the author or the reviewer specified in the commits don't match the ones in
- the Differential revision
+ the Differential revision
The owners of the package can accept or specify concern for such commits by
clicking the "Audit Status" link.
diff --git a/src/docs/user/userguide/remarkup.diviner b/src/docs/user/userguide/remarkup.diviner
--- a/src/docs/user/userguide/remarkup.diviner
+++ b/src/docs/user/userguide/remarkup.diviner
@@ -556,6 +556,6 @@
= Fullscreen Mode =
-Remarkup editors provide a fullscreen composition mode. This can make it easier
+Remarkup editors provide a fullscreen composition mode. This can make it easier
to edit large blocks of text, or improve focus by removing distractions. You can
exit **Fullscreen** mode by clicking the button again or by pressing escape.
diff --git a/src/infrastructure/celerity/CelerityAPI.php b/src/infrastructure/celerity/CelerityAPI.php
--- a/src/infrastructure/celerity/CelerityAPI.php
+++ b/src/infrastructure/celerity/CelerityAPI.php
@@ -3,8 +3,6 @@
/**
* Indirection layer which provisions for a terrifying future where we need to
* build multiple resource responses per page.
- *
- * @group celerity
*/
final class CelerityAPI {
diff --git a/src/infrastructure/celerity/CelerityPhabricatorResourceController.php b/src/infrastructure/celerity/CelerityPhabricatorResourceController.php
--- a/src/infrastructure/celerity/CelerityPhabricatorResourceController.php
+++ b/src/infrastructure/celerity/CelerityPhabricatorResourceController.php
@@ -2,10 +2,8 @@
/**
* Delivers CSS and JS resources to the browser. This controller handles all
- * ##/res/## requests, and manages caching, package construction, and resource
+ * `/res/` requests, and manages caching, package construction, and resource
* preprocessing.
- *
- * @group celerity
*/
final class CelerityPhabricatorResourceController
extends CelerityResourceController {
diff --git a/src/infrastructure/celerity/CelerityResourceTransformer.php b/src/infrastructure/celerity/CelerityResourceTransformer.php
--- a/src/infrastructure/celerity/CelerityResourceTransformer.php
+++ b/src/infrastructure/celerity/CelerityResourceTransformer.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group celerity
- */
final class CelerityResourceTransformer {
private $minify;
@@ -346,7 +343,6 @@
* @return string|null Data URI, or null if we declined to generate one.
*/
private function generateDataURI($resource_name) {
-
$ext = last(explode('.', $resource_name));
switch ($ext) {
case 'png':
@@ -380,5 +376,4 @@
return $uri;
}
-
}
diff --git a/src/infrastructure/celerity/CelerityStaticResourceResponse.php b/src/infrastructure/celerity/CelerityStaticResourceResponse.php
--- a/src/infrastructure/celerity/CelerityStaticResourceResponse.php
+++ b/src/infrastructure/celerity/CelerityStaticResourceResponse.php
@@ -4,8 +4,6 @@
* Tracks and resolves dependencies the page declares with
* @{function:require_celerity_resource}, and then builds appropriate HTML or
* Ajax responses.
- *
- * @group celerity
*/
final class CelerityStaticResourceResponse {
diff --git a/src/infrastructure/celerity/__tests__/CelerityResourceTransformerTestCase.php b/src/infrastructure/celerity/__tests__/CelerityResourceTransformerTestCase.php
--- a/src/infrastructure/celerity/__tests__/CelerityResourceTransformerTestCase.php
+++ b/src/infrastructure/celerity/__tests__/CelerityResourceTransformerTestCase.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group celerity
- */
final class CelerityResourceTransformerTestCase extends PhabricatorTestCase {
public function testTransformation() {
diff --git a/src/infrastructure/celerity/api.php b/src/infrastructure/celerity/api.php
--- a/src/infrastructure/celerity/api.php
+++ b/src/infrastructure/celerity/api.php
@@ -12,8 +12,6 @@
* @param string Name of the celerity module to include. This is whatever you
* annotated as "@provides" in the file.
* @return void
- *
- * @group celerity
*/
function require_celerity_resource($symbol, $source_name = 'phabricator') {
$response = CelerityAPI::getStaticResourceResponse();
@@ -29,8 +27,6 @@
* @return string A string appropriate for use as an 'id' attribute on a DOM
* node. It is guaranteed to be unique for the current page, even
* if the current request is a subsequent Ajax request.
- *
- * @group celerity
*/
function celerity_generate_unique_node_id() {
static $uniq = 0;
@@ -46,8 +42,6 @@
*
* @param string Path to the raw image.
* @return string Versioned path to the image, if one is available.
- *
- * @group celerity
*/
function celerity_get_resource_uri($resource, $source = 'phabricator') {
$resource = ltrim($resource, '/');
diff --git a/src/infrastructure/daemon/bot/PhabricatorBot.php b/src/infrastructure/daemon/bot/PhabricatorBot.php
--- a/src/infrastructure/daemon/bot/PhabricatorBot.php
+++ b/src/infrastructure/daemon/bot/PhabricatorBot.php
@@ -7,8 +7,6 @@
* script system interactions and integrate with other systems.
*
* NOTE: This is super janky and experimental right now.
- *
- * @group irc
*/
final class PhabricatorBot extends PhabricatorDaemon {
diff --git a/src/infrastructure/daemon/bot/handler/PhabricatorBotFeedNotificationHandler.php b/src/infrastructure/daemon/bot/handler/PhabricatorBotFeedNotificationHandler.php
--- a/src/infrastructure/daemon/bot/handler/PhabricatorBotFeedNotificationHandler.php
+++ b/src/infrastructure/daemon/bot/handler/PhabricatorBotFeedNotificationHandler.php
@@ -1,9 +1,7 @@
<?php
/**
- * Watches the feed and puts notifications into channel(s) of choice
- *
- * @group irc
+ * Watches the feed and puts notifications into channel(s) of choice.
*/
final class PhabricatorBotFeedNotificationHandler
extends PhabricatorBotHandler {
@@ -33,48 +31,47 @@
switch ($verbosity) {
case 2:
$verbs[] = array(
- 'commented',
- 'added',
- 'changed',
- 'resigned',
- 'explained',
- 'modified',
- 'attached',
- 'edited',
- 'joined',
- 'left',
- 'removed'
- );
+ 'commented',
+ 'added',
+ 'changed',
+ 'resigned',
+ 'explained',
+ 'modified',
+ 'attached',
+ 'edited',
+ 'joined',
+ 'left',
+ 'removed',
+ );
// fallthrough
case 1:
$verbs[] = array(
- 'updated',
- 'accepted',
- 'requested',
- 'planned',
- 'claimed',
- 'summarized',
- 'commandeered',
- 'assigned'
- );
+ 'updated',
+ 'accepted',
+ 'requested',
+ 'planned',
+ 'claimed',
+ 'summarized',
+ 'commandeered',
+ 'assigned',
+ );
// fallthrough
case 0:
$verbs[] = array(
- 'created',
- 'closed',
- 'raised',
- 'committed',
- 'abandoned',
- 'reclaimed',
- 'reopened',
- 'deleted'
- );
- break;
+ 'created',
+ 'closed',
+ 'raised',
+ 'committed',
+ 'abandoned',
+ 'reclaimed',
+ 'reopened',
+ 'deleted',
+ );
+ break;
case 3:
default:
return true;
- break;
}
$verbs = '/('.implode('|', array_mergev($verbs)).')/';
@@ -92,10 +89,10 @@
public function runBackgroundTasks() {
if ($this->startupDelay > 0) {
- // the event loop runs every 1s so delay enough to fully conenct
- $this->startupDelay--;
+ // the event loop runs every 1s so delay enough to fully conenct
+ $this->startupDelay--;
- return;
+ return;
}
if ($this->lastSeenChronoKey == 0) {
// Since we only want to post notifications about new stories, skip
diff --git a/src/infrastructure/daemon/bot/handler/PhabricatorBotHandler.php b/src/infrastructure/daemon/bot/handler/PhabricatorBotHandler.php
--- a/src/infrastructure/daemon/bot/handler/PhabricatorBotHandler.php
+++ b/src/infrastructure/daemon/bot/handler/PhabricatorBotHandler.php
@@ -3,8 +3,6 @@
/**
* Responds to IRC messages. You plug a bunch of these into a
* @{class:PhabricatorBot} to give it special behavior.
- *
- * @group irc
*/
abstract class PhabricatorBotHandler {
@@ -70,4 +68,5 @@
return $this->writeMessage($reply);
}
+
}
diff --git a/src/infrastructure/daemon/bot/handler/PhabricatorBotLogHandler.php b/src/infrastructure/daemon/bot/handler/PhabricatorBotLogHandler.php
--- a/src/infrastructure/daemon/bot/handler/PhabricatorBotLogHandler.php
+++ b/src/infrastructure/daemon/bot/handler/PhabricatorBotLogHandler.php
@@ -2,15 +2,12 @@
/**
* Logs chatter.
- *
- * @group irc
*/
final class PhabricatorBotLogHandler extends PhabricatorBotHandler {
private $futures = array();
public function receiveMessage(PhabricatorBotMessage $message) {
-
switch ($message->getCommand()) {
case 'MESSAGE':
$target = $message->getTarget();
diff --git a/src/infrastructure/daemon/bot/handler/PhabricatorBotMacroHandler.php b/src/infrastructure/daemon/bot/handler/PhabricatorBotMacroHandler.php
--- a/src/infrastructure/daemon/bot/handler/PhabricatorBotMacroHandler.php
+++ b/src/infrastructure/daemon/bot/handler/PhabricatorBotMacroHandler.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group irc
- */
final class PhabricatorBotMacroHandler extends PhabricatorBotHandler {
private $macros;
diff --git a/src/infrastructure/daemon/bot/handler/PhabricatorBotObjectNameHandler.php b/src/infrastructure/daemon/bot/handler/PhabricatorBotObjectNameHandler.php
--- a/src/infrastructure/daemon/bot/handler/PhabricatorBotObjectNameHandler.php
+++ b/src/infrastructure/daemon/bot/handler/PhabricatorBotObjectNameHandler.php
@@ -2,8 +2,6 @@
/**
* Looks for Dxxxx, Txxxx and links to them.
- *
- * @group irc
*/
final class PhabricatorBotObjectNameHandler extends PhabricatorBotHandler {
@@ -14,183 +12,182 @@
private $recentlyMentioned = array();
public function receiveMessage(PhabricatorBotMessage $original_message) {
-
switch ($original_message->getCommand()) {
- case 'MESSAGE':
- $message = $original_message->getBody();
- $matches = null;
-
- $paste_ids = array();
- $commit_names = array();
- $vote_ids = array();
- $file_ids = array();
- $object_names = array();
- $output = array();
-
- $pattern =
- '@'.
- '(?<!/)(?:^|\b)'.
- '(R2D2)'.
- '(?:\b|$)'.
- '@';
-
- if (preg_match_all($pattern, $message, $matches, PREG_SET_ORDER)) {
- foreach ($matches as $match) {
- switch ($match[1]) {
- case 'R2D2':
- $output[$match[1]] = pht('beep hoop bop');
- break;
+ case 'MESSAGE':
+ $message = $original_message->getBody();
+ $matches = null;
+
+ $paste_ids = array();
+ $commit_names = array();
+ $vote_ids = array();
+ $file_ids = array();
+ $object_names = array();
+ $output = array();
+
+ $pattern =
+ '@'.
+ '(?<!/)(?:^|\b)'.
+ '(R2D2)'.
+ '(?:\b|$)'.
+ '@';
+
+ if (preg_match_all($pattern, $message, $matches, PREG_SET_ORDER)) {
+ foreach ($matches as $match) {
+ switch ($match[1]) {
+ case 'R2D2':
+ $output[$match[1]] = pht('beep hoop bop');
+ break;
+ }
}
}
- }
-
- $pattern =
- '@'.
- '(?<!/)(?:^|\b)'. // Negative lookbehind prevent matching "/D123".
- '([A-Z])(\d+)'.
- '(?:\b|$)'.
- '@';
-
- if (preg_match_all($pattern, $message, $matches, PREG_SET_ORDER)) {
- foreach ($matches as $match) {
- switch ($match[1]) {
- case 'P':
- $paste_ids[] = $match[2];
- break;
- case 'V':
- $vote_ids[] = $match[2];
- break;
- case 'F':
- $file_ids[] = $match[2];
- break;
- default:
- $name = $match[1].$match[2];
- switch ($name) {
- case 'T1000':
- $output[$name] = pht(
- 'T1000: A mimetic poly-alloy assassin controlled by '.
- 'Skynet');
- break;
- default:
- $object_names[] = $name;
- break;
- }
- break;
+
+ $pattern =
+ '@'.
+ '(?<!/)(?:^|\b)'. // Negative lookbehind prevent matching "/D123".
+ '([A-Z])(\d+)'.
+ '(?:\b|$)'.
+ '@';
+
+ if (preg_match_all($pattern, $message, $matches, PREG_SET_ORDER)) {
+ foreach ($matches as $match) {
+ switch ($match[1]) {
+ case 'P':
+ $paste_ids[] = $match[2];
+ break;
+ case 'V':
+ $vote_ids[] = $match[2];
+ break;
+ case 'F':
+ $file_ids[] = $match[2];
+ break;
+ default:
+ $name = $match[1].$match[2];
+ switch ($name) {
+ case 'T1000':
+ $output[$name] = pht(
+ 'T1000: A mimetic poly-alloy assassin controlled by '.
+ 'Skynet');
+ break;
+ default:
+ $object_names[] = $name;
+ break;
+ }
+ break;
+ }
}
}
- }
-
- $pattern =
- '@'.
- '(?<!/)(?:^|\b)'.
- '(r[A-Z]+)([0-9a-z]{0,40})'.
- '(?:\b|$)'.
- '@';
- if (preg_match_all($pattern, $message, $matches, PREG_SET_ORDER)) {
- foreach ($matches as $match) {
- if ($match[2]) {
- $commit_names[] = $match[1].$match[2];
- } else {
- $object_names[] = $match[1];
+
+ $pattern =
+ '@'.
+ '(?<!/)(?:^|\b)'.
+ '(r[A-Z]+)([0-9a-z]{0,40})'.
+ '(?:\b|$)'.
+ '@';
+ if (preg_match_all($pattern, $message, $matches, PREG_SET_ORDER)) {
+ foreach ($matches as $match) {
+ if ($match[2]) {
+ $commit_names[] = $match[1].$match[2];
+ } else {
+ $object_names[] = $match[1];
+ }
}
}
- }
-
- if ($object_names) {
- $objects = $this->getConduit()->callMethodSynchronous(
- 'phid.lookup',
- array(
- 'names' => $object_names,
- ));
- foreach ($objects as $object) {
- $output[$object['phid']] = $object['fullName'].' - '.$object['uri'];
- }
- }
- if ($vote_ids) {
- foreach ($vote_ids as $vote_id) {
- $vote = $this->getConduit()->callMethodSynchronous(
- 'slowvote.info',
+ if ($object_names) {
+ $objects = $this->getConduit()->callMethodSynchronous(
+ 'phid.lookup',
array(
- 'poll_id' => $vote_id,
+ 'names' => $object_names,
));
- $output[$vote['phid']] = 'V'.$vote['id'].': '.$vote['question'].
- ' Come Vote '.$vote['uri'];
+ foreach ($objects as $object) {
+ $output[$object['phid']] = $object['fullName'].' - '.$object['uri'];
+ }
}
- }
- if ($file_ids) {
- foreach ($file_ids as $file_id) {
- $file = $this->getConduit()->callMethodSynchronous(
- 'file.info',
- array(
- 'id' => $file_id,
- ));
- $output[$file['phid']] = $file['objectName'].': '.$file['uri'].' - '.
- $file['name'];
+ if ($vote_ids) {
+ foreach ($vote_ids as $vote_id) {
+ $vote = $this->getConduit()->callMethodSynchronous(
+ 'slowvote.info',
+ array(
+ 'poll_id' => $vote_id,
+ ));
+ $output[$vote['phid']] = 'V'.$vote['id'].': '.$vote['question'].
+ ' Come Vote '.$vote['uri'];
+ }
}
- }
- if ($paste_ids) {
- foreach ($paste_ids as $paste_id) {
- $paste = $this->getConduit()->callMethodSynchronous(
- 'paste.info',
- array(
- 'paste_id' => $paste_id,
- ));
- // Eventually I'd like to show the username of the paster as well,
- // however that will need something like a user.username_from_phid
- // since we (ideally) want to keep the bot to Conduit calls...and
- // not call to Phabricator-specific stuff (like actually loading
- // the User object and fetching his/her username.)
- $output[$paste['phid']] = 'P'.$paste['id'].': '.$paste['uri'].' - '.
- $paste['title'];
-
- if ($paste['language']) {
- $output[$paste['phid']] .= ' ('.$paste['language'].')';
+ if ($file_ids) {
+ foreach ($file_ids as $file_id) {
+ $file = $this->getConduit()->callMethodSynchronous(
+ 'file.info',
+ array(
+ 'id' => $file_id,
+ ));
+ $output[$file['phid']] = $file['objectName'].': '.$file['uri'].' - '.
+ $file['name'];
}
}
- }
-
- if ($commit_names) {
- $commits = $this->getConduit()->callMethodSynchronous(
- 'diffusion.getcommits',
- array(
- 'commits' => $commit_names,
- ));
- foreach ($commits as $commit) {
- if (isset($commit['error'])) {
- continue;
+
+ if ($paste_ids) {
+ foreach ($paste_ids as $paste_id) {
+ $paste = $this->getConduit()->callMethodSynchronous(
+ 'paste.info',
+ array(
+ 'paste_id' => $paste_id,
+ ));
+ // Eventually I'd like to show the username of the paster as well,
+ // however that will need something like a user.username_from_phid
+ // since we (ideally) want to keep the bot to Conduit calls...and
+ // not call to Phabricator-specific stuff (like actually loading
+ // the User object and fetching his/her username.)
+ $output[$paste['phid']] = 'P'.$paste['id'].': '.$paste['uri'].' - '.
+ $paste['title'];
+
+ if ($paste['language']) {
+ $output[$paste['phid']] .= ' ('.$paste['language'].')';
+ }
}
- $output[$commit['commitPHID']] = $commit['uri'];
}
- }
- foreach ($output as $phid => $description) {
+ if ($commit_names) {
+ $commits = $this->getConduit()->callMethodSynchronous(
+ 'diffusion.getcommits',
+ array(
+ 'commits' => $commit_names,
+ ));
+ foreach ($commits as $commit) {
+ if (isset($commit['error'])) {
+ continue;
+ }
+ $output[$commit['commitPHID']] = $commit['uri'];
+ }
+ }
- // Don't mention the same object more than once every 10 minutes
- // in public channels, so we avoid spamming the chat over and over
- // again for discsussions of a specific revision, for example.
+ foreach ($output as $phid => $description) {
- $target_name = $original_message->getTarget()->getName();
- if (empty($this->recentlyMentioned[$target_name])) {
- $this->recentlyMentioned[$target_name] = array();
- }
+ // Don't mention the same object more than once every 10 minutes
+ // in public channels, so we avoid spamming the chat over and over
+ // again for discsussions of a specific revision, for example.
- $quiet_until = idx(
- $this->recentlyMentioned[$target_name],
- $phid,
- 0) + (60 * 10);
+ $target_name = $original_message->getTarget()->getName();
+ if (empty($this->recentlyMentioned[$target_name])) {
+ $this->recentlyMentioned[$target_name] = array();
+ }
- if (time() < $quiet_until) {
- // Remain quiet on this channel.
- continue;
- }
+ $quiet_until = idx(
+ $this->recentlyMentioned[$target_name],
+ $phid,
+ 0) + (60 * 10);
- $this->recentlyMentioned[$target_name][$phid] = time();
- $this->replyTo($original_message, $description);
- }
- break;
+ if (time() < $quiet_until) {
+ // Remain quiet on this channel.
+ continue;
+ }
+
+ $this->recentlyMentioned[$target_name][$phid] = time();
+ $this->replyTo($original_message, $description);
+ }
+ break;
}
}
diff --git a/src/infrastructure/daemon/bot/handler/PhabricatorBotSymbolHandler.php b/src/infrastructure/daemon/bot/handler/PhabricatorBotSymbolHandler.php
--- a/src/infrastructure/daemon/bot/handler/PhabricatorBotSymbolHandler.php
+++ b/src/infrastructure/daemon/bot/handler/PhabricatorBotSymbolHandler.php
@@ -2,48 +2,45 @@
/**
* Watches for "where is <symbol>?"
- *
- * @group irc
*/
final class PhabricatorBotSymbolHandler extends PhabricatorBotHandler {
public function receiveMessage(PhabricatorBotMessage $message) {
-
switch ($message->getCommand()) {
- case 'MESSAGE':
- $text = $message->getBody();
-
- $matches = null;
- if (!preg_match('/where(?: in the world)? is (\S+?)\?/i',
- $text, $matches)) {
- break;
+ case 'MESSAGE':
+ $text = $message->getBody();
+
+ $matches = null;
+ if (!preg_match('/where(?: in the world)? is (\S+?)\?/i',
+ $text, $matches)) {
+ break;
+ }
+
+ $symbol = $matches[1];
+ $results = $this->getConduit()->callMethodSynchronous(
+ 'diffusion.findsymbols',
+ array(
+ 'name' => $symbol,
+ ));
+
+ $default_uri = $this->getURI('/diffusion/symbol/'.$symbol.'/');
+
+ if (count($results) > 1) {
+ $response = "Multiple symbols named '{$symbol}': {$default_uri}";
+ } else if (count($results) == 1) {
+ $result = head($results);
+ $response =
+ $result['type'].' '.
+ $result['name'].' '.
+ '('.$result['language'].'): '.
+ nonempty($result['uri'], $default_uri);
+ } else {
+ $response = "No symbol '{$symbol}' found anywhere.";
}
- $symbol = $matches[1];
- $results = $this->getConduit()->callMethodSynchronous(
- 'diffusion.findsymbols',
- array(
- 'name' => $symbol,
- ));
-
- $default_uri = $this->getURI('/diffusion/symbol/'.$symbol.'/');
-
- if (count($results) > 1) {
- $response = "Multiple symbols named '{$symbol}': {$default_uri}";
- } else if (count($results) == 1) {
- $result = head($results);
- $response =
- $result['type'].' '.
- $result['name'].' '.
- '('.$result['language'].'): '.
- nonempty($result['uri'], $default_uri);
- } else {
- $response = "No symbol '{$symbol}' found anywhere.";
- }
-
- $this->replyTo($message, $response);
-
- break;
+ $this->replyTo($message, $response);
+
+ break;
}
}
diff --git a/src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php b/src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php
--- a/src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php
+++ b/src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php
@@ -2,8 +2,6 @@
/**
* Responds to "Whats new?" with some recent feed content
- *
- * @group irc
*/
final class PhabricatorBotWhatsNewHandler extends PhabricatorBotHandler {
diff --git a/src/infrastructure/daemon/workers/PhabricatorWorker.php b/src/infrastructure/daemon/workers/PhabricatorWorker.php
--- a/src/infrastructure/daemon/workers/PhabricatorWorker.php
+++ b/src/infrastructure/daemon/workers/PhabricatorWorker.php
@@ -2,8 +2,6 @@
/**
* @task config Configuring Retries and Failures
- *
- * @group worker
*/
abstract class PhabricatorWorker {
@@ -215,7 +213,7 @@
/**
- * Queue a task to be executed after this one suceeds.
+ * Queue a task to be executed after this one succeeds.
*
* The followup task will be queued only if this task completes cleanly.
*
diff --git a/src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php b/src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php
--- a/src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php
+++ b/src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php
@@ -2,8 +2,6 @@
/**
* Select and lease tasks from the worker task queue.
- *
- * @group worker
*/
final class PhabricatorWorkerLeaseQuery extends PhabricatorQuery {
diff --git a/src/infrastructure/events/PhabricatorEvent.php b/src/infrastructure/events/PhabricatorEvent.php
--- a/src/infrastructure/events/PhabricatorEvent.php
+++ b/src/infrastructure/events/PhabricatorEvent.php
@@ -1,9 +1,5 @@
<?php
-
-/**
- * @group events
- */
final class PhabricatorEvent extends PhutilEvent {
private $user;
diff --git a/src/infrastructure/events/PhabricatorExampleEventListener.php b/src/infrastructure/events/PhabricatorExampleEventListener.php
--- a/src/infrastructure/events/PhabricatorExampleEventListener.php
+++ b/src/infrastructure/events/PhabricatorExampleEventListener.php
@@ -3,15 +3,12 @@
/**
* Example event listener. For details about installing Phabricator event hooks,
* refer to @{article:Events User Guide: Installing Event Listeners}.
- *
- * @group events
*/
final class PhabricatorExampleEventListener extends PhabricatorEventListener {
public function register() {
// When your listener is installed, its register() method will be called.
// You should listen() to any events you are interested in here.
-
$this->listen(PhabricatorEventType::TYPE_TEST_DIDRUNTEST);
}
diff --git a/src/infrastructure/events/constant/PhabricatorEventType.php b/src/infrastructure/events/constant/PhabricatorEventType.php
--- a/src/infrastructure/events/constant/PhabricatorEventType.php
+++ b/src/infrastructure/events/constant/PhabricatorEventType.php
@@ -3,8 +3,6 @@
/**
* For detailed explanations of these events, see
* @{article:Events User Guide: Installing Event Listeners}.
- *
- * @group events
*/
final class PhabricatorEventType extends PhutilEventType {
diff --git a/src/infrastructure/markup/PhabricatorMarkupInterface.php b/src/infrastructure/markup/PhabricatorMarkupInterface.php
--- a/src/infrastructure/markup/PhabricatorMarkupInterface.php
+++ b/src/infrastructure/markup/PhabricatorMarkupInterface.php
@@ -14,8 +14,6 @@
* these cases, the implementation can largely ignore the `$field` parameter.
*
* @task markup Markup Interface
- *
- * @group markup
*/
interface PhabricatorMarkupInterface {
@@ -26,7 +24,7 @@
/**
* Get a key to identify this field. This should uniquely identify the block
* of text to be rendered and be usable as a cache key. If the object has a
- * PHID, using the PHID and the field name is likley reasonable:
+ * PHID, using the PHID and the field name is likely reasonable:
*
* "{$phid}:{$field}"
*
diff --git a/src/infrastructure/markup/PhabricatorSyntaxHighlighter.php b/src/infrastructure/markup/PhabricatorSyntaxHighlighter.php
--- a/src/infrastructure/markup/PhabricatorSyntaxHighlighter.php
+++ b/src/infrastructure/markup/PhabricatorSyntaxHighlighter.php
@@ -1,8 +1,5 @@
<?php
-/**
- * @group markup
- */
final class PhabricatorSyntaxHighlighter {
public static function newEngine() {
@@ -31,5 +28,4 @@
return $engine->highlightSource($language, $source);
}
-
}
diff --git a/src/infrastructure/markup/rule/PhabricatorRemarkupRuleYoutube.php b/src/infrastructure/markup/rule/PhabricatorRemarkupRuleYoutube.php
--- a/src/infrastructure/markup/rule/PhabricatorRemarkupRuleYoutube.php
+++ b/src/infrastructure/markup/rule/PhabricatorRemarkupRuleYoutube.php
@@ -1,10 +1,6 @@
<?php
-/**
- * @group markup
- */
-final class PhabricatorRemarkupRuleYoutube
- extends PhutilRemarkupRule {
+final class PhabricatorRemarkupRuleYoutube extends PhutilRemarkupRule {
public function getPriority() {
return 350.0;
diff --git a/src/infrastructure/storage/lisk/LiskDAO.php b/src/infrastructure/storage/lisk/LiskDAO.php
--- a/src/infrastructure/storage/lisk/LiskDAO.php
+++ b/src/infrastructure/storage/lisk/LiskDAO.php
@@ -93,7 +93,7 @@
*
* $dog = id(new Dog())->load($id);
*
- * This will load the Dog record with ID $id into $dog, or ##null## if no such
+ * This will load the Dog record with ID $id into $dog, or `null` if no such
* record exists (@{method:load} is an instance method rather than a static
* method because PHP does not support late static binding, at least until PHP
* 5.3).
@@ -161,8 +161,6 @@
* @task util Utilities
* @task xaction Managing Transactions
* @task isolate Isolation for Unit Testing
- *
- * @group storage
*/
abstract class LiskDAO {
@@ -464,7 +462,7 @@
*
* @task load
*/
- public function loadAllWhere($pattern/* , $arg, $arg, $arg ... */) {
+ public function loadAllWhere($pattern /* , $arg, $arg, $arg ... */) {
$args = func_get_args();
array_unshift($args, null);
$data = call_user_func_array(
@@ -484,7 +482,7 @@
*
* @task load
*/
- public function loadColumnsWhere(array $columns, $pattern/* , $args... */) {
+ public function loadColumnsWhere(array $columns, $pattern /* , $args... */) {
if (!$this->getConfigOption(self::CONFIG_PARTIAL_OBJECTS)) {
throw new BadMethodCallException(
'This class does not support partial objects.');
@@ -499,7 +497,7 @@
/**
* Load a single object identified by a 'WHERE' clause. You provide
- * everything after the 'WHERE', and Lisk builds the first half of the
+ * everything after the 'WHERE', and Lisk builds the first half of the
* query. See loadAllWhere(). This method is similar, but returns a single
* result instead of a list.
*
@@ -509,7 +507,7 @@
*
* @task load
*/
- public function loadOneWhere($pattern/* , $arg, $arg, $arg ... */) {
+ public function loadOneWhere($pattern /* , $arg, $arg, $arg ... */) {
$args = func_get_args();
array_unshift($args, null);
$data = call_user_func_array(
@@ -530,7 +528,7 @@
}
- protected function loadRawDataWhere($columns, $pattern/* , $args... */) {
+ protected function loadRawDataWhere($columns, $pattern /* , $args... */) {
$connection = $this->establishConnection('r');
$lock_clause = '';
@@ -579,7 +577,6 @@
* @task load
*/
public function reload() {
-
if (!$this->getID()) {
throw new Exception("Unable to reload object that hasn't been loaded!");
}
@@ -601,10 +598,11 @@
* Initialize this object's properties from a dictionary. Generally, you
* load single objects with loadOneWhere(), but sometimes it may be more
* convenient to pull data from elsewhere directly (e.g., a complicated
- * join via queryData()) and then load from an array representation.
+ * join via @{method:queryData}) and then load from an array representation.
*
* @param dict Dictionary of properties, which should be equivalent to
- * selecting a row from the table or calling getProperties().
+ * selecting a row from the table or calling
+ * @{method:getProperties}.
* @return this
*
* @task load
@@ -654,9 +652,9 @@
/**
* Initialize a list of objects from a list of dictionaries. Usually you
- * load lists of objects with loadAllWhere(), but sometimes that isn't
- * flexible enough. One case is if you need to do joins to select the right
- * objects:
+ * load lists of objects with @{method:loadAllWhere}, but sometimes that
+ * isn't flexible enough. One case is if you need to do joins to select the
+ * right objects:
*
* function loadAllWithOwner($owner) {
* $data = $this->queryData(
@@ -669,7 +667,7 @@
* return $this->loadAllFromArray($data);
* }
*
- * This is a lot messier than loadAllWhere(), but more flexible.
+ * This is a lot messier than @{method:loadAllWhere}, but more flexible.
*
* @param list List of property dictionaries.
* @return dict List of constructed objects, keyed on ID.
@@ -1044,9 +1042,9 @@
/**
* Convert this object into a property dictionary. This dictionary can be
- * restored into an object by using loadFromArray() (unless you're using
- * legacy features with CONFIG_CONVERT_CAMELCASE, but in that case you should
- * just go ahead and die in a fire).
+ * restored into an object by using @{method:loadFromArray} (unless you're
+ * using legacy features with CONFIG_CONVERT_CAMELCASE, but in that case you
+ * should just go ahead and die in a fire).
*
* @return dict Dictionary of object properties.
*
@@ -1370,7 +1368,7 @@
/**
* Hook to apply serialization or validation to data before it is written to
- * the database. See also willReadData().
+ * the database. See also @{method:willReadData}.
*
* @task hook
*/
@@ -1411,7 +1409,7 @@
/**
* Hook to apply serialization or validation to data as it is read from the
- * database. See also willWriteData().
+ * database. See also @{method:willWriteData}.
*
* @task hook
*/
@@ -1442,7 +1440,7 @@
/**
* Reads the value from a field. Override this method for custom behavior
- * of getField() instead of overriding getField directly.
+ * of @{method:getField} instead of overriding getField directly.
*
* @param string Canonical field name
* @return mixed Value of the field
@@ -1706,7 +1704,6 @@
* @task util
*/
public function __call($method, $args) {
-
// NOTE: PHP has a bug that static variables defined in __call() are shared
// across all children classes. Call a different method to work around this
// bug.
diff --git a/webroot/rsrc/externals/javelin/core/Event.js b/webroot/rsrc/externals/javelin/core/Event.js
--- a/webroot/rsrc/externals/javelin/core/Event.js
+++ b/webroot/rsrc/externals/javelin/core/Event.js
@@ -21,7 +21,6 @@
*
* @task stop Stopping Event Behaviors
* @task info Getting Event Information
- * @group event
*/
JX.install('Event', {
members : {
@@ -211,7 +210,7 @@
/**
* Get the metadata associated with the node that corresponds to the key
- * in this event's node map. This is a simple helper method that makes
+ * in this event's node map. This is a simple helper method that makes
* the API for accessing metadata associated with specific nodes less ugly.
*
* JX.Stratcom.listen('click', 'tag:a', function(event) {
diff --git a/webroot/rsrc/externals/javelin/core/Stratcom.js b/webroot/rsrc/externals/javelin/core/Stratcom.js
--- a/webroot/rsrc/externals/javelin/core/Stratcom.js
+++ b/webroot/rsrc/externals/javelin/core/Stratcom.js
@@ -31,7 +31,6 @@
* @task sigil Managing Sigils
* @task meta Managing Metadata
* @task internal Internals
- * @group event
*/
JX.install('Stratcom', {
statics : {
diff --git a/webroot/rsrc/externals/javelin/core/install.js b/webroot/rsrc/externals/javelin/core/install.js
--- a/webroot/rsrc/externals/javelin/core/install.js
+++ b/webroot/rsrc/externals/javelin/core/install.js
@@ -77,8 +77,6 @@
* "namespace" (e.g., JX.Pancake).
* @param map Map of properties, see method documentation.
* @return void
- *
- * @group install
*/
JX.install = function(new_name, new_junk) {
@@ -157,8 +155,6 @@
*
* @param junk Map of properties, see method documentation.
* @return function Constructor of a class created
- *
- * @group install
*/
JX.createClass = function(junk) {
var name = junk.name || '';
diff --git a/webroot/rsrc/externals/javelin/core/util.js b/webroot/rsrc/externals/javelin/core/util.js
--- a/webroot/rsrc/externals/javelin/core/util.js
+++ b/webroot/rsrc/externals/javelin/core/util.js
@@ -22,8 +22,6 @@
* Throw an exception and attach the caller data in the exception.
*
* @param string Exception message.
- *
- * @group util
*/
JX.$E = function(message) {
var e = new Error(message);
@@ -45,8 +43,6 @@
*
* @param obj Array, or array-like object.
* @return Array Actual array.
- *
- * @group util
*/
JX.$A = function(object) {
// IE8 throws "JScript object expected" when trying to call
@@ -77,8 +73,6 @@
* @param wild Scalar or Array.
* @return Array If the argument was a scalar, an Array with the argument as
* its only element. Otherwise, the original Array.
- *
- * @group util
*/
JX.$AX = function(maybe_scalar) {
return JX.isArray(maybe_scalar) ? maybe_scalar : [maybe_scalar];
@@ -93,8 +87,6 @@
*
* @param wild Any value.
* @return bool true if the argument is an array, false otherwise.
- *
- * @group util
*/
JX.isArray = Array.isArray || function(maybe_array) {
return Object.prototype.toString.call(maybe_array) == '[object Array]';
@@ -132,8 +124,6 @@
* @param obj Destination object, which properties should be copied to.
* @param obj Source object, which properties should be copied from.
* @return obj Modified destination object.
- *
- * @group util
*/
JX.copy = function(copy_dst, copy_src) {
for (var k in copy_src) {
@@ -227,8 +217,6 @@
* @param ... Zero or more arguments to bind.
* @return function New function which invokes the original function with
* bound context and arguments when called.
- *
- * @group util
*/
JX.bind = function(context, func, more) {
if (__DEV__) {
@@ -256,8 +244,6 @@
* actually have an effect.
*
* @return void
- *
- * @group util
*/
JX.bag = function() {
// \o\ \o/ /o/ woo dance party
@@ -271,8 +257,6 @@
*
* @param obj Object to retrieve keys from.
* @return list List of keys.
- *
- * @group util
*/
JX.keys = Object.keys || function(obj) {
var r = [];
@@ -289,8 +273,6 @@
*
* @param wild Any value.
* @return wild The passed argument.
- *
- * @group util
*/
JX.id = function(any) {
return any;
@@ -314,8 +296,6 @@
*
* @param string Message to print to the browser debugging console.
* @return void
- *
- * @group util
*/
JX.log = function(message) {
window.console.log(message);
diff --git a/webroot/rsrc/externals/javelin/docs/Base.js b/webroot/rsrc/externals/javelin/docs/Base.js
--- a/webroot/rsrc/externals/javelin/docs/Base.js
+++ b/webroot/rsrc/externals/javelin/docs/Base.js
@@ -8,7 +8,6 @@
* which exist on all Javelin classes. This class documents those methods.
*
* @task events Builtin Events
- * @group install
*/
JX.install('Base', {
members : {
diff --git a/webroot/rsrc/externals/javelin/docs/onload.js b/webroot/rsrc/externals/javelin/docs/onload.js
--- a/webroot/rsrc/externals/javelin/docs/onload.js
+++ b/webroot/rsrc/externals/javelin/docs/onload.js
@@ -13,7 +13,6 @@
*
* @param function Callback function to invoke after DOMContentReady.
* @return void
- * @group util
*/
JX.onload = function(callback) {
// This isn't the real function definition, it's only defined here to let the
diff --git a/webroot/rsrc/externals/javelin/lib/DOM.js b/webroot/rsrc/externals/javelin/lib/DOM.js
--- a/webroot/rsrc/externals/javelin/lib/DOM.js
+++ b/webroot/rsrc/externals/javelin/lib/DOM.js
@@ -32,8 +32,6 @@
*
* @param string "id" attribute to select from the document.
* @return Node Node with the specified "id" attribute.
- *
- * @group dom
*/
JX.$ = function(id) {
@@ -81,8 +79,6 @@
*
* @task build String into HTML
* @task nodes HTML into Nodes
- *
- * @group dom
*/
JX.install('HTML', {
@@ -193,8 +189,6 @@
* know it is from a trusted source and any data in it has been
* properly escaped.
* @return JX.HTML HTML object, suitable for use with @{JX.$N}.
- *
- * @group dom
*/
JX.$H = function(str) {
return new JX.HTML(str);
@@ -274,8 +268,6 @@
* which may be dangerous).
* @return Node New node with whatever attributes and
* content were specified.
- *
- * @group dom
*/
JX.$N = function(tag, attr, content) {
if (typeof content == 'undefined' &&
@@ -338,8 +330,6 @@
* @task convenience Convenience Methods
* @task query Finding Nodes in the DOM
* @task view Changing View State
- *
- * @group dom
*/
JX.install('DOM', {
statics : {
diff --git a/webroot/rsrc/externals/javelin/lib/JSON.js b/webroot/rsrc/externals/javelin/lib/JSON.js
--- a/webroot/rsrc/externals/javelin/lib/JSON.js
+++ b/webroot/rsrc/externals/javelin/lib/JSON.js
@@ -21,7 +21,6 @@
*
* @task json JSON Manipulation
* @task internal Internal
- * @group util
*/
JX.install('JSON', {
statics : {
diff --git a/webroot/rsrc/externals/javelin/lib/Mask.js b/webroot/rsrc/externals/javelin/lib/Mask.js
--- a/webroot/rsrc/externals/javelin/lib/Mask.js
+++ b/webroot/rsrc/externals/javelin/lib/Mask.js
@@ -45,8 +45,6 @@
*
* The mask has sigil `jx-mask`, which can be used to intercept events
* targeting it, like clicks on the mask.
- *
- * @group control
*/
JX.install('Mask', {
statics : {
diff --git a/webroot/rsrc/externals/javelin/lib/Request.js b/webroot/rsrc/externals/javelin/lib/Request.js
--- a/webroot/rsrc/externals/javelin/lib/Request.js
+++ b/webroot/rsrc/externals/javelin/lib/Request.js
@@ -13,8 +13,6 @@
/**
* Make basic AJAX XMLHTTPRequests.
- *
- * @group workflow
*/
JX.install('Request', {
construct : function(uri, handler) {
diff --git a/webroot/rsrc/externals/javelin/lib/URI.js b/webroot/rsrc/externals/javelin/lib/URI.js
--- a/webroot/rsrc/externals/javelin/lib/URI.js
+++ b/webroot/rsrc/externals/javelin/lib/URI.js
@@ -17,8 +17,6 @@
*
* @param string Unparsed URI.
* @return @{class:JX.URI} JX.URI instance.
- *
- * @group uri
*/
JX.$U = function(uri) {
return new JX.URI(uri);
@@ -38,8 +36,6 @@
*
* uri.setFragment('clowntown');
* uri.toString() // http://www.example.com/asdf.php?a=b&c=d#clowntown
- *
- * @group uri
*/
JX.install('URI', {
statics : {
diff --git a/webroot/rsrc/externals/javelin/lib/Vector.js b/webroot/rsrc/externals/javelin/lib/Vector.js
--- a/webroot/rsrc/externals/javelin/lib/Vector.js
+++ b/webroot/rsrc/externals/javelin/lib/Vector.js
@@ -20,8 +20,6 @@
* If numeric, the x-coordinate for the new vector.
* @param number? The y-coordinate for the new vector.
* @return @{class:JX.Vector} New vector.
- *
- * @group dom
*/
JX.$V = function(x, y) {
return new JX.Vector(x, y);
@@ -75,8 +73,6 @@
* @task query Querying Positions and Dimensions
* @task update Changing Positions and Dimensions
* @task manip Manipulating Vectors
- *
- * @group dom
*/
JX.install('Vector', {
diff --git a/webroot/rsrc/externals/javelin/lib/Workflow.js b/webroot/rsrc/externals/javelin/lib/Workflow.js
--- a/webroot/rsrc/externals/javelin/lib/Workflow.js
+++ b/webroot/rsrc/externals/javelin/lib/Workflow.js
@@ -12,9 +12,6 @@
* @javelin
*/
-/**
- * @group workflow
- */
JX.install('Workflow', {
construct : function(uri, data) {
if (__DEV__) {
diff --git a/webroot/rsrc/externals/javelin/lib/behavior.js b/webroot/rsrc/externals/javelin/lib/behavior.js
--- a/webroot/rsrc/externals/javelin/lib/behavior.js
+++ b/webroot/rsrc/externals/javelin/lib/behavior.js
@@ -23,7 +23,6 @@
* @param string Behavior name.
* @param function Behavior callback/definition.
* @return void
- * @group behavior
*/
JX.behavior = function(name, control_function) {
if (__DEV__) {
@@ -76,7 +75,6 @@
* are lists of configuration dictionaries. The behavior will be
* invoked once for each configuration dictionary.
* @return void
- * @group behavior
*/
JX.initBehaviors = function(map) {
var missing_behaviors = [];
diff --git a/webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js b/webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js
--- a/webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js
+++ b/webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js
@@ -30,8 +30,6 @@
*
* When the tokenizer is focused, the CSS class `jx-tokenizer-container-focused`
* is added to the container node.
- *
- * @group control
*/
JX.install('Tokenizer', {
construct : function(containerNode) {
diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js
--- a/webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js
+++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js
@@ -32,7 +32,6 @@
* @task start Activating a Typeahead
* @task control Controlling Typeaheads from Javascript
* @task internal Internal Methods
- * @group control
*/
JX.install('Typeahead', {
/**
diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js
--- a/webroot/rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js
+++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js
@@ -4,9 +4,6 @@
* @javelin
*/
-/**
- * @group control
- */
JX.install('TypeaheadNormalizer', {
statics : {
/**
diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js
--- a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js
+++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js
@@ -6,9 +6,6 @@
* @javelin
*/
-/**
- * @group control
- */
JX.install('TypeaheadCompositeSource', {
extend : 'TypeaheadSource',
diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js
--- a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js
+++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js
@@ -7,9 +7,6 @@
* @javelin
*/
-/**
- * @group control
- */
JX.install('TypeaheadOnDemandSource', {
extend : 'TypeaheadSource',
diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js
--- a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js
+++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js
@@ -12,8 +12,6 @@
* URI. This is appropriate if the total data size is small (up to perhaps a
* few thousand items). If you have more items so you can't ship them down to
* the client in one repsonse, use @{JX.TypeaheadOnDemandSource}.
- *
- * @group control
*/
JX.install('TypeaheadPreloadedSource', {
diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js
--- a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js
+++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js
@@ -7,9 +7,6 @@
* @javelin
*/
-/**
- * @group control
- */
JX.install('TypeaheadSource', {
construct : function() {
this._raw = {};
@@ -60,7 +57,7 @@
* - **display**: the text or nodes to show in the DOM. Usually just the
* same as ##name##.
* - **tokenizable**: if you want to tokenize something other than the
- * ##name##, for the typeahead to complete on, specify it here. A
+ * ##name##, for the typeahead to complete on, specify it here. A
* selected entry from the typeahead will still insert the ##name##
* into the input, but the ##tokenizable## field lets you complete on
* non-name things.
diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js
--- a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js
+++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js
@@ -9,8 +9,6 @@
* Typeahead source that uses static data passed to the constructor. For larger
* datasets, use @{class:JX.TypeaheadPreloadedSource} or
* @{class:JX.TypeaheadOnDemandSource} to improve performance.
- *
- * @group control
*/
JX.install('TypeaheadStaticSource', {
diff --git a/webroot/rsrc/js/application/releeph/releeph-request-typeahead.js b/webroot/rsrc/js/application/releeph/releeph-request-typeahead.js
--- a/webroot/rsrc/js/application/releeph/releeph-request-typeahead.js
+++ b/webroot/rsrc/js/application/releeph/releeph-request-typeahead.js
@@ -58,7 +58,7 @@
/**
* The default normalizer removes useful control characters that would help
- * out search. For example, I was just trying to search for a commit with
+ * out search. For example, I was just trying to search for a commit with
* the string "a_file" in the message, which was normalized to "afile".
*/
datasource.setNormalizer(function(query) {
diff --git a/webroot/rsrc/js/core/behavior-toggle-class.js b/webroot/rsrc/js/core/behavior-toggle-class.js
--- a/webroot/rsrc/js/core/behavior-toggle-class.js
+++ b/webroot/rsrc/js/core/behavior-toggle-class.js
@@ -13,8 +13,6 @@
*
* Optionally, you may provide a `state` key to set the default state of the
* element.
- *
- * @group ui
*/
JX.behavior('toggle-class', function() {
JX.Stratcom.listen(

File Metadata

Mime Type
text/plain
Expires
Sun, Nov 9, 12:55 AM (4 w, 7 h ago)
Storage Engine
amazon-s3
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
phabricator/secure/sm/vw/n6b2ktkfl67ibthr
Default Alt Text
D9859.largetrue.diff (262 KB)

Event Timeline

Phabricator · Built by Phacility