ArcanistDiffParserTestCase.php
No OneTemporary
Actions

Size

14 KB

Referenced Files

None

Subscribers

None

ArcanistDiffParserTestCase.php
View Options

	<?php

	/*
	* Copyright 2011 Facebook, Inc.
	*
	* Licensed under the Apache License, Version 2.0 (the "License");
	* you may not use this file except in compliance with the License.
	* You may obtain a copy of the License at
	*
	* http://www.apache.org/licenses/LICENSE-2.0
	*
	* Unless required by applicable law or agreed to in writing, software
	* distributed under the License is distributed on an "AS IS" BASIS,
	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	* See the License for the specific language governing permissions and
	* limitations under the License.
	*/

	/**
	* Test cases for @{class:ArcanistDiffParser}.
	*
	* @group testcase
	*/
	class ArcanistDiffParserTestCase extends ArcanistPhutilTestCase {

	public function testParser() {
	$root = dirname(__FILE__).'/data/';
	foreach (Filesystem::listDirectory($root, $hidden = false) as $file) {
	$this->parseDiff($root.$file);
	}
	}

	private function parseDiff($diff_file) {
	$contents = Filesystem::readFile($diff_file);
	$file = basename($diff_file);

	$parser = new ArcanistDiffParser();
	$changes = $parser->parseDiff($contents);

	switch ($file) {
	case 'basic-missing-both-newlines-plus.udiff':
	case 'basic-missing-both-newlines.udiff':
	case 'basic-missing-new-newline-plus.udiff':
	case 'basic-missing-new-newline.udiff':
	case 'basic-missing-old-newline-plus.udiff':
	case 'basic-missing-old-newline.udiff':
	$expect_old = strpos($file, '-old-') \|\| strpos($file, '-both-');
	$expect_new = strpos($file, '-new-') \|\| strpos($file, '-both-');
	$expect_two = strpos($file, '-plus');

	$this->assertEqual(count($changes), $expect_two ? 2 : 1);
	$change = reset($changes);
	$this->assertEqual(true, $change !== null);

	$hunks = $change->getHunks();
	$this->assertEqual(1, count($hunks));

	$hunk = reset($hunks);
	$this->assertEqual((bool)$expect_old, $hunk->getIsMissingOldNewline());
	$this->assertEqual((bool)$expect_new, $hunk->getIsMissingNewNewline());
	break;
	case 'basic-binary.udiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);
	$this->assertEqual(
	ArcanistDiffChangeType::FILE_BINARY,
	$change->getFileType());
	break;
	case 'basic-multi-hunk.udiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);
	$hunks = $change->getHunks();
	$this->assertEqual(4, count($hunks));
	$this->assertEqual('right', $change->getCurrentPath());
	$this->assertEqual('left', $change->getOldPath());
	break;
	case 'basic-multi-hunk-content.svndiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);
	$hunks = $change->getHunks();
	$this->assertEqual(2, count($hunks));

	$there_is_a_literal_trailing_space_here = ' ';

	$corpus_0 = <<<EOCORPUS
	asdfasdf
	+% quack
	%
	-%
	%%
	%%
	%%%
	EOCORPUS;
	$corpus_1 = <<<EOCORPUS
	%%%%%
	%%%%%
	{$there_is_a_literal_trailing_space_here}
	-!
	+! quack
	EOCORPUS;
	$this->assertEqual(
	$corpus_0,
	$hunks[0]->getCorpus());
	$this->assertEqual(
	$corpus_1,
	$hunks[1]->getCorpus());
	break;
	case 'svn-ignore-whitespace-only.svndiff':
	$this->assertEqual(2, count($changes));
	$hunks = reset($changes)->getHunks();
	$this->assertEqual(0, count($hunks));
	break;
	case 'svn-property-add.svndiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);
	$hunks = reset($changes)->getHunks();
	$this->assertEqual(1, count($hunks));
	$this->assertEqual(
	array(
	'duck' => 'quack',
	),
	$change->getNewProperties()
	);
	break;
	case 'svn-property-modify.svndiff':
	$this->assertEqual(2, count($changes));

	$change = array_shift($changes);
	$this->assertEqual(0, count($change->getHunks()));
	$this->assertEqual(
	array(
	'svn:ignore' => '*.phpz',
	),
	$change->getOldProperties()
	);
	$this->assertEqual(
	array(
	'svn:ignore' => '*.php',
	),
	$change->getNewProperties()
	);

	$change = array_shift($changes);
	$this->assertEqual(0, count($change->getHunks()));
	$this->assertEqual(
	array(
	'svn:special' => '*',
	),
	$change->getOldProperties()
	);
	$this->assertEqual(
	array(
	'svn:special' => 'moo',
	),
	$change->getNewProperties()
	);
	break;
	case 'svn-property-delete.svndiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);

	$this->assertEqual(0, count($change->getHunks()));
	$this->assertEqual(
	$change->getOldProperties(),
	array(
	'svn:special' => '*',
	));
	$this->assertEqual(
	array(
	),
	$change->getNewProperties());
	break;
	case 'svn-property-merged.svndiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);

	$this->assertEqual(count($change->getHunks()), 0);

	$this->assertEqual(
	$change->getOldProperties(),
	array());
	$this->assertEqual(
	$change->getNewProperties(),
	array());
	break;
	case 'svn-property-merge.svndiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);

	$this->assertEqual(count($change->getHunks()), 0);
	$this->assertEqual(
	$change->getOldProperties(),
	array(
	));
	$this->assertEqual(
	$change->getNewProperties(),
	array(
	'svn:mergeinfo' => <<<EOTEXT
	Merged /tfb/branches/internmove/www/html/js/help/UIFaq.js:r83462-126155
	Merged /tfb/branches/ads-create-v3/www/html/js/help/UIFaq.js:r140558-142418
	EOTEXT
	));
	break;
	case 'svn-binary-add.svndiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);
	$this->assertEqual(
	ArcanistDiffChangeType::FILE_BINARY,
	$change->getFileType());
	$this->assertEqual(0, count($change->getHunks()));
	$this->assertEqual(
	array(
	'svn:mime-type' => 'application/octet-stream',
	),
	$change->getNewProperties()
	);
	break;
	case 'svn-binary-diff.svndiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);
	$this->assertEqual(
	ArcanistDiffChangeType::FILE_BINARY,
	$change->getFileType());
	$this->assertEqual(count($change->getHunks()), 0);
	break;
	case 'git-delete-file.gitdiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);
	$this->assertEqual(
	ArcanistDiffChangeType::TYPE_DELETE,
	$change->getType());
	$this->assertEqual(
	'scripts/intern/test/testfile2',
	$change->getCurrentPath());
	$this->assertEqual(1, count($change->getHunks()));
	break;
	case 'git-binary-change.gitdiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);
	$this->assertEqual(
	ArcanistDiffChangeType::FILE_BINARY,
	$change->getFileType());
	$this->assertEqual(0, count($change->getHunks()));
	break;
	case 'git-filemode-change.gitdiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);
	$this->assertEqual(1, count($change->getHunks()));
	$this->assertEqual(
	array(
	'unix:filemode' => '100644',
	),
	$change->getOldProperties()
	);
	$this->assertEqual(
	array(
	'unix:filemode' => '100755',
	),
	$change->getNewProperties()
	);
	break;
	case 'git-filemode-change-only.gitdiff':
	$this->assertEqual(count($changes), 2);
	$change = reset($changes);
	$this->assertEqual(count($change->getHunks()), 0);
	$this->assertEqual(
	array(
	'unix:filemode' => '100644',
	),
	$change->getOldProperties()
	);
	$this->assertEqual(
	array(
	'unix:filemode' => '100755',
	),
	$change->getNewProperties()
	);
	break;
	case 'svn-empty-file.svndiff':
	$this->assertEqual(2, count($changes));
	$change = array_shift($changes);
	$this->assertEqual(0, count($change->getHunks()));
	break;
	case 'git-ignore-whitespace-only.gitdiff':
	$this->assertEqual(count($changes), 2);

	$change = array_shift($changes);
	$this->assertEqual(count($change->getHunks()), 0);
	$this->assertEqual(
	$change->getOldPath(),
	'scripts/intern/test/testfile2');
	$this->assertEqual(
	$change->getCurrentPath(),
	'scripts/intern/test/testfile2');

	$change = array_shift($changes);
	$this->assertEqual(count($change->getHunks()), 1);
	$this->assertEqual(
	$change->getOldPath(),
	'scripts/intern/test/testfile3');
	$this->assertEqual(
	$change->getCurrentPath(),
	'scripts/intern/test/testfile3');
	break;
	case 'git-move.gitdiff':
	case 'git-move-edit.gitdiff':
	case 'git-move-plus.gitdiff':

	$extra_changeset = (bool)strpos($file, '-plus');
	$has_hunk = (bool)strpos($file, '-edit');

	$this->assertEqual($extra_changeset ? 3 : 2, count($changes));

	$change = array_shift($changes);
	$this->assertEqual($has_hunk ? 1 : 0,
	count($change->getHunks()));
	$this->assertEqual(
	$change->getType(),
	ArcanistDiffChangeType::TYPE_MOVE_HERE);

	$target = $change;

	$change = array_shift($changes);
	$this->assertEqual(0, count($change->getHunks()));
	$this->assertEqual(
	ArcanistDiffChangeType::TYPE_MOVE_AWAY,
	$change->getType()
	);

	$this->assertEqual(
	$change->getCurrentPath(),
	$target->getOldPath());
	$this->assertEqual(
	true,
	in_array($target->getCurrentPath(), $change->getAwayPaths()));
	break;
	case 'git-merge-header.gitdiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);
	$this->assertEqual(
	ArcanistDiffChangeType::TYPE_MESSAGE,
	$change->getType());
	$this->assertEqual(
	'501f6d519703458471dbea6284ec5f49d1408598',
	$change->getCommitHash());
	break;
	case 'git-new-file.gitdiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);
	$this->assertEqual(
	ArcanistDiffChangeType::TYPE_ADD,
	$change->getType());
	break;
	case 'git-copy.gitdiff':
	$this->assertEqual(2, count($changes));

	$change = array_shift($changes);
	$this->assertEqual(0, count($change->getHunks()));
	$this->assertEqual(
	ArcanistDiffChangeType::TYPE_COPY_HERE,
	$change->getType());
	$this->assertEqual(
	'flib/intern/widgets/ui/UIWidgetRSSBox.php',
	$change->getCurrentPath());

	$change = array_shift($changes);
	$this->assertEqual(0, count($change->getHunks()));
	$this->assertEqual(
	ArcanistDiffChangeType::TYPE_COPY_AWAY,
	$change->getType());
	$this->assertEqual(
	'lib/display/intern/ui/widget/UIWidgetRSSBox.php',
	$change->getCurrentPath());

	break;
	case 'git-copy-plus.gitdiff':
	$this->assertEqual(2, count($changes));

	$change = array_shift($changes);
	$this->assertEqual(3, count($change->getHunks()));
	$this->assertEqual(
	ArcanistDiffChangeType::TYPE_COPY_HERE,
	$change->getType());
	$this->assertEqual(
	'flib/intern/widgets/ui/UIWidgetGraphConnect.php',
	$change->getCurrentPath());

	$change = array_shift($changes);
	$this->assertEqual(0, count($change->getHunks()));
	$this->assertEqual(
	ArcanistDiffChangeType::TYPE_COPY_AWAY,
	$change->getType());
	$this->assertEqual(
	'lib/display/intern/ui/widget/UIWidgetLunchtime.php',
	$change->getCurrentPath());
	break;
	case 'svn-property-multiline.svndiff':
	$this->assertEqual(1, count($changes));
	$change = array_shift($changes);

	$this->assertEqual(0, count($change->getHunks()));
	$this->assertEqual(
	array(
	'svn:ignore' => 'tags',
	),
	$change->getOldProperties()
	);
	$this->assertEqual(
	array(
	'svn:ignore' => "tags\nasdf\nlol\nwhat",
	),
	$change->getNewProperties()
	);
	break;
	case 'git-empty-files.gitdiff':
	$this->assertEqual(2, count($changes));
	while ($change = array_shift($changes)) {
	$this->assertEqual(0, count($change->getHunks()));
	}
	break;
	case 'git-mnemonicprefix.gitdiff':
	// Check parsing of diffs created with `diff.mnemonicprefix`
	// configuration option set to `true`.
	$this->assertEqual(1, count($changes));
	$this->assertEqual(1, count(reset($changes)->getHunks()));
	break;
	case 'git-commit.gitdiff':
	$this->assertEqual(1, count($changes));
	$change = reset($changes);
	$this->assertEqual(
	ArcanistDiffChangeType::TYPE_MESSAGE,
	$change->getType());
	$this->assertEqual(
	'76e2f1339c298c748aa0b52030799ed202a6537b',
	$change->getCommitHash());
	$this->assertEqual(
	<<<EOTEXT

	Deprecating UIActionButton (Part 1)

	Summary: Replaces calls to UIActionButton with <ui:button>. I tested most
	of these calls, but there were some that I didn't know how to
	reach, so if you are one of the owners of this code, please test
	your feature in my sandbox: www.ngao.devrs013.facebook.com

	@brosenthal, I removed some logic that was setting a disabled state
	on a UIActionButton, which is actually a no-op.

	Reviewed By: brosenthal

	Other Commenters: sparker, egiovanola

	Test Plan: www.ngao.devrs013.facebook.com

	Explicitly tested:
	* ads creation flow (add keyword)
	* ads manager (conversion tracking)
	* help center (create a discussion)
	* new user wizard (next step button)

	Revert: OK

	DiffCamp Revision: 94064

	git-svn-id: svn+ssh://tubbs/svnroot/tfb/trunk/www@223593 2c7ba8d8
	EOTEXT
	, $change->getMetadata('message')
	);
	break;
	default:
	throw new Exception("No test block for diff file {$diff_file}.");
	break;
	}
	}
	}

File Metadata

Mime Type: text/x-php
Expires: Fri, Jul 31, 11:27 AM (1 d, 21 h)
Storage Engine: blob
Storage Format: Encrypted (AES-256-CBC)
Storage Handle: 16432330
Default Alt Text: ArcanistDiffParserTestCase.php (14 KB)

ArcanistDiffParserTestCase.phpNo OneTemporaryActions

ArcanistDiffParserTestCase.phpView Options

File Metadata

Event Timeline

ArcanistDiffParserTestCase.php
No OneTemporary
Actions

ArcanistDiffParserTestCase.php
View Options