Page MenuHomePhabricator
Feed All Stories

May 12 2022

epriestley requested review of D21823: Remove file attachment edge types, including API access.
May 12 2022, 10:40 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21822: Straggling fixes for PhutilURI under PHP 8.1.
May 12 2022, 10:38 PM · Infrastructure
epriestley requested review of D21822: Straggling fixes for PhutilURI under PHP 8.1.
May 12 2022, 10:38 PM
epriestley requested review of D21821: Fix some test suite stragglers with PHP 8.1 compatibility.
May 12 2022, 10:37 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21821: Fix some test suite stragglers with PHP 8.1 compatibility.
May 12 2022, 10:37 PM · Infrastructure
epriestley requested review of D21820: Remove all "FileHasObject" edge reads and writes.
May 12 2022, 10:25 PM
epriestley requested review of D21819: Remove all "ObjectHasFile" edge reads and writes.
May 12 2022, 10:15 PM
epriestley requested review of D21818: Copy file attachment edges to new storage.
May 12 2022, 9:59 PM
epriestley requested review of D21817: Adjust paste content transaction to support earlier file PHID extraction.
May 12 2022, 9:43 PM
epriestley requested review of D21816: Double-write file attachment to old "edge" storage and new "attachment" storage.
May 12 2022, 9:34 PM
epriestley requested review of D21815: Remove "PhabricatorFile->detachFromObject()".
May 12 2022, 9:15 PM
epriestley closed D21814: Add "pht_list()", a translation wrapper for lists of items.
May 12 2022, 5:57 PM
epriestley committed rARC3cc486d5c156: Add "pht_list()", a translation wrapper for lists of items (authored by epriestley).
Add "pht_list()", a translation wrapper for lists of items
May 12 2022, 5:57 PM
epriestley requested review of D21814: Add "pht_list()", a translation wrapper for lists of items.
May 12 2022, 5:57 PM

May 10 2022

epriestley requested review of D21813: Add database storage for a dedicated file attachment table.
May 10 2022, 11:24 PM
epriestley requested review of D21812: Do not extract file PHIDs from remarkup blocks for attachment.
May 10 2022, 6:54 PM
epriestley added a comment to T13588: PHP 8 Compatibility.

I am pretty sure that this error message does not exist prior to PHP 8.1, and PHP 7.4 can not possibly emit it. See here for some evidence that this is true -- note that the error message is not present in the script output until PHP 8.1:

May 10 2022, 12:18 PM · Infrastructure
bleketux added a comment to T13588: PHP 8 Compatibility.

Trying to fresh install using PHP 7.4 or PHP 8.1, have the same result when executing:

  • ./bin/config set phd.user root
[2022-05-10 02:01:12] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=fc5b228db537), phabricator(head=master, ref.master=698ada2470b1)
  #0 PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phabricator>/src/infrastructure/env/PhabricatorEnv.php:128]
  #1 PhabricatorEnv::initializeCommonEnvironment(boolean) called at [<phabricator>/src/infrastructure/env/PhabricatorEnv.php:75]
  #2 PhabricatorEnv::initializeScriptEnvironment(boolean) called at [<phabricator>/scripts/init/lib.php:26]
  #3 init_phabricator_script(array) called at [<phabricator>/scripts/init/init-setup.php:11]
  #4 require_once(string) called at [<phabricator>/scripts/setup/manage_config.php:5]
May 10 2022, 3:58 AM · Infrastructure

May 9 2022

epriestley closed T13677: Drydock may grow resource pools too cautiously as Resolved.

There may be additional work here, but presuming this is more or less resolved until evidence to the contrary arises.

May 9 2022, 10:21 PM · Drydock
epriestley closed T13679: Non-administrators can incorrectly edit default global settings as Resolved.

I believe D21811 covers this completely.

May 9 2022, 10:19 PM · Security
epriestley updated the task description for T13679: Non-administrators can incorrectly edit default global settings.
May 9 2022, 10:18 PM · Security
epriestley committed rP698ada2470b1: Correct overbroad automatic capability grant of global settings objects (authored by epriestley).
Correct overbroad automatic capability grant of global settings objects
May 9 2022, 10:10 PM
epriestley closed D21811: Correct overbroad automatic capability grant of global settings objects.
May 9 2022, 10:10 PM
epriestley requested review of D21811: Correct overbroad automatic capability grant of global settings objects.
May 9 2022, 10:10 PM
epriestley added a revision to T13679: Non-administrators can incorrectly edit default global settings: D21811: Correct overbroad automatic capability grant of global settings objects.
May 9 2022, 10:10 PM · Security
epriestley triaged T13679: Non-administrators can incorrectly edit default global settings as Normal priority.
May 9 2022, 10:08 PM · Security
epriestley closed T13678: Remarkup objects may form rendering cycles when embedded as Resolved.
May 9 2022, 7:02 PM · Remarkup
epriestley closed D21810: Prevent embedded remarkup content from cycling when it contains embedded self-references.
May 9 2022, 6:21 PM
epriestley committed rP01253d533bbc: Prevent embedded remarkup content from cycling when it contains embedded self… (authored by epriestley).
Prevent embedded remarkup content from cycling when it contains embedded self…
May 9 2022, 6:21 PM
epriestley added a comment to D21810: Prevent embedded remarkup content from cycling when it contains embedded self-references.

Screen Shot 2022-05-09 at 11.16.25 AM.png (1×2 px, 321 KB)

May 9 2022, 6:20 PM
epriestley requested review of D21810: Prevent embedded remarkup content from cycling when it contains embedded self-references.
May 9 2022, 6:20 PM
epriestley added a revision to T13678: Remarkup objects may form rendering cycles when embedded: D21810: Prevent embedded remarkup content from cycling when it contains embedded self-references.
May 9 2022, 6:20 PM · Remarkup
epriestley triaged T13678: Remarkup objects may form rendering cycles when embedded as Normal priority.
May 9 2022, 6:06 PM · Remarkup
epriestley closed D21809: In Drydock, yield for reclaiming resources in the "released" state.
May 9 2022, 5:45 PM
epriestley committed rPa640a4a4930f: In Drydock, yield for reclaiming resources in the "released" state (authored by epriestley).
In Drydock, yield for reclaiming resources in the "released" state
May 9 2022, 5:45 PM
epriestley requested review of D21809: In Drydock, yield for reclaiming resources in the "released" state.
May 9 2022, 5:45 PM
epriestley added a revision to T13677: Drydock may grow resource pools too cautiously: D21809: In Drydock, yield for reclaiming resources in the "released" state.
May 9 2022, 5:45 PM · Drydock
epriestley committed rP1835ca1918a4: Remove the "25% of active pool" growth rate throttle from Drydock (authored by epriestley).
Remove the "25% of active pool" growth rate throttle from Drydock
May 9 2022, 5:40 PM
epriestley closed D21808: Remove the "25% of active pool" growth rate throttle from Drydock.
May 9 2022, 5:40 PM
epriestley closed D21807: Adjust the Drydock allocator to limit each pending lease to one allocating resource.
May 9 2022, 5:40 PM
epriestley closed D21806: Formalize some more Drydock conditions and bookkeeping.
May 9 2022, 5:40 PM
epriestley committed rP62360ea40689: Adjust the Drydock allocator to limit each pending lease to one allocating… (authored by epriestley).
Adjust the Drydock allocator to limit each pending lease to one allocating…
May 9 2022, 5:40 PM
epriestley committed rP13a37282bcb3: Formalize some more Drydock conditions and bookkeeping (authored by epriestley).
Formalize some more Drydock conditions and bookkeeping
May 9 2022, 5:40 PM
epriestley closed D21805: Add "--all" flags to "release-lease" and "release-resource" workflows in "bin/drydock".
May 9 2022, 5:40 PM
epriestley committed rP1b6727ac3d6a: Add "--all" flags to "release-lease" and "release-resource" workflows in… (authored by epriestley).
Add "--all" flags to "release-lease" and "release-resource" workflows in…
May 9 2022, 5:40 PM
epriestley updated the test plan for D21807: Adjust the Drydock allocator to limit each pending lease to one allocating resource.
May 9 2022, 5:39 PM
epriestley requested review of D21808: Remove the "25% of active pool" growth rate throttle from Drydock.
May 9 2022, 5:30 PM
epriestley added a revision to T13677: Drydock may grow resource pools too cautiously: D21808: Remove the "25% of active pool" growth rate throttle from Drydock.
May 9 2022, 5:30 PM · Drydock
epriestley updated the diff for D21807: Adjust the Drydock allocator to limit each pending lease to one allocating resource.
  • Fix some variable names and exception handling.
May 9 2022, 5:27 PM
epriestley updated the diff for D21806: Formalize some more Drydock conditions and bookkeeping.
  • Update library map.
May 9 2022, 5:26 PM
epriestley requested review of D21807: Adjust the Drydock allocator to limit each pending lease to one allocating resource.
May 9 2022, 5:24 PM
epriestley added a revision to T13677: Drydock may grow resource pools too cautiously: D21807: Adjust the Drydock allocator to limit each pending lease to one allocating resource.
May 9 2022, 5:24 PM · Drydock
epriestley added a revision to T13677: Drydock may grow resource pools too cautiously: D21806: Formalize some more Drydock conditions and bookkeeping.
May 9 2022, 5:09 PM · Drydock
epriestley requested review of D21806: Formalize some more Drydock conditions and bookkeeping.
May 9 2022, 5:09 PM
mrjoops updated mrjoops.
May 9 2022, 12:49 PM

May 5 2022

epriestley added a comment to T13677: Drydock may grow resource pools too cautiously.

When this mechanism is removed (by commenting out the logic that cares about the 25% limit), we'd expect Drydock to build 8 resources at a time (limited by number of taskmasters). It actually builds ~1-4...

May 5 2022, 11:29 PM · Drydock
epriestley requested review of D21805: Add "--all" flags to "release-lease" and "release-resource" workflows in "bin/drydock".
May 5 2022, 11:01 PM
epriestley added a revision to T13677: Drydock may grow resource pools too cautiously: D21805: Add "--all" flags to "release-lease" and "release-resource" workflows in "bin/drydock".
May 5 2022, 11:01 PM · Drydock
epriestley closed D21804: Return STDIN, STDOUT, and STDERR file descriptors from parent process.
May 5 2022, 5:27 PM
epriestley committed rARCfc5b228db537: Return STDIN, STDOUT, and STDERR file descriptors from parent process (authored by epriestley).
Return STDIN, STDOUT, and STDERR file descriptors from parent process
May 5 2022, 5:27 PM
epriestley added a revision to T13675: Can Arcanist plausibly be compiled into a binary?: D21804: Return STDIN, STDOUT, and STDERR file descriptors from parent process.
May 5 2022, 5:27 PM · Arcanist
epriestley requested review of D21804: Return STDIN, STDOUT, and STDERR file descriptors from parent process.
May 5 2022, 5:27 PM
epriestley added a comment to T13675: Can Arcanist plausibly be compiled into a binary?.

We may fopen() an additional stdout and/or stderr handle, but do not fclose() it?

May 5 2022, 4:48 PM · Arcanist
epriestley added a comment to T13675: Can Arcanist plausibly be compiled into a binary?.

I am suspicious that D21794 may have broken something subtle with unix magic, since I'm seeing some hangs out of deployment scripts wrapping daemon management scripts. I think the issue is probably one of:

May 5 2022, 2:15 PM · Arcanist

May 4 2022

epriestley added a comment to T13677: Drydock may grow resource pools too cautiously.

The outline above isn't quite sufficient because when the active resource list is nonempty, we don't actually reach the "new allocation" logic. Broadly, executeAllocator() is kind of wonky and needs some additional restructuring to cover both the D19762 case ("allocate up to the resource limit before reusing resources") and the normal set of cases. The proper logic is something like:

May 4 2022, 10:48 PM · Drydock
epriestley added a comment to T13677: Drydock may grow resource pools too cautiously.

This issue partially reproduces (consistent with the original report, not immediately consistent with my theorizing about a root cause in PHI2177 -- actually, looks like both parts are right, see below): Drydock builds ~1 working copy per minute serially until it reaches a pool size of 5 resources. Then, it begins allocating 2 simultaneous resources.

May 4 2022, 10:16 PM · Drydock
epriestley triaged T13677: Drydock may grow resource pools too cautiously as Normal priority.
May 4 2022, 9:37 PM · Drydock
epriestley added a comment to T13675: Can Arcanist plausibly be compiled into a binary?.

What options exist for inter-process communication?

May 4 2022, 6:27 PM · Arcanist
epriestley added a comment to T13675: Can Arcanist plausibly be compiled into a binary?.

Here's how I'm thinking about overengineering this:

May 4 2022, 5:17 PM · Arcanist

May 3 2022

epriestley closed T11336: Provide a stable address range for Phacility outbound requests as Resolved.

This was resolved as part of T13630. I didn't actually put it in the UI anywhere, but all requests will now originate from 13.56.71.101, and this isn't likely to change given the wind-down of Phacility hosting.

May 3 2022, 11:29 PM · Customer Impact
epriestley added a project to T10522: Build plan page doesn't warn about unapproved Drydock blueprints: Drydock.
May 3 2022, 11:25 PM · Drydock, Restricted Project, Harbormaster (v3)
epriestley added a comment to T10508: Drydock WorkingCopy blueprints allow selection of invalid "Use Blueprints".

D21801, motivated by T13676, made this more practical.

May 3 2022, 11:19 PM · Drydock (v3)
epriestley added a task to D21801: Use the same logic in "bin/drydock lease" and LeaseUpdateWorker to identify candidate blueprints: T10508: Drydock WorkingCopy blueprints allow selection of invalid "Use Blueprints".
May 3 2022, 11:18 PM
epriestley added a revision to T10508: Drydock WorkingCopy blueprints allow selection of invalid "Use Blueprints": D21801: Use the same logic in "bin/drydock lease" and LeaseUpdateWorker to identify candidate blueprints.
May 3 2022, 11:18 PM · Drydock (v3)
epriestley closed T11694: Allow clients to generally reason about Drydock leases over the API as Resolved.

This is somewhat resolved and neither next steps or motivation are clear any longer, so I'm going to call it done until evidence to the contrary arises.

May 3 2022, 11:17 PM · Restricted Project, Drydock
epriestley closed T11694: Allow clients to generally reason about Drydock leases over the API, a subtask of T11693: Make drydock command interfaces accessible via SSH workflows, as Resolved.
May 3 2022, 11:17 PM · Restricted Project, Drydock
epriestley closed T13676: Drydock may reclaim recently-used resources as Resolved.

Perhaps a philosophical question here is: do we care about which repositories are checked out in a working copy resource?

May 3 2022, 11:15 PM · Drydock
epriestley committed rP6417e950f622: Don't reclaim resources that have a destroyed lease less than 3 minutes old (authored by epriestley).
Don't reclaim resources that have a destroyed lease less than 3 minutes old
May 3 2022, 10:57 PM
epriestley closed D21803: Don't reclaim resources that have a destroyed lease less than 3 minutes old.
May 3 2022, 10:57 PM
epriestley committed rPdfdbe7a6be04: Allow "bin/drydock lease ..." to select particular blueprints with "--blueprint" (authored by epriestley).
Allow "bin/drydock lease ..." to select particular blueprints with "--blueprint"
May 3 2022, 10:57 PM
epriestley closed D21802: Allow "bin/drydock lease ..." to select particular blueprints with "--blueprint".
May 3 2022, 10:57 PM
epriestley closed D21801: Use the same logic in "bin/drydock lease" and LeaseUpdateWorker to identify candidate blueprints.
May 3 2022, 10:57 PM
epriestley committed rP30c3d1e92946: Allow "bin/drydock lease" to acquire many identical leases with "--count N" (authored by epriestley).
Allow "bin/drydock lease" to acquire many identical leases with "--count N"
May 3 2022, 10:57 PM
epriestley committed rP25cf955a89af: Use the same logic in "bin/drydock lease" and LeaseUpdateWorker to identify… (authored by epriestley).
Use the same logic in "bin/drydock lease" and LeaseUpdateWorker to identify…
May 3 2022, 10:57 PM
epriestley committed rP9ec6677c0271: Update "bin/drydock command" help text to use more standard quoting (authored by epriestley).
Update "bin/drydock command" help text to use more standard quoting
May 3 2022, 10:57 PM
epriestley closed D21800: Allow "bin/drydock lease" to acquire many identical leases with "--count N".
May 3 2022, 10:57 PM
epriestley closed D21797: Update "bin/drydock command" help text to use more standard quoting.
May 3 2022, 10:57 PM
epriestley committed rPd1fd2975b062: Fail in a more comprehensible way when a WorkingCopy lease omits or mangles… (authored by epriestley).
Fail in a more comprehensible way when a WorkingCopy lease omits or mangles…
May 3 2022, 10:57 PM
epriestley closed D21796: Fail in a more comprehensible way when a WorkingCopy lease omits or mangles "repositories.map".
May 3 2022, 10:57 PM
epriestley committed rP00a20d3cdc54: Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock"… (authored by epriestley).
Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock"…
May 3 2022, 10:57 PM
epriestley closed D21795: Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock" pathways.
May 3 2022, 10:57 PM
epriestley closed D21799: Add an ArgumentParser helper for integers.
May 3 2022, 10:57 PM
epriestley committed rARC2969f2496188: Add an ArgumentParser helper for integers (authored by epriestley).
Add an ArgumentParser helper for integers
May 3 2022, 10:57 PM
epriestley added a comment to T13676: Drydock may reclaim recently-used resources.

Before, instant reclaim after lease destruction:

May 3 2022, 10:56 PM · Drydock
epriestley added a revision to T13676: Drydock may reclaim recently-used resources: D21803: Don't reclaim resources that have a destroyed lease less than 3 minutes old.
May 3 2022, 10:54 PM · Drydock
epriestley requested review of D21803: Don't reclaim resources that have a destroyed lease less than 3 minutes old.
May 3 2022, 10:54 PM
epriestley added a comment to T13676: Drydock may reclaim recently-used resources.

To create resource pressure, I'm now going to try this -- I guess I don't really need the --count flag, but it does make the terminal juggling slightly easier:

May 3 2022, 10:51 PM · Drydock
epriestley added a comment to T13676: Drydock may reclaim recently-used resources.

The blueprint thing was on the way toward creating allocation pressure, so D21802 allows you to select a blueprint (or a set of possible blueprints) with --blueprint. You can specify an ID or PHID:

May 3 2022, 10:07 PM · Drydock
epriestley requested review of D21802: Allow "bin/drydock lease ..." to select particular blueprints with "--blueprint".
May 3 2022, 10:03 PM
epriestley added a revision to T13676: Drydock may reclaim recently-used resources: D21802: Allow "bin/drydock lease ..." to select particular blueprints with "--blueprint".
May 3 2022, 10:03 PM · Drydock