Page MenuHomePhabricator
Feed All Stories

Apr 7 2021

Harbormaster failed to build B25359: rP95662ae8f1a7: Don't attempt to test capabilities on incomplete handles for rP95662ae8f1a7: Don't attempt to test capabilities on incomplete handles!
Apr 7 2021, 9:57 PM
epriestley closed D21662: Don't attempt to test capabilities on incomplete handles.
Apr 7 2021, 9:56 PM
epriestley committed rP95662ae8f1a7: Don't attempt to test capabilities on incomplete handles (authored by epriestley).
Don't attempt to test capabilities on incomplete handles
Apr 7 2021, 9:56 PM
epriestley requested review of D21662: Don't attempt to test capabilities on incomplete handles.
Apr 7 2021, 9:54 PM
epriestley added a comment to D21661: New MediaWiki logo for the icon that represents the MediaWiki oauth provider..

Ah, I think it's:

Apr 7 2021, 9:46 PM
epriestley added a comment to D21661: New MediaWiki logo for the icon that represents the MediaWiki oauth provider..

(This might need to be sprite-sheeted too, but I think the sprite stuff hasn't been used in years -- since we switched pretty much everything to icon fonts -- and don't remember exactly how it works. I can look into it and do the actual bin/uh-generate-a-sprite-sheet or whatever in a followup.)

Apr 7 2021, 9:42 PM
epriestley accepted D21661: New MediaWiki logo for the icon that represents the MediaWiki oauth provider..

Thanks!

Apr 7 2021, 9:41 PM
20after4 requested review of D21661: New MediaWiki logo for the icon that represents the MediaWiki oauth provider..
Apr 7 2021, 8:59 PM

Apr 6 2021

epriestley triaged T13649: Address higher-impact `arc` toolsets behaviors as Normal priority.
Apr 6 2021, 3:54 PM · Arcanist

Apr 1 2021

avivey updated the diff for D21660: arc-unit: only list failing tests.

tweak wording

Apr 1 2021, 7:50 PM
avivey requested review of D21660: arc-unit: only list failing tests.
Apr 1 2021, 7:48 PM
avivey added a revision to T8856: Show a summary of failed unit tests at the end of `arc unit` or `arc diff` if there are failures: D21660: arc-unit: only list failing tests.
Apr 1 2021, 7:48 PM · Restricted Project, Arcanist
avivey edited the content of Community Resources.
Apr 1 2021, 6:19 PM

Mar 29 2021

epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Mar 29 2021, 4:44 PM · Almanac, Infrastructure, Phacility
epriestley committed rP5efe7fb4c181: On inline comments, track an explicit "committed" content state (authored by epriestley).
On inline comments, track an explicit "committed" content state
Mar 29 2021, 4:01 PM
epriestley committed rP1308a5555fee: Update client logic for inline comment "Save" and "Cancel" actions (authored by epriestley).
Update client logic for inline comment "Save" and "Cancel" actions
Mar 29 2021, 4:01 PM
epriestley committed rP6fd55d692f14: Formally track "initial", "committed", and "active" states for inline comments (authored by epriestley).
Formally track "initial", "committed", and "active" states for inline comments
Mar 29 2021, 4:01 PM
epriestley committed rPb75517918d86: When creating an inline comment, populate the content state with the default… (authored by epriestley).
When creating an inline comment, populate the content state with the default…
Mar 29 2021, 4:01 PM
epriestley committed rP428fff2e58f3: Fix an issue when undoing mutiple inline comment deletions (authored by epriestley).
Fix an issue when undoing mutiple inline comment deletions
Mar 29 2021, 4:01 PM
epriestley closed D21651: On inline comments, track an explicit "committed" content state.
Mar 29 2021, 4:01 PM
epriestley closed D21653: Formally track "initial", "committed", and "active" states for inline comments.
Mar 29 2021, 4:01 PM
epriestley closed D21654: Update client logic for inline comment "Save" and "Cancel" actions.
Mar 29 2021, 4:01 PM
epriestley closed D21652: When creating an inline comment, populate the content state with the default suggestion text.
Mar 29 2021, 4:00 PM
epriestley closed D21650: Fix an issue when undoing mutiple inline comment deletions.
Mar 29 2021, 4:00 PM
epriestley committed rPd30c3a961cd9: Make the client authoritative for "Cancel" actions (authored by epriestley).
Make the client authoritative for "Cancel" actions
Mar 29 2021, 4:00 PM
epriestley committed rP60e869f4114f: Make the client authoritative for "Save" actions (authored by epriestley).
Make the client authoritative for "Save" actions
Mar 29 2021, 4:00 PM
epriestley closed D21649: Make the client authoritative for "Cancel" actions.
Mar 29 2021, 4:00 PM
epriestley committed rPb964731b6a6b: Make inline "ContentState" a client object, and track "hasSuggestion" on it (authored by epriestley).
Make inline "ContentState" a client object, and track "hasSuggestion" on it
Mar 29 2021, 4:00 PM
epriestley committed rPcb00cb99e244: Make client inlines track an "active" state (authored by epriestley).
Make client inlines track an "active" state
Mar 29 2021, 4:00 PM
epriestley committed rP87c6c270b435: Fix an issue where inlines could be duplicated in the client list (authored by epriestley).
Fix an issue where inlines could be duplicated in the client list
Mar 29 2021, 4:00 PM
epriestley committed rP0f04d9e58458: Remove direct reads of form state from main Inline client code (authored by epriestley).
Remove direct reads of form state from main Inline client code
Mar 29 2021, 4:00 PM
epriestley closed D21645: Make inline "ContentState" a client object, and track "hasSuggestion" on it.
Mar 29 2021, 4:00 PM
epriestley closed D21648: Make the client authoritative for "Save" actions.
Mar 29 2021, 4:00 PM
epriestley closed D21642: Fix an issue where inlines could be duplicated in the client list.
Mar 29 2021, 4:00 PM
epriestley closed D21646: Make client inlines track an "active" state.
Mar 29 2021, 4:00 PM
epriestley closed D21647: Remove direct reads of form state from main Inline client code.
Mar 29 2021, 4:00 PM

Mar 28 2021

epriestley committed rP2afedad61c51: (stable) Skip "git for-each-ref" when identifying deleted commits (authored by epriestley).
(stable) Skip "git for-each-ref" when identifying deleted commits
Mar 28 2021, 6:16 PM
epriestley committed rPaa70b008f3a1: Skip "git for-each-ref" when identifying deleted commits (authored by epriestley).
Skip "git for-each-ref" when identifying deleted commits
Mar 28 2021, 6:04 PM
epriestley closed D21658: Skip "git for-each-ref" when identifying deleted commits.
Mar 28 2021, 6:04 PM
epriestley requested review of D21658: Skip "git for-each-ref" when identifying deleted commits.
Mar 28 2021, 5:59 PM
epriestley added a revision to T13647: Reduce repository update cost for repositories with large numbers of refs: D21658: Skip "git for-each-ref" when identifying deleted commits.
Mar 28 2021, 5:58 PM · Diffusion
epriestley added a comment to T13647: Reduce repository update cost for repositories with large numbers of refs.

One call to for-each-ref comes from resolving a list of commit hashes, to test if they still exist. This is accomplished with DiffusionLowLevelResolveRefsQuery, which calls git for-each-ref first and falls back to git cat-file --batch-check.

Mar 28 2021, 5:44 PM · Diffusion
epriestley added a comment to T13647: Reduce repository update cost for repositories with large numbers of refs.

Has this repository changed?

Mar 28 2021, 5:25 PM · Diffusion

Mar 27 2021

epriestley committed rP33c847e667b6: (stable) Correct issue with "bindings" conduit attachment (authored by epriestley).
(stable) Correct issue with "bindings" conduit attachment
Mar 27 2021, 4:26 PM
epriestley committed rP5b8b5f214148: Correct issue with "bindings" conduit attachment (authored by epriestley).
Correct issue with "bindings" conduit attachment
Mar 27 2021, 4:26 PM
epriestley closed D21657: Correct issue with "bindings" conduit attachment.
Mar 27 2021, 4:26 PM
epriestley requested review of D21657: Correct issue with "bindings" conduit attachment.
Mar 27 2021, 4:26 PM
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: D21657: Correct issue with "bindings" conduit attachment.
Mar 27 2021, 4:25 PM · Almanac
epriestley triaged T13648: Transaction publishing may stall during mail expansion of package recipients as Wishlist priority.
Mar 27 2021, 2:57 PM · Transactions

Mar 26 2021

epriestley triaged T13647: Reduce repository update cost for repositories with large numbers of refs as Normal priority.
Mar 26 2021, 11:09 PM · Diffusion
epriestley closed T13639: Allow revisions to be queried by affected path via the API as Resolved.

This is now in stable; presuming it works until evidence to the contrary emerges.

Mar 26 2021, 6:08 PM · Conduit, Differential
epriestley edited the content of Changelog.
Mar 26 2021, 6:07 PM
epriestley created an object: 2021 Week 13 (Late March).
Mar 26 2021, 6:06 PM
epriestley committed rARC7af9846f994a: (stable) Promote 2021 Week 13 (authored by epriestley).
(stable) Promote 2021 Week 13
Mar 26 2021, 6:05 PM
epriestley committed rPda8a579600c0: (stable) Promote 2021 Week 13 (authored by epriestley).
(stable) Promote 2021 Week 13
Mar 26 2021, 6:05 PM
epriestley added a comment to T13646: Add "E" to "variables_order" in Phacility environments.

D21656 fixes variables_order.

Mar 26 2021, 5:52 PM · Phacility, Infrastructure
epriestley added a revision to T13646: Add "E" to "variables_order" in Phacility environments: Unknown Object (Differential Revision).
Mar 26 2021, 5:19 PM · Phacility, Infrastructure
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: Unknown Object (Differential Revision).
Mar 26 2021, 5:15 PM · Almanac
epriestley updated the test plan for D21654: Update client logic for inline comment "Save" and "Cancel" actions.
Mar 26 2021, 3:48 PM
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 26 2021, 3:48 PM · Accessibility, Differential

Mar 25 2021

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 25 2021, 9:14 PM · Accessibility, Differential
epriestley requested review of D21654: Update client logic for inline comment "Save" and "Cancel" actions.
Mar 25 2021, 9:13 PM
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 25 2021, 9:13 PM · Accessibility, Differential
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21654: Update client logic for inline comment "Save" and "Cancel" actions.
Mar 25 2021, 9:12 PM · Accessibility, Differential
epriestley requested review of D21653: Formally track "initial", "committed", and "active" states for inline comments.
Mar 25 2021, 9:11 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21653: Formally track "initial", "committed", and "active" states for inline comments.
Mar 25 2021, 9:10 PM · Accessibility, Differential
epriestley requested review of D21652: When creating an inline comment, populate the content state with the default suggestion text.
Mar 25 2021, 9:08 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21652: When creating an inline comment, populate the content state with the default suggestion text.
Mar 25 2021, 9:07 PM · Accessibility, Differential
epriestley requested review of D21651: On inline comments, track an explicit "committed" content state.
Mar 25 2021, 9:06 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21651: On inline comments, track an explicit "committed" content state.
Mar 25 2021, 9:05 PM · Accessibility, Differential
epriestley requested review of D21650: Fix an issue when undoing mutiple inline comment deletions.
Mar 25 2021, 9:04 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21650: Fix an issue when undoing mutiple inline comment deletions.
Mar 25 2021, 9:03 PM · Accessibility, Differential
epriestley requested review of D21649: Make the client authoritative for "Cancel" actions.
Mar 25 2021, 9:01 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21649: Make the client authoritative for "Cancel" actions.
Mar 25 2021, 9:00 PM · Accessibility, Differential
epriestley requested review of D21648: Make the client authoritative for "Save" actions.
Mar 25 2021, 8:59 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21648: Make the client authoritative for "Save" actions.
Mar 25 2021, 8:58 PM · Accessibility, Differential
epriestley requested review of D21647: Remove direct reads of form state from main Inline client code.
Mar 25 2021, 8:57 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21647: Remove direct reads of form state from main Inline client code.
Mar 25 2021, 8:56 PM · Accessibility, Differential
epriestley requested review of D21646: Make client inlines track an "active" state.
Mar 25 2021, 8:55 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21646: Make client inlines track an "active" state.
Mar 25 2021, 8:54 PM · Accessibility, Differential
epriestley requested review of D21645: Make inline "ContentState" a client object, and track "hasSuggestion" on it.
Mar 25 2021, 8:52 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21645: Make inline "ContentState" a client object, and track "hasSuggestion" on it.
Mar 25 2021, 8:51 PM · Accessibility, Differential
epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

The "Cancel" button should mean "Delete" if...

Mar 25 2021, 8:21 PM · Accessibility, Differential
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 25 2021, 6:16 PM · Accessibility, Differential
epriestley triaged T13646: Add "E" to "variables_order" in Phacility environments as Low priority.
Mar 25 2021, 3:31 PM · Phacility, Infrastructure

Mar 24 2021

epriestley committed rP61272e7ac31a: Correct "getActiveBindings()" method name (authored by epriestley).
Correct "getActiveBindings()" method name
Mar 24 2021, 5:15 PM
epriestley closed D21644: Correct "getActiveBindings()" method name.
Mar 24 2021, 5:15 PM
epriestley requested review of D21644: Correct "getActiveBindings()" method name.
Mar 24 2021, 5:13 PM

Mar 23 2021

epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

Currently, the inline code partially conflates four separate content states:

Mar 23 2021, 5:57 PM · Accessibility, Differential
20after4 awarded T12843: Add support for creating workboard columns from the Conduit API a Baby Tequila token.
Mar 23 2021, 3:08 PM · Conduit, Projects, Workboards, Feature Request

Mar 22 2021

epriestley committed rARCf0f95e5b2612: On Windows, implement "Filesystem::copyFile()" with "copy()" (authored by epriestley).
On Windows, implement "Filesystem::copyFile()" with "copy()"
Mar 22 2021, 7:00 PM
epriestley closed D21643: On Windows, implement "Filesystem::copyFile()" with "copy()".
Mar 22 2021, 7:00 PM
epriestley renamed T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions from Filesystem class invokes "copy" command on Windows, which fails after "bypass_shell" changes to Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.
Mar 22 2021, 7:00 PM · Windows, Arcanist
epriestley added a comment to T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.

D21643 "fixes" this by using copy(). However:

Mar 22 2021, 6:59 PM · Windows, Arcanist
epriestley requested review of D21643: On Windows, implement "Filesystem::copyFile()" with "copy()".
Mar 22 2021, 6:43 PM
epriestley added a revision to T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions: D21643: On Windows, implement "Filesystem::copyFile()" with "copy()".
Mar 22 2021, 6:43 PM · Windows, Arcanist
epriestley updated the task description for T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.
Mar 22 2021, 6:14 PM · Windows, Arcanist
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 22 2021, 6:13 PM · Accessibility, Differential
epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

When you "Quote" a comment, then cancel, the comment disappears from the UI.

Mar 22 2021, 5:36 PM · Accessibility, Differential
epriestley updated the task description for T13534: Inline Comment errata after editing persistence.
Mar 22 2021, 5:32 PM · Differential