Page MenuHomePhabricator
Feed All Stories

Jul 30 2020

jg added a comment to D21432: Move "Wait for Previous Commits to Build" out of prototype.

lotsofthumbsup

Jul 30 2020, 7:56 PM
epriestley added a comment to D21432: Move "Wait for Previous Commits to Build" out of prototype.

See PHI1833.

Jul 30 2020, 7:50 PM
epriestley committed rPc1eeacd8500b: Move "Wait for Previous Commits to Build" out of prototype (authored by epriestley).
Move "Wait for Previous Commits to Build" out of prototype
Jul 30 2020, 7:46 PM
epriestley closed D21432: Move "Wait for Previous Commits to Build" out of prototype.
Jul 30 2020, 7:46 PM
epriestley requested review of D21432: Move "Wait for Previous Commits to Build" out of prototype.
Jul 30 2020, 7:45 PM

Jul 28 2020

epriestley requested review of D21431: Improve handle/status list display on devices in commit graph lists.
Jul 28 2020, 6:16 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21431: Improve handle/status list display on devices in commit graph lists.
Jul 28 2020, 6:15 PM · Differential
epriestley requested review of D21430: Improve commit action item layout on mobile.
Jul 28 2020, 5:11 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21430: Improve commit action item layout on mobile.
Jul 28 2020, 5:08 PM · Differential

Jul 27 2020

epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jul 27 2020, 6:06 PM · Guides, Arcanist

Jul 25 2020

epriestley edited the content of Changelog.
Jul 25 2020, 3:26 PM
epriestley committed rARCccd39feb6d3b: (stable) Promote 2020 Week 29 (authored by epriestley).
(stable) Promote 2020 Week 29
Jul 25 2020, 3:25 PM
epriestley committed rP1b54f45c4c47: (stable) Promote 2020 Week 29 (authored by epriestley).
(stable) Promote 2020 Week 29
Jul 25 2020, 3:25 PM
epriestley created an object: 2020 Week 29 (Late July).
Jul 25 2020, 3:25 PM
avivey added a comment to T13550: Strip markup from project descriptions displayed in the "Browse Projects" dialog.

related to T3278, probably?

Jul 25 2020, 10:57 AM · Typeahead, Feature Request

Jul 24 2020

epriestley committed rP017ef1927c3e: Revert use of "user-select: all" to modify tab selection behavior (authored by epriestley).
Revert use of "user-select: all" to modify tab selection behavior
Jul 24 2020, 8:41 PM
epriestley added a reverting change for D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior: rP017ef1927c3e: Revert use of "user-select: all" to modify tab selection behavior.
Jul 24 2020, 8:41 PM
epriestley closed D21429: Revert use of "user-select: all" to modify tab selection behavior.
Jul 24 2020, 8:41 PM
epriestley requested review of D21429: Revert use of "user-select: all" to modify tab selection behavior.
Jul 24 2020, 8:41 PM
epriestley added a comment to D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior.

I reverted this in D21429, since it also makes these sequences select with a single click.

Jul 24 2020, 8:40 PM
epriestley added a reverting change for D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior: D21429: Revert use of "user-select: all" to modify tab selection behavior.
Jul 24 2020, 8:40 PM
epriestley added a comment to T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes.

In D21426, I removed phd.trace and phd.verbose.

Jul 24 2020, 12:18 AM · Daemons

Jul 23 2020

epriestley committed rPa27c83757d9f: Remove ancient "phd.trace" and "phd.verbose" configuration options (authored by epriestley).
Remove ancient "phd.trace" and "phd.verbose" configuration options
Jul 23 2020, 7:31 PM
epriestley closed D21426: Remove ancient "phd.trace" and "phd.verbose" configuration options.
Jul 23 2020, 7:31 PM
epriestley updated the diff for D21426: Remove ancient "phd.trace" and "phd.verbose" configuration options.
  • Include "obsolete config" setup checks.
Jul 23 2020, 7:28 PM
epriestley requested review of D21426: Remove ancient "phd.trace" and "phd.verbose" configuration options.
Jul 23 2020, 7:23 PM
epriestley added a revision to T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes: D21426: Remove ancient "phd.trace" and "phd.verbose" configuration options.
Jul 23 2020, 7:22 PM · Daemons
epriestley committed rP78d1b62bb8e9: Streamline handling of Futures and PIDs in daemons (authored by epriestley).
Streamline handling of Futures and PIDs in daemons
Jul 23 2020, 6:22 PM
epriestley committed rP5f0535934d72: Manage PIDs more carefully in DaemonHandle (authored by epriestley).
Manage PIDs more carefully in DaemonHandle
Jul 23 2020, 6:22 PM
epriestley closed D21424: Manage PIDs more carefully in DaemonHandle.
Jul 23 2020, 6:22 PM
epriestley closed D21425: Streamline handling of Futures and PIDs in daemons.
Jul 23 2020, 6:22 PM
epriestley committed rARCceb082ef6b29: Give Futures clearer start/end and exception semantics (authored by epriestley).
Give Futures clearer start/end and exception semantics
Jul 23 2020, 6:22 PM
epriestley closed D21423: Give Futures clearer start/end and exception semantics.
Jul 23 2020, 6:22 PM
epriestley claimed T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes.
Jul 23 2020, 6:05 PM · Daemons
epriestley triaged T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes as Wishlist priority.
Jul 23 2020, 6:05 PM · Daemons
epriestley updated the diff for D21425: Streamline handling of Futures and PIDs in daemons.
  • Use "$caught", not "$ex", to make the code less fragile.
Jul 23 2020, 5:42 PM
epriestley requested review of D21425: Streamline handling of Futures and PIDs in daemons.
Jul 23 2020, 5:41 PM
epriestley added a revision to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall: D21425: Streamline handling of Futures and PIDs in daemons.
Jul 23 2020, 5:40 PM · Daemons
epriestley updated the diff for D21423: Give Futures clearer start/end and exception semantics.
  • Add "ExecFuture->hasPID()" to simplify reading PID information.
Jul 23 2020, 5:17 PM
epriestley added a comment to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall.

The call sequence here is approximately:

Jul 23 2020, 5:11 PM · Daemons
epriestley requested review of D21424: Manage PIDs more carefully in DaemonHandle.
Jul 23 2020, 5:10 PM
epriestley added a revision to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall: D21424: Manage PIDs more carefully in DaemonHandle.
Jul 23 2020, 5:09 PM · Daemons
epriestley requested review of D21423: Give Futures clearer start/end and exception semantics.
Jul 23 2020, 5:08 PM
epriestley added a revision to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall: D21423: Give Futures clearer start/end and exception semantics.
Jul 23 2020, 5:07 PM · Daemons
epriestley triaged T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall as Normal priority.
Jul 23 2020, 2:58 PM · Daemons
epriestley committed rPfcb75d0503c6: Fix an issue where prose diffing may fail after hitting the PCRE backtracking… (authored by epriestley).
Fix an issue where prose diffing may fail after hitting the PCRE backtracking…
Jul 23 2020, 2:46 PM
epriestley closed D21422: Fix an issue where prose diffing may fail after hitting the PCRE backtracking limit.
Jul 23 2020, 2:46 PM
epriestley closed T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()" as Resolved by committing rPfcb75d0503c6: Fix an issue where prose diffing may fail after hitting the PCRE backtracking….
Jul 23 2020, 2:46 PM · Infrastructure
epriestley requested review of D21422: Fix an issue where prose diffing may fail after hitting the PCRE backtracking limit.
Jul 23 2020, 2:41 PM
epriestley added a revision to T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()": D21422: Fix an issue where prose diffing may fail after hitting the PCRE backtracking limit.
Jul 23 2020, 2:40 PM · Infrastructure
epriestley added a comment to T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()".

This is a PCRE backtracking issue. It reproduces on an input corpus of length 3,277 bytes with only "x", " " (space), and "\n" (newline) characters, and disappears if I increase pcre.backtrack_limit.

Jul 23 2020, 2:36 PM · Infrastructure
epriestley triaged T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()" as Low priority.
Jul 23 2020, 1:41 PM · Infrastructure

Jul 22 2020

epriestley added a comment to T13545: Upgrading: Mid 2020 Changes to "arc diff".

Please use Discourse to discuss Phabricator.

Jul 22 2020, 11:49 PM · Arcanist, Guides
jbrownEP added a comment to T13545: Upgrading: Mid 2020 Changes to "arc diff".

This task references more details on "Excuses" and "Prompts", but there isn't any. Is there any way to provide context around lint issues?

Jul 22 2020, 11:46 PM · Arcanist, Guides
epriestley committed rP324445589b5e: (stable) Fix an issue with destruction of Revision and Diff objects with… (authored by epriestley).
(stable) Fix an issue with destruction of Revision and Diff objects with…
Jul 22 2020, 8:20 PM
epriestley committed rP8f9ba4852861: Fix an issue with destruction of Revision and Diff objects with viewstates (authored by epriestley).
Fix an issue with destruction of Revision and Diff objects with viewstates
Jul 22 2020, 8:07 PM
epriestley closed D21421: Fix an issue with destruction of Revision and Diff objects with viewstates.
Jul 22 2020, 8:07 PM
epriestley requested review of D21421: Fix an issue with destruction of Revision and Diff objects with viewstates.
Jul 22 2020, 6:56 PM
epriestley added a comment to D21041: Use a named remote and branches for staging to help git-lfs.

If you believe you've found a bug in Phabricator, please report it on Discourse, including complete reproduction instructions.

Jul 22 2020, 2:07 AM
maroux added inline comments to D21041: Use a named remote and branches for staging to help git-lfs.
Jul 22 2020, 1:03 AM

Jul 21 2020

ipalencar updated ipalencar.
Jul 21 2020, 6:42 PM
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jul 21 2020, 6:24 PM · Guides, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jul 21 2020, 6:24 PM · Guides, Arcanist
epriestley triaged T13553: Creating a milestone via the API fails when accessing the project's parent as Normal priority.
Jul 21 2020, 5:54 PM · Transactions, Projects

Jul 20 2020

epriestley removed a member for Phacility Core Access: amckinley.
Jul 20 2020, 5:23 PM
epriestley removed a member for Phacility: amckinley.
Jul 20 2020, 5:23 PM
epriestley defrocked amckinley.
Jul 20 2020, 5:23 PM

Jul 18 2020

epriestley committed rPd32c3f8d7d65: (stable) Likely, fix a warning when rendering modified coverage (authored by epriestley).
(stable) Likely, fix a warning when rendering modified coverage
Jul 18 2020, 2:45 AM
epriestley committed rP0ed5569e9f7b: Likely, fix a warning when rendering modified coverage (authored by epriestley).
Likely, fix a warning when rendering modified coverage
Jul 18 2020, 2:45 AM
epriestley closed D21420: Likely, fix a warning when rendering modified coverage.
Jul 18 2020, 2:45 AM
epriestley requested review of D21420: Likely, fix a warning when rendering modified coverage.
Jul 18 2020, 2:45 AM

Jul 17 2020

epriestley committed rP37ffb71c4d5e: In source views, wrap display tabs in "user-select: all" to improve cursor… (authored by epriestley).
In source views, wrap display tabs in "user-select: all" to improve cursor…
Jul 17 2020, 10:10 PM
epriestley closed D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior.
Jul 17 2020, 10:10 PM
epriestley requested review of D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior.
Jul 17 2020, 10:08 PM
epriestley added a revision to T2495: Improve whitespace expansion of tab literals: D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior.
Jul 17 2020, 10:07 PM · Restricted Project, FreeBSD, Differential, Diffusion

Jul 16 2020

epriestley added a comment to T6769: Confusing UI when harbormaster fails but differential is accepted.

Please use Discourse to discuss Phabricator. (And please don't bump unrelated tasks from five and a half years ago.)

Jul 16 2020, 3:11 PM · Harbormaster
Kwisatz added a comment to T6769: Confusing UI when harbormaster fails but differential is accepted.

Is this really a harbormaster problem though? I would have located it within Differential.

Jul 16 2020, 12:49 PM · Harbormaster

Jul 12 2020

epriestley requested review of D21418: Improve desktop and mobile layouts for new "CommitGridView".
Jul 12 2020, 9:27 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21418: Improve desktop and mobile layouts for new "CommitGridView".
Jul 12 2020, 9:26 PM · Differential
epriestley requested review of D21417: Unify more build, property, auditor, and status information into "CommitGraphView".
Jul 12 2020, 7:47 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21417: Unify more build, property, auditor, and status information into "CommitGraphView".
Jul 12 2020, 7:45 PM · Differential
epriestley requested review of D21416: Clean up some minor commit list CSS.
Jul 12 2020, 6:04 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21416: Clean up some minor commit list CSS.
Jul 12 2020, 6:03 PM · Differential
epriestley requested review of D21415: Remove "PhabricatorAuditListView".
Jul 12 2020, 5:45 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21415: Remove "PhabricatorAuditListView".
Jul 12 2020, 5:44 PM · Differential
epriestley requested review of D21414: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView".
Jul 12 2020, 4:26 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21414: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView".
Jul 12 2020, 4:25 PM · Differential
epriestley requested review of D21413: Move the view of merged changes to "DiffusionCommitGraphView".
Jul 12 2020, 4:17 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21413: Move the view of merged changes to "DiffusionCommitGraphView".
Jul 12 2020, 4:16 PM · Differential
epriestley requested review of D21412: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView".
Jul 12 2020, 3:44 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21412: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView".
Jul 12 2020, 3:41 PM · Differential

Jul 11 2020

epriestley committed rARC2565cc7b4d1d: (stable) Promote 2020 Week 27 (authored by epriestley).
(stable) Promote 2020 Week 27
Jul 11 2020, 4:34 PM
epriestley edited the content of Changelog.
Jul 11 2020, 4:33 PM
epriestley committed rP2710a1e7aa42: (stable) Promote 2020 Week 27 (authored by epriestley).
(stable) Promote 2020 Week 27
Jul 11 2020, 4:32 PM
epriestley created an object: 2020 Week 27 (Mid July).
Jul 11 2020, 4:32 PM

Jul 10 2020

epriestley requested review of D21411: Improve rendering of history graph in "CommitGraphView".
Jul 10 2020, 6:46 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21411: Improve rendering of history graph in "CommitGraphView".
Jul 10 2020, 6:44 PM · Differential
epriestley requested review of D21410: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and "HistoryTableView".
Jul 10 2020, 6:22 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21410: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and "HistoryTableView".
Jul 10 2020, 6:20 PM · Differential
epriestley requested review of D21409: Remove the "Graph" view as a dedicated repository view.
Jul 10 2020, 5:57 PM