Page MenuHomePhabricator
Feed All Stories

Aug 15 2019

epriestley triaged T13376: Write about "add more logging / monitoring / tests" as Wishlist priority.
Aug 15 2019, 4:42 PM · Guides

Aug 13 2019

jcox awarded Changelog a Love token.
Aug 13 2019, 4:30 PM

Aug 12 2019

epriestley requested review of D20713: Add scaffolding for ad-hoc email addresses associated with Phortune accounts.
Aug 12 2019, 10:59 PM
epriestley added a revision to T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails: D20713: Add scaffolding for ad-hoc email addresses associated with Phortune accounts.
Aug 12 2019, 10:58 PM · Phortune, Phacility
epriestley committed rP82cf97ad65a9: When many commits are discovered at once, import them at lower priority (authored by epriestley).
When many commits are discovered at once, import them at lower priority
Aug 12 2019, 7:59 PM
epriestley closed D20712: When many commits are discovered at once, import them at lower priority.
Aug 12 2019, 7:59 PM
epriestley committed rP006cb659cbf1: Make the success message from "bin/config" more clear (authored by epriestley).
Make the success message from "bin/config" more clear
Aug 12 2019, 7:50 PM
epriestley closed D20711: Make the success message from "bin/config" more clear.
Aug 12 2019, 7:50 PM
epriestley committed rPc092492a53e0: Fix missing display cell in daemon summary table (authored by epriestley).
Fix missing display cell in daemon summary table
Aug 12 2019, 7:47 PM
epriestley closed D20710: Fix missing display cell in daemon summary table.
Aug 12 2019, 7:46 PM
epriestley closed T13374: Daemons summary table is missing a cell in the "Temporary Failures" row as Resolved by committing rPc092492a53e0: Fix missing display cell in daemon summary table.
Aug 12 2019, 7:46 PM · Daemons
epriestley requested review of D20712: When many commits are discovered at once, import them at lower priority.
Aug 12 2019, 7:11 PM
epriestley added a revision to T13369: When a large number of commits are pushed to a repository, import them at lower priority: D20712: When many commits are discovered at once, import them at lower priority.
Aug 12 2019, 7:09 PM · Daemons, Diffusion
epriestley requested review of D20711: Make the success message from "bin/config" more clear.
Aug 12 2019, 6:23 PM
epriestley added a revision to T13373: Clarify some messaging in `bin/config`: D20711: Make the success message from "bin/config" more clear.
Aug 12 2019, 6:22 PM · Setup, Config
epriestley requested review of D20710: Fix missing display cell in daemon summary table.
Aug 12 2019, 6:14 PM
epriestley added a revision to T13374: Daemons summary table is missing a cell in the "Temporary Failures" row: D20710: Fix missing display cell in daemon summary table.
Aug 12 2019, 6:12 PM · Daemons
epriestley added a comment to T731: Allow revisions to have alternate acceptance conditions.

See PHI1378, which is interested in "at least N", for N = 2.

Aug 12 2019, 5:42 PM · Restricted Project, Restricted Project, Differential
epriestley closed T13371: When instances change up/down status, start or stop their daemons as Resolved.

There was one issue with this: bin/host stop --instance X (which is rarely used, and has no prior automated callers) used --force, which stops all daemons on the host. The recent changes to the --force flag in D20601 also had an indirect impact here. I fixed this and redeployed the repo tier.

Aug 12 2019, 3:19 PM · Phacility
epriestley triaged T13375: Treat "'to'" address failures as permanent in Mailgun adapter as Low priority.
Aug 12 2019, 3:14 PM · Mail

Aug 11 2019

epriestley triaged T13374: Daemons summary table is missing a cell in the "Temporary Failures" row as Low priority.
Aug 11 2019, 8:24 PM · Daemons
epriestley edited the content of Changelog.
Aug 11 2019, 4:50 PM
epriestley committed rP26f9ba4684a8: (stable) Promote 2019 Week 32 (authored by epriestley).
(stable) Promote 2019 Week 32
Aug 11 2019, 4:49 PM
epriestley created an object: 2019 Week 32 (Early August).
Aug 11 2019, 4:48 PM
epriestley updated the task description for T13371: When instances change up/down status, start or stop their daemons.
Aug 11 2019, 4:40 PM · Phacility
epriestley added a revision to T13371: When instances change up/down status, start or stop their daemons: Unknown Object (Differential Revision).
Aug 11 2019, 4:38 PM · Phacility
epriestley added a revision to T13371: When instances change up/down status, start or stop their daemons: Unknown Object (Differential Revision).
Aug 11 2019, 4:35 PM · Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Aug 11 2019, 4:19 PM · Ops, Restricted Project, Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Aug 11 2019, 4:10 PM · Ops, Restricted Project, Phacility
epriestley closed T13372: Permanently remove references to "phd.bots" in "core/" as Resolved by committing Restricted Diffusion Commit.
Aug 11 2019, 3:57 PM · Phacility
epriestley added a revision to T13372: Permanently remove references to "phd.bots" in "core/": Unknown Object (Differential Revision).
Aug 11 2019, 3:55 PM · Phacility
epriestley triaged T13373: Clarify some messaging in `bin/config` as Low priority.
Aug 11 2019, 3:45 PM · Setup, Config
epriestley triaged T13372: Permanently remove references to "phd.bots" in "core/" as Low priority.
Aug 11 2019, 3:40 PM · Phacility
epriestley triaged T13371: When instances change up/down status, start or stop their daemons as Normal priority.
Aug 11 2019, 3:39 PM · Phacility

Aug 9 2019

avivey awarded T13369: When a large number of commits are pushed to a repository, import them at lower priority a Piece of Eight token.
Aug 9 2019, 6:46 PM · Daemons, Diffusion
epriestley committed rP0a3c26998fc9: When the feed query on project profile pages overheats, contain the damage (authored by epriestley).
When the feed query on project profile pages overheats, contain the damage
Aug 9 2019, 4:02 AM
epriestley closed D20704: When the feed query on project profile pages overheats, contain the damage.
Aug 9 2019, 4:01 AM

Aug 8 2019

epriestley committed rP9bd74dfa6c07: Autofocus the "App Code" input on the TOTP prompt during MFA gates after login (authored by epriestley).
Autofocus the "App Code" input on the TOTP prompt during MFA gates after login
Aug 8 2019, 7:54 PM
epriestley closed D20703: Autofocus the "App Code" input on the TOTP prompt during MFA gates after login.
Aug 8 2019, 7:54 PM
epriestley created P2122 synthace.js.
Aug 8 2019, 7:05 PM
epriestley requested review of D20704: When the feed query on project profile pages overheats, contain the damage.
Aug 8 2019, 5:39 PM
epriestley added a revision to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core: D20704: When the feed query on project profile pages overheats, contain the damage.
Aug 8 2019, 5:37 PM · Feed
epriestley added a comment to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core.

See downstream https://phabricator.wikimedia.org/T230001 for a similar issue on project pages.

Aug 8 2019, 5:31 PM · Feed
epriestley requested review of D20703: Autofocus the "App Code" input on the TOTP prompt during MFA gates after login.
Aug 8 2019, 5:29 PM
epriestley committed rP46d9065bf148: Drop test for awardable badges on "Badges" tab of user profiles to avoid… (authored by epriestley).
Drop test for awardable badges on "Badges" tab of user profiles to avoid…
Aug 8 2019, 5:19 PM
epriestley closed T13370: Badges tab on profile pages may overheat if user can not edit the first 10 badges as Resolved by committing rP46d9065bf148: Drop test for awardable badges on "Badges" tab of user profiles to avoid….
Aug 8 2019, 5:19 PM · Badges
epriestley closed D20702: Drop test for awardable badges on "Badges" tab of user profiles to avoid overheating.
Aug 8 2019, 5:19 PM
epriestley committed rP937edcdc580c: Fix a warning in BoardLayoutEngine when no objects are being updated (authored by epriestley).
Fix a warning in BoardLayoutEngine when no objects are being updated
Aug 8 2019, 5:18 PM
epriestley closed D20701: Fix a warning in BoardLayoutEngine when no objects are being updated.
Aug 8 2019, 5:18 PM
epriestley closed T13368: Correct several issues with "Move to Project..." on Workboards as Resolved by committing rP937edcdc580c: Fix a warning in BoardLayoutEngine when no objects are being updated.
Aug 8 2019, 5:18 PM · Workboards
epriestley requested review of D20702: Drop test for awardable badges on "Badges" tab of user profiles to avoid overheating.
Aug 8 2019, 5:17 PM
epriestley added a revision to T13370: Badges tab on profile pages may overheat if user can not edit the first 10 badges: D20702: Drop test for awardable badges on "Badges" tab of user profiles to avoid overheating.
Aug 8 2019, 5:16 PM · Badges
epriestley added a comment to T13370: Badges tab on profile pages may overheat if user can not edit the first 10 badges.

The repro case is something like:

Aug 8 2019, 5:14 PM · Badges
epriestley triaged T13370: Badges tab on profile pages may overheat if user can not edit the first 10 badges as Low priority.
Aug 8 2019, 5:11 PM · Badges
jmeador added a comment to D20221: Improve performance of "arc diff" updates for changes with large diff text.

Oh, good catch. Yeah, that would be an improvement.

use cases seem very weak.

Aug 8 2019, 4:19 PM
epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Aug 8 2019, 2:27 PM · Harbormaster
epriestley added a comment to D20221: Improve performance of "arc diff" updates for changes with large diff text.

Oh, good catch. Yeah, that would be an improvement.

Aug 8 2019, 2:23 PM
Yomi updated Yomi.
Aug 8 2019, 8:40 AM
jmeador added inline comments to D20221: Improve performance of "arc diff" updates for changes with large diff text.
Aug 8 2019, 12:12 AM

Aug 7 2019

epriestley triaged T13369: When a large number of commits are pushed to a repository, import them at lower priority as Low priority.
Aug 7 2019, 5:03 PM · Daemons, Diffusion
epriestley added a comment to T13123: Plans: Improve SSH key parsing and handling.

This thread suggests that some version of ssh-keygen is sensitive to trailing whitespace in private keys:

Aug 7 2019, 4:42 PM · Plans, Auth
fabe added a comment to T13358: Generate PDFs for Phortune invoices.

you can add libreoffice/soffice to your list. last time we had to do sth like this we used soffice --headless --convert-to pdf
not really better than running a browser though... in our use case we needed to use merchant uploaded doc/docx templates in combination with our data. so even less options.
but yeah most options around pdf generation are clunky.

Aug 7 2019, 4:30 PM · Phortune, Phacility
epriestley committed rP0561043a1f57: In "Move task to..." workflow, separate visible and hidden columns in the… (authored by epriestley).
In "Move task to..." workflow, separate visible and hidden columns in the…
Aug 7 2019, 4:24 PM
epriestley closed D20700: In "Move task to..." workflow, separate visible and hidden columns in the dropdown.
Aug 7 2019, 4:24 PM
epriestley committed rP6deac356599f: Don't show proxy (subproject/milestone) columns as options in "Move tasks..."… (authored by epriestley).
Don't show proxy (subproject/milestone) columns as options in "Move tasks..."…
Aug 7 2019, 4:23 PM
epriestley closed D20699: Don't show proxy (subproject/milestone) columns as options in "Move tasks..." workflows from workboards.
Aug 7 2019, 4:23 PM
epriestley committed rP31254c5124d5: Correct column options presented in "Move tasks to project..." on workboards (authored by epriestley).
Correct column options presented in "Move tasks to project..." on workboards
Aug 7 2019, 4:23 PM
epriestley closed D20698: Correct column options presented in "Move tasks to project..." on workboards.
Aug 7 2019, 4:23 PM
epriestley requested review of D20701: Fix a warning in BoardLayoutEngine when no objects are being updated.
Aug 7 2019, 4:21 PM
epriestley added a revision to T13368: Correct several issues with "Move to Project..." on Workboards: D20701: Fix a warning in BoardLayoutEngine when no objects are being updated.
Aug 7 2019, 4:20 PM · Workboards
epriestley requested review of D20700: In "Move task to..." workflow, separate visible and hidden columns in the dropdown.
Aug 7 2019, 4:20 PM
epriestley added a revision to T13368: Correct several issues with "Move to Project..." on Workboards: D20700: In "Move task to..." workflow, separate visible and hidden columns in the dropdown.
Aug 7 2019, 4:18 PM · Workboards
epriestley requested review of D20699: Don't show proxy (subproject/milestone) columns as options in "Move tasks..." workflows from workboards.
Aug 7 2019, 4:12 PM
epriestley added a revision to T13368: Correct several issues with "Move to Project..." on Workboards: D20699: Don't show proxy (subproject/milestone) columns as options in "Move tasks..." workflows from workboards.
Aug 7 2019, 4:10 PM · Workboards
epriestley requested review of D20698: Correct column options presented in "Move tasks to project..." on workboards.
Aug 7 2019, 4:09 PM
epriestley added a revision to T13368: Correct several issues with "Move to Project..." on Workboards: D20698: Correct column options presented in "Move tasks to project..." on workboards.
Aug 7 2019, 4:08 PM · Workboards
epriestley triaged T13368: Correct several issues with "Move to Project..." on Workboards as Low priority.
Aug 7 2019, 4:06 PM · Workboards
epriestley added a comment to T13358: Generate PDFs for Phortune invoices.

Yeah, I'm really hoping to not require us to run an entire browser or depend on an external service to generate PDFs. The approaches I found in my research were:

Aug 7 2019, 3:36 PM · Phortune, Phacility
magnetik added a comment to T13358: Generate PDFs for Phortune invoices.

Just my two cents here, but chrome has an headless mode that allows to "print to pdf" : https://developers.google.com/web/updates/2017/04/headless-chrome

Aug 7 2019, 3:11 PM · Phortune, Phacility
seporaitis updated seporaitis.
Aug 7 2019, 12:31 PM

Aug 5 2019

ztas updated ztas.
Aug 5 2019, 10:44 PM
epriestley added a comment to T13358: Generate PDFs for Phortune invoices.

When I apt-get install wkhtmltopdf (or something like that) on aux001, which is Ubuntu 14, I get this:

Aug 5 2019, 12:33 AM · Phortune, Phacility

Aug 4 2019

avivey added a comment to T13358: Generate PDFs for Phortune invoices.

I've worked with wkhtmltopdf several times, and I don't remember it actually requiring any special setup - in all cases, I basically dropped the binary in the machine (Although it's possible all my machines had X11 built in for some reason? I've never intentionally installed X11).

Aug 4 2019, 7:02 PM · Phortune, Phacility

Aug 2 2019

epriestley added a comment to T13358: Generate PDFs for Phortune invoices.

Just some observations after popping open PDF invoices which have shown up in my inbox recently:

Aug 2 2019, 11:18 PM · Phortune, Phacility
epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

See PHI1367, which featured a specific case where git repack unambiguously did something good instead of being magic fairy dust that we sprinkle around to ward off demons.

Aug 2 2019, 10:07 PM · Phacility, Diffusion
epriestley requested review of D20697: Refactor the Phortune account detail page into a series of smaller, more focused sections.
Aug 2 2019, 6:57 PM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20697: Refactor the Phortune account detail page into a series of smaller, more focused sections.
Aug 2 2019, 6:55 PM · Phortune, Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 2 2019, 6:52 PM · Phortune, Phacility
epriestley triaged T13367: Phortune "enterprise" update errata as Low priority.
Aug 2 2019, 6:49 PM · Phortune, Phacility
epriestley added a comment to T13366: Update Phortune to work better with "enterprise" billing/accounts departments.

This is also more "while I'm here", but there's no web UI way to void an invoice right now. It would be nice to have a "Void Invoice" button for staff instead of requiring database fiddling, since this comes up occasionally.

Aug 2 2019, 6:37 PM · Phortune, Phacility
epriestley committed rP87f878ec8a77: Stop trying to CC merchants on invoices/receipts (authored by epriestley).
Stop trying to CC merchants on invoices/receipts
Aug 2 2019, 5:51 PM
epriestley closed T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22, a subtask of T13366: Update Phortune to work better with "enterprise" billing/accounts departments, as Resolved.
Aug 2 2019, 5:51 PM · Phortune, Phacility
epriestley closed T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22 as Resolved by committing rP87f878ec8a77: Stop trying to CC merchants on invoices/receipts.
Aug 2 2019, 5:51 PM · Phortune, Phacility
epriestley closed D20696: Stop trying to CC merchants on invoices/receipts.
Aug 2 2019, 5:51 PM
epriestley requested review of D20696: Stop trying to CC merchants on invoices/receipts.
Aug 2 2019, 5:50 PM
epriestley added a revision to T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22: D20696: Stop trying to CC merchants on invoices/receipts.
Aug 2 2019, 5:48 PM · Phortune, Phacility
epriestley added a comment to T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22.

Per T13366, I'm just going to get rid of this behavior for now, with the expectation that we'll soon begin generating side-channel emails for "Billing Department Email Address" under the umbrella of T8389 and could put "Merchant Emails" on a similar channel if we want.

Aug 2 2019, 5:43 PM · Phortune, Phacility
epriestley added a parent task for T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley added a parent task for T7607: Invoicing emails probably need some work: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley added a parent task for T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility