Page MenuHomePhabricator
Feed All Stories

Jun 13 2019

epriestley added a revision to T13309: Git protocol proxy can not parse protocol frames if repository on disk is a shallow clone: D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.
Jun 13 2019, 11:31 PM · Diffusion
epriestley added a comment to T13309: Git protocol proxy can not parse protocol frames if repository on disk is a shallow clone.

The shallow <hash> frames can not advertise capabilities.

Jun 13 2019, 11:28 PM · Diffusion
epriestley added a comment to T13309: Git protocol proxy can not parse protocol frames if repository on disk is a shallow clone.

Here's what goes over the wire:

Jun 13 2019, 10:46 PM · Diffusion
epriestley added a comment to T13309: Git protocol proxy can not parse protocol frames if repository on disk is a shallow clone.

To reproduce this, you can:

Jun 13 2019, 10:42 PM · Diffusion
epriestley created T13309: Git protocol proxy can not parse protocol frames if repository on disk is a shallow clone.
Jun 13 2019, 10:42 PM · Diffusion
epriestley added a revision to T13308: Phacility account import flow can misfire when both invites and account links are present: Unknown Object (Differential Revision).
Jun 13 2019, 10:15 PM · Phacility
epriestley added a comment to T13308: Phacility account import flow can misfire when both invites and account links are present.

To reproduce the first issue, do this:

Jun 13 2019, 8:43 PM · Phacility
epriestley created T13308: Phacility account import flow can misfire when both invites and account links are present.
Jun 13 2019, 8:23 PM · Phacility
epriestley added a revision to T13146: Phacility account import tool fails to recognize usernames with differing case, e.g. "Alice" vs "alice": Unknown Object (Differential Revision).
Jun 13 2019, 8:10 PM · Phacility

Jun 11 2019

epriestley updated the task description for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Jun 11 2019, 6:18 PM · Arcanist, Differential

Jun 6 2019

epriestley added a comment to D20574: Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT".

Ignore this, test.

Jun 6 2019, 2:35 AM
epriestley requested review of D20574: Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT".
Jun 6 2019, 2:25 AM
epriestley added a project to T13307: "Sign With MFA" requires "CAN_EDIT" permission, but should only require "CAN_INTERACT" permission: Auth.
Jun 6 2019, 2:23 AM · Auth
epriestley added a revision to T13307: "Sign With MFA" requires "CAN_EDIT" permission, but should only require "CAN_INTERACT" permission: D20574: Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT".
Jun 6 2019, 2:23 AM · Auth
epriestley created T13307: "Sign With MFA" requires "CAN_EDIT" permission, but should only require "CAN_INTERACT" permission.
Jun 6 2019, 2:18 AM · Auth
epriestley added a subtask for T10469: Implement "Tabs", an amazing feature where multiple different pages are loaded in the same browser window!: T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.
Jun 6 2019, 1:58 AM · Quicksand, Feature Request, Workboards
epriestley added a parent task for T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it: T10469: Implement "Tabs", an amazing feature where multiple different pages are loaded in the same browser window!.
Jun 6 2019, 1:58 AM · Quicksand
epriestley renamed T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it from With Quicksand enabled, "Choose Subtype" dialog on "Create Subtask" workflow is not dismissed by making a selection to When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.
Jun 6 2019, 1:57 AM · Quicksand
epriestley added a comment to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.

D20573 will fix this, but perhaps not in the most graceful way possible.

Jun 6 2019, 1:56 AM · Quicksand
epriestley requested review of D20573: When a user clicks a navigation link in a dialog, close the dialog.
Jun 6 2019, 1:52 AM
epriestley added a revision to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it: D20573: When a user clicks a navigation link in a dialog, close the dialog.
Jun 6 2019, 1:50 AM · Quicksand

Jun 5 2019

epriestley requested review of D20572: Recommend dumping database backups with "--compress --output X" instead of "| gzip > X".
Jun 5 2019, 10:02 PM
epriestley added a revision to T13304: Phabricator "Backups" instructions are somewhat out of date: D20572: Recommend dumping database backups with "--compress --output X" instead of "| gzip > X".
Jun 5 2019, 10:00 PM · Database
epriestley requested review of D20571: Add "bin/file migrate" options to support import of a local-disk backup for Phacility instances.
Jun 5 2019, 9:38 PM
epriestley added a revision to T13306: Provide a mechanism for importing local disk file backups into the Phacility cluster: D20571: Add "bin/file migrate" options to support import of a local-disk backup for Phacility instances.
Jun 5 2019, 9:36 PM · Phacility, Files
epriestley requested review of D20570: Skip loading transaction handles in an old migration.
Jun 5 2019, 6:44 PM
epriestley added a revision to T13305: Migration "20180208.maniphest.02.populate.php" may fail when queueing indexing tasks: D20570: Skip loading transaction handles in an old migration.
Jun 5 2019, 6:43 PM · Installing & Upgrading, Database
epriestley claimed T13306: Provide a mechanism for importing local disk file backups into the Phacility cluster.
Jun 5 2019, 5:59 PM · Phacility, Files
epriestley created T13306: Provide a mechanism for importing local disk file backups into the Phacility cluster.
Jun 5 2019, 5:59 PM · Phacility, Files
epriestley added a comment to T13305: Migration "20180208.maniphest.02.populate.php" may fail when queueing indexing tasks.

I applied this change to 20180208.maniphest.02.populate.php:

Jun 5 2019, 5:24 PM · Installing & Upgrading, Database
epriestley created T13305: Migration "20180208.maniphest.02.populate.php" may fail when queueing indexing tasks.
Jun 5 2019, 5:18 PM · Installing & Upgrading, Database
yelirekim added a comment to T13289: Plans: 2019 Week 21-23 Bonus Content.

Meow Meow

Jun 5 2019, 4:19 PM · Plans
epriestley committed rPf1a588c771f6: Add a basic profiler to Herald transcripts (authored by epriestley).
Add a basic profiler to Herald transcripts
Jun 5 2019, 3:50 PM
epriestley closed D20566: Add a basic profiler to Herald transcripts.
Jun 5 2019, 3:50 PM
epriestley created T13304: Phabricator "Backups" instructions are somewhat out of date.
Jun 5 2019, 3:26 PM · Database

Jun 4 2019

epriestley committed rPb7aacaa4d30b: Differentiate Remarkup header sizes more clearly (authored by epriestley).
Differentiate Remarkup header sizes more clearly
Jun 4 2019, 11:03 PM
epriestley closed D20569: Differentiate Remarkup header sizes more clearly.
Jun 4 2019, 11:03 PM
epriestley added inline comments to D20566: Add a basic profiler to Herald transcripts.
Jun 4 2019, 9:29 PM
D20566: Add a basic profiler to Herald transcripts is now accepted and ready to land.
Jun 4 2019, 9:26 PM
amckinley awarded D20569: Differentiate Remarkup header sizes more clearly a Party Time token.
Jun 4 2019, 9:18 PM
D20569: Differentiate Remarkup header sizes more clearly is now accepted and ready to land.
Jun 4 2019, 9:18 PM
epriestley merged T10307: Option to move child pages when parent in renamed into T6004: When moving a wiki page with subpages prompt to also move subpages.
Jun 4 2019, 8:01 PM · Phriction
epriestley merged task T10307: Option to move child pages when parent in renamed into T6004: When moving a wiki page with subpages prompt to also move subpages.
Jun 4 2019, 8:01 PM · Feature Request, Phriction
epriestley added a comment to T6004: When moving a wiki page with subpages prompt to also move subpages.

See also PHI1275. Now that Phriction supports relative references in [[ ... ]] syntax, moves should be able to modify those references.

Jun 4 2019, 7:46 PM · Phriction
epriestley added 1 mock(s) for T13289: Plans: 2019 Week 21-23 Bonus Content: M1479: Meow Meow.
Jun 4 2019, 7:38 PM · Plans
epriestley added 1 task(s) for M1479: Meow Meow: T13289: Plans: 2019 Week 21-23 Bonus Content.
Jun 4 2019, 7:38 PM
epriestley added a comment to T13289: Plans: 2019 Week 21-23 Bonus Content.

  • Jun 4 2019, 7:37 PM · Plans
    epriestley updated images of M1479: Meow Meow.
    Jun 4 2019, 7:36 PM
    epriestley added a comment to D20569: Differentiate Remarkup header sizes more clearly.

    New before:

    Jun 4 2019, 7:26 PM
    epriestley added inline comments to D20569: Differentiate Remarkup header sizes more clearly.
    Jun 4 2019, 7:25 PM
    epriestley added a comment to D20569: Differentiate Remarkup header sizes more clearly.
    • Remove "h1" rule, which is never used (the largest header is "<h2>", with the page header being "<h1>").
    • Adjust sizes a bit more.
    • Remove redundant weird override in some other file.
    • Simplify margins slightly.
    Jun 4 2019, 7:25 PM
    epriestley added a comment to D20569: Differentiate Remarkup header sizes more clearly.

    This also means that the actual page header (for example, the document title on a Phriction page) may be smaller than an <h1> in the same document.

    Jun 4 2019, 7:13 PM
    epriestley requested review of D20569: Differentiate Remarkup header sizes more clearly.
    Jun 4 2019, 7:09 PM
    epriestley added a comment to D20568: Parse remarkup tables with something like a real parser instead of regular expressions.
    • Add a couple of extra non-semantic newlines to the test cases for prettiness.
    Jun 4 2019, 4:37 PM
    epriestley added inline comments to D20568: Parse remarkup tables with something like a real parser instead of regular expressions.
    Jun 4 2019, 4:36 PM
    epriestley requested review of D20568: Parse remarkup tables with something like a real parser instead of regular expressions.
    Jun 4 2019, 4:32 PM
    epriestley added a revision to T13160: Support <colgroup> in the verbose remarkup <table> syntax for specifying column widths: D20568: Parse remarkup tables with something like a real parser instead of regular expressions.
    Jun 4 2019, 4:32 PM · Remarkup
    epriestley committed rPd7890d08b828: Add "bin/herald rule ..." to modify Herald rules from the CLI (authored by epriestley).
    Add "bin/herald rule ..." to modify Herald rules from the CLI
    Jun 4 2019, 2:12 PM
    epriestley closed D20567: Add "bin/herald rule ..." to modify Herald rules from the CLI.
    Jun 4 2019, 2:12 PM
    epriestley added a comment to D20567: Add "bin/herald rule ..." to modify Herald rules from the CLI.
    • More wordsmithing.
    Jun 4 2019, 2:02 PM
    epriestley committed rP760406762a6f: When a revision is closed, always promote it out of draft (authored by epriestley).
    When a revision is closed, always promote it out of draft
    Jun 4 2019, 1:56 PM
    epriestley closed D20565: When a revision is closed, always promote it out of draft.
    Jun 4 2019, 1:56 PM
    epriestley closed T13300: When a "Draft" revision is closed into "Published" (not "Abandoned"), it should immediately promote as Resolved by committing rP760406762a6f: When a revision is closed, always promote it out of draft.
    Jun 4 2019, 1:56 PM · Diffusion, Differential

    Jun 2 2019

    epriestley added a comment to D20567: Add "bin/herald rule ..." to modify Herald rules from the CLI.

    Oh, I edited "an to edit" into "an rule to edit" or something. Perhaps not my greatest work.

    Jun 2 2019, 2:30 PM
    D20567: Add "bin/herald rule ..." to modify Herald rules from the CLI is now accepted and ready to land.
    Jun 2 2019, 8:33 AM
    D20565: When a revision is closed, always promote it out of draft is now accepted and ready to land.
    Jun 2 2019, 8:28 AM

    May 31 2019

    epriestley added a comment to D20567: Add "bin/herald rule ..." to modify Herald rules from the CLI.
    • Wordsmithing.
    May 31 2019, 4:32 PM
    jmeador added inline comments to D20567: Add "bin/herald rule ..." to modify Herald rules from the CLI.
    May 31 2019, 4:30 PM
    epriestley requested review of D20567: Add "bin/herald rule ..." to modify Herald rules from the CLI.
    May 31 2019, 3:01 PM
    epriestley added a revision to T13298: Improve Herald profiling information available in transcripts: D20567: Add "bin/herald rule ..." to modify Herald rules from the CLI.
    May 31 2019, 2:59 PM · Herald
    epriestley requested review of D20566: Add a basic profiler to Herald transcripts.
    May 31 2019, 2:34 PM
    epriestley added a revision to T13298: Improve Herald profiling information available in transcripts: D20566: Add a basic profiler to Herald transcripts.
    May 31 2019, 2:33 PM · Herald
    epriestley requested review of D20565: When a revision is closed, always promote it out of draft.
    May 31 2019, 1:19 PM
    epriestley added a revision to T13300: When a "Draft" revision is closed into "Published" (not "Abandoned"), it should immediately promote: D20565: When a revision is closed, always promote it out of draft.
    May 31 2019, 1:18 PM · Diffusion, Differential
    joshuaspence abandoned D19795: Allow searching for Maniphest tasks by parent/subtask ID.
    May 31 2019, 8:16 AM
    epriestley committed rP67f062b0049d: When triggering audits, count "Accepted" revisions as successfully reviewed (authored by epriestley).
    When triggering audits, count "Accepted" revisions as successfully reviewed
    May 31 2019, 12:18 AM
    epriestley closed D20564: When triggering audits, count "Accepted" revisions as successfully reviewed.
    May 31 2019, 12:18 AM
    epriestley committed rP81134d7e7d54: After reloading transactions for the recipient while building transaction mail… (authored by epriestley).
    After reloading transactions for the recipient while building transaction mail…
    May 31 2019, 12:15 AM
    epriestley closed D20563: After reloading transactions for the recipient while building transaction mail, put them in the input order.
    May 31 2019, 12:15 AM

    May 30 2019

    D20564: When triggering audits, count "Accepted" revisions as successfully reviewed is now accepted and ready to land.
    May 30 2019, 11:52 PM
    D20563: After reloading transactions for the recipient while building transaction mail, put them in the input order is now accepted and ready to land.
    May 30 2019, 11:50 PM
    epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
    May 30 2019, 11:48 PM · Plans
    epriestley added a comment to T13297: "vi" and "vim" may exit with errors even though edits succeed.

    I'm just going to close this in the hope it fades quietly into the night now that it has been "fixed".

    May 30 2019, 11:47 PM · Arcanist
    epriestley added a comment to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.

    D20563 probably fixes mail. I don't think (?) it will fix notifications but haven't hunted that down yet.

    May 30 2019, 11:15 PM · Transactions
    epriestley requested review of D20564: When triggering audits, count "Accepted" revisions as successfully reviewed.
    May 30 2019, 11:08 PM
    epriestley requested review of D20563: After reloading transactions for the recipient while building transaction mail, put them in the input order.
    May 30 2019, 10:39 PM
    epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: D20563: After reloading transactions for the recipient while building transaction mail, put them in the input order.
    May 30 2019, 10:37 PM · Transactions
    epriestley committed rP9a32a563f047: Add a "View Task" button to HTML mail from Maniphest (authored by epriestley).
    Add a "View Task" button to HTML mail from Maniphest
    May 30 2019, 10:24 PM
    epriestley closed D20561: Add a "View Task" button to HTML mail from Maniphest.
    May 30 2019, 10:24 PM
    epriestley added a comment to D20561: Add a "View Task" button to HTML mail from Maniphest.
    • Share more API in Differential.
    • Add support in Diffusion for good measure.
    May 30 2019, 10:22 PM
    epriestley committed rPfb5dec4c036b: Require valid comments to contain at least one non-whitespace character (authored by epriestley).
    Require valid comments to contain at least one non-whitespace character
    May 30 2019, 10:15 PM
    epriestley closed D20562: Require valid comments to contain at least one non-whitespace character.
    May 30 2019, 10:15 PM
    epriestley committed rP874720480775: Clean up "phabricator.timezone" configuration instructions a little bit (authored by epriestley).
    Clean up "phabricator.timezone" configuration instructions a little bit
    May 30 2019, 10:08 PM
    epriestley closed D20560: Clean up "phabricator.timezone" configuration instructions a little bit.
    May 30 2019, 10:08 PM
    epriestley committed rPe5a16819031e: Render timezone names more readably, with spaces rather than underscores… (authored by epriestley).
    Render timezone names more readably, with spaces rather than underscores…
    May 30 2019, 10:03 PM
    epriestley closed D20559: Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles")..
    May 30 2019, 10:03 PM
    D20562: Require valid comments to contain at least one non-whitespace character is now accepted and ready to land.
    May 30 2019, 7:37 PM
    epriestley requested review of D20562: Require valid comments to contain at least one non-whitespace character.
    May 30 2019, 7:28 PM
    epriestley updated the task description for T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.
    May 30 2019, 7:10 PM · Quicksand
    epriestley renamed T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes from There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changs to There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.
    May 30 2019, 7:09 PM · Transactions