- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
May 26 2022
May 26 2022
epriestley committed rP9dad49472c04: Move Slowvote vote types to a separate object (authored by epriestley).
Move Slowvote vote types to a separate object
- Update some file/class names.
epriestley committed rP9f075839a23f: Update Slowvote to use sensible string constants for response visibility (authored by epriestley).
Update Slowvote to use sensible string constants for response visibility
epriestley committed rP23094b495024: Move Slowvote response visibility to a separate object (authored by epriestley).
Move Slowvote response visibility to a separate object
epriestley committed rPb1533e5468b1: Migrate "SlowvotePoll" to modern mailkey storage (authored by epriestley).
Migrate "SlowvotePoll" to modern mailkey storage
epriestley committed rPd91727e66ceb: Update nonstandard PHID key on "SlowvotePoll" (authored by epriestley).
Update nonstandard PHID key on "SlowvotePoll"
After recent changes, only DifferentialRevision and ManiphestTask still have onboard mail keys.
May 25 2022
May 25 2022
epriestley committed rP7e5f7b96404f: Update "Files" attachment table to show more attachment details and support… (authored by epriestley).
Update "Files" attachment table to show more attachment details and support…
epriestley added a comment to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
"PhabricatorApplicationTransactionCommentView->setDraft()" has exactly two callers: one in Slowvote...
epriestley committed rP5aa159a83013: Pass "object" to modular transaction methods explicitly (authored by epriestley).
Pass "object" to modular transaction methods explicitly
May 24 2022
May 24 2022
epriestley committed rP8e703c8c351d: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" (authored by epriestley).
Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery"
epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
epriestley committed rP5493f028dca6: Provide a simple "Attach File" explicit workflow for files referenced but not… (authored by epriestley).
Provide a simple "Attach File" explicit workflow for files referenced but not…
epriestley updated the diff for D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.
- Rebuild Celerity map.
epriestley updated the diff for D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.
- Correct some translation strings.
May 23 2022
May 23 2022
epriestley committed rP021e5ab933e4: Provide a rudimentary "Attached Files" curtain UI panel (authored by epriestley).
Provide a rudimentary "Attached Files" curtain UI panel
epriestley committed rP5033ef6f88b3: Give "FileAttachment" policy support and a query object (authored by epriestley).
Give "FileAttachment" policy support and a query object
epriestley committed rP631c36aee326: Don't consider file references inside quoted text blocks to grant "attachment… (authored by epriestley).
Don't consider file references inside quoted text blocks to grant "attachment…
epriestley committed rP2a0feb3de0e2: Only attach files that are both referenced in Remarkup and attached by explicit… (authored by epriestley).
Only attach files that are both referenced in Remarkup and attached by explicit…
- Further improve unit test coverage and test "reference doesn't grant view permission".
- Also fix indirect reference attachment/scrambling test.
- Fix unit test.
epriestley committed rP8cd02e6727e3: Provide missing default attachment list for Files transactions (authored by epriestley).
Provide missing default attachment list for Files transactions
epriestley requested review of D21834: Provide missing default attachment list for Files transactions.
May 20 2022
May 20 2022
epriestley committed rPcc44ae32c546: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl" (authored by epriestley).
Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl"
epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
epriestley requested review of D21831: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl".
May 19 2022
May 19 2022
epriestley committed rP42876de60d28: Generate file attachment transactions for explicit Remarkup attachments on… (authored by epriestley).
Generate file attachment transactions for explicit Remarkup attachments on…
epriestley committed rPfee8297121f0: Remove file attachment edge types, including API access (authored by epriestley).
Remove file attachment edge types, including API access
epriestley committed rPb872640c160a: Remove all "FileHasObject" edge reads and writes (authored by epriestley).
Remove all "FileHasObject" edge reads and writes
epriestley committed rPc25a8fabfc1e: Remove all "ObjectHasFile" edge reads and writes (authored by epriestley).
Remove all "ObjectHasFile" edge reads and writes
epriestley committed rP0329df0fa8d4: Copy file attachment edges to new storage (authored by epriestley).
Copy file attachment edges to new storage
epriestley committed rP4a2d961e7632: Adjust paste content transaction to support earlier file PHID extraction (authored by epriestley).
Adjust paste content transaction to support earlier file PHID extraction
epriestley committed rPd017f3f21021: Double-write file attachment to old "edge" storage and new "attachment" storage (authored by epriestley).
Double-write file attachment to old "edge" storage and new "attachment" storage
epriestley committed rP7fcc0f9ebd91: Remove "PhabricatorFile->detachFromObject()" (authored by epriestley).
Remove "PhabricatorFile->detachFromObject()"
epriestley committed rPcfa42c5e655c: Add database storage for a dedicated file attachment table (authored by epriestley).
Add database storage for a dedicated file attachment table
epriestley committed rP6fea5e5ce7d5: Do not extract file PHIDs from remarkup blocks for attachment (authored by epriestley).
Do not extract file PHIDs from remarkup blocks for attachment
epriestley triaged T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default" as Normal priority.
epriestley abandoned D21829: Generate attachment edges from drag-and-dropped files in stacked comments.
This is likely easier to implement by unifying it more closely with the non-comment pathway, and representing it as metadata on the transaction at this level (rather than as a separate transaction).
- Perform this migration entirely in SQL instead.
epriestley committed rPee6e2a396fec: Fix some test suite stragglers with PHP 8.1 compatibility (authored by epriestley).
Fix some test suite stragglers with PHP 8.1 compatibility
epriestley committed rP7693a711a725: Persist remarkup metadata in "VersionedDrafts" and record explicit file uploads (authored by epriestley).
Persist remarkup metadata in "VersionedDrafts" and record explicit file uploads