Page MenuHomePhabricator
Feed All Stories

Mar 25 2021

epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21650: Fix an issue when undoing mutiple inline comment deletions.
Mar 25 2021, 9:03 PM · Accessibility, Differential
epriestley requested review of D21649: Make the client authoritative for "Cancel" actions.
Mar 25 2021, 9:01 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21649: Make the client authoritative for "Cancel" actions.
Mar 25 2021, 9:00 PM · Accessibility, Differential
epriestley requested review of D21648: Make the client authoritative for "Save" actions.
Mar 25 2021, 8:59 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21648: Make the client authoritative for "Save" actions.
Mar 25 2021, 8:58 PM · Accessibility, Differential
epriestley requested review of D21647: Remove direct reads of form state from main Inline client code.
Mar 25 2021, 8:57 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21647: Remove direct reads of form state from main Inline client code.
Mar 25 2021, 8:56 PM · Accessibility, Differential
epriestley requested review of D21646: Make client inlines track an "active" state.
Mar 25 2021, 8:55 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21646: Make client inlines track an "active" state.
Mar 25 2021, 8:54 PM · Accessibility, Differential
epriestley requested review of D21645: Make inline "ContentState" a client object, and track "hasSuggestion" on it.
Mar 25 2021, 8:52 PM
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21645: Make inline "ContentState" a client object, and track "hasSuggestion" on it.
Mar 25 2021, 8:51 PM · Accessibility, Differential
epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

The "Cancel" button should mean "Delete" if...

Mar 25 2021, 8:21 PM · Accessibility, Differential
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 25 2021, 6:16 PM · Accessibility, Differential
epriestley triaged T13646: Add "E" to "variables_order" in Phacility environments as Low priority.
Mar 25 2021, 3:31 PM · Phacility, Infrastructure

Mar 24 2021

epriestley committed rP61272e7ac31a: Correct "getActiveBindings()" method name (authored by epriestley).
Correct "getActiveBindings()" method name
Mar 24 2021, 5:15 PM
epriestley closed D21644: Correct "getActiveBindings()" method name.
Mar 24 2021, 5:15 PM
epriestley requested review of D21644: Correct "getActiveBindings()" method name.
Mar 24 2021, 5:13 PM

Mar 23 2021

epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

Currently, the inline code partially conflates four separate content states:

Mar 23 2021, 5:57 PM · Accessibility, Differential
20after4 awarded T12843: Add support for creating workboard columns from the Conduit API a Baby Tequila token.
Mar 23 2021, 3:08 PM · Conduit, Projects, Workboards, Feature Request

Mar 22 2021

epriestley committed rARCf0f95e5b2612: On Windows, implement "Filesystem::copyFile()" with "copy()" (authored by epriestley).
On Windows, implement "Filesystem::copyFile()" with "copy()"
Mar 22 2021, 7:00 PM
epriestley closed D21643: On Windows, implement "Filesystem::copyFile()" with "copy()".
Mar 22 2021, 7:00 PM
epriestley renamed T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions from Filesystem class invokes "copy" command on Windows, which fails after "bypass_shell" changes to Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.
Mar 22 2021, 7:00 PM · Windows, Arcanist
epriestley added a comment to T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.

D21643 "fixes" this by using copy(). However:

Mar 22 2021, 6:59 PM · Windows, Arcanist
epriestley requested review of D21643: On Windows, implement "Filesystem::copyFile()" with "copy()".
Mar 22 2021, 6:43 PM
epriestley added a revision to T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions: D21643: On Windows, implement "Filesystem::copyFile()" with "copy()".
Mar 22 2021, 6:43 PM · Windows, Arcanist
epriestley updated the task description for T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.
Mar 22 2021, 6:14 PM · Windows, Arcanist
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 22 2021, 6:13 PM · Accessibility, Differential
epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

When you "Quote" a comment, then cancel, the comment disappears from the UI.

Mar 22 2021, 5:36 PM · Accessibility, Differential
epriestley updated the task description for T13534: Inline Comment errata after editing persistence.
Mar 22 2021, 5:32 PM · Differential
epriestley added a comment to T13534: Inline Comment errata after editing persistence.

When you are viewing a change under engine X, and comments made under engine Y are present, they are not handled specially.

Mar 22 2021, 5:32 PM · Differential
epriestley updated the task description for T13642: Inline comment line numbers on DocumentEngine block diffs may be clamped to raw lines in the source file.
Mar 22 2021, 5:31 PM · Differential

Mar 20 2021

epriestley added a comment to D21624: Remove or correct various "phabricator/" references to "libphutil".

Diviner updates based on the deployed software version on secure, and I just haven't deployed this yet. Stuff usually gets deployed in about a day, this has been on the slower side since I've been moving furniture.

Mar 20 2021, 3:55 PM
jrtc27 added a comment to D21624: Remove or correct various "phabricator/" references to "libphutil".

I stumbled across its mention in the Arcanist Quick Start doc whilst setting up a new machine today so went to write a patch before realising that you'd just fixed this a few days ago. Is it expected that Diviner has yet to update?

Mar 20 2021, 10:58 AM

Mar 18 2021

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 18 2021, 6:45 PM · Accessibility, Differential
epriestley requested review of D21642: Fix an issue where inlines could be duplicated in the client list.
Mar 18 2021, 6:40 PM
epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Mar 18 2021, 6:39 PM · Accessibility, Differential
epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21642: Fix an issue where inlines could be duplicated in the client list.
Mar 18 2021, 6:33 PM · Accessibility, Differential

Mar 17 2021

epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".

A general concern with "batch processing" is that it's quite bad if one commit failing to import can stall the entire repository forever.

Mar 17 2021, 11:18 PM · Diffusion, Differential
epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".

See also T13552, which modifies the above discussion. The "Update" steps now happen after the "Publish" step.

Mar 17 2021, 11:12 PM · Diffusion, Differential
epriestley closed T13425: Support diffs between abstract block lists in the UI as Resolved.

The bulk of this work is done and I think there's nothing unique and actionable left here. This is survived by T13642 and other issues.

Mar 17 2021, 11:07 PM · Differential
epriestley closed T13515: Differential: Inlines and View Options as Resolved.

Survived by T13534, etc.

Mar 17 2021, 11:01 PM · Differential
epriestley updated the task description for T13534: Inline Comment errata after editing persistence.
Mar 17 2021, 11:00 PM · Differential
epriestley updated the task description for T13515: Differential: Inlines and View Options.
Mar 17 2021, 11:00 PM · Differential
epriestley closed T13513: Make schema changes to inlines to prepare for new inline features as Resolved.

When you are viewing a document with engine X, and comments originally made with engine Y are present, this should be indicated ("This comment was made while looking at this change as a Q document."). They should probably also be moved to the top/bottom of the file, at least by default, since "Jupyter line number 9 = raw source line number 9" is an exceptionally bad and confusing guess at how to map line numbers.

Mar 17 2021, 10:59 PM · Inline Comments, Diffusion, Differential
epriestley closed T13513: Make schema changes to inlines to prepare for new inline features, a subtask of T13515: Differential: Inlines and View Options, as Resolved.
Mar 17 2021, 10:59 PM · Differential
epriestley updated the task description for T13534: Inline Comment errata after editing persistence.
Mar 17 2021, 10:59 PM · Differential
epriestley closed T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch as Resolved.

Some tag stuff ended up here; I moved it to T13645.

Mar 17 2021, 10:47 PM · Differential
epriestley updated the task description for T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.
Mar 17 2021, 10:46 PM · Differential
epriestley triaged T13645: In Diffusion "Tags" view, improve behavior for tags that point at tag objects as Low priority.
Mar 17 2021, 10:45 PM · Diffusion
epriestley closed T13638: Investigate "AllowEncodedSlashes" Apache setting as Resolved.

Given the generally high degree of mootness here, I'm not planning to add a setup test or recommend installs adjust the setting.

Mar 17 2021, 10:40 PM · Setup
epriestley closed T13644: Command-clicking a changeset header in Differential attempts to perform symbol lookup as Resolved.
Mar 17 2021, 10:32 PM · Differential
epriestley committed rPdb9191f9a8d5: Correct minor "jump to symbol" behavior in Differential (authored by epriestley).
Correct minor "jump to symbol" behavior in Differential
Mar 17 2021, 10:32 PM
epriestley closed D21641: Correct minor "jump to symbol" behavior in Differential.
Mar 17 2021, 10:32 PM
epriestley requested review of D21641: Correct minor "jump to symbol" behavior in Differential.
Mar 17 2021, 10:31 PM
epriestley added a revision to T13644: Command-clicking a changeset header in Differential attempts to perform symbol lookup: D21641: Correct minor "jump to symbol" behavior in Differential.
Mar 17 2021, 10:30 PM · Differential
epriestley added a revision to T13638: Investigate "AllowEncodedSlashes" Apache setting: D21641: Correct minor "jump to symbol" behavior in Differential.
Mar 17 2021, 10:30 PM · Setup
epriestley added a comment to T13638: Investigate "AllowEncodedSlashes" Apache setting.

Previously, see T13437.

Mar 17 2021, 10:15 PM · Setup
epriestley added a comment to T13638: Investigate "AllowEncodedSlashes" Apache setting.

This reproduces locally.

Mar 17 2021, 10:11 PM · Setup
epriestley added a comment to T13638: Investigate "AllowEncodedSlashes" Apache setting.

See also T13644, which appears to be the origin of the particular requests observed in PHI2021.

Mar 17 2021, 9:38 PM · Setup
epriestley committed rP527dd3ce50b2: Replace Differential "unit stars" with icons (authored by epriestley).
Replace Differential "unit stars" with icons
Mar 17 2021, 8:46 PM
epriestley committed rPd6ed9392d4e0: Replace Differential "lint stars" with icons (authored by epriestley).
Replace Differential "lint stars" with icons
Mar 17 2021, 8:46 PM
epriestley closed D21639: Replace Differential "unit stars" with icons.
Mar 17 2021, 8:46 PM
epriestley closed D21640: Replace Differential "lint stars" with icons.
Mar 17 2021, 8:46 PM
epriestley closed T9764: Lint star colors have different meaning for revisions and diffs as Resolved.
  • Colors are now consistent.
  • Icons no longer use only color to communicate information.
  • Icons are (mostly) consistent with the Harbormaster icons that have similar meanings.
  • See ConfigModules/ExtensionsConstants: Differential.
Mar 17 2021, 8:45 PM · Restricted Project, Differential
epriestley requested review of D21640: Replace Differential "lint stars" with icons.
Mar 17 2021, 8:45 PM
epriestley added a revision to T9764: Lint star colors have different meaning for revisions and diffs: D21640: Replace Differential "lint stars" with icons.
Mar 17 2021, 8:44 PM · Restricted Project, Differential
epriestley requested review of D21639: Replace Differential "unit stars" with icons.
Mar 17 2021, 8:28 PM
epriestley added a revision to T9764: Lint star colors have different meaning for revisions and diffs: D21639: Replace Differential "unit stars" with icons.
Mar 17 2021, 8:26 PM · Restricted Project, Differential
epriestley closed T8591: Undefined index in changeset parser as Resolved.

The diff above no longer reproduces this, and I think an equivalent to D18302 landed in D21178. T13524 was almost certainly the same issue.

Mar 17 2021, 7:32 PM · Differential
epriestley abandoned D18302: Fix "undefined index" error in Differential changeset parser.

I think this was mooted by the similar change in D21178. See T8591 for followup.

Mar 17 2021, 7:31 PM
epriestley commandeered D18302: Fix "undefined index" error in Differential changeset parser.
Mar 17 2021, 7:31 PM
epriestley moved T13644: Command-clicking a changeset header in Differential attempts to perform symbol lookup from Backlog to Next on the Differential board.
Mar 17 2021, 7:30 PM · Differential
epriestley triaged T13644: Command-clicking a changeset header in Differential attempts to perform symbol lookup as Low priority.
Mar 17 2021, 7:29 PM · Differential
epriestley closed T9298: Lint/unittest excuses overwrite each other as Resolved.

This is mooted because I've removed the "excuses" feature about a year ago -- on the balance, I think it generated more confusion and busywork than signal.

Mar 17 2021, 7:26 PM · Differential
epriestley renamed T13643: Permissions and UI around manual web "Update Diff" workflow are inconsistent from Permissions around manual web "Update Diff" workflow are inconsistent to Permissions and UI around manual web "Update Diff" workflow are inconsistent.
Mar 17 2021, 7:23 PM · Differential
epriestley closed T9499: Revision repository is not updated when it is changed in the UI as Resolved.

The modern differential.revision.search API returns the repository for the revision.

Mar 17 2021, 7:23 PM · Differential, Conduit
epriestley committed rP1d1003af7854: When using "Update Diff" from the web UI, prefill "Repository" properly (authored by epriestley).
When using "Update Diff" from the web UI, prefill "Repository" properly
Mar 17 2021, 7:23 PM
epriestley closed D21638: When using "Update Diff" from the web UI, prefill "Repository" properly.
Mar 17 2021, 7:23 PM
epriestley moved T13643: Permissions and UI around manual web "Update Diff" workflow are inconsistent from Backlog to Future Work on the Differential board.
Mar 17 2021, 7:22 PM · Differential
epriestley triaged T13643: Permissions and UI around manual web "Update Diff" workflow are inconsistent as Wishlist priority.
Mar 17 2021, 7:22 PM · Differential
epriestley requested review of D21638: When using "Update Diff" from the web UI, prefill "Repository" properly.
Mar 17 2021, 7:20 PM
epriestley added a revision to T9499: Revision repository is not updated when it is changed in the UI: D21638: When using "Update Diff" from the web UI, prefill "Repository" properly.
Mar 17 2021, 7:19 PM · Differential, Conduit
epriestley moved T12256: Parse multiple commits and commit metadata from "git show" and "git format-patch" from Backlog to Diff Parsing on the Differential board.
Mar 17 2021, 7:07 PM · Differential, KDE
epriestley moved T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export" from Backlog to Diff Parsing on the Differential board.
Mar 17 2021, 7:07 PM · Arcanist, Mercurial, Differential, Conduit, Feature Request
epriestley moved T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats from Backlog to Diff Parsing on the Differential board.
Mar 17 2021, 7:07 PM · Arcanist, Differential
epriestley moved T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly from Backlog to Diff Parsing on the Differential board.
Mar 17 2021, 7:07 PM · Differential
epriestley added a comment to T9764: Lint star colors have different meaning for revisions and diffs.

See also PHI1910.

Mar 17 2021, 7:06 PM · Restricted Project, Differential
epriestley moved T10219: Show suggested lint autofix in Differential web view from Backlog to Next on the Differential board.
Mar 17 2021, 7:04 PM · Lint, Differential
epriestley moved T9947: "Expand File" keyboard shortcut in Differential should work on files which were not loaded by default from Backlog to Next on the Differential board.
Mar 17 2021, 7:04 PM · Restricted Project, Differential, Feature Request
epriestley moved T9764: Lint star colors have different meaning for revisions and diffs from Backlog to Next on the Differential board.
Mar 17 2021, 7:04 PM · Restricted Project, Differential
epriestley moved T9590: Subversion directory anchoring rules are unclear and underpowered from Backlog to Subversion on the Differential board.
Mar 17 2021, 7:03 PM · Differential, Subversion
epriestley moved T9499: Revision repository is not updated when it is changed in the UI from Backlog to Next on the Differential board.
Mar 17 2021, 7:03 PM · Differential, Conduit
epriestley moved T9298: Lint/unittest excuses overwrite each other from Backlog to Next on the Differential board.
Mar 17 2021, 7:03 PM · Differential
epriestley moved T8591: Undefined index in changeset parser from Backlog to Next on the Differential board.
Mar 17 2021, 7:03 PM · Differential
epriestley moved T4453: When multiple commits correspond to a single revision, Differential updates to show one of them arbitrarily from Next to Backlog on the Differential board.
Mar 17 2021, 7:01 PM · Restricted Project, Prioritized, Differential
epriestley moved T4453: When multiple commits correspond to a single revision, Differential updates to show one of them arbitrarily from Backlog to Next on the Differential board.
Mar 17 2021, 7:01 PM · Restricted Project, Prioritized, Differential
epriestley moved T4305: File state not saved in revision when parsing form svn repo from Backlog to Subversion on the Differential board.
Mar 17 2021, 7:01 PM · Subversion, Differential
epriestley closed T7677: 1-up Renderer should probably render comments full-width as Wontfix.

I think the complexity of changing this probably isn't worth the benefit. The complexity is high because of how much client-side interaction there is around inlines, and even with more space for the inline, the example screenshot doesn't seem great for code review anyway since none of the code fits.

Mar 17 2021, 7:01 PM · Restricted Project, Differential
epriestley moved T4678: Support changelist-based SVN workflows in Arcanist and Differential from Backlog to Subversion on the Differential board.
Mar 17 2021, 6:55 PM · Differential, Arcanist, Subversion
epriestley moved T4698: Support for SVN patches, created by PhpStorm from Backlog to Subversion on the Differential board.
Mar 17 2021, 6:55 PM · Subversion, Differential