Page MenuHomePhabricator
Feed All Stories

Mar 17 2021

epriestley moved T13643: Permissions and UI around manual web "Update Diff" workflow are inconsistent from Backlog to Future Work on the Differential board.
Mar 17 2021, 7:22 PM · Differential
epriestley triaged T13643: Permissions and UI around manual web "Update Diff" workflow are inconsistent as Wishlist priority.
Mar 17 2021, 7:22 PM · Differential
epriestley requested review of D21638: When using "Update Diff" from the web UI, prefill "Repository" properly.
Mar 17 2021, 7:20 PM
epriestley added a revision to T9499: Revision repository is not updated when it is changed in the UI: D21638: When using "Update Diff" from the web UI, prefill "Repository" properly.
Mar 17 2021, 7:19 PM · Differential, Conduit
epriestley moved T12256: Parse multiple commits and commit metadata from "git show" and "git format-patch" from Backlog to Diff Parsing on the Differential board.
Mar 17 2021, 7:07 PM · Differential, KDE
epriestley moved T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export" from Backlog to Diff Parsing on the Differential board.
Mar 17 2021, 7:07 PM · Arcanist, Mercurial, Differential, Conduit, Feature Request
epriestley moved T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats from Backlog to Diff Parsing on the Differential board.
Mar 17 2021, 7:07 PM · Arcanist, Differential
epriestley moved T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly from Backlog to Diff Parsing on the Differential board.
Mar 17 2021, 7:07 PM · Differential
epriestley added a comment to T9764: Lint star colors have different meaning for revisions and diffs.

See also PHI1910.

Mar 17 2021, 7:06 PM · Restricted Project, Differential
epriestley moved T10219: Show suggested lint autofix in Differential web view from Backlog to Next on the Differential board.
Mar 17 2021, 7:04 PM · Lint, Differential
epriestley moved T9947: "Expand File" keyboard shortcut in Differential should work on files which were not loaded by default from Backlog to Next on the Differential board.
Mar 17 2021, 7:04 PM · Restricted Project, Differential, Feature Request
epriestley moved T9764: Lint star colors have different meaning for revisions and diffs from Backlog to Next on the Differential board.
Mar 17 2021, 7:04 PM · Restricted Project, Differential
epriestley moved T9590: Subversion directory anchoring rules are unclear and underpowered from Backlog to Subversion on the Differential board.
Mar 17 2021, 7:03 PM · Differential, Subversion
epriestley moved T9499: Revision repository is not updated when it is changed in the UI from Backlog to Next on the Differential board.
Mar 17 2021, 7:03 PM · Differential, Conduit
epriestley moved T9298: Lint/unittest excuses overwrite each other from Backlog to Next on the Differential board.
Mar 17 2021, 7:03 PM · Differential
epriestley moved T8591: Undefined index in changeset parser from Backlog to Next on the Differential board.
Mar 17 2021, 7:03 PM · Differential
epriestley moved T4453: When multiple commits correspond to a single revision, Differential updates to show one of them arbitrarily from Next to Backlog on the Differential board.
Mar 17 2021, 7:01 PM · Restricted Project, Prioritized, Differential
epriestley moved T4453: When multiple commits correspond to a single revision, Differential updates to show one of them arbitrarily from Backlog to Next on the Differential board.
Mar 17 2021, 7:01 PM · Restricted Project, Prioritized, Differential
epriestley moved T4305: File state not saved in revision when parsing form svn repo from Backlog to Subversion on the Differential board.
Mar 17 2021, 7:01 PM · Subversion, Differential
epriestley closed T7677: 1-up Renderer should probably render comments full-width as Wontfix.

I think the complexity of changing this probably isn't worth the benefit. The complexity is high because of how much client-side interaction there is around inlines, and even with more space for the inline, the example screenshot doesn't seem great for code review anyway since none of the code fits.

Mar 17 2021, 7:01 PM · Restricted Project, Differential
epriestley moved T4678: Support changelist-based SVN workflows in Arcanist and Differential from Backlog to Subversion on the Differential board.
Mar 17 2021, 6:55 PM · Arcanist, Subversion, Differential
epriestley moved T4698: Support for SVN patches, created by PhpStorm from Backlog to Subversion on the Differential board.
Mar 17 2021, 6:55 PM · Subversion, Differential
epriestley moved T5999: `arc diff` not uploading file content for svn:executable files under SVN 1.7.4 from Backlog to Subversion on the Differential board.
Mar 17 2021, 6:54 PM · Arcanist, Differential, Subversion
epriestley moved T386: Differential display of revisions with "svn cp x@12345 x" is inaccurate from Backlog to Subversion on the Differential board.
Mar 17 2021, 6:54 PM · Subversion, Differential
epriestley committed rPff0a4a2c6fce: Use a less-misleading example for Conduit custom constraints (authored by epriestley).
Use a less-misleading example for Conduit custom constraints
Mar 17 2021, 6:47 PM
epriestley closed D21637: Use a less-misleading example for Conduit custom constraints.
Mar 17 2021, 6:47 PM
epriestley requested review of D21637: Use a less-misleading example for Conduit custom constraints.
Mar 17 2021, 6:32 PM
epriestley moved T13642: Inline comment line numbers on DocumentEngine block diffs may be clamped to raw lines in the source file from Backlog to Next on the Differential board.
Mar 17 2021, 5:14 PM · Differential
epriestley added a comment to T13642: Inline comment line numbers on DocumentEngine block diffs may be clamped to raw lines in the source file.

In D21435, inlines were clamped. Adjusting this code is necessary, but not sufficient, to correct this problem.

Mar 17 2021, 5:14 PM · Differential
epriestley triaged T13642: Inline comment line numbers on DocumentEngine block diffs may be clamped to raw lines in the source file as Low priority.
Mar 17 2021, 4:57 PM · Differential

Mar 16 2021

Harbormaster failed to build B25299: rP7c0e33c34d6f: Modernize "mailKey" for Almanac Bindings for rP7c0e33c34d6f: Modernize "mailKey" for Almanac Bindings!
Mar 16 2021, 10:59 PM
Harbormaster failed to build B25295: rPc3e6db6f0b32: Migrate Almanac Device "mailKey" to modern storage for rPc3e6db6f0b32: Migrate Almanac Device "mailKey" to modern storage!
Mar 16 2021, 10:56 PM
Harbormaster failed to build B25294: rP9003a453691f: Make minor Almanac device modernization updates for rP9003a453691f: Make minor Almanac device modernization updates!
Mar 16 2021, 10:56 PM
epriestley committed rP86669ab54f97: Modernize "mailKey" for Almanac Networks (authored by epriestley).
Modernize "mailKey" for Almanac Networks
Mar 16 2021, 10:52 PM
epriestley committed rP12341e4bc8b4: Forbid disabled devices from authenticating via SSH or HTTP (authored by epriestley).
Forbid disabled devices from authenticating via SSH or HTTP
Mar 16 2021, 10:52 PM
epriestley closed D21632: Modernize "mailKey" for Almanac Networks.
Mar 16 2021, 10:52 PM
epriestley committed rP3267859aeeb2: Modernize "mailKey" on Fund initiatives (authored by epriestley).
Modernize "mailKey" on Fund initiatives
Mar 16 2021, 10:52 PM
epriestley committed rP7c0e33c34d6f: Modernize "mailKey" for Almanac Bindings (authored by epriestley).
Modernize "mailKey" for Almanac Bindings
Mar 16 2021, 10:52 PM
epriestley committed rPe6a23274fee4: Default the Almanac Devices query to "Active Devices" (authored by epriestley).
Default the Almanac Devices query to "Active Devices"
Mar 16 2021, 10:52 PM
epriestley closed D21635: Forbid disabled devices from authenticating via SSH or HTTP.
Mar 16 2021, 10:52 PM
epriestley committed rPeeb009b4fa61: Modernize "mailKey" for Calendar Event (authored by epriestley).
Modernize "mailKey" for Calendar Event
Mar 16 2021, 10:52 PM
epriestley closed D21631: Modernize "mailKey" on Almanac Namespaces.
Mar 16 2021, 10:52 PM
epriestley closed D21633: Modernize "mailKey" for Calendar Event.
Mar 16 2021, 10:52 PM
epriestley committed rP8226b3c88082: Modernize "mailKey" on Almanac Namespaces (authored by epriestley).
Modernize "mailKey" on Almanac Namespaces
Mar 16 2021, 10:52 PM
epriestley closed D21634: Modernize "mailKey" on Fund initiatives.
Mar 16 2021, 10:52 PM
epriestley committed rPfadb2bd52b5e: Modernize "mailKey" on AlamnacService (authored by epriestley).
Modernize "mailKey" on AlamnacService
Mar 16 2021, 10:52 PM
epriestley closed D21636: Default the Almanac Devices query to "Active Devices".
Mar 16 2021, 10:52 PM
epriestley closed D21630: Modernize "mailKey" for Almanac Bindings.
Mar 16 2021, 10:52 PM
epriestley closed D21629: Modernize "mailKey" on AlamnacService.
Mar 16 2021, 10:52 PM
epriestley committed rP5d64fb1815f7: Add a "status" property to Almanac devices (authored by epriestley).
Add a "status" property to Almanac devices
Mar 16 2021, 10:52 PM
epriestley closed D21627: Add a "status" property to Almanac devices.
Mar 16 2021, 10:52 PM
epriestley committed rP9003a453691f: Make minor Almanac device modernization updates (authored by epriestley).
Make minor Almanac device modernization updates
Mar 16 2021, 10:52 PM
epriestley committed rPc3e6db6f0b32: Migrate Almanac Device "mailKey" to modern storage (authored by epriestley).
Migrate Almanac Device "mailKey" to modern storage
Mar 16 2021, 10:52 PM
epriestley committed rP15c0c895a506: Make upstream callers respect "active bindings" when querying Almanac (authored by epriestley).
Make upstream callers respect "active bindings" when querying Almanac
Mar 16 2021, 10:52 PM
epriestley closed D21625: Migrate Almanac Device "mailKey" to modern storage.
Mar 16 2021, 10:52 PM
epriestley closed D21628: Make upstream callers respect "active bindings" when querying Almanac.
Mar 16 2021, 10:52 PM
epriestley closed D21626: Make minor Almanac device modernization updates.
Mar 16 2021, 10:52 PM
epriestley requested review of D21636: Default the Almanac Devices query to "Active Devices".
Mar 16 2021, 10:51 PM
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: D21636: Default the Almanac Devices query to "Active Devices".
Mar 16 2021, 10:50 PM · Almanac
epriestley updated the task description for T13641: Support "Disabled" devices in Almanac.
Mar 16 2021, 10:47 PM · Almanac
epriestley requested review of D21635: Forbid disabled devices from authenticating via SSH or HTTP.
Mar 16 2021, 10:42 PM
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: D21635: Forbid disabled devices from authenticating via SSH or HTTP.
Mar 16 2021, 10:41 PM · Almanac
epriestley updated the task description for T13641: Support "Disabled" devices in Almanac.
Mar 16 2021, 10:31 PM · Almanac
epriestley added a comment to T13065: Move storage for `mailKey` to the Mail application.

After recent changes, only DifferentialRevision and ManiphestTask still have onboard mail keys.

Mar 16 2021, 10:27 PM · Mail
epriestley requested review of D21634: Modernize "mailKey" on Fund initiatives.
Mar 16 2021, 10:23 PM
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: D21634: Modernize "mailKey" on Fund initiatives.
Mar 16 2021, 10:22 PM · Mail
epriestley requested review of D21633: Modernize "mailKey" for Calendar Event.
Mar 16 2021, 10:20 PM
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: D21633: Modernize "mailKey" for Calendar Event.
Mar 16 2021, 10:19 PM · Mail
epriestley requested review of D21632: Modernize "mailKey" for Almanac Networks.
Mar 16 2021, 10:12 PM
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: D21632: Modernize "mailKey" for Almanac Networks.
Mar 16 2021, 10:11 PM · Almanac
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: D21632: Modernize "mailKey" for Almanac Networks.
Mar 16 2021, 10:11 PM · Mail
epriestley requested review of D21631: Modernize "mailKey" on Almanac Namespaces.
Mar 16 2021, 10:09 PM
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: D21631: Modernize "mailKey" on Almanac Namespaces.
Mar 16 2021, 10:08 PM · Almanac
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: D21631: Modernize "mailKey" on Almanac Namespaces.
Mar 16 2021, 10:08 PM · Mail
epriestley requested review of D21630: Modernize "mailKey" for Almanac Bindings.
Mar 16 2021, 10:06 PM
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: D21630: Modernize "mailKey" for Almanac Bindings.
Mar 16 2021, 10:05 PM · Mail
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: D21630: Modernize "mailKey" for Almanac Bindings.
Mar 16 2021, 10:05 PM · Almanac
epriestley requested review of D21629: Modernize "mailKey" on AlamnacService.
Mar 16 2021, 10:02 PM
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: D21629: Modernize "mailKey" on AlamnacService.
Mar 16 2021, 10:01 PM · Mail
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: D21629: Modernize "mailKey" on AlamnacService.
Mar 16 2021, 10:01 PM · Almanac
epriestley requested review of D21628: Make upstream callers respect "active bindings" when querying Almanac.
Mar 16 2021, 9:48 PM
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: D21628: Make upstream callers respect "active bindings" when querying Almanac.
Mar 16 2021, 9:47 PM · Almanac
epriestley updated the task description for T13641: Support "Disabled" devices in Almanac.
Mar 16 2021, 9:28 PM · Almanac
epriestley updated the task description for T13641: Support "Disabled" devices in Almanac.
Mar 16 2021, 9:23 PM · Almanac
epriestley updated the task description for T13641: Support "Disabled" devices in Almanac.
Mar 16 2021, 9:23 PM · Almanac
epriestley updated the task description for T13641: Support "Disabled" devices in Almanac.
Mar 16 2021, 9:23 PM · Almanac
epriestley removed a revision from T13065: Move storage for `mailKey` to the Mail application: D21626: Make minor Almanac device modernization updates.
Mar 16 2021, 9:23 PM · Mail
epriestley removed a task from D21626: Make minor Almanac device modernization updates: T13065: Move storage for `mailKey` to the Mail application.
Mar 16 2021, 9:23 PM
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: D21626: Make minor Almanac device modernization updates.
Mar 16 2021, 9:23 PM · Almanac
epriestley updated the summary of D21626: Make minor Almanac device modernization updates.
Mar 16 2021, 9:23 PM
epriestley updated the task description for T13641: Support "Disabled" devices in Almanac.
Mar 16 2021, 9:22 PM · Almanac
epriestley requested review of D21627: Add a "status" property to Almanac devices.
Mar 16 2021, 8:42 PM
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: D21627: Add a "status" property to Almanac devices.
Mar 16 2021, 8:41 PM · Almanac
epriestley updated the task description for T13641: Support "Disabled" devices in Almanac.
Mar 16 2021, 8:28 PM · Almanac
epriestley requested review of D21626: Make minor Almanac device modernization updates.
Mar 16 2021, 6:19 PM
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: D21626: Make minor Almanac device modernization updates.
Mar 16 2021, 6:18 PM · Mail
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: D21625: Migrate Almanac Device "mailKey" to modern storage.
Mar 16 2021, 6:17 PM · Almanac
epriestley added a task to D21625: Migrate Almanac Device "mailKey" to modern storage: T13641: Support "Disabled" devices in Almanac.
Mar 16 2021, 6:17 PM
epriestley requested review of D21625: Migrate Almanac Device "mailKey" to modern storage.
Mar 16 2021, 6:12 PM
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: D21625: Migrate Almanac Device "mailKey" to modern storage.
Mar 16 2021, 6:11 PM · Mail