Page MenuHomePhabricator
Feed All Stories

Sep 16 2020

epriestley committed rP3a80efa440f0: Build "DiffusionCommitRef" objects from "internal.commit.search", not… (authored by epriestley).
Build "DiffusionCommitRef" objects from "internal.commit.search", not…
Sep 16 2020, 12:37 AM
epriestley closed D21458: Fix a view fatal in CommitGraphView when commits are undiscovered.
Sep 16 2020, 12:37 AM
epriestley closed D21450: Move task and revision closure to the "publishing" step of the commit import pipeline.
Sep 16 2020, 12:37 AM
epriestley committed rPa745055813e4: Lift Diffusion Conduit call proxying to the root level of Conduit (authored by epriestley).
Lift Diffusion Conduit call proxying to the root level of Conduit
Sep 16 2020, 12:37 AM
epriestley committed rPf6238f9d9bd3: Remove "bin/repository lookup-users" workflow (authored by epriestley).
Remove "bin/repository lookup-users" workflow
Sep 16 2020, 12:37 AM
epriestley committed rPa9506097ea04: Add "internal.commit.search" to replace the cache bypass mode of "diffusion. (authored by epriestley).
Add "internal.commit.search" to replace the cache bypass mode of "diffusion.
Sep 16 2020, 12:37 AM
epriestley closed D21449: Make "CommitData" wrap and persist a "CommitRef" record.
Sep 16 2020, 12:37 AM
epriestley committed rP367cd289270d: Delete some commit dead parsing code (authored by epriestley).
Delete some commit dead parsing code
Sep 16 2020, 12:37 AM
epriestley closed D21448: Wrap all direct access to author/committer properties on "CommitData".
Sep 16 2020, 12:36 AM
epriestley closed D21446: Build "DiffusionCommitRef" objects from "internal.commit.search", not "diffusion.querycommits", in the message parser worker.
Sep 16 2020, 12:36 AM
epriestley closed D21444: Remove "bin/repository lookup-users" workflow.
Sep 16 2020, 12:36 AM
epriestley closed D21447: Turn "bypassCache" into a no-op in "diffusion.querycommits".
Sep 16 2020, 12:36 AM
epriestley closed D21443: Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits".
Sep 16 2020, 12:36 AM
epriestley closed D21442: Lift Diffusion Conduit call proxying to the root level of Conduit.
Sep 16 2020, 12:36 AM
epriestley closed D21441: Delete some commit dead parsing code.
Sep 16 2020, 12:36 AM
epriestley committed rARCde209ec06488: When raising a Conduit client exception, show the called method in the error… (authored by epriestley).
When raising a Conduit client exception, show the called method in the error…
Sep 16 2020, 12:34 AM
epriestley closed D21463: When raising a Conduit client exception, show the called method in the error message.
Sep 16 2020, 12:34 AM
epriestley requested review of D21464: Log unexpected exceptions raised by Conduit calls.
Sep 16 2020, 12:25 AM
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21464: Log unexpected exceptions raised by Conduit calls.
Sep 16 2020, 12:24 AM · Differential
epriestley requested review of D21463: When raising a Conduit client exception, show the called method in the error message.
Sep 16 2020, 12:20 AM
epriestley requested review of D21462: Fix an issue where a GROUP BY was missing when a query matched a revision using multiple hashes.
Sep 16 2020, 12:20 AM
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21463: When raising a Conduit client exception, show the called method in the error message.
Sep 16 2020, 12:20 AM · Differential
epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21462: Fix an issue where a GROUP BY was missing when a query matched a revision using multiple hashes.
Sep 16 2020, 12:19 AM · Differential
epriestley triaged T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Normal priority.
Sep 16 2020, 12:16 AM · Differential

Sep 15 2020

epriestley committed rP3dfa89dd5d27: Update SES API to use AWSv4 signatures (authored by epriestley).
Update SES API to use AWSv4 signatures
Sep 15 2020, 8:03 PM
epriestley closed D21461: Update SES API to use AWSv4 signatures.
Sep 15 2020, 8:03 PM
epriestley closed T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly, a subtask of T13570: Amazon is retiring SMTP V3 Signatures, as Resolved.
Sep 15 2020, 8:03 PM · Mail
epriestley closed T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly as Resolved by committing rP3dfa89dd5d27: Update SES API to use AWSv4 signatures.
Sep 15 2020, 8:03 PM · Mail
epriestley requested review of D21461: Update SES API to use AWSv4 signatures.
Sep 15 2020, 4:20 PM
epriestley added a comment to T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly.

I've marked D21461 as resolving this, since the new errors surface the particulars:

Sep 15 2020, 4:19 PM · Mail
epriestley added a revision to T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly: D21461: Update SES API to use AWSv4 signatures.
Sep 15 2020, 4:15 PM · Mail
epriestley added a revision to T13570: Amazon is retiring SMTP V3 Signatures: D21461: Update SES API to use AWSv4 signatures.
Sep 15 2020, 4:15 PM · Mail
epriestley edited the content of Dependencies.
Sep 15 2020, 4:08 PM
epriestley added a subtask for T13570: Amazon is retiring SMTP V3 Signatures: T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly.
Sep 15 2020, 4:08 PM · Mail
epriestley added a parent task for T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly: T13570: Amazon is retiring SMTP V3 Signatures.
Sep 15 2020, 4:08 PM · Mail

Sep 8 2020

epriestley requested review of D21460: When a commit is marked "closeable", clear the "published" flag.
Sep 8 2020, 8:43 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21460: When a commit is marked "closeable", clear the "published" flag.
Sep 8 2020, 8:42 PM · Differential
epriestley requested review of D21459: When an in-process worker subtask fails permanently, don't fatal the whole process.
Sep 8 2020, 8:17 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21459: When an in-process worker subtask fails permanently, don't fatal the whole process.
Sep 8 2020, 8:16 PM · Differential
epriestley added a revision to T13569: When running worker tasks in-process, subtasks which fail incorrectly cause the parent tasks to fail: D21459: When an in-process worker subtask fails permanently, don't fatal the whole process.
Sep 8 2020, 8:15 PM · Daemons
epriestley requested review of D21458: Fix a view fatal in CommitGraphView when commits are undiscovered.
Sep 8 2020, 7:56 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21458: Fix a view fatal in CommitGraphView when commits are undiscovered.
Sep 8 2020, 7:55 PM · Differential
epriestley triaged T13580: Make "fully imported" a separate commit bit or standalone flag, not a complex bitmask operation as Wishlist priority.
Sep 8 2020, 7:49 PM · Diffusion
epriestley closed T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path as Resolved.
  • D21457 fixes approximately 20 additional errors identified by the linter in phabricator/.
Sep 8 2020, 6:48 PM · Arcanist
epriestley committed rARC73847a4b194b: Fix a false negative in lint for "xsprintf()"-family functions (authored by epriestley).
Fix a false negative in lint for "xsprintf()"-family functions
Sep 8 2020, 6:46 PM
epriestley committed rARC7112ee3d5960: Fix additional "xsprintf()"-family static parameter errors (authored by epriestley).
Fix additional "xsprintf()"-family static parameter errors
Sep 8 2020, 6:46 PM
epriestley committed rARC83e63aeb078b: Allow AAST to extract string literal values from HEREDOCs (authored by epriestley).
Allow AAST to extract string literal values from HEREDOCs
Sep 8 2020, 6:46 PM
epriestley committed rARC1c327208d7ba: Fix a missing "pht()" parameter in HTTPSFuture (authored by epriestley).
Fix a missing "pht()" parameter in HTTPSFuture
Sep 8 2020, 6:46 PM
epriestley closed D21456: Fix additional "xsprintf()"-family static parameter errors.
Sep 8 2020, 6:46 PM
epriestley closed D21453: Fix a false negative in lint for "xsprintf()"-family functions.
Sep 8 2020, 6:46 PM
epriestley closed D21454: Fix a missing "pht()" parameter in HTTPSFuture.
Sep 8 2020, 6:46 PM
epriestley closed D21455: Allow AAST to extract string literal values from HEREDOCs.
Sep 8 2020, 6:46 PM
epriestley committed rP6e1b5da1121c: Fix additional "xprintf()"-class static parameter lint errors (authored by epriestley).
Fix additional "xprintf()"-class static parameter lint errors
Sep 8 2020, 6:45 PM
epriestley closed D21457: Fix additional "xprintf()"-class static parameter lint errors.
Sep 8 2020, 6:45 PM
epriestley requested review of D21457: Fix additional "xprintf()"-class static parameter lint errors.
Sep 8 2020, 3:56 PM
epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: D21457: Fix additional "xprintf()"-class static parameter lint errors.
Sep 8 2020, 3:55 PM · Arcanist

Sep 5 2020

tiguchi added a comment to T5776: Make Slowvote choices editable by the author.

I just created a poll where I accidentally hit enter while editing options, so I was left with an incomplete poll which I wasn't allowed to complete, so I had to close it. Would you consider adding a feature that allows us to edit poll options as long as there are no votes cast yet?

Sep 5 2020, 4:46 PM · Slowvote
epriestley added a comment to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.
  • D21454 fixes the specific issue in HTTPSFuture.
Sep 5 2020, 12:32 AM · Arcanist
epriestley requested review of D21456: Fix additional "xsprintf()"-family static parameter errors.
Sep 5 2020, 12:32 AM
epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: D21456: Fix additional "xsprintf()"-family static parameter errors.
Sep 5 2020, 12:32 AM · Arcanist
epriestley requested review of D21455: Allow AAST to extract string literal values from HEREDOCs.
Sep 5 2020, 12:26 AM
epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: D21455: Allow AAST to extract string literal values from HEREDOCs.
Sep 5 2020, 12:26 AM · Arcanist
epriestley requested review of D21454: Fix a missing "pht()" parameter in HTTPSFuture.
Sep 5 2020, 12:10 AM
epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: D21454: Fix a missing "pht()" parameter in HTTPSFuture.
Sep 5 2020, 12:09 AM · Arcanist
epriestley added a comment to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.

Check if arc lint catches this.

Sep 5 2020, 12:09 AM · Arcanist
epriestley requested review of D21453: Fix a false negative in lint for "xsprintf()"-family functions.
Sep 5 2020, 12:07 AM
epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: D21453: Fix a false negative in lint for "xsprintf()"-family functions.
Sep 5 2020, 12:07 AM · Arcanist

Sep 4 2020

epriestley committed rP5fff4ed8dbb7: (stable) Remove obsolete write to "pid" property in "annihilateProcessGroup()"… (authored by epriestley).
(stable) Remove obsolete write to "pid" property in "annihilateProcessGroup()"…
Sep 4 2020, 11:44 PM
epriestley committed rP69662a11d73d: (stable) When printing timestamps on paper: use an absolute, context-free date… (authored by epriestley).
(stable) When printing timestamps on paper: use an absolute, context-free date…
Sep 4 2020, 11:44 PM
epriestley committed rP7daaaa8463e2: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon… (authored by epriestley).
Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon…
Sep 4 2020, 11:41 PM
epriestley closed D21452: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer.
Sep 4 2020, 11:41 PM
epriestley requested review of D21452: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer.
Sep 4 2020, 11:41 PM
epriestley added a revision to T13579: Overseer may fatal when trying to write to "pid" property in "annihilateProcessGroup()": D21452: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer.
Sep 4 2020, 11:39 PM · Daemons
epriestley triaged T13579: Overseer may fatal when trying to write to "pid" property in "annihilateProcessGroup()" as Normal priority.
Sep 4 2020, 11:38 PM · Daemons
epriestley committed rP0854425d191f: When printing timestamps on paper: use an absolute, context-free date format (authored by epriestley).
When printing timestamps on paper: use an absolute, context-free date format
Sep 4 2020, 11:36 PM
epriestley closed D21451: When printing timestamps on paper: use an absolute, context-free date format.
Sep 4 2020, 11:36 PM
epriestley requested review of D21451: When printing timestamps on paper: use an absolute, context-free date format.
Sep 4 2020, 11:33 PM
epriestley added a revision to T13573: When printing, render dates in an absolute, context-free format: D21451: When printing timestamps on paper: use an absolute, context-free date format.
Sep 4 2020, 11:25 PM · Infrastructure
epriestley renamed T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting from Include "Moved/Copied" gutter in 1-up diffs, and add aural cues to Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Sep 4 2020, 5:56 PM · Accessibility, Differential
epriestley triaged T13578: Provide `bin/user approve` to approve an account from the CLI as Wishlist priority.
Sep 4 2020, 5:52 PM · Setup, Auth
epriestley triaged T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path as Low priority.
Sep 4 2020, 5:49 PM · Arcanist
epriestley triaged T13576: Certain "arc land" merges fail when they should succeed as Normal priority.
Sep 4 2020, 5:46 PM · Arcanist

Sep 1 2020

20after4 added a comment to T13478: Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones.

Probably related: According to https://phabricator.wikimedia.org/T261642, it seems that when leaving a project, phabricator leaves behind some cruft in the form of materialized memberships for milestones of that project.

Sep 1 2020, 9:42 PM · Policy, Projects
mavit added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

MYSQL_PWD can be observed always

Sep 1 2020, 8:02 PM · Bug Report
IgoSha added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

The main problem here is that command "./bin/storage dump" exposes password on system process list in clear text. It happens due to way the storage tool calls mysqldump command. In my opinion this is universally applicable to every Linux distribution Phabricator can run on.

Sep 1 2020, 1:44 PM · Bug Report

Aug 29 2020

MagicInventor added a comment to T13568: In "arc land --incremental", rebased branches are not repeatedly rebased as changes iterate.
Aug 29 2020, 12:19 AM · Arcanist
MagicInventor updated MagicInventor.
Aug 29 2020, 12:11 AM

Aug 24 2020

epriestley added a comment to T5055: Distribution mechanism for arc extensions.

New user is told "install dinosaurs, you can trust epriestley.

Aug 24 2020, 4:49 PM · Arcanist

Aug 22 2020

avivey added a comment to T5055: Distribution mechanism for arc extensions.

The public key won't necessarily be available to Phabricator (because it's kinda funny to have the public key and signature in the same place). We'll just register the fingerprints I guess?

I think the public key has to be available -- you can't verify signatures otherwise.

Aug 22 2020, 6:28 AM · Arcanist

Aug 21 2020

epriestley added a comment to T5055: Distribution mechanism for arc extensions.

Distribution would just be zip/tgz files for each package

Aug 21 2020, 5:01 PM · Arcanist
avivey added a comment to T5055: Distribution mechanism for arc extensions.

I think I'm going to start working on the Arcanist side of this soon...

Aug 21 2020, 12:15 PM · Arcanist
kuba-orlik raised a concern with rARC7ddaed9aba1a: Improve "arc land" behavior in the presence of merge conflicts and change….

This commit has introduced an issue when landing a commit that's been merged with the target branch already.

Aug 21 2020, 12:04 PM
alexnb awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Love token.
Aug 21 2020, 8:31 AM · Differential, Quick Look

Aug 20 2020

Firehed added a comment to T13575: PHP built-in webserver fails on POST.

For what it's worth, the only reason I was trying to figure out stuff with the built-in server was because at the time trying to get Phabricator running in Docker correctly was... not nearly as easy as I would have liked. Quickly skimming online suggests that's improved in the interim.

Aug 20 2020, 8:06 PM · Infrastructure
avivey added a comment to T13575: PHP built-in webserver fails on POST.

Yeah, it might make sense to drop it; I use it because it's easier to setup then Apache and the error log is right in my console, but setting up a real server isn't that much of a bother, except for Apple changing the rugs on you every other day (Soon with both x86 and ARM versions!)

Aug 20 2020, 7:39 PM · Infrastructure
epriestley added a project to T13575: PHP built-in webserver fails on POST: Infrastructure.
Aug 20 2020, 6:48 PM · Infrastructure
epriestley added a comment to T13575: PHP built-in webserver fails on POST.

I wonder if maintaining support for the builtin webserver is worthwhile -- I never use it, and I feel like I only see it referenced when users report bugs like this in the vein of "PHP builtin webserver has been completely broken for 13 years", which suggests it's probably not seeing very much use in the wild, either.

Aug 20 2020, 6:47 PM · Infrastructure
avivey created T13575: PHP built-in webserver fails on POST.
Aug 20 2020, 5:43 PM · Infrastructure
artms requested review of D20972: `arc patch --arcbundle` might require authentification if it can't find base commit.
Aug 20 2020, 5:58 AM
artms planned changes to D20972: `arc patch --arcbundle` might require authentification if it can't find base commit.
Aug 20 2020, 5:58 AM