Page MenuHomePhabricator
Feed All Stories

Jul 10 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21409: Remove the "Graph" view as a dedicated repository view.
Jul 10 2020, 5:56 PM · Differential
epriestley requested review of D21408: Remove "Recent Commits" from repository landing page.
Jul 10 2020, 5:49 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21408: Remove "Recent Commits" from repository landing page.
Jul 10 2020, 5:48 PM · Differential
epriestley requested review of D21407: Remove "DiffusionTagTableView".
Jul 10 2020, 4:27 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21407: Remove "DiffusionTagTableView".
Jul 10 2020, 4:25 PM · Differential
epriestley requested review of D21406: Remove the "authored" subheader from commits.
Jul 10 2020, 4:21 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21406: Remove the "authored" subheader from commits.
Jul 10 2020, 4:20 PM · Differential
Krinkle awarded T13069: Make mail stamps routable on the server, include transaction information, and replace mail tags a Orange Medal token.
Jul 10 2020, 4:17 PM · Mail
epriestley requested review of D21405: Modernize "Author" and "Committer" rendering for commits.
Jul 10 2020, 4:17 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21405: Modernize "Author" and "Committer" rendering for commits.
Jul 10 2020, 4:16 PM · Differential
epriestley added a comment to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.

The broader structural issue here is:

Jul 10 2020, 4:11 PM · Differential
epriestley requested review of D21404: Remove construction of "author" information from "LastModified" payload in Diffusion.
Jul 10 2020, 4:06 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21404: Remove construction of "author" information from "LastModified" payload in Diffusion.
Jul 10 2020, 4:05 PM · Differential
arian.maykon updated arian.maykon.
Jul 10 2020, 12:47 PM

Jul 9 2020

epriestley added a comment to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.

A second issue is that some of the "publish" behavior depends on the commit/revision relationship. This can still be sequenced correctly entirely in the publish daemon, but "close related revisions" and "publish the commit" are not entirely independent.

Jul 9 2020, 10:24 PM · Differential
epriestley triaged T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch as Normal priority.
Jul 9 2020, 10:13 PM · Differential
epriestley renamed T13361: Get rid of the "Actions" dropdown in Diffusion from Get rid of the "Actions" dropdown in in Diffusion to Get rid of the "Actions" dropdown in Diffusion.
Jul 9 2020, 9:37 PM · Design, Diffusion
epriestley closed T13369: When a large number of commits are pushed to a repository, import them at lower priority as Resolved.

This appears stable.

Jul 9 2020, 9:36 PM · Daemons, Diffusion
epriestley committed rP1d4d860cb5a0: Allow non-authors to "Request Review" of draft revisions (authored by epriestley).
Allow non-authors to "Request Review" of draft revisions
Jul 9 2020, 9:21 PM
epriestley committed rP6e85b521fe86: Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't… (authored by epriestley).
Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't…
Jul 9 2020, 9:21 PM
epriestley committed rPb21b73b8dd35: Expand Revision transaction API to allow actions to vary more broadly based on… (authored by epriestley).
Expand Revision transaction API to allow actions to vary more broadly based on…
Jul 9 2020, 9:21 PM
epriestley closed D21403: Allow non-authors to "Request Review" of draft revisions.
Jul 9 2020, 9:20 PM
epriestley closed D21401: Expand Revision transaction API to allow actions to vary more broadly based on the viewer and revision state.
Jul 9 2020, 9:20 PM
epriestley closed D21402: Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't adding any non-you subscribers.
Jul 9 2020, 9:20 PM
epriestley requested review of D21403: Allow non-authors to "Request Review" of draft revisions.
Jul 9 2020, 9:11 PM
epriestley requested review of D21402: Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't adding any non-you subscribers.
Jul 9 2020, 9:02 PM
epriestley requested review of D21401: Expand Revision transaction API to allow actions to vary more broadly based on the viewer and revision state.
Jul 9 2020, 7:31 PM
epriestley requested review of D21400: Require rows passed to "loadAllFromArray()" have unique keys.
Jul 9 2020, 5:58 PM
epriestley added a reverting change for D21399: Fix an issue where querying for a large number of projects by slug could paginate incorrectly: D21400: Require rows passed to "loadAllFromArray()" have unique keys.
Jul 9 2020, 5:56 PM
epriestley committed rP852e368cb777: (stable) Fix an issue where querying for a large number of projects by slug… (authored by epriestley).
(stable) Fix an issue where querying for a large number of projects by slug…
Jul 9 2020, 5:50 PM
epriestley committed rP73c4240415e0: Add some additional patterns to the "filter Mercurial --debug output" list (authored by epriestley).
Add some additional patterns to the "filter Mercurial --debug output" list
Jul 9 2020, 5:50 PM
epriestley closed D21398: Add some additional patterns to the "filter Mercurial --debug output" list.
Jul 9 2020, 5:50 PM
epriestley committed rP56838c0e3dc2: Fix an issue where querying for a large number of projects by slug could… (authored by epriestley).
Fix an issue where querying for a large number of projects by slug could…
Jul 9 2020, 5:50 PM
epriestley closed D21399: Fix an issue where querying for a large number of projects by slug could paginate incorrectly.
Jul 9 2020, 5:50 PM
epriestley requested review of D21399: Fix an issue where querying for a large number of projects by slug could paginate incorrectly.
Jul 9 2020, 5:49 PM
epriestley requested review of D21398: Add some additional patterns to the "filter Mercurial --debug output" list.
Jul 9 2020, 5:35 PM
epriestley committed rARC65cda1596f25: Preserve bookmarks across "hg rebase --keep --collapse", and destroy them… (authored by epriestley).
Preserve bookmarks across "hg rebase --keep --collapse", and destroy them…
Jul 9 2020, 12:43 AM
epriestley closed D21397: Preserve bookmarks across "hg rebase --keep --collapse", and destroy them before "hg strip/prune".
Jul 9 2020, 12:43 AM

Jul 8 2020

epriestley requested review of D21397: Preserve bookmarks across "hg rebase --keep --collapse", and destroy them before "hg strip/prune".
Jul 8 2020, 11:21 PM
epriestley committed rARC710bceab1031: When "arc land" fails a Mercurial push, actually raise it as an exception (authored by epriestley).
When "arc land" fails a Mercurial push, actually raise it as an exception
Jul 8 2020, 10:30 PM
epriestley committed rARC354da1ddaa89: When saving and restoring local state in Mercurial, also save and restore… (authored by epriestley).
When saving and restoring local state in Mercurial, also save and restore…
Jul 8 2020, 10:30 PM
epriestley committed rARC3633364bb96f: Clean up push failure messaging in "arc land" slightly (authored by epriestley).
Clean up push failure messaging in "arc land" slightly
Jul 8 2020, 10:30 PM
epriestley closed D21396: When saving and restoring local state in Mercurial, also save and restore bookmarks.
Jul 8 2020, 10:30 PM
epriestley closed D21395: Clean up push failure messaging in "arc land" slightly.
Jul 8 2020, 10:30 PM
epriestley closed D21394: When "arc land" fails a Mercurial push, actually raise it as an exception.
Jul 8 2020, 10:30 PM
epriestley requested review of D21396: When saving and restoring local state in Mercurial, also save and restore bookmarks.
Jul 8 2020, 9:37 PM
epriestley requested review of D21395: Clean up push failure messaging in "arc land" slightly.
Jul 8 2020, 9:14 PM
epriestley requested review of D21394: When "arc land" fails a Mercurial push, actually raise it as an exception.
Jul 8 2020, 9:12 PM

Jul 7 2020

epriestley committed rARCe3ed781f363d: (stable) Fix additional Mercurial/Python compatibility issues in "arc land" (authored by epriestley).
(stable) Fix additional Mercurial/Python compatibility issues in "arc land"
Jul 7 2020, 5:21 PM
epriestley committed rARC41774ba9cceb: Fix additional Mercurial/Python compatibility issues in "arc land" (authored by epriestley).
Fix additional Mercurial/Python compatibility issues in "arc land"
Jul 7 2020, 5:20 PM
epriestley closed D21393: Fix additional Mercurial/Python compatibility issues in "arc land".
Jul 7 2020, 5:20 PM
epriestley requested review of D21393: Fix additional Mercurial/Python compatibility issues in "arc land".
Jul 7 2020, 5:19 PM

Jul 6 2020

epriestley committed rARC1a54e1103c23: (stable) Allow "hg arc-ls-markers" to run under Python 2 or Python 3 (authored by epriestley).
(stable) Allow "hg arc-ls-markers" to run under Python 2 or Python 3
Jul 6 2020, 10:34 PM
epriestley committed rARCa28e76b7b3df: Allow "hg arc-ls-markers" to run under Python 2 or Python 3 (authored by epriestley).
Allow "hg arc-ls-markers" to run under Python 2 or Python 3
Jul 6 2020, 10:29 PM
epriestley closed D21392: Allow "hg arc-ls-markers" to run under Python 2 or Python 3.
Jul 6 2020, 10:29 PM
epriestley requested review of D21392: Allow "hg arc-ls-markers" to run under Python 2 or Python 3.
Jul 6 2020, 10:29 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21392: Allow "hg arc-ls-markers" to run under Python 2 or Python 3.
Jul 6 2020, 10:29 PM · Arcanist
epriestley added a comment to T13546: Modernize the "arc land" workflow.

See PHI1807. At time of writing, arc land can delete the local master if you land it onto itself. This isn't a big deal (it gives you the command to get it back), but not intended and undesirable. Although it isn't recommended, arc land is supposed to support working in master and landing master into itself.

Jul 6 2020, 10:00 PM · Arcanist
epriestley committed rARCe2ac83ce572c: (stable) Fix a MarkerRef call to get the active bookmark in Mercurial (authored by epriestley).
(stable) Fix a MarkerRef call to get the active bookmark in Mercurial
Jul 6 2020, 9:08 PM
epriestley committed rARC79a6dfd7a99f: Fix a MarkerRef call to get the active bookmark in Mercurial (authored by epriestley).
Fix a MarkerRef call to get the active bookmark in Mercurial
Jul 6 2020, 9:08 PM
epriestley closed D21391: Fix a MarkerRef call to get the active bookmark in Mercurial.
Jul 6 2020, 9:08 PM
epriestley requested review of D21391: Fix a MarkerRef call to get the active bookmark in Mercurial.
Jul 6 2020, 9:06 PM

Jul 3 2020

epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jul 3 2020, 8:19 PM · Guides, Arcanist
epriestley edited the content of Changelog.
Jul 3 2020, 8:13 PM
epriestley created an object: 2020 Week 26 (Early July).
Jul 3 2020, 8:11 PM
epriestley committed rARC8795282286a7: (stable) Promote 2020 Week 26 (authored by epriestley).
(stable) Promote 2020 Week 26
Jul 3 2020, 8:10 PM
epriestley committed rPb2f0937e300c: (stable) Promote 2020 Week 26 (authored by epriestley).
(stable) Promote 2020 Week 26
Jul 3 2020, 8:10 PM
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jul 3 2020, 7:46 PM · Guides, Arcanist
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jul 3 2020, 7:45 PM · Guides, Arcanist
epriestley committed rARCa5480609f870: Render the state tree in "arc branches" slightly more cleanly (authored by epriestley).
Render the state tree in "arc branches" slightly more cleanly
Jul 3 2020, 7:43 PM
epriestley closed D21390: Render the state tree in "arc branches" slightly more cleanly.
Jul 3 2020, 7:43 PM
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jul 3 2020, 7:43 PM · Guides, Arcanist
epriestley updated the diff for D21390: Render the state tree in "arc branches" slightly more cleanly.
  • Improve "stack" behavior.
Jul 3 2020, 6:54 PM
epriestley requested review of D21390: Render the state tree in "arc branches" slightly more cleanly.
Jul 3 2020, 6:40 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21390: Render the state tree in "arc branches" slightly more cleanly.
Jul 3 2020, 6:39 PM · Arcanist
epriestley added a comment to T13551: "debug.time-limit" no longer functions in PHP7.

A sometimes-suitable replacement would be some bin/request mechanism which simulates a web request in process. There are some limits to how authentic this can be, but for some substantial subset of hangs it may still be useful.

Jul 3 2020, 6:02 PM · Infrastructure

Jul 1 2020

epriestley triaged T13551: "debug.time-limit" no longer functions in PHP7 as Wishlist priority.
Jul 1 2020, 7:32 PM · Infrastructure
epriestley added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.

PHI1776 is another report of this behavior.

Jul 1 2020, 7:05 PM · Bug Report, Diffusion
epriestley committed rARCb8a5191e3b36: Improve login/auth messages from Arcanist toolset workflows (authored by epriestley).
Improve login/auth messages from Arcanist toolset workflows
Jul 1 2020, 1:37 PM
epriestley committed rARC17f2668d1f75: When tab-completing "arc" commands, suggest paths if the argument is empty and… (authored by epriestley).
When tab-completing "arc" commands, suggest paths if the argument is empty and…
Jul 1 2020, 1:37 PM
epriestley committed rARC01e91dc260a7: Clean up some service profiler behavior in Conduit futures (authored by epriestley).
Clean up some service profiler behavior in Conduit futures
Jul 1 2020, 1:37 PM
epriestley committed rARC65e4927dca33: Drop intended support for "--anonymous" from Arcanist Toolsets (authored by epriestley).
Drop intended support for "--anonymous" from Arcanist Toolsets
Jul 1 2020, 1:37 PM
epriestley closed D21388: Clean up some service profiler behavior in Conduit futures.
Jul 1 2020, 1:37 PM
epriestley closed D21387: Improve login/auth messages from Arcanist toolset workflows.
Jul 1 2020, 1:37 PM
epriestley committed rARC7e9f80971bd6: Implement Conduit login prompt behavior as a pure FutureProxy, not a Future… (authored by epriestley).
Implement Conduit login prompt behavior as a pure FutureProxy, not a Future…
Jul 1 2020, 1:37 PM
epriestley committed rARC98ca5cfa8171: Remove an unused method in "ArcanistUploadWorkflow" (authored by epriestley).
Remove an unused method in "ArcanistUploadWorkflow"
Jul 1 2020, 1:37 PM
epriestley closed D21386: Drop intended support for "--anonymous" from Arcanist Toolsets.
Jul 1 2020, 1:37 PM
epriestley closed D21385: When tab-completing "arc" commands, suggest paths if the argument is empty and a path wildcard argument exists.
Jul 1 2020, 1:37 PM
epriestley committed rARC2daf9b16aeb1: Improve resolution behaviors of FutureProxy (authored by epriestley).
Improve resolution behaviors of FutureProxy
Jul 1 2020, 1:37 PM
epriestley closed D21382: Remove an unused method in "ArcanistUploadWorkflow".
Jul 1 2020, 1:37 PM
epriestley closed D21384: Implement Conduit login prompt behavior as a pure FutureProxy, not a Future-like object.
Jul 1 2020, 1:37 PM
epriestley closed D21383: Improve resolution behaviors of FutureProxy.
Jul 1 2020, 1:37 PM
epriestley updated the summary of D21389: Allow the Fact daemon to hibernate.
Jul 1 2020, 1:35 PM
epriestley committed rP205657ac76a2: Allow the Fact daemon to hibernate (authored by epriestley).
Allow the Fact daemon to hibernate
Jul 1 2020, 1:33 PM
epriestley closed D21389: Allow the Fact daemon to hibernate.
Jul 1 2020, 1:33 PM
epriestley requested review of D21389: Allow the Fact daemon to hibernate.
Jul 1 2020, 1:29 PM
epriestley requested review of D21388: Clean up some service profiler behavior in Conduit futures.
Jul 1 2020, 1:25 PM
epriestley requested review of D21387: Improve login/auth messages from Arcanist toolset workflows.
Jul 1 2020, 1:15 PM
epriestley requested review of D21386: Drop intended support for "--anonymous" from Arcanist Toolsets.
Jul 1 2020, 12:52 PM
epriestley updated the summary of D21384: Implement Conduit login prompt behavior as a pure FutureProxy, not a Future-like object.
Jul 1 2020, 12:49 PM