Page MenuHomePhabricator
Feed All Stories

Feb 12 2020

epriestley added a revision to T13395: Strip libphutil for parts: D20975: Move lingering "Aphront" classes to Phabricator.
Feb 12 2020, 7:48 PM · libphutil
epriestley requested review of D20974: Move lingering "Aphront" classes out of libphutil.
Feb 12 2020, 7:47 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20974: Move lingering "Aphront" classes out of libphutil.
Feb 12 2020, 7:47 PM · libphutil
epriestley edited the content of Changelog.
Feb 12 2020, 7:35 PM
epriestley committed rPff6f24db2bc0: (stable) Promote 2020 Week 6 (authored by epriestley).
(stable) Promote 2020 Week 6
Feb 12 2020, 7:34 PM
epriestley created an object: 2020 Week 6 (Early February).
Feb 12 2020, 7:34 PM

Feb 10 2020

artms added inline comments to D20973: Fix diffusion.branchquery returning dictionary instead of array when branches are filtered out.
Feb 10 2020, 1:26 PM
artms requested review of D20973: Fix diffusion.branchquery returning dictionary instead of array when branches are filtered out.
Feb 10 2020, 1:25 PM
artms updated the test plan for D20972: `arc patch --arcbundle` might require authentification if it can't find base commit.
Feb 10 2020, 9:30 AM
artms requested review of D20972: `arc patch --arcbundle` might require authentification if it can't find base commit.
Feb 10 2020, 9:29 AM

Feb 7 2020

epriestley added a comment to T2383: Run PHP environment checks from CLI.

https://discourse.phabricator-community.org/t/activities-notifications-spam/3286/ is likely a case where curl was not installed on the CLI, but was installed in the web SAPI.

Feb 7 2020, 8:52 PM · Setup
epriestley added a comment to T13426: Add a "Saved States" indirection layer on top of "Staging Areas".

A saved state is likely something like this:

Feb 7 2020, 4:54 PM · Harbormaster, Drydock, Arcanist
epriestley added a comment to T11402: Garbage collect and/or compress/archive harbormaster build unit messages.

I'd like to leave behind a "Results were GC'd on X/Y/Z" message when we GC these so it's clear what's going on.

Feb 7 2020, 2:07 PM · Restricted Project, Harbormaster, Feature Request

Feb 6 2020

epriestley committed rP2327578adc94: Respect linebreaks in full HTML tables in Remarkup (authored by epriestley).
Respect linebreaks in full HTML tables in Remarkup
Feb 6 2020, 11:01 PM
epriestley closed T5427: Force a line break in a table cell as Resolved by committing rP2327578adc94: Respect linebreaks in full HTML tables in Remarkup.
Feb 6 2020, 11:01 PM · Remarkup
epriestley closed D20971: Respect linebreaks in full HTML tables in Remarkup.
Feb 6 2020, 11:01 PM
epriestley requested review of D20971: Respect linebreaks in full HTML tables in Remarkup.
Feb 6 2020, 10:54 PM
epriestley added a revision to T5427: Force a line break in a table cell: D20971: Respect linebreaks in full HTML tables in Remarkup.
Feb 6 2020, 10:53 PM · Remarkup
epriestley added a comment to T5427: Force a line break in a table cell.

(See also T13160, and D20568 for additional rationale.)

Feb 6 2020, 10:50 PM · Remarkup
epriestley reopened T5427: Force a line break in a table cell as "Open".

See also PHI1630.

Feb 6 2020, 10:49 PM · Remarkup

Feb 5 2020

epriestley committed rP9d1af762d518: In summary interfaces, don't render very large inline remarkup details for unit… (authored by epriestley).
In summary interfaces, don't render very large inline remarkup details for unit…
Feb 5 2020, 10:26 PM
epriestley closed D20970: In summary interfaces, don't render very large inline remarkup details for unit test messages.
Feb 5 2020, 10:26 PM
epriestley requested review of D20970: In summary interfaces, don't render very large inline remarkup details for unit test messages.
Feb 5 2020, 3:46 PM
epriestley added a revision to T10635: Loading differential revision slow when lots of unit test messages exist: D20970: In summary interfaces, don't render very large inline remarkup details for unit test messages.
Feb 5 2020, 3:45 PM · Restricted Project, Haskell.org, Harbormaster, Performance
epriestley triaged T10635: Loading differential revision slow when lots of unit test messages exist as Wishlist priority.
Feb 5 2020, 3:41 PM · Restricted Project, Haskell.org, Harbormaster, Performance

Feb 4 2020

epriestley committed rPfd46c597aec5: When sorting subscriber references for display in the curtain UI, sort without… (authored by epriestley).
When sorting subscriber references for display in the curtain UI, sort without…
Feb 4 2020, 11:26 PM
epriestley closed D20969: When sorting subscriber references for display in the curtain UI, sort without case sensitivity.
Feb 4 2020, 11:26 PM
epriestley requested review of D20969: When sorting subscriber references for display in the curtain UI, sort without case sensitivity.
Feb 4 2020, 11:08 PM
epriestley committed rPfdbe9ba149b6: Improve Remarkup parsing performance for certain large input blocks (authored by epriestley).
Improve Remarkup parsing performance for certain large input blocks
Feb 4 2020, 11:07 PM
epriestley closed D20968: Improve Remarkup parsing performance for certain large input blocks.
Feb 4 2020, 11:07 PM
epriestley closed T13487: Improve performance of remarkup block splitting as Resolved by committing rPfdbe9ba149b6: Improve Remarkup parsing performance for certain large input blocks.
Feb 4 2020, 11:07 PM · Remarkup
epriestley added a revision to T13486: Dates in curtain bylines may be hidden by long usernames: D20969: When sorting subscriber references for display in the curtain UI, sort without case sensitivity.
Feb 4 2020, 11:06 PM · Design
epriestley added inline comments to D20968: Improve Remarkup parsing performance for certain large input blocks.
Feb 4 2020, 10:42 PM
epriestley requested review of D20968: Improve Remarkup parsing performance for certain large input blocks.
Feb 4 2020, 10:39 PM
epriestley added a revision to T13487: Improve performance of remarkup block splitting: D20968: Improve Remarkup parsing performance for certain large input blocks.
Feb 4 2020, 10:37 PM · Remarkup
epriestley added a comment to T13487: Improve performance of remarkup block splitting.

To attempt to justify micro-optimizing this loop:

Feb 4 2020, 9:45 PM · Remarkup
epriestley triaged T13487: Improve performance of remarkup block splitting as Wishlist priority.
Feb 4 2020, 9:23 PM · Remarkup
epriestley added a comment to T10635: Loading differential revision slow when lots of unit test messages exist.

See also PHI1628, which reports that a 4MB blob of test details is slow to render.

Feb 4 2020, 8:48 PM · Restricted Project, Haskell.org, Harbormaster, Performance
epriestley closed T13486: Dates in curtain bylines may be hidden by long usernames as Resolved.

I might make some more tweaks to the UI, but this looks like it's in better shape now.

Feb 4 2020, 8:44 PM · Design
epriestley committed rP0e82bd024a8c: Use the new "CurtainObjectRefList" UI element for subscribers (authored by epriestley).
Use the new "CurtainObjectRefList" UI element for subscribers
Feb 4 2020, 8:38 PM
epriestley closed D20967: Use the new "CurtainObjectRefList" UI element for subscribers.
Feb 4 2020, 8:38 PM
epriestley committed rP2a92fef8798d: Improve wrapping and overflow behavior for curtain panels containing long… (authored by epriestley).
Improve wrapping and overflow behavior for curtain panels containing long…
Feb 4 2020, 8:31 PM
epriestley closed D20966: Improve wrapping and overflow behavior for curtain panels containing long usernames.
Feb 4 2020, 8:31 PM
epriestley requested review of D20967: Use the new "CurtainObjectRefList" UI element for subscribers.
Feb 4 2020, 8:30 PM
epriestley added a revision to T13486: Dates in curtain bylines may be hidden by long usernames: D20967: Use the new "CurtainObjectRefList" UI element for subscribers.
Feb 4 2020, 8:29 PM · Design
epriestley requested review of D20966: Improve wrapping and overflow behavior for curtain panels containing long usernames.
Feb 4 2020, 5:26 PM
epriestley added a revision to T13486: Dates in curtain bylines may be hidden by long usernames: D20966: Improve wrapping and overflow behavior for curtain panels containing long usernames.
Feb 4 2020, 5:25 PM · Design
epriestley triaged T13486: Dates in curtain bylines may be hidden by long usernames as Wishlist priority.
Feb 4 2020, 4:18 PM · Design
epriestley committed rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted… (authored by epriestley).
Fix an issue where intracontent empty lines were incorrectly trimmed in quoted…
Feb 4 2020, 4:09 PM
epriestley closed D20965: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks.
Feb 4 2020, 4:09 PM
epriestley closed T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup as Resolved by committing rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted….
Feb 4 2020, 4:09 PM · Remarkup
epriestley requested review of D20965: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks.
Feb 4 2020, 4:07 PM
epriestley added a revision to T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup: D20965: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks.
Feb 4 2020, 4:05 PM · Remarkup
epriestley committed rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"… (authored by epriestley).
Update GitHub API calls to use "Authorization" header instead of "access_token"…
Feb 4 2020, 3:58 PM
epriestley closed T13485: Update GitHub integration for "access_token" deprecation changes as Resolved by committing rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"….
Feb 4 2020, 3:58 PM · Auth
epriestley closed D20964: Update GitHub API calls to use "Authorization" header instead of "access_token" URI parameter.
Feb 4 2020, 3:58 PM
epriestley requested review of D20964: Update GitHub API calls to use "Authorization" header instead of "access_token" URI parameter.
Feb 4 2020, 3:53 PM
epriestley added a revision to T13485: Update GitHub integration for "access_token" deprecation changes: D20964: Update GitHub API calls to use "Authorization" header instead of "access_token" URI parameter.
Feb 4 2020, 3:51 PM · Auth
epriestley added a comment to T13485: Update GitHub integration for "access_token" deprecation changes.

The actual replacement is Authorization: token <token>, I believe:

Feb 4 2020, 3:47 PM · Auth
epriestley committed rP6d4c6924d6d9: Update Herald rule creation workflow to use more modern UI elements (authored by epriestley).
Update Herald rule creation workflow to use more modern UI elements
Feb 4 2020, 3:38 PM
epriestley closed D20956: Update Herald rule creation workflow to use more modern UI elements.
Feb 4 2020, 3:38 PM
epriestley updated the diff for D20956: Update Herald rule creation workflow to use more modern UI elements.
  • Rebase and use "PHUILauncherView" in the new UIs.
Feb 4 2020, 3:35 PM
epriestley committed rP4904d7711ea1: When publishing a commit, copy "Related Tasks" from the associated revision (if… (authored by epriestley).
When publishing a commit, copy "Related Tasks" from the associated revision (if…
Feb 4 2020, 3:05 PM
epriestley closed T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx", a subtask of T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships, as Resolved.
Feb 4 2020, 3:05 PM · Customer Impact, Differential, Maniphest
epriestley closed T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx" as Resolved by committing rP4904d7711ea1: When publishing a commit, copy "Related Tasks" from the associated revision (if….
Feb 4 2020, 3:05 PM · Maniphest, Differential, Diffusion
epriestley closed D20961: When publishing a commit, copy "Related Tasks" from the associated revision (if one exists).
Feb 4 2020, 3:05 PM
epriestley committed rP530145ba3be6: Give "Config" a full-width, hierarchical layout (authored by epriestley).
Give "Config" a full-width, hierarchical layout
Feb 4 2020, 3:00 PM
epriestley closed D20934: Give "Config" a full-width, hierarchical layout.
Feb 4 2020, 2:59 PM
epriestley committed rP26c2a1ba68b1: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView" (authored by epriestley).
Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView"
Feb 4 2020, 2:52 PM
epriestley closed D20933: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView".
Feb 4 2020, 2:52 PM
epriestley committed rPcb481f36c54b: Carve out a separate "Services" section of Config (authored by epriestley).
Carve out a separate "Services" section of Config
Feb 4 2020, 2:47 PM
epriestley closed D20931: Carve out a separate "Services" section of Config.
Feb 4 2020, 2:47 PM
epriestley committed rPa72ade94757a: Carve out a separate "Modules/Extensions" section of Config (authored by epriestley).
Carve out a separate "Modules/Extensions" section of Config
Feb 4 2020, 2:42 PM
epriestley closed D20930: Carve out a separate "Modules/Extensions" section of Config.
Feb 4 2020, 2:42 PM
epriestley triaged T13485: Update GitHub integration for "access_token" deprecation changes as Low priority.
Feb 4 2020, 2:39 PM · Auth

Feb 3 2020

epriestley added a comment to T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".

I just wanted to hold it across the release cut, it's headed to master shortly.

Feb 3 2020, 7:02 PM · Maniphest, Differential, Diffusion
swisspol added a comment to T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".

@epriestley what's blocking landing this diff?

Feb 3 2020, 6:46 PM · Maniphest, Differential, Diffusion
epriestley committed rPc42c5983aa6a: Fix an issue where loading a mangled project graph could fail too abruptly (authored by epriestley).
Fix an issue where loading a mangled project graph could fail too abruptly
Feb 3 2020, 4:54 PM
epriestley closed D20963: Fix an issue where loading a mangled project graph could fail too abruptly.
Feb 3 2020, 4:54 PM
epriestley requested review of D20963: Fix an issue where loading a mangled project graph could fail too abruptly.
Feb 3 2020, 4:47 PM
epriestley added a revision to T13484: Allow the policy layer to mark objects as damaged when filtering them: D20963: Fix an issue where loading a mangled project graph could fail too abruptly.
Feb 3 2020, 4:45 PM · Policy
epriestley triaged T13484: Allow the policy layer to mark objects as damaged when filtering them as Wishlist priority.
Feb 3 2020, 4:40 PM · Policy
epriestley closed T13483: (2020 Week 5) Restart AWS host db001 (i-3a9b99f2) as Resolved.

Both of these hosts restarted cleanly.

Feb 3 2020, 2:19 PM · Phacility, Ops
epriestley added a comment to T13483: (2020 Week 5) Restart AWS host db001 (i-3a9b99f2).

AWS is also rebooting web007.

Feb 3 2020, 1:22 PM · Phacility, Ops
epriestley committed rP46fcd135ae68: (stable) Fix an issue where Herald rules could fail to evaluate at post-commit… (authored by epriestley).
(stable) Fix an issue where Herald rules could fail to evaluate at post-commit…
Feb 3 2020, 1:10 PM
epriestley committed rP42e46bbe5a91: Fix an issue where Herald rules could fail to evaluate at post-commit time (authored by epriestley).
Fix an issue where Herald rules could fail to evaluate at post-commit time
Feb 3 2020, 1:09 PM
epriestley closed D20962: Fix an issue where Herald rules could fail to evaluate at post-commit time.
Feb 3 2020, 1:09 PM
epriestley added a comment to D20962: Fix an issue where Herald rules could fail to evaluate at post-commit time.

For posterity, here's the trace I hit:

Feb 3 2020, 1:08 PM
epriestley requested review of D20962: Fix an issue where Herald rules could fail to evaluate at post-commit time.
Feb 3 2020, 1:07 PM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20962: Fix an issue where Herald rules could fail to evaluate at post-commit time.
Feb 3 2020, 1:05 PM · Projects, Owners, Herald
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

See https://discourse.phabricator-community.org/t/herald-rule-not-adding-auditors-to-commits-following-upgrade/3505 for one bug with this.

Feb 3 2020, 1:04 PM · Projects, Owners, Herald

Jan 30 2020

epriestley edited the content of Changelog.
Jan 30 2020, 9:39 PM
epriestley created an object: 2020 Week 5 (Very Late January).
Jan 30 2020, 9:35 PM
epriestley committed rPHU034cf7cc3994: (stable) Promote 2020 Week 5 (authored by epriestley).
(stable) Promote 2020 Week 5
Jan 30 2020, 9:21 PM
epriestley committed rARC729100955129: (stable) Promote 2020 Week 5 (authored by epriestley).
(stable) Promote 2020 Week 5
Jan 30 2020, 9:21 PM
epriestley committed rPcc11dff7d317: (stable) Promote 2020 Week 5 (authored by epriestley).
(stable) Promote 2020 Week 5
Jan 30 2020, 9:21 PM
epriestley closed T13440: Provide a richer "Revisions/Commits" UI in Maniphest as Resolved.

Sounds good. It felt slightly odd to me at first, too, but I think I also got used to it.

Jan 30 2020, 8:16 PM · Diffusion, Differential, Maniphest
swisspol added a comment to T13440: Provide a richer "Revisions/Commits" UI in Maniphest.

It wasn't a major UI issue to start with and yes, you get used to it. I would ignore.

Jan 30 2020, 7:37 PM · Diffusion, Differential, Maniphest
epriestley added a task to D20959: Fix an issue where the last line of block-based diffs could be incorrectly hidden: T13425: Support diffs between abstract block lists in the UI.
Jan 30 2020, 6:45 PM
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20959: Fix an issue where the last line of block-based diffs could be incorrectly hidden.
Jan 30 2020, 6:45 PM · Differential