Page MenuHomePhabricator
Feed All Stories

Jan 30 2020

epriestley closed T13434: Support Perforce/Git in "arc land" as Resolved.

This appears to be working. T13481 fixed one straggling issue with changes to remote handling in very old versions of Git but nothing else has cropped up.

Jan 30 2020, 6:44 PM · Arcanist
epriestley added a comment to T13440: Provide a richer "Revisions/Commits" UI in Maniphest.

The empty space means "this is a normal commit with no special audit state", and the column collapses if no commits have issues (see this task for an example). That seems fairly reasonable to me?

Jan 30 2020, 6:42 PM · Diffusion, Differential, Maniphest
epriestley closed T13450: Update "Renaming Instances" in Phacility documentation as Resolved by committing Restricted Diffusion Commit.
Jan 30 2020, 6:37 PM · Phacility
epriestley triaged T13483: (2020 Week 5) Restart AWS host db001 (i-3a9b99f2) as Normal priority.
Jan 30 2020, 6:36 PM · Phacility, Ops
epriestley requested review of D20961: When publishing a commit, copy "Related Tasks" from the associated revision (if one exists).
Jan 30 2020, 6:33 PM
epriestley added a revision to T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx": D20961: When publishing a commit, copy "Related Tasks" from the associated revision (if one exists).
Jan 30 2020, 6:32 PM · Maniphest, Differential, Diffusion
epriestley added a revision to T13450: Update "Renaming Instances" in Phacility documentation: Unknown Object (Differential Revision).
Jan 30 2020, 5:51 PM · Phacility
epriestley closed T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body as Resolved.

I think D20905 is as good as we're going to get.

Jan 30 2020, 4:44 PM · Auth
epriestley added a comment to T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view.

The underlying code is still a bit shaky, so let me know if you catch other issues.

Jan 30 2020, 4:31 PM · Differential
epriestley committed rPccf28a81121e: Fix an issue where the last line of block-based diffs could be incorrectly… (authored by epriestley).
Fix an issue where the last line of block-based diffs could be incorrectly…
Jan 30 2020, 4:19 PM
epriestley closed T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view as Resolved by committing rPccf28a81121e: Fix an issue where the last line of block-based diffs could be incorrectly….
Jan 30 2020, 4:19 PM · Differential
epriestley closed D20959: Fix an issue where the last line of block-based diffs could be incorrectly hidden.
Jan 30 2020, 4:19 PM
epriestley requested review of D20959: Fix an issue where the last line of block-based diffs could be incorrectly hidden.
Jan 30 2020, 4:19 PM
epriestley added a revision to T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view: D20959: Fix an issue where the last line of block-based diffs could be incorrectly hidden.
Jan 30 2020, 4:17 PM · Differential
epriestley added a comment to T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view.

In DifferentialHunkParser->generateVisibleLinesMask(), we pass a 0-based array in and get a 1-based ("line number") array out. The loop condition stops us from reaching the last line of the 0-based array.

Jan 30 2020, 3:54 PM · Differential
epriestley triaged T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view as Low priority.
Jan 30 2020, 3:36 PM · Differential
epriestley added a project to T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view: Differential.
Jan 30 2020, 3:36 PM · Differential
epriestley committed rP12c337098872: When issuing a "no-op" MFA token because no MFA is configured, don't give the… (authored by epriestley).
When issuing a "no-op" MFA token because no MFA is configured, don't give the…
Jan 30 2020, 3:35 PM
epriestley closed D20958: When issuing a "no-op" MFA token because no MFA is configured, don't give the timeline story a badge.
Jan 30 2020, 3:35 PM
epriestley closed T13475: Fix incorrect MFA badge on some stories when MFA is not configured at all as Resolved by committing rP12c337098872: When issuing a "no-op" MFA token because no MFA is configured, don't give the….
Jan 30 2020, 3:35 PM · Auth
epriestley requested review of D20958: When issuing a "no-op" MFA token because no MFA is configured, don't give the timeline story a badge.
Jan 30 2020, 3:34 PM
epriestley added a revision to T13475: Fix incorrect MFA badge on some stories when MFA is not configured at all: D20958: When issuing a "no-op" MFA token because no MFA is configured, don't give the timeline story a badge.
Jan 30 2020, 3:33 PM · Auth
epriestley closed T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml) as Wontfix.

We have no open customer requests for this and it's very complex, so I don't currently plan to implement it.

Jan 30 2020, 2:59 PM · Restricted Project, Harbormaster
PhoneixS added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

Another use case :

Jan 30 2020, 12:37 PM · Restricted Project, Harbormaster

Jan 29 2020

epriestley committed rPc99485e8a00d: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and… (authored by epriestley).
Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and…
Jan 29 2020, 11:52 PM
epriestley closed D20957: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and Hooks.
Jan 29 2020, 11:52 PM
epriestley closed T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields as Resolved by committing rPc99485e8a00d: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and….
Jan 29 2020, 11:52 PM · Projects, Owners, Herald
epriestley committed rP6628cd2b4f7b: In Herald "Commit" rules, use repository identities to identify authors and… (authored by epriestley).
In Herald "Commit" rules, use repository identities to identify authors and…
Jan 29 2020, 11:49 PM
epriestley closed D20955: In Herald "Commit" rules, use repository identities to identify authors and committers.
Jan 29 2020, 11:49 PM
epriestley committed rP41f143f7feeb: Respect repository identities when figuring out authors/committers in Herald… (authored by epriestley).
Respect repository identities when figuring out authors/committers in Herald…
Jan 29 2020, 11:15 PM
epriestley closed D20953: Respect repository identities when figuring out authors/committers in Herald pre-commit hook rules.
Jan 29 2020, 11:15 PM
epriestley committed rPa0a346be347e: In Herald transcripts, render some field values in a more readable way (authored by epriestley).
In Herald transcripts, render some field values in a more readable way
Jan 29 2020, 11:14 PM
epriestley closed D20951: In Herald transcripts, render some field values in a more readable way.
Jan 29 2020, 11:14 PM
epriestley committed rP19662e33bc45: In Herald transcript rendering, don't store display labels in keys (authored by epriestley).
In Herald transcript rendering, don't store display labels in keys
Jan 29 2020, 11:11 PM
epriestley closed D20949: In Herald transcript rendering, don't store display labels in keys.
Jan 29 2020, 11:11 PM
epriestley committed rPa5a9a5e0027f: Remove legacy pre-loading of handles from Herald rendering (authored by epriestley).
Remove legacy pre-loading of handles from Herald rendering
Jan 29 2020, 11:07 PM
epriestley closed D20948: Remove legacy pre-loading of handles from Herald rendering.
Jan 29 2020, 11:07 PM
epriestley requested review of D20957: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and Hooks.
Jan 29 2020, 10:58 PM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20957: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and Hooks.
Jan 29 2020, 10:56 PM · Projects, Owners, Herald
epriestley requested review of D20956: Update Herald rule creation workflow to use more modern UI elements.
Jan 29 2020, 8:41 PM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20956: Update Herald rule creation workflow to use more modern UI elements.
Jan 29 2020, 8:40 PM · Projects, Owners, Herald
epriestley requested review of D20955: In Herald "Commit" rules, use repository identities to identify authors and committers.
Jan 29 2020, 6:41 PM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20955: In Herald "Commit" rules, use repository identities to identify authors and committers.
Jan 29 2020, 6:40 PM · Projects, Owners, Herald
epriestley updated the task description for T13482: Remove strikethru style from checked-off Remarkup list items.
Jan 29 2020, 5:21 PM · Remarkup
epriestley closed T12865: Strikethrough for icons in checked remarkup list items as Wontfix.

I removed the strikethrough in T13482, which mostly moots this.

Jan 29 2020, 5:21 PM · Remarkup, Feature Request
epriestley committed rP7a1681b8dae1: Don't use "line-through" style for completed items in remarkup checklists (authored by epriestley).
Don't use "line-through" style for completed items in remarkup checklists
Jan 29 2020, 5:00 PM
epriestley closed D20954: Don't use "line-through" style for completed items in remarkup checklists.
Jan 29 2020, 4:59 PM
epriestley closed T13482: Remove strikethru style from checked-off Remarkup list items as Resolved by committing rP7a1681b8dae1: Don't use "line-through" style for completed items in remarkup checklists.
Jan 29 2020, 4:59 PM · Remarkup
epriestley requested review of D20954: Don't use "line-through" style for completed items in remarkup checklists.
Jan 29 2020, 4:55 PM
epriestley added a revision to T13482: Remove strikethru style from checked-off Remarkup list items: D20954: Don't use "line-through" style for completed items in remarkup checklists.
Jan 29 2020, 4:53 PM · Remarkup
epriestley triaged T13482: Remove strikethru style from checked-off Remarkup list items as Wishlist priority.
Jan 29 2020, 4:52 PM · Remarkup

Jan 27 2020

tiguchi awarded T7616: Arcanist to be able to access site requiring client side SSL certificate a Like token.
Jan 27 2020, 9:31 PM · Arcanist, libphutil

Jan 24 2020

epriestley requested review of D20953: Respect repository identities when figuring out authors/committers in Herald pre-commit hook rules.
Jan 24 2020, 1:17 AM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20953: Respect repository identities when figuring out authors/committers in Herald pre-commit hook rules.
Jan 24 2020, 1:16 AM · Projects, Owners, Herald
epriestley committed rARC21a1828ea06c: Omit "--" in older fallback commands for Git remote URIs (authored by epriestley).
Omit "--" in older fallback commands for Git remote URIs
Jan 24 2020, 12:51 AM
epriestley closed D20952: Omit "--" in older fallback commands for Git remote URIs.
Jan 24 2020, 12:51 AM
epriestley updated the diff for D20952: Omit "--" in older fallback commands for Git remote URIs.
  • Only omit "--" in "git ls-remote", since it seems like it's okay for even very old "git config".
Jan 24 2020, 12:50 AM
epriestley requested review of D20952: Omit "--" in older fallback commands for Git remote URIs.
Jan 24 2020, 12:39 AM
epriestley added a revision to T13481: Don't require "git remote get-url" in Arcanist: D20952: Omit "--" in older fallback commands for Git remote URIs.
Jan 24 2020, 12:39 AM · Arcanist

Jan 23 2020

epriestley requested review of D20951: In Herald transcripts, render some field values in a more readable way.
Jan 23 2020, 11:40 PM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20951: In Herald transcripts, render some field values in a more readable way.
Jan 23 2020, 11:38 PM · Projects, Owners, Herald
epriestley committed rARC70c0fd3f2233: In Git, fall back across versions more cleanly when trying to get the URI for a… (authored by epriestley).
In Git, fall back across versions more cleanly when trying to get the URI for a…
Jan 23 2020, 11:19 PM
epriestley closed D20950: In Git, fall back across versions more cleanly when trying to get the URI for a remote.
Jan 23 2020, 11:19 PM
epriestley closed T13481: Don't require "git remote get-url" in Arcanist as Resolved by committing rARC70c0fd3f2233: In Git, fall back across versions more cleanly when trying to get the URI for a….
Jan 23 2020, 11:19 PM · Arcanist
epriestley requested review of D20950: In Git, fall back across versions more cleanly when trying to get the URI for a remote.
Jan 23 2020, 11:18 PM
epriestley added a revision to T13481: Don't require "git remote get-url" in Arcanist: D20950: In Git, fall back across versions more cleanly when trying to get the URI for a remote.
Jan 23 2020, 11:17 PM · Arcanist
epriestley updated the task description for T13481: Don't require "git remote get-url" in Arcanist.
Jan 23 2020, 10:12 PM · Arcanist
epriestley triaged T13481: Don't require "git remote get-url" in Arcanist as Wishlist priority.
Jan 23 2020, 10:09 PM · Arcanist
epriestley requested review of D20949: In Herald transcript rendering, don't store display labels in keys.
Jan 23 2020, 7:53 PM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20949: In Herald transcript rendering, don't store display labels in keys.
Jan 23 2020, 7:51 PM · Projects, Owners, Herald
epriestley requested review of D20948: Remove legacy pre-loading of handles from Herald rendering.
Jan 23 2020, 7:43 PM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20948: Remove legacy pre-loading of handles from Herald rendering.
Jan 23 2020, 7:42 PM · Projects, Owners, Herald
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

Remaining work:

Jan 23 2020, 2:43 AM · Projects, Owners, Herald
epriestley committed rPb38449ce8f4b: Implement an "Author's packages" Herald field for Differential (authored by epriestley).
Implement an "Author's packages" Herald field for Differential
Jan 23 2020, 2:28 AM
epriestley closed D20947: Implement an "Author's packages" Herald field for Differential.
Jan 23 2020, 2:27 AM
epriestley committed rP6c4500046f7c: Add "Project tags added" and "Project tags removed" fields in Herald (authored by epriestley).
Add "Project tags added" and "Project tags removed" fields in Herald
Jan 23 2020, 2:21 AM
epriestley closed D20946: Add "Project tags added" and "Project tags removed" fields in Herald.
Jan 23 2020, 2:21 AM
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

D20947 does not implement "Author's packages" as a "Commit Content" field, nor as a "Commit Content (Hook)" field. The reason for this is that getting the modern authorPHID in both cases is somewhat complicated.

Jan 23 2020, 2:20 AM · Projects, Owners, Herald
epriestley requested review of D20947: Implement an "Author's packages" Herald field for Differential.
Jan 23 2020, 2:19 AM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20947: Implement an "Author's packages" Herald field for Differential.
Jan 23 2020, 2:17 AM · Projects, Owners, Herald

Jan 21 2020

epriestley requested review of D20946: Add "Project tags added" and "Project tags removed" fields in Herald.
Jan 21 2020, 7:33 PM
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20946: Add "Project tags added" and "Project tags removed" fields in Herald.
Jan 21 2020, 7:31 PM · Projects, Owners, Herald
epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

The logic here appears to be that gc.auto is set to some value (by default: 6,700). If the number of loose objects exceeds this threshold (technically, if the number of loose objects in objects/17/ is more than 1/256th of this value), it triggers a repack (in a comment, git repack -d -l).

Jan 21 2020, 6:00 PM · Phacility, Diffusion
epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

See PHI1613, where an install hit this warning (and resolved it by running git prune):

Jan 21 2020, 5:13 PM · Phacility, Diffusion
epriestley lowered the priority of T13473: Provide full payload logging for inbound CircleCI build requests from Low to Wishlist.

The issue in PHI1605 resolved itself without apparent intervention, presumably as a result of changes on the CircleCI side. I can't find any release notes to shed any light on things, but this is no longer time-sensitive.

Jan 21 2020, 5:12 PM · Infrastructure

Jan 17 2020

epriestley renamed T13478: Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones from Fix various policy issues issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones to Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones.
Jan 17 2020, 5:19 PM · Policy, Projects
epriestley triaged T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields as Wishlist priority.
Jan 17 2020, 5:05 PM · Projects, Owners, Herald
epriestley added a comment to T13395: Strip libphutil for parts.

See also https://discourse.phabricator-community.org/t/storage-upgrade-failed-class-phutilauthadapter-not-defined/3468.

Jan 17 2020, 4:55 PM · libphutil

Jan 16 2020

epriestley committed rP6ccb6a6463f7: Update "git rev-parse" invocation to work in Git 2.25.0 (authored by epriestley).
Update "git rev-parse" invocation to work in Git 2.25.0
Jan 16 2020, 7:39 PM
epriestley closed D20945: Update "git rev-parse" invocation to work in Git 2.25.0.
Jan 16 2020, 7:39 PM
epriestley closed T13479: Update "git rev-parse --show-toplevel" for Git 2.25.0 as Resolved by committing rP6ccb6a6463f7: Update "git rev-parse" invocation to work in Git 2.25.0.
Jan 16 2020, 7:39 PM · Diffusion
epriestley requested review of D20945: Update "git rev-parse" invocation to work in Git 2.25.0.
Jan 16 2020, 7:38 PM
epriestley added a revision to T13479: Update "git rev-parse --show-toplevel" for Git 2.25.0: D20945: Update "git rev-parse" invocation to work in Git 2.25.0.
Jan 16 2020, 7:37 PM · Diffusion
epriestley triaged T13479: Update "git rev-parse --show-toplevel" for Git 2.25.0 as Low priority.
Jan 16 2020, 7:18 PM · Diffusion
epriestley closed T10779: Cannot manage base project milestones if base project has subprojects as Resolved.

See T13478 for followup.

Jan 16 2020, 6:50 PM · Restricted Project, Projects, Bug Report
epriestley triaged T13478: Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones as Low priority.
Jan 16 2020, 6:49 PM · Policy, Projects
epriestley reopened T10779: Cannot manage base project milestones if base project has subprojects as "Open".

I'm also still able to reproduce this specific variant of things, so it looks like I was too optimistic about T13462 covering this in at least some cases.

Jan 16 2020, 4:50 PM · Restricted Project, Projects, Bug Report

Jan 15 2020

epriestley committed rPd0b01a41f249: Fix two issues with missing whitespace when elements stack on top of each other… (authored by epriestley).
Fix two issues with missing whitespace when elements stack on top of each other…
Jan 15 2020, 4:53 PM
epriestley closed D20944: Fix two issues with missing whitespace when elements stack on top of each other while wrapping.
Jan 15 2020, 4:53 PM
epriestley closed T13476: Correct vertical spacing issues when some components wrap across a line break as Resolved by committing rPd0b01a41f249: Fix two issues with missing whitespace when elements stack on top of each other….
Jan 15 2020, 4:53 PM · Design