This appears to be working. T13481 fixed one straggling issue with changes to remote handling in very old versions of Git but nothing else has cropped up.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jan 30 2020
The empty space means "this is a normal commit with no special audit state", and the column collapses if no commits have issues (see this task for an example). That seems fairly reasonable to me?
I think D20905 is as good as we're going to get.
The underlying code is still a bit shaky, so let me know if you catch other issues.
In DifferentialHunkParser->generateVisibleLinesMask(), we pass a 0-based array in and get a 1-based ("line number") array out. The loop condition stops us from reaching the last line of the 0-based array.
We have no open customer requests for this and it's very complex, so I don't currently plan to implement it.
Another use case :
Jan 29 2020
I removed the strikethrough in T13482, which mostly moots this.
Jan 27 2020
Jan 24 2020
- Only omit "--" in "git ls-remote", since it seems like it's okay for even very old "git config".
Jan 23 2020
Remaining work:
D20947 does not implement "Author's packages" as a "Commit Content" field, nor as a "Commit Content (Hook)" field. The reason for this is that getting the modern authorPHID in both cases is somewhat complicated.
Jan 21 2020
The logic here appears to be that gc.auto is set to some value (by default: 6,700). If the number of loose objects exceeds this threshold (technically, if the number of loose objects in objects/17/ is more than 1/256th of this value), it triggers a repack (in a comment, git repack -d -l).
See PHI1613, where an install hit this warning (and resolved it by running git prune):
The issue in PHI1605 resolved itself without apparent intervention, presumably as a result of changes on the CircleCI side. I can't find any release notes to shed any light on things, but this is no longer time-sensitive.
Jan 17 2020
Jan 16 2020
See T13478 for followup.
I'm also still able to reproduce this specific variant of things, so it looks like I was too optimistic about T13462 covering this in at least some cases.