Page MenuHomePhabricator
Feed All Stories

Nov 9 2019

epriestley committed rARC2979752639a0: (experimental) Merge branch "master" into experimental (authored by epriestley).
(experimental) Merge branch "master" into experimental
Nov 9 2019, 2:16 AM
epriestley edited the content of Changelog.
Nov 9 2019, 2:10 AM
epriestley created an object: 2019 Week 45 (Mid November).
Nov 9 2019, 2:09 AM
epriestley committed rPcf6df55dbee3: (stable) Promote 2019 Week 45 (authored by epriestley).
(stable) Promote 2019 Week 45
Nov 9 2019, 2:08 AM
epriestley committed rP72f82abe0723: Improve recovery from panel action rendering exceptions, and mark "Changeset"… (authored by epriestley).
Improve recovery from panel action rendering exceptions, and mark "Changeset"…
Nov 9 2019, 1:15 AM
epriestley closed T13443: Creating a dashboard query panel with the type "Differential Changesets" breaks the dashboard editor as Resolved by committing rP72f82abe0723: Improve recovery from panel action rendering exceptions, and mark "Changeset"….
Nov 9 2019, 1:15 AM · Dashboards
epriestley closed D20902: Improve recovery from panel action rendering exceptions, and mark "Changeset" queries as not suitable for panel generation.
Nov 9 2019, 1:15 AM
epriestley requested review of D20902: Improve recovery from panel action rendering exceptions, and mark "Changeset" queries as not suitable for panel generation.
Nov 9 2019, 1:13 AM
epriestley added a revision to T13443: Creating a dashboard query panel with the type "Differential Changesets" breaks the dashboard editor: D20902: Improve recovery from panel action rendering exceptions, and mark "Changeset" queries as not suitable for panel generation.
Nov 9 2019, 1:12 AM · Dashboards
epriestley claimed T13443: Creating a dashboard query panel with the type "Differential Changesets" breaks the dashboard editor.
Nov 9 2019, 1:09 AM · Dashboards
epriestley committed rPa3f4cbd7484b: Correct rendering of workboard column move stories when a single transaction… (authored by epriestley).
Correct rendering of workboard column move stories when a single transaction…
Nov 9 2019, 12:57 AM
epriestley closed D20901: Correct rendering of workboard column move stories when a single transaction performs moves on multiple boards.
Nov 9 2019, 12:57 AM
epriestley requested review of D20901: Correct rendering of workboard column move stories when a single transaction performs moves on multiple boards.
Nov 9 2019, 12:56 AM
epriestley committed rPb83b3224bb75: Add an "Advanced/Developer..." action item for viewing object handle details… (authored by epriestley).
Add an "Advanced/Developer..." action item for viewing object handle details…
Nov 9 2019, 12:47 AM
epriestley closed D20887: Add an "Advanced/Developer..." action item for viewing object handle details and hovercards.
Nov 9 2019, 12:47 AM

Nov 8 2019

epriestley committed rPcd60a8aa563b: Update various Asana odds-and-ends for "gid" API changes (authored by epriestley).
Update various Asana odds-and-ends for "gid" API changes
Nov 8 2019, 5:08 PM
epriestley closed D20900: Update various Asana odds-and-ends for "gid" API changes.
Nov 8 2019, 5:08 PM
epriestley requested review of D20900: Update various Asana odds-and-ends for "gid" API changes.
Nov 8 2019, 5:03 PM
epriestley committed rP2223d6b91467: Update Asana Auth adapter for "gid" API changes (authored by epriestley).
Update Asana Auth adapter for "gid" API changes
Nov 8 2019, 5:02 PM
epriestley closed D20899: Update Asana Auth adapter for "gid" API changes.
Nov 8 2019, 5:02 PM
epriestley added a revision to T13453: Update Asana Auth Adapter for "gid" API changes: D20900: Update various Asana odds-and-ends for "gid" API changes.
Nov 8 2019, 5:01 PM · Asana, Auth
epriestley requested review of D20899: Update Asana Auth adapter for "gid" API changes.
Nov 8 2019, 5:01 PM
epriestley added a revision to T13453: Update Asana Auth Adapter for "gid" API changes: D20899: Update Asana Auth adapter for "gid" API changes.
Nov 8 2019, 5:00 PM · Asana, Auth
epriestley added a comment to T13453: Update Asana Auth Adapter for "gid" API changes.

This may also impact the Doorkeeper integration, which reads "id" fields from a few calls.

Nov 8 2019, 4:45 PM · Asana, Auth
epriestley triaged T13453: Update Asana Auth Adapter for "gid" API changes as Wishlist priority.
Nov 8 2019, 4:44 PM · Asana, Auth
epriestley committed rP338b4cb2e709: Prevent workboard cards from being grabbed by the "Txxx" object name text (authored by epriestley).
Prevent workboard cards from being grabbed by the "Txxx" object name text
Nov 8 2019, 4:30 PM
epriestley closed D20898: Prevent workboard cards from being grabbed by the "Txxx" object name text.
Nov 8 2019, 4:30 PM
epriestley closed T13452: Clarify behavior of object names on workboard cards as Resolved by committing rP338b4cb2e709: Prevent workboard cards from being grabbed by the "Txxx" object name text.
Nov 8 2019, 4:30 PM · Workboards
epriestley requested review of D20898: Prevent workboard cards from being grabbed by the "Txxx" object name text.
Nov 8 2019, 4:29 PM
epriestley added a revision to T13452: Clarify behavior of object names on workboard cards: D20898: Prevent workboard cards from being grabbed by the "Txxx" object name text.
Nov 8 2019, 4:28 PM · Workboards
epriestley triaged T13452: Clarify behavior of object names on workboard cards as Wishlist priority.
Nov 8 2019, 4:24 PM · Workboards
epriestley added a comment to T13451: Chrome double-click selection behavior has changed in LayoutNG.

I'm planning to give Chrome some time to triage the report. If it sits there for a while or they decide it's how LayoutNG is going to handle this case, I'll look for workarounds. I don't think our intent/markup is totally unambiguous, and it may be reasonable to decide that this behavior is acceptable, even though Safari and Firefox have different behavior.

Nov 8 2019, 4:10 PM · Google Chrome
epriestley updated the task description for T13451: Chrome double-click selection behavior has changed in LayoutNG.
Nov 8 2019, 4:07 PM · Google Chrome
epriestley renamed T13451: Chrome double-click selection behavior has changed in LayoutNG from Chrome double-click selection behavior has changed in Chrome ~78? to Chrome double-click selection behavior has changed in LayoutNG.
Nov 8 2019, 4:06 PM · Google Chrome
epriestley added a comment to T13451: Chrome double-click selection behavior has changed in LayoutNG.

Here's a simple reproduction case:

Nov 8 2019, 4:05 PM · Google Chrome
epriestley triaged T13451: Chrome double-click selection behavior has changed in LayoutNG as Low priority.
Nov 8 2019, 3:41 PM · Google Chrome
epriestley committed rPd4491ddc225e: Fix an issue with 1up diff block rendering for added or removed blocks (authored by epriestley).
Fix an issue with 1up diff block rendering for added or removed blocks
Nov 8 2019, 3:37 PM
epriestley closed D20897: Fix an issue with 1up diff block rendering for added or removed blocks.
Nov 8 2019, 3:37 PM
epriestley updated subscribers of D20897: Fix an issue with 1up diff block rendering for added or removed blocks.

See also https://discourse.phabricator-community.org/t/error-when-trying-to-view-jupyter-notebooks-changes-via-view-unified/3258.

Nov 8 2019, 3:36 PM
epriestley updated the test plan for D20897: Fix an issue with 1up diff block rendering for added or removed blocks.
Nov 8 2019, 3:36 PM
epriestley requested review of D20897: Fix an issue with 1up diff block rendering for added or removed blocks.
Nov 8 2019, 3:36 PM
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20897: Fix an issue with 1up diff block rendering for added or removed blocks.
Nov 8 2019, 3:35 PM · Differential
epriestley triaged T13450: Update "Renaming Instances" in Phacility documentation as Wishlist priority.
Nov 8 2019, 2:27 AM · Phacility
epriestley added a subtask for T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes: T13449: When objects are created with a particular subtype, apply subtype-appropriate validation rules.
Nov 8 2019, 12:57 AM · Custom Fields, Maniphest
epriestley added a parent task for T13449: When objects are created with a particular subtype, apply subtype-appropriate validation rules: T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes.
Nov 8 2019, 12:57 AM · Transactions
epriestley triaged T13449: When objects are created with a particular subtype, apply subtype-appropriate validation rules as Normal priority.
Nov 8 2019, 12:57 AM · Transactions
epriestley committed rP502ca4767e4b: When "Fetch Refs" are configured for a repository, highlight the "Branches"… (authored by epriestley).
When "Fetch Refs" are configured for a repository, highlight the "Branches"…
Nov 8 2019, 12:28 AM
epriestley closed D20895: When "Fetch Refs" are configured for a repository, highlight the "Branches" menu item in the Diffusion Management UI.
Nov 8 2019, 12:28 AM
epriestley requested review of D20895: When "Fetch Refs" are configured for a repository, highlight the "Branches" menu item in the Diffusion Management UI.
Nov 8 2019, 12:27 AM
epriestley added a revision to T13448: Respect "Fetch Refs" when cloning a new repository: D20895: When "Fetch Refs" are configured for a repository, highlight the "Branches" menu item in the Diffusion Management UI.
Nov 8 2019, 12:25 AM · Diffusion
epriestley committed rP1b40f7e5408b: Always initialize Git repositories with "git init", never with "git clone" (authored by epriestley).
Always initialize Git repositories with "git init", never with "git clone"
Nov 8 2019, 12:17 AM
epriestley closed D20894: Always initialize Git repositories with "git init", never with "git clone".
Nov 8 2019, 12:17 AM
epriestley closed T13448: Respect "Fetch Refs" when cloning a new repository as Resolved by committing rP1b40f7e5408b: Always initialize Git repositories with "git init", never with "git clone".
Nov 8 2019, 12:17 AM · Diffusion
epriestley committed rP8dd57a1ed221: When fetching Git repositories, pass "--no-tags" to make explicit "Fetch Refs"… (authored by epriestley).
When fetching Git repositories, pass "--no-tags" to make explicit "Fetch Refs"…
Nov 8 2019, 12:17 AM
epriestley closed D20893: When fetching Git repositories, pass "--no-tags" to make explicit "Fetch Refs" operate more narrowly.
Nov 8 2019, 12:17 AM
epriestley committed rP9dbde24dda72: Manually prune Git working copy refs instead of using "--prune", to improve… (authored by epriestley).
Manually prune Git working copy refs instead of using "--prune", to improve…
Nov 8 2019, 12:15 AM
epriestley closed D20892: Manually prune Git working copy refs instead of using "--prune", to improve "Fetch Refs" behavior.
Nov 8 2019, 12:15 AM
epriestley requested review of D20894: Always initialize Git repositories with "git init", never with "git clone".
Nov 8 2019, 12:09 AM
epriestley added a revision to T13448: Respect "Fetch Refs" when cloning a new repository: D20894: Always initialize Git repositories with "git init", never with "git clone".
Nov 8 2019, 12:07 AM · Diffusion

Nov 7 2019

epriestley requested review of D20893: When fetching Git repositories, pass "--no-tags" to make explicit "Fetch Refs" operate more narrowly.
Nov 7 2019, 11:53 PM
epriestley added a revision to T13448: Respect "Fetch Refs" when cloning a new repository: D20893: When fetching Git repositories, pass "--no-tags" to make explicit "Fetch Refs" operate more narrowly.
Nov 7 2019, 11:51 PM · Diffusion
epriestley requested review of D20892: Manually prune Git working copy refs instead of using "--prune", to improve "Fetch Refs" behavior.
Nov 7 2019, 11:41 PM
epriestley added a revision to T13448: Respect "Fetch Refs" when cloning a new repository: D20892: Manually prune Git working copy refs instead of using "--prune", to improve "Fetch Refs" behavior.
Nov 7 2019, 11:39 PM · Diffusion
epriestley added a comment to T13448: Respect "Fetch Refs" when cloning a new repository.

I stopped the daemons, then created a new repository observed from GitHub with "Fetch Refs" set to "refs/heads/master". I ran bin/repository pull X --trace to update it, and saw it clone:

Nov 7 2019, 11:15 PM · Diffusion
epriestley triaged T13448: Respect "Fetch Refs" when cloning a new repository as Low priority.
Nov 7 2019, 10:57 PM · Diffusion
epriestley added a comment to T13447: Make "bin/aphlict notify" send notifications in-process.

This looks like an edge case that fell out of D19864, which was originally motivated by similar goals (fixing how test notifications work).

Nov 7 2019, 10:38 PM · Aphlict
epriestley claimed T13447: Make "bin/aphlict notify" send notifications in-process.
Nov 7 2019, 10:28 PM · Aphlict
epriestley triaged T13447: Make "bin/aphlict notify" send notifications in-process as Low priority.
Nov 7 2019, 10:28 PM · Aphlict
avivey edited the content of Community Resources.
Nov 7 2019, 7:24 PM
artms abandoned D20891: Jupyter notebook.
Nov 7 2019, 1:50 PM
artms requested review of D20891: Jupyter notebook.
Nov 7 2019, 1:49 PM

Nov 6 2019

epriestley committed rPf5f2a0bc5696: Allow username changes which modify letter case to go through as valid (authored by epriestley).
Allow username changes which modify letter case to go through as valid
Nov 6 2019, 4:10 PM
epriestley closed D20890: Allow username changes which modify letter case to go through as valid.
Nov 6 2019, 4:10 PM
epriestley closed T13446: Allow username changes to change the letter case of an existing username as Resolved by committing rPf5f2a0bc5696: Allow username changes which modify letter case to go through as valid.
Nov 6 2019, 4:10 PM · People
epriestley requested review of D20890: Allow username changes which modify letter case to go through as valid.
Nov 6 2019, 4:10 PM
epriestley added a revision to T13446: Allow username changes to change the letter case of an existing username: D20890: Allow username changes which modify letter case to go through as valid.
Nov 6 2019, 4:08 PM · People
epriestley triaged T13446: Allow username changes to change the letter case of an existing username as Low priority.
Nov 6 2019, 4:00 PM · People
epriestley committed rP6bada7db4ceb: Change the Herald "do not include [any of]" condition label to "include none of" (authored by epriestley).
Change the Herald "do not include [any of]" condition label to "include none of"
Nov 6 2019, 3:56 PM
epriestley closed D20889: Change the Herald "do not include [any of]" condition label to "include none of".
Nov 6 2019, 3:55 PM
epriestley closed T13445: Improve clarity of "do not include" condition in Herald as Resolved by committing rP6bada7db4ceb: Change the Herald "do not include [any of]" condition label to "include none of".
Nov 6 2019, 3:55 PM · Herald
epriestley requested review of D20889: Change the Herald "do not include [any of]" condition label to "include none of".
Nov 6 2019, 3:55 PM
epriestley updated the task description for T13445: Improve clarity of "do not include" condition in Herald.
Nov 6 2019, 3:53 PM · Herald
epriestley added a revision to T13445: Improve clarity of "do not include" condition in Herald: D20889: Change the Herald "do not include [any of]" condition label to "include none of".
Nov 6 2019, 3:53 PM · Herald
epriestley triaged T13445: Improve clarity of "do not include" condition in Herald as Low priority.
Nov 6 2019, 3:51 PM · Herald

Nov 4 2019

epriestley added a subtask for T12164: Put an indirection layer between author/committer strings and user accounts: T13444: Provide a standalone script entry point for resolving a repository identity.
Nov 4 2019, 8:24 PM · Customer Impact, Diffusion (v3)
epriestley added a parent task for T13444: Provide a standalone script entry point for resolving a repository identity: T12164: Put an indirection layer between author/committer strings and user accounts.
Nov 4 2019, 8:24 PM · Diffusion
epriestley triaged T13444: Provide a standalone script entry point for resolving a repository identity as Wishlist priority.
Nov 4 2019, 8:23 PM · Diffusion
leoluk added a comment to T550: Build an SSH conduit client.

I'm planning to support this in the arc experimental branch, although initial support won't be optimized. We can look at ControlPath and/or adding batching to the protocol layer to improve performance once it works.

Nov 4 2019, 8:13 PM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
swisspol added a comment to T13440: Provide a richer "Revisions/Commits" UI in Maniphest.

Layout looks very neat but a strange too with that big space gap between the icon on each row and the actual text in this case:

image.png (362×780 px, 66 KB)

Nov 4 2019, 7:57 PM · Diffusion, Differential, Maniphest
davidgiga1993 added a comment to T7000: 404 when accessing repo via http.

Yes sure. But in the case I've described above the user has access to diffusion (is member of the project having the diffusion application permission).

Nov 4 2019, 6:11 PM · Diffusion
leoluk added a comment to T7000: 404 when accessing repo via http.

Isn't this working as designed? A user (or the public) needing access to the diffusion application in order to access repositories is exactly the behavior I would expect.

Nov 4 2019, 5:45 PM · Diffusion
leoluk updated the task description for T13443: Creating a dashboard query panel with the type "Differential Changesets" breaks the dashboard editor.
Nov 4 2019, 4:28 PM · Dashboards
leoluk updated the task description for T13443: Creating a dashboard query panel with the type "Differential Changesets" breaks the dashboard editor.
Nov 4 2019, 4:20 PM · Dashboards
leoluk created T13443: Creating a dashboard query panel with the type "Differential Changesets" breaks the dashboard editor.
Nov 4 2019, 4:18 PM · Dashboards
davidgiga1993 added a comment to T7000: 404 when accessing repo via http.

Again, this issue is still relevant. Updating did again break it.

Nov 4 2019, 9:07 AM · Diffusion
davidgiga1993 updated the task description for T7000: 404 when accessing repo via http.
Nov 4 2019, 9:07 AM · Diffusion
epriestley edited the content of Changelog.
Nov 4 2019, 2:08 AM
epriestley created an object: 2019 Week 44 (Early November).
Nov 4 2019, 2:07 AM
epriestley committed rARCdb1959900a64: (stable) Promote 2019 Week 44 (authored by epriestley).
(stable) Promote 2019 Week 44
Nov 4 2019, 2:07 AM
epriestley committed rP7585b1212b90: (stable) Promote 2019 Week 44 (authored by epriestley).
(stable) Promote 2019 Week 44
Nov 4 2019, 2:07 AM