In D20880#264515, @epriestley wrote:

Oh, sorry, I think I misunderstood what you're describing in your test plan -- you're saying that you're currently observing the revision not closing, and believe this fixes it. I'll see if I can reproduce this.

Oct 31 2019, 4:32 PM

epriestley requested review of D20881: Show repository information (and use repository identities) in commit hovercards.

Oct 31 2019, 4:00 PM

epriestley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D20881: Show repository information (and use repository identities) in commit hovercards.

Oct 31 2019, 3:59 PM · Customer Impact, Diffusion (v3)

epriestley added a revision to T13439: Include repository information on commit hovercards: D20881: Show repository information (and use repository identities) in commit hovercards.

Oct 31 2019, 3:58 PM · Diffusion

epriestley added a comment to T13439: Include repository information on commit hovercards.

Show audit status?

Oct 31 2019, 3:23 PM · Diffusion

epriestley added a comment to T13439: Include repository information on commit hovercards.

Here's the current hovercard:

Oct 31 2019, 3:21 PM · Diffusion

epriestley added a comment to D20880: Force `PhabricatorRepositoryGitCommitMessageParserWorker` to be executed when changing commit from non permanent to permanent which ensures that corresponding Differential Revision is closed.

Oh, sorry, I think I misunderstood what you're describing in your test plan -- you're saying that you're currently observing the revision not closing, and believe this fixes it. I'll see if I can reproduce this.

Oct 31 2019, 3:12 PM

Phabricator parses commit and actually closes corresponding Differential Revision and not only marks commit as published

Oct 31 2019, 3:07 PM

artms added inline comments to D20428: When a commit appears as an ancestor of a permanent ref for the first time, run all import steps.

Oct 31 2019, 3:05 PM

artms requested review of D20880: Force `PhabricatorRepositoryGitCommitMessageParserWorker` to be executed when changing commit from non permanent to permanent which ensures that corresponding Differential Revision is closed.

Oct 31 2019, 3:04 PM

Oct 30 2019

artms committed rPbcf15abcd33c: Return empty data if fact dimension is missing, not yet available (authored by artms).

Return empty data if fact dimension is missing, not yet available

Oct 30 2019, 2:34 PM

artms closed D20861: Return empty data if fact dimension is missing, not yet available.

Oct 30 2019, 2:34 PM

Oct 29 2019

epriestley committed rP9d8cdce8e1f2: Make the top-level burndown chart in "Maniphest > Reports" show open tasks, not… (authored by epriestley).

Make the top-level burndown chart in "Maniphest > Reports" show open tasks, not…

Oct 29 2019, 8:48 PM

epriestley closed D20879: Make the top-level burndown chart in "Maniphest > Reports" show open tasks, not total tasks.

Oct 29 2019, 8:48 PM

epriestley requested review of D20879: Make the top-level burndown chart in "Maniphest > Reports" show open tasks, not total tasks.

Oct 29 2019, 8:48 PM

epriestley added a revision to T13279: Build Charting for Facts: D20879: Make the top-level burndown chart in "Maniphest > Reports" show open tasks, not total tasks.

Oct 29 2019, 8:46 PM · Plans, Facts

epriestley triaged T13439: Include repository information on commit hovercards as Low priority.

Oct 29 2019, 8:42 PM · Diffusion

epriestley committed rP114166dd3261: Roughly implement "harbormaster.artifact.search" (authored by epriestley).

Roughly implement "harbormaster.artifact.search"

Oct 29 2019, 8:37 PM

epriestley closed D20878: Roughly implement "harbormaster.artifact.search".

Oct 29 2019, 8:37 PM

leoluk awarded D20875: Don't use "phutil_hashes_are_identical()" to compare public keys a Y So Serious token.

Oct 29 2019, 8:32 PM

epriestley requested review of D20878: Roughly implement "harbormaster.artifact.search".

Oct 29 2019, 8:32 PM

epriestley added a revision to T13438: Implement "harbormaster.artifact.search": D20878: Roughly implement "harbormaster.artifact.search".

Oct 29 2019, 8:30 PM · Harbormaster

epriestley triaged T13438: Implement "harbormaster.artifact.search" as Low priority.

Oct 29 2019, 8:29 PM · Harbormaster

epriestley accepted D20861: Return empty data if fact dimension is missing, not yet available.

Thanks!

Oct 29 2019, 5:16 PM

epriestley added a comment to T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.

After D20877, we'll forcefully override this option when generating diffs internally.

Oct 29 2019, 5:15 PM · Differential

epriestley committed rARCcc1ff38843c4: When generating diffs in "arc diff", disable Git config option "diff. (authored by epriestley).

When generating diffs in "arc diff", disable Git config option "diff.

Oct 29 2019, 5:14 PM

epriestley closed D20877: When generating diffs in "arc diff", disable Git config option "diff.suppressBlankEmpty".

Oct 29 2019, 5:14 PM

epriestley requested review of D20877: When generating diffs in "arc diff", disable Git config option "diff.suppressBlankEmpty".

Oct 29 2019, 5:13 PM

epriestley added a revision to T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly: D20877: When generating diffs in "arc diff", disable Git config option "diff.suppressBlankEmpty".

Oct 29 2019, 5:12 PM · Differential

epriestley updated the task description for T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.

Oct 29 2019, 5:04 PM · Differential

epriestley committed rPe1da1d86d680: Trim and URI encode symbol names before building URIs from them (authored by epriestley).

Trim and URI encode symbol names before building URIs from them

Oct 29 2019, 4:48 PM

epriestley closed D20876: Trim and URI encode symbol names before building URIs from them.

Oct 29 2019, 4:48 PM

epriestley closed T13437: "Jump to Symbol" URIs from diff views are built without proper escaping as Resolved by committing rPe1da1d86d680: Trim and URI encode symbol names before building URIs from them.

Oct 29 2019, 4:48 PM · Diffusion, Differential

epriestley updated the task description for T13437: "Jump to Symbol" URIs from diff views are built without proper escaping.

Oct 29 2019, 4:48 PM · Diffusion, Differential

epriestley requested review of D20876: Trim and URI encode symbol names before building URIs from them.

Oct 29 2019, 4:43 PM

epriestley added a revision to T13437: "Jump to Symbol" URIs from diff views are built without proper escaping: D20876: Trim and URI encode symbol names before building URIs from them.

Oct 29 2019, 4:41 PM · Diffusion, Differential

epriestley triaged T13437: "Jump to Symbol" URIs from diff views are built without proper escaping as Low priority.

Oct 29 2019, 4:32 PM · Diffusion, Differential

epriestley committed rPe4cc74f1b87a: (stable) Don't use "phutil_hashes_are_identical()" to compare public keys (authored by epriestley).

(stable) Don't use "phutil_hashes_are_identical()" to compare public keys

Oct 29 2019, 1:51 AM

epriestley committed rP257830ae71d1: (stable) Remove the "ssh-auth-key" script (authored by epriestley).

(stable) Remove the "ssh-auth-key" script

Oct 29 2019, 1:51 AM

epriestley committed rP5a4a1e8c9f13: (stable) Add an optional "--sshd-key" argument to "bin/ssh-auth" for reading… (authored by epriestley).

(stable) Add an optional "--sshd-key" argument to "bin/ssh-auth" for reading…

Oct 29 2019, 1:51 AM

epriestley added a comment to T13436: Improve performance of "ssh-auth".

I deployed the --sshd-key %k stuff to secure and it looks like that shaved ~1,000-2000ms off the total cost. The ssh-auth cost has dropped to about 200ms:

Oct 29 2019, 1:47 AM · Diffusion, Phacility, Infrastructure

Harbormaster failed to build B23594: rP4a53fc339e32: Don't use "phutil_hashes_are_identical()" to compare public keys for rP4a53fc339e32: Don't use "phutil_hashes_are_identical()" to compare public keys!

Oct 29 2019, 1:36 AM

epriestley committed rP4a53fc339e32: Don't use "phutil_hashes_are_identical()" to compare public keys (authored by epriestley).

Don't use "phutil_hashes_are_identical()" to compare public keys

Oct 29 2019, 1:34 AM

epriestley closed D20875: Don't use "phutil_hashes_are_identical()" to compare public keys.

Oct 29 2019, 1:34 AM

epriestley requested review of D20875: Don't use "phutil_hashes_are_identical()" to compare public keys.

Oct 29 2019, 1:32 AM

epriestley added a revision to T13436: Improve performance of "ssh-auth": D20875: Don't use "phutil_hashes_are_identical()" to compare public keys.

Oct 29 2019, 1:31 AM · Diffusion, Phacility, Infrastructure

epriestley committed rP24f771c1bc07: Add an optional "--sshd-key" argument to "bin/ssh-auth" for reading "%k" from… (authored by epriestley).

Add an optional "--sshd-key" argument to "bin/ssh-auth" for reading "%k" from…

Oct 29 2019, 12:57 AM

epriestley closed D20874: Add an optional "--sshd-key" argument to "bin/ssh-auth" for reading "%k" from modern sshd.

Oct 29 2019, 12:57 AM

epriestley committed rP02f85f03bda7: Remove the "ssh-auth-key" script (authored by epriestley).

Remove the "ssh-auth-key" script

Oct 29 2019, 12:52 AM

epriestley closed D20873: Remove the "ssh-auth-key" script.

Oct 29 2019, 12:52 AM

epriestley requested review of D20874: Add an optional "--sshd-key" argument to "bin/ssh-auth" for reading "%k" from modern sshd.

Oct 29 2019, 12:50 AM

epriestley added a revision to T13436: Improve performance of "ssh-auth": D20874: Add an optional "--sshd-key" argument to "bin/ssh-auth" for reading "%k" from modern sshd.

Oct 29 2019, 12:49 AM · Diffusion, Phacility, Infrastructure

epriestley requested review of D20873: Remove the "ssh-auth-key" script.

Oct 29 2019, 12:39 AM

epriestley added a revision to T13436: Improve performance of "ssh-auth": D20873: Remove the "ssh-auth-key" script.

Oct 29 2019, 12:36 AM · Diffusion, Phacility, Infrastructure

epriestley added a comment to T13436: Improve performance of "ssh-auth".

I saw things hang during deploy and the OpenSSH bug should have been fixed years ago.

Oct 29 2019, 12:20 AM · Diffusion, Phacility, Infrastructure

epriestley added a comment to T13436: Improve performance of "ssh-auth".

I configured ControlMaster on secure.

Oct 29 2019, 12:14 AM · Diffusion, Phacility, Infrastructure

Oct 28 2019

epriestley triaged T13436: Improve performance of "ssh-auth" as Normal priority.

Oct 28 2019, 11:00 PM · Diffusion, Phacility, Infrastructure

epriestley committed rP5d8457a07ee3: In the repository URI index, store Phabricator's own URIs as tokens (authored by epriestley).

In the repository URI index, store Phabricator's own URIs as tokens

Oct 28 2019, 9:44 PM

epriestley closed T13435: When "phabricator.base-uri" changes, the repository "uriindex" table must be rebuilt as Resolved by committing rP5d8457a07ee3: In the repository URI index, store Phabricator's own URIs as tokens.

Oct 28 2019, 9:44 PM · Diffusion

epriestley closed D20872: In the repository URI index, store Phabricator's own URIs as tokens.

Oct 28 2019, 9:44 PM

epriestley requested review of D20872: In the repository URI index, store Phabricator's own URIs as tokens.

Oct 28 2019, 9:37 PM

epriestley added a revision to T13435: When "phabricator.base-uri" changes, the repository "uriindex" table must be rebuilt: D20872: In the repository URI index, store Phabricator's own URIs as tokens.

Oct 28 2019, 9:35 PM · Diffusion

epriestley committed rARC73943d1bc9d3: Make "arc land --merge" an explicit error when targeting a Perforce remote (authored by epriestley).

Make "arc land --merge" an explicit error when targeting a Perforce remote

Oct 28 2019, 6:59 PM

epriestley closed D20871: Make "arc land --merge" an explicit error when targeting a Perforce remote.

Oct 28 2019, 6:59 PM

epriestley requested review of D20871: Make "arc land --merge" an explicit error when targeting a Perforce remote.

Oct 28 2019, 6:52 PM

epriestley added a revision to T13434: Support Perforce/Git in "arc land": D20871: Make "arc land --merge" an explicit error when targeting a Perforce remote.

Oct 28 2019, 6:52 PM · Arcanist

epriestley added a comment to T13434: Support Perforce/Git in "arc land".

Under the --merge workflow (which does a --no-ff merge and always generates a merge commit; as opposed to the --squash strategy, which does a rebase-like squash merge) the git p4 submit --commit ... fails:

Oct 28 2019, 6:47 PM · Arcanist

epriestley committed rARC7383c2f4e6d2: In "arc land", when "remote/onto" does not exist locally, try to fetch it… (authored by epriestley).

In "arc land", when "remote/onto" does not exist locally, try to fetch it…

Oct 28 2019, 6:31 PM

epriestley closed D20870: In "arc land", when "remote/onto" does not exist locally, try to fetch it before giving up.

Oct 28 2019, 6:31 PM

epriestley closed T10650: `arc land` can raise misleading error message if a branch exists in the remote but has never been fetched as Resolved by committing rARC7383c2f4e6d2: In "arc land", when "remote/onto" does not exist locally, try to fetch it….

Oct 28 2019, 6:31 PM · Restricted Project, Arcanist

epriestley committed rARCa76054f8d66d: Update "arc help land" to reference Perforce support (authored by epriestley).

Update "arc help land" to reference Perforce support

Oct 28 2019, 6:25 PM

epriestley closed T12668: "arc help land" says "current branch", but means "branch targeted by the land operation" as Resolved by committing rARCa76054f8d66d: Update "arc help land" to reference Perforce support.