Page MenuHomePhabricator
Feed All Stories

Oct 28 2019

epriestley requested review of D20870: In "arc land", when "remote/onto" does not exist locally, try to fetch it before giving up.
Oct 28 2019, 6:21 PM
epriestley added a revision to T10650: `arc land` can raise misleading error message if a branch exists in the remote but has never been fetched: D20870: In "arc land", when "remote/onto" does not exist locally, try to fetch it before giving up.
Oct 28 2019, 6:20 PM · Restricted Project, Arcanist
epriestley requested review of D20869: Update "arc help land" to reference Perforce support.
Oct 28 2019, 6:04 PM
epriestley added a revision to T13434: Support Perforce/Git in "arc land": D20869: Update "arc help land" to reference Perforce support.
Oct 28 2019, 6:04 PM · Arcanist
epriestley added a revision to T12668: "arc help land" says "current branch", but means "branch targeted by the land operation": D20869: Update "arc help land" to reference Perforce support.
Oct 28 2019, 6:04 PM · Arcanist
epriestley claimed T12668: "arc help land" says "current branch", but means "branch targeted by the land operation".
Oct 28 2019, 6:01 PM · Arcanist
epriestley updated the diff for D20868: Support Perforce/Git repositories in "arc land".
  • Fix an issue with the non-dirty flow introduced when making the dirty flow work.
  • Ran "arc land" end-to-end in a normal topic branch workflow.
  • Ran "arc land" end-to-end in a normal topic branch workflow with a dirty target branch.
  • Ran "arc land" end-to-end in a no-topic-branch workflow.
Oct 28 2019, 5:52 PM
epriestley requested review of D20868: Support Perforce/Git repositories in "arc land".
Oct 28 2019, 5:40 PM
epriestley added a revision to T13434: Support Perforce/Git in "arc land": D20868: Support Perforce/Git repositories in "arc land".
Oct 28 2019, 5:40 PM · Arcanist
epriestley added a comment to T13434: Support Perforce/Git in "arc land".

I'm passing these additional flags to git p4 submit:

Oct 28 2019, 5:01 PM · Arcanist
epriestley added a comment to T13434: Support Perforce/Git in "arc land".

If you haven't logged in to Perforce recently (I think?), the sync can fail like this:

Oct 28 2019, 4:31 PM · Arcanist
epriestley updated the diff for D20867: Move Git-specific "arc land" parsing of "--onto" and "--remote" into GitLandEngine.
  • Fix "$this" references so the code actually runs.
  • Used "arc land" to land changes.
Oct 28 2019, 4:12 PM
epriestley requested review of D20867: Move Git-specific "arc land" parsing of "--onto" and "--remote" into GitLandEngine.
Oct 28 2019, 4:04 PM
epriestley added a revision to T13434: Support Perforce/Git in "arc land": D20867: Move Git-specific "arc land" parsing of "--onto" and "--remote" into GitLandEngine.
Oct 28 2019, 4:04 PM · Arcanist
epriestley edited the content of 2019 Week 43 (Late October).
Oct 28 2019, 3:10 PM
epriestley created an object: 2019 Week 43 (Late October).
Oct 28 2019, 3:09 PM
epriestley edited the content of Changelog.
Oct 28 2019, 2:52 PM
siepkes awarded T4348: Provide a workflow for "auditing a codebase" via Nuance or some new tool a Like token.
Oct 28 2019, 12:40 PM · Diffusion
leoluk added a comment to T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available.

Agreed that supporting YubiKey OTP is pointless - it's impractical and basically a dead legacy feature at this point. WebAuthn has emerged as the de-facto standard for hardware tokens.

Oct 28 2019, 11:36 AM · Haskell.org, Auth

Oct 26 2019

epriestley committed rPf5b3528a2670: (stable) Fix an issue where added or removed source files could incorrectly… (authored by epriestley).
(stable) Fix an issue where added or removed source files could incorrectly…
Oct 26 2019, 7:17 PM
epriestley committed rP292f8fc612bd: Fix an issue where added or removed source files could incorrectly select a… (authored by epriestley).
Fix an issue where added or removed source files could incorrectly select a…
Oct 26 2019, 7:17 PM
epriestley closed D20866: Fix an issue where added or removed source files could incorrectly select a DocumentEngine.
Oct 26 2019, 7:16 PM
epriestley requested review of D20866: Fix an issue where added or removed source files could incorrectly select a DocumentEngine.
Oct 26 2019, 7:11 PM
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20866: Fix an issue where added or removed source files could incorrectly select a DocumentEngine.
Oct 26 2019, 7:09 PM · Differential
epriestley added a comment to T13233: Consider supporting GPG/PGP.

I am running through GPG for the first time:

Oct 26 2019, 6:44 PM · Diffusion, Mail
Harbormaster failed to build B23569: rPa787b37db416: (stable) Promote 2019 Week 43 for rPa787b37db416: (stable) Promote 2019 Week 43!
Oct 26 2019, 3:39 PM
Harbormaster failed to build B23569: rPa787b37db416: (stable) Promote 2019 Week 43 for rPa787b37db416: (stable) Promote 2019 Week 43!
Oct 26 2019, 3:38 PM
epriestley committed rARC79ec6e44594f: (stable) Promote 2019 Week 43 (authored by epriestley).
(stable) Promote 2019 Week 43
Oct 26 2019, 3:34 PM
epriestley committed rPa787b37db416: (stable) Promote 2019 Week 43 (authored by epriestley).
(stable) Promote 2019 Week 43
Oct 26 2019, 3:34 PM
epriestley committed rP8ff0e3ab351f: Support rich diff rendering with DocumentEngine for added/removed files (authored by epriestley).
Support rich diff rendering with DocumentEngine for added/removed files
Oct 26 2019, 3:21 PM
epriestley closed D20865: Support rich diff rendering with DocumentEngine for added/removed files.
Oct 26 2019, 3:21 PM

Oct 25 2019

swisspol added a comment to T13434: Support Perforce/Git in "arc land".

This makes a lot of sense, thanks or the time to explain.

Oct 25 2019, 11:26 PM · Arcanist
leoluk awarded D20865: Support rich diff rendering with DocumentEngine for added/removed files a Love token.
Oct 25 2019, 9:37 PM
epriestley requested review of D20865: Support rich diff rendering with DocumentEngine for added/removed files.
Oct 25 2019, 6:49 PM
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: D20865: Support rich diff rendering with DocumentEngine for added/removed files.
Oct 25 2019, 6:47 PM · Differential
epriestley merged task T11362: Arcanist tries to land onto identical remote branch instead of 'master' into T11535: Make it possible for arc land to disable upstream branch tracking.
Oct 25 2019, 6:20 PM · Arcanist, Bug Report
epriestley merged T11362: Arcanist tries to land onto identical remote branch instead of 'master' into T11535: Make it possible for arc land to disable upstream branch tracking.
Oct 25 2019, 6:20 PM · Arcanist, Restricted Project
epriestley added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.

I'm going to merge this into T11535 since it's basically the same issue.

Oct 25 2019, 6:20 PM · Arcanist, Bug Report
epriestley renamed T10300: On branch "xyz", "arc land --onto xyz abc" does not result in update to "xyz" even when "xyz" is not ahead of the remote from Arcanist not always pulling landed branch to On branch "xyz", "arc land --onto xyz abc" does not result in update to "xyz" even when "xyz" is not ahead of the remote.
Oct 25 2019, 6:17 PM · Arcanist
epriestley closed T5964: When landing, it might be nice if arcanist could check if changes are being pushed to the canonical git repository as Wontfix.

This hasn't come up again, so it looks like it probably isn't a feature that would see a lot of general use.

Oct 25 2019, 6:12 PM · Arcanist
epriestley moved T5852: arc should ignore abandoned revisions when landing from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:06 PM · Restricted Project, Arcanist
epriestley moved T11535: Make it possible for arc land to disable upstream branch tracking from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:05 PM · Arcanist, Restricted Project
epriestley edited projects for T11535: Make it possible for arc land to disable upstream branch tracking, added: Arcanist; removed Feature Request.
Oct 25 2019, 6:05 PM · Arcanist, Restricted Project
epriestley moved T2493: Support `arc land` in stacked commits from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:04 PM · Restricted Project, Arcanist
epriestley moved T3875: Allow arc to perform cascading rebases, maybe during or after `arc land` from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:04 PM · Prioritized, Restricted Project, Arcanist
epriestley moved T5964: When landing, it might be nice if arcanist could check if changes are being pushed to the canonical git repository from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:04 PM · Arcanist
epriestley moved T10300: On branch "xyz", "arc land --onto xyz abc" does not result in update to "xyz" even when "xyz" is not ahead of the remote from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:03 PM · Arcanist
epriestley moved T10650: `arc land` can raise misleading error message if a branch exists in the remote but has never been fetched from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:03 PM · Restricted Project, Arcanist
epriestley moved T11362: Arcanist tries to land onto identical remote branch instead of 'master' from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:03 PM · Arcanist, Bug Report
epriestley moved T12668: "arc help land" says "current branch", but means "branch targeted by the land operation" from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:02 PM · Arcanist
epriestley moved T12876: Improve initial arc land experience when destination repo is empty from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:02 PM · Arcanist
epriestley moved T13434: Support Perforce/Git in "arc land" from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:02 PM · Arcanist
epriestley added a comment to T13434: Support Perforce/Git in "arc land".

Why not just implement the basic path for arc land and fail with an error if the user has some esoteric setup?

Oct 25 2019, 5:54 PM · Arcanist
swisspol added a comment to T13434: Support Perforce/Git in "arc land".

It's possible I'm misreading/misunderstanding this, so maybe the right algorithm is actually to select the "p4" remote ahead of the "origin" remote, i.e. swap steps (2) and (3).

Oct 25 2019, 5:17 PM · Arcanist
epriestley triaged T13435: When "phabricator.base-uri" changes, the repository "uriindex" table must be rebuilt as Low priority.
Oct 25 2019, 10:43 AM · Diffusion
epriestley added a comment to T13434: Support Perforce/Git in "arc land".

the config with the dépôt path to “fetch” latest changelists from is saved inside .git directory

Oct 25 2019, 10:26 AM · Arcanist
swisspol added a comment to T13434: Support Perforce/Git in "arc land".

You don’t need to pass any arguments to git p4 sync: the config with the dépôt path to “fetch” latest changelists from is saved inside .git directory. Did you follow the exact instructions I provided?

Oct 25 2019, 6:43 AM · Arcanist
epriestley added a comment to T13434: Support Perforce/Git in "arc land".

I got Git/Perforce working after a large amount of bashing my head into errors like these:

Oct 25 2019, 3:20 AM · Arcanist
epriestley triaged T13434: Support Perforce/Git in "arc land" as Low priority.
Oct 25 2019, 2:12 AM · Arcanist
epriestley committed rP38694578e1d0: Improve project member list behaviors related to disabled users (authored by epriestley).
Improve project member list behaviors related to disabled users
Oct 25 2019, 1:41 AM
epriestley closed D20864: Improve project member list behaviors related to disabled users.
Oct 25 2019, 1:41 AM
epriestley closed T13431: Make "Members" lists in projects more clear about disabled members as Resolved by committing rP38694578e1d0: Improve project member list behaviors related to disabled users.
Oct 25 2019, 1:41 AM · Projects
epriestley committed rP633aa5288c58: Persist login instructions onto flow-specific login pages (username/password… (authored by epriestley).
Persist login instructions onto flow-specific login pages (username/password…
Oct 25 2019, 1:38 AM
epriestley closed D20863: Persist login instructions onto flow-specific login pages (username/password and LDAP).
Oct 25 2019, 1:38 AM
epriestley closed T13433: Continue showing custom login instructions on provider-specific login screens as Resolved by committing rP633aa5288c58: Persist login instructions onto flow-specific login pages (username/password….
Oct 25 2019, 1:38 AM · Auth
epriestley requested review of D20864: Improve project member list behaviors related to disabled users.
Oct 25 2019, 1:37 AM
epriestley added a revision to T13431: Make "Members" lists in projects more clear about disabled members: D20864: Improve project member list behaviors related to disabled users.
Oct 25 2019, 1:35 AM · Projects
epriestley added a comment to D20863: Persist login instructions onto flow-specific login pages (username/password and LDAP).

Screen Shot 2019-10-24 at 6.09.30 PM.png (944×1 px, 164 KB)

Oct 25 2019, 1:09 AM
epriestley requested review of D20863: Persist login instructions onto flow-specific login pages (username/password and LDAP).
Oct 25 2019, 1:09 AM
epriestley added a revision to T13433: Continue showing custom login instructions on provider-specific login screens: D20863: Persist login instructions onto flow-specific login pages (username/password and LDAP).
Oct 25 2019, 1:07 AM · Auth
epriestley triaged T13433: Continue showing custom login instructions on provider-specific login screens as Low priority.
Oct 25 2019, 12:56 AM · Auth
epriestley committed rP5b36f0c97ac9: Add default branch, description, and metrics (commit count, recent commit) to… (authored by epriestley).
Add default branch, description, and metrics (commit count, recent commit) to…
Oct 25 2019, 12:17 AM
epriestley closed D20862: Add default branch, description, and metrics (commit count, recent commit) to "diffusion.repository.search".
Oct 25 2019, 12:17 AM
epriestley closed T13430: Provide more information in "diffusion.repository.search" (default branch, description, last push date) as Resolved by committing rP5b36f0c97ac9: Add default branch, description, and metrics (commit count, recent commit) to….
Oct 25 2019, 12:17 AM · Conduit, Diffusion

Oct 24 2019

epriestley requested review of D20862: Add default branch, description, and metrics (commit count, recent commit) to "diffusion.repository.search".
Oct 24 2019, 11:45 PM
epriestley added a revision to T13430: Provide more information in "diffusion.repository.search" (default branch, description, last push date): D20862: Add default branch, description, and metrics (commit count, recent commit) to "diffusion.repository.search".
Oct 24 2019, 11:44 PM · Conduit, Diffusion
epriestley added a comment to T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.

One change we can make here is to explicitly specify -c diff.suppressBlankEmpty false in the arc diff command, as we currently use --src-prefix and --dst-prefix to override diff.mnemonicprefix. This is likely desirable, but it would be good to also parse these diffs properly if they arrive through --raw or copy/pasting, etc.

Oct 24 2019, 11:02 PM · Differential
dennisv updated dennisv.
Oct 24 2019, 3:59 PM
Pawka awarded T1022: arc patch fails to properly apply a patch which changes a symlink to a real file a Like token.
Oct 24 2019, 5:48 AM · Arcanist
epriestley renamed T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly from Diffs that have had tailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly to Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.
Oct 24 2019, 2:43 AM · Differential
epriestley added a parent task for T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Oct 24 2019, 2:43 AM · Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.
Oct 24 2019, 2:43 AM · Arcanist, Differential
epriestley triaged T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly as Wishlist priority.
Oct 24 2019, 2:43 AM · Differential

Oct 22 2019

swisspol edited P2123 Masterwork From Distant Lands.
Oct 22 2019, 9:33 PM
epriestley triaged T13431: Make "Members" lists in projects more clear about disabled members as Low priority.
Oct 22 2019, 5:38 PM · Projects
artms added a task to D20855: Add index on dateCreated database field because it is used by Feed->Transactions functionality: T13416: Transaction logs may overheat explosively.
Oct 22 2019, 7:43 AM
artms added a revision to T13416: Transaction logs may overheat explosively: D20855: Add index on dateCreated database field because it is used by Feed->Transactions functionality.
Oct 22 2019, 7:43 AM · Feed

Oct 21 2019

artms requested review of D20861: Return empty data if fact dimension is missing, not yet available.
Oct 21 2019, 1:38 PM

Oct 18 2019

artms added a comment to T13427: Task to reproduce lack of transaction object validation.

Thanks!

Oct 18 2019, 6:35 AM · artms

Oct 17 2019

epriestley triaged T13430: Provide more information in "diffusion.repository.search" (default branch, description, last push date) as Low priority.
Oct 17 2019, 5:27 PM · Conduit, Diffusion
epriestley closed T13427: Task to reproduce lack of transaction object validation as Resolved.

This now renders properly; see T13429 for followup.

Oct 17 2019, 5:03 PM · artms
epriestley committed rPf497b93e4311: Fix a fatal in the "Projects" curtain extension when a project edge connects an… (authored by epriestley).
Fix a fatal in the "Projects" curtain extension when a project edge connects an…
Oct 17 2019, 4:49 PM
epriestley closed D20860: Fix a fatal in the "Projects" curtain extension when a project edge connects an object to a non-project.
Oct 17 2019, 4:49 PM
epriestley requested review of D20860: Fix a fatal in the "Projects" curtain extension when a project edge connects an object to a non-project.
Oct 17 2019, 4:45 PM
epriestley added a revision to T13429: Edge transactions are broadly non-modular and lack transaction hooks, including hooks for validation behavior: D20860: Fix a fatal in the "Projects" curtain extension when a project edge connects an object to a non-project.
Oct 17 2019, 4:43 PM · Transactions
epriestley triaged T13429: Edge transactions are broadly non-modular and lack transaction hooks, including hooks for validation behavior as Low priority.
Oct 17 2019, 4:34 PM · Transactions
epriestley committed rPd34dfa37461b: Fix an error message when calling "transaction.search" with a non-transactional… (authored by epriestley).
Fix an error message when calling "transaction.search" with a non-transactional…
Oct 17 2019, 4:20 PM
epriestley closed D20859: Fix an error message when calling "transaction.search" with a non-transactional object PHID as an "objectIdentifier".
Oct 17 2019, 4:20 PM
epriestley requested review of D20859: Fix an error message when calling "transaction.search" with a non-transactional object PHID as an "objectIdentifier".
Oct 17 2019, 4:18 PM
epriestley committed rP5dafabd5b4d0: Fix deprecated argument order for "implode()" (authored by epriestley).
Fix deprecated argument order for "implode()"
Oct 17 2019, 4:11 PM