Page MenuHomePhabricator
Feed All Stories

Sep 9 2019

epriestley added a comment to T8952: Hide "Herald added subscribers..." stories from feed completely.

0.00000000001 is very funny and we would be losing a truly great joke at such a young age

Sep 9 2019, 8:15 PM · Feed, Herald
epriestley added a revision to T8952: Hide "Herald added subscribers..." stories from feed completely: D20797: When Herald changes object subscribers, always hide the feed story.
Sep 9 2019, 8:14 PM · Feed, Herald
epriestley requested review of D20796: Add a "Remove flag" action to Herald.
Sep 9 2019, 8:03 PM
epriestley added a revision to T13409: Support a "Remove Flag" action in Herald: D20796: Add a "Remove flag" action to Herald.
Sep 9 2019, 8:02 PM · Herald
epriestley committed rPd965d9a669b5: Index Herald fields, not just actions, when identifying objects related to a… (authored by epriestley).
Index Herald fields, not just actions, when identifying objects related to a…
Sep 9 2019, 7:50 PM
epriestley closed D20795: Index Herald fields, not just actions, when identifying objects related to a particular Herald rule.
Sep 9 2019, 7:50 PM
epriestley closed T13408: Examine conditions, not just actions, when indexing Herald rules for links to other objects as Resolved by committing rPd965d9a669b5: Index Herald fields, not just actions, when identifying objects related to a….
Sep 9 2019, 7:50 PM · Herald
epriestley requested review of D20795: Index Herald fields, not just actions, when identifying objects related to a particular Herald rule.
Sep 9 2019, 7:45 PM
epriestley committed rPaaaea5759133: Fix fatal during redirection safety check for searching for Phabricator base… (authored by epriestley).
Fix fatal during redirection safety check for searching for Phabricator base…
Sep 9 2019, 7:45 PM
epriestley closed D20794: Fix fatal during redirection safety check for searching for Phabricator base-uri with no trailing slash.
Sep 9 2019, 7:45 PM
epriestley closed T13412: Searching for the install URI with no trailing slash fatals as Resolved by committing rPaaaea5759133: Fix fatal during redirection safety check for searching for Phabricator base….
Sep 9 2019, 7:45 PM · Search
epriestley added a revision to T13408: Examine conditions, not just actions, when indexing Herald rules for links to other objects: D20795: Index Herald fields, not just actions, when identifying objects related to a particular Herald rule.
Sep 9 2019, 7:44 PM · Herald
epriestley requested review of D20794: Fix fatal during redirection safety check for searching for Phabricator base-uri with no trailing slash.
Sep 9 2019, 7:31 PM
epriestley added a revision to T13412: Searching for the install URI with no trailing slash fatals: D20794: Fix fatal during redirection safety check for searching for Phabricator base-uri with no trailing slash.
Sep 9 2019, 7:30 PM · Search
epriestley committed rP278092974f2f: Don't offer personal saved queries in global "Search Scope" settings dropdown (authored by epriestley).
Don't offer personal saved queries in global "Search Scope" settings dropdown
Sep 9 2019, 7:21 PM
epriestley closed D20793: Don't offer personal saved queries in global "Search Scope" settings dropdown.
Sep 9 2019, 7:21 PM
epriestley closed T13405: Support customization of the default global search scope as Resolved by committing rP278092974f2f: Don't offer personal saved queries in global "Search Scope" settings dropdown.
Sep 9 2019, 7:21 PM · User Preferences
epriestley committed rPec931b93848f: (stable) Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the… (authored by epriestley).
(stable) Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the…
Sep 9 2019, 7:19 PM
epriestley committed rP63c7302af130: Fix global search scope fatal on 404 page (or other pages with no Application) (authored by epriestley).
Fix global search scope fatal on 404 page (or other pages with no Application)
Sep 9 2019, 7:18 PM
epriestley closed D20792: Fix global search scope fatal on 404 page (or other pages with no Application).
Sep 9 2019, 7:18 PM
epriestley requested review of D20793: Don't offer personal saved queries in global "Search Scope" settings dropdown.
Sep 9 2019, 7:18 PM
epriestley committed rP535c8e6bdc1e: Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the setup key… (authored by epriestley).
Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the setup key…
Sep 9 2019, 7:18 PM
epriestley closed D20791: Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the setup key for "STRICT_ALL_TABLES".
Sep 9 2019, 7:18 PM
epriestley committed rPf16365ed0778: Weaken the guidance recommending that installs enable "STRICT_ALL_TABLES" (authored by epriestley).
Weaken the guidance recommending that installs enable "STRICT_ALL_TABLES"
Sep 9 2019, 7:17 PM
epriestley closed D20790: Weaken the guidance recommending that installs enable "STRICT_ALL_TABLES".
Sep 9 2019, 7:17 PM
epriestley added a revision to T13405: Support customization of the default global search scope: D20793: Don't offer personal saved queries in global "Search Scope" settings dropdown.
Sep 9 2019, 7:16 PM · User Preferences
epriestley requested review of D20792: Fix global search scope fatal on 404 page (or other pages with no Application).
Sep 9 2019, 7:12 PM
epriestley added a revision to T13405: Support customization of the default global search scope: D20792: Fix global search scope fatal on 404 page (or other pages with no Application).
Sep 9 2019, 7:11 PM · User Preferences
epriestley triaged T13412: Searching for the install URI with no trailing slash fatals as Low priority.
Sep 9 2019, 5:10 PM · Search
epriestley moved T6802: "Custom policy" for editing/viewing does not link to details from Backlog to Next on the Policy board.
Sep 9 2019, 5:07 PM · Design, Policy
epriestley moved T8808: Policy menu should show actual project icon next to project from Backlog to Next on the Policy board.
Sep 9 2019, 5:07 PM · Policy
epriestley moved T13411: Improve "Custom Policy" behavior in policy dialogs from Backlog to Next on the Policy board.
Sep 9 2019, 5:06 PM · Policy
epriestley triaged T13411: Improve "Custom Policy" behavior in policy dialogs as Low priority.
Sep 9 2019, 5:06 PM · Policy
epriestley added a comment to T13410: Update Phriction UI structural behaviors.

Left Nav

Sep 9 2019, 4:56 PM · Phriction
epriestley updated the task description for T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 4:07 PM · Phriction
epriestley updated the task description for T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 4:02 PM · Phriction
epriestley updated the task description for T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 4:01 PM · Phriction
epriestley removed a subtask for T8552: Increase user control over document hierarchy in Phriction: T13011: Let community to fund features and bug fixes for increased priority and earlier delivery.
Sep 9 2019, 3:58 PM · Phriction, Restricted Project
epriestley removed a parent task for T13011: Let community to fund features and bug fixes for increased priority and earlier delivery: T8552: Increase user control over document hierarchy in Phriction.
Sep 9 2019, 3:58 PM · Feature Request, Fund
epriestley added a parent task for T8552: Increase user control over document hierarchy in Phriction: T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 3:58 PM · Phriction, Restricted Project
epriestley added a parent task for T4280: Embed anchor in remark up text and later link to it. : T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 3:58 PM · Remarkup
epriestley added subtasks for T13410: Update Phriction UI structural behaviors: T4280: Embed anchor in remark up text and later link to it. , T8552: Increase user control over document hierarchy in Phriction.
Sep 9 2019, 3:58 PM · Phriction
epriestley triaged T13410: Update Phriction UI structural behaviors as Normal priority.
Sep 9 2019, 3:57 PM · Phriction
epriestley added a comment to T13405: Support customization of the default global search scope.

There may also be no Application in contexts where we want to render a global search menu, notably the 404 page:

Sep 9 2019, 3:37 PM · User Preferences
epriestley triaged T13409: Support a "Remove Flag" action in Herald as Low priority.
Sep 9 2019, 2:35 PM · Herald
epriestley triaged T13408: Examine conditions, not just actions, when indexing Herald rules for links to other objects as Low priority.
Sep 9 2019, 2:33 PM · Herald
epriestley edited the content of Changelog.
Sep 9 2019, 12:04 AM
epriestley committed rPHU7736d42caf87: (stable) Promote 2019 Week 36 (authored by epriestley).
(stable) Promote 2019 Week 36
Sep 9 2019, 12:03 AM
epriestley committed rARC8b5fbb5a1346: (stable) Promote 2019 Week 36 (authored by epriestley).
(stable) Promote 2019 Week 36
Sep 9 2019, 12:03 AM
epriestley committed rP19af9d74f8c3: (stable) Promote 2019 Week 36 (authored by epriestley).
(stable) Promote 2019 Week 36
Sep 9 2019, 12:03 AM
epriestley created an object: 2019 Week 36 (Early September).
Sep 9 2019, 12:02 AM

Sep 8 2019

epriestley triaged T13407: If an S3 request returns with HTTP 404, error handling behavior is poor as Wishlist priority.
Sep 8 2019, 8:22 PM · Files
epriestley requested review of D20791: Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the setup key for "STRICT_ALL_TABLES".
Sep 8 2019, 8:04 PM
epriestley added a revision to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY: D20791: Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the setup key for "STRICT_ALL_TABLES".
Sep 8 2019, 8:02 PM · Database, Infrastructure
epriestley requested review of D20790: Weaken the guidance recommending that installs enable "STRICT_ALL_TABLES".
Sep 8 2019, 8:00 PM
epriestley added a revision to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY: D20790: Weaken the guidance recommending that installs enable "STRICT_ALL_TABLES".
Sep 8 2019, 7:59 PM · Database, Infrastructure
epriestley committed rPcaccbb69d20b: When users try to log out with no providers configured, warn them of the… (authored by epriestley).
When users try to log out with no providers configured, warn them of the…
Sep 8 2019, 7:27 PM
epriestley closed D20789: When users try to log out with no providers configured, warn them of the consequences.
Sep 8 2019, 7:27 PM
epriestley closed T13406: When a user with no authentication providers configured tries to log out, warn them as Resolved by committing rPcaccbb69d20b: When users try to log out with no providers configured, warn them of the….
Sep 8 2019, 7:27 PM · Setup
epriestley added a comment to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.

Vaguely adjacent:

Sep 8 2019, 7:27 PM · Database, Infrastructure
leoluk awarded T3967: Build a 2-up preview mode into the fullscreen Remarkup editor a Like token.
Sep 8 2019, 5:22 PM · Remarkup
epriestley requested review of D20789: When users try to log out with no providers configured, warn them of the consequences.
Sep 8 2019, 4:50 PM
epriestley added a revision to T13406: When a user with no authentication providers configured tries to log out, warn them: D20789: When users try to log out with no providers configured, warn them of the consequences.
Sep 8 2019, 4:48 PM · Setup
epriestley triaged T13406: When a user with no authentication providers configured tries to log out, warn them as Wishlist priority.
Sep 8 2019, 4:27 PM · Setup
epriestley updated the task description for T12910: Allow SES to be used for inbound mail.
Sep 8 2019, 2:58 PM · Mail
avivey committed rP318e8ebdac95: Allow bin/config to create config file (authored by avivey).
Allow bin/config to create config file
Sep 8 2019, 12:16 AM
avivey closed D20788: Allow bin/config to create config file.
Sep 8 2019, 12:16 AM

Sep 7 2019

epriestley accepted D20788: Allow bin/config to create config file.

Oops -- I think this is a reasonable fix, thanks!

Sep 7 2019, 11:01 PM
avivey added a comment to D20788: Allow bin/config to create config file.

assertWritable checks that the file exists and writable. There's assertWritableFile, but it's private, and it's being called anyway from setKeys.
This might be hiding some other strange conditions, but I couldn't think of any that don't end up just making the file un-writeable.

Sep 7 2019, 7:20 PM
avivey requested review of D20788: Allow bin/config to create config file.
Sep 7 2019, 7:19 PM
swisspol added a comment to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.

Now that we are on RDS I can confirm that MySQL also has ONLY_FULL_GROUP_BY enabled by default.

Sep 7 2019, 1:55 AM · Database, Infrastructure

Sep 6 2019

epriestley reopened T13405: Support customization of the default global search scope as "Open".

I think I missed one case here: the global preference will currently show custom personal queries for the viewing user, but selecting these queries won't work (at least, not completely) for other users. Instead, the control should offer only hard-coded options and global queries.

Sep 6 2019, 5:54 PM · User Preferences
epriestley committed rP7e2bec92807d: Add a global setting for controlling the default main menu search scope (authored by epriestley).
Add a global setting for controlling the default main menu search scope
Sep 6 2019, 3:39 PM
epriestley closed D20787: Add a global setting for controlling the default main menu search scope.
Sep 6 2019, 3:39 PM
epriestley closed T13405: Support customization of the default global search scope as Resolved by committing rP7e2bec92807d: Add a global setting for controlling the default main menu search scope.
Sep 6 2019, 3:39 PM · User Preferences
epriestley requested review of D20787: Add a global setting for controlling the default main menu search scope.
Sep 6 2019, 3:26 PM
epriestley added a revision to T13405: Support customization of the default global search scope: D20787: Add a global setting for controlling the default main menu search scope.
Sep 6 2019, 3:25 PM · User Preferences
epriestley triaged T13405: Support customization of the default global search scope as Low priority.
Sep 6 2019, 3:21 PM · User Preferences
leoluk awarded D20786: When running "arc land" from a detached HEAD, don't try to delete the source ref a Party Time token.
Sep 6 2019, 8:42 AM

Sep 5 2019

epriestley added a comment to T13394: Evaluate Okta OAuth.

But did you check your spam folder? 😄

Sep 5 2019, 11:10 PM · Auth
swisspol added a comment to T13394: Evaluate Okta OAuth.

But did you check your spam folder? 😄

Sep 5 2019, 10:54 PM · Auth
epriestley added a comment to T13394: Evaluate Okta OAuth.

I attempted to register for a developer account and am receiving neither an email verification email nor a password reset email. 🤷

Sep 5 2019, 9:44 PM · Auth
epriestley committed rARC3cdfe1fff806: When running "arc land" from a detached HEAD, don't try to delete the source ref (authored by epriestley).
When running "arc land" from a detached HEAD, don't try to delete the source ref
Sep 5 2019, 12:31 PM
epriestley closed T10321: Running "arc land" without a branch checked out sort of works but fails when trying to delete the branch as Resolved by committing rARC3cdfe1fff806: When running "arc land" from a detached HEAD, don't try to delete the source ref.
Sep 5 2019, 12:31 PM · Bug Report
epriestley closed D20786: When running "arc land" from a detached HEAD, don't try to delete the source ref.
Sep 5 2019, 12:31 PM
epriestley requested review of D20786: When running "arc land" from a detached HEAD, don't try to delete the source ref.
Sep 5 2019, 12:25 PM
epriestley added a revision to T10321: Running "arc land" without a branch checked out sort of works but fails when trying to delete the branch: D20786: When running "arc land" from a detached HEAD, don't try to delete the source ref.
Sep 5 2019, 12:25 PM · Bug Report
epriestley added a comment to T10321: Running "arc land" without a branch checked out sort of works but fails when trying to delete the branch.

See also https://discourse.phabricator-community.org/t/arc-land-fails-with-detached-head/3078/.

Sep 5 2019, 12:19 PM · Bug Report
epriestley committed rPadc2002d2870: Make it easier to parse "X-Forwarded-For" with one or more load balancers (authored by epriestley).
Make it easier to parse "X-Forwarded-For" with one or more load balancers
Sep 5 2019, 11:30 AM
epriestley closed D20785: Make it easier to parse "X-Forwarded-For" with one or more load balancers.
Sep 5 2019, 11:30 AM
epriestley closed T13392: Current implementations of "X-Forwarded-For" may take the wrong element as Resolved by committing rPadc2002d2870: Make it easier to parse "X-Forwarded-For" with one or more load balancers.
Sep 5 2019, 11:30 AM · Infrastructure
epriestley requested review of D20785: Make it easier to parse "X-Forwarded-For" with one or more load balancers.
Sep 5 2019, 11:28 AM
epriestley added a revision to T13392: Current implementations of "X-Forwarded-For" may take the wrong element: D20785: Make it easier to parse "X-Forwarded-For" with one or more load balancers.
Sep 5 2019, 11:26 AM · Infrastructure
epriestley added a comment to T13392: Current implementations of "X-Forwarded-For" may take the wrong element.

Our behavior appears to be correct when the load balancer is an AWS ELB.

Sep 5 2019, 9:57 AM · Infrastructure

Sep 4 2019

epriestley committed rP764db4869cb0: Make "bin/storage destroy" target individual hosts in database cluster mode (authored by epriestley).
Make "bin/storage destroy" target individual hosts in database cluster mode
Sep 4 2019, 5:11 PM
epriestley closed D20784: Make "bin/storage destroy" target individual hosts in database cluster mode.
Sep 4 2019, 5:11 PM
epriestley requested review of D20784: Make "bin/storage destroy" target individual hosts in database cluster mode.
Sep 4 2019, 5:10 PM
epriestley added a revision to T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE: D20784: Make "bin/storage destroy" target individual hosts in database cluster mode.
Sep 4 2019, 5:08 PM · Infrastructure
Krinkle awarded T13279: Build Charting for Facts a Orange Medal token.
Sep 4 2019, 4:04 PM · Plans, Facts
Harbormaster failed to build B23383: rP0c3f59fd688a: (stable) Update a straggling "getAuthorities()" call in Fund for rP0c3f59fd688a: (stable) Update a straggling "getAuthorities()" call in Fund!
Sep 4 2019, 3:11 PM