Page MenuHomePhabricator
Feed All Stories

Fri, Sep 6

epriestley reopened T13405: Support customization of the default global search scope as "Open".

I think I missed one case here: the global preference will currently show custom personal queries for the viewing user, but selecting these queries won't work (at least, not completely) for other users. Instead, the control should offer only hard-coded options and global queries.

Fri, Sep 6, 5:54 PMUser Preferences
epriestley committed rP7e2bec92807d: Add a global setting for controlling the default main menu search scope (authored by epriestley).
Add a global setting for controlling the default main menu search scope
Fri, Sep 6, 3:39 PM
epriestley closed D20787: Add a global setting for controlling the default main menu search scope.
Fri, Sep 6, 3:39 PM
epriestley closed T13405: Support customization of the default global search scope as Resolved by committing rP7e2bec92807d: Add a global setting for controlling the default main menu search scope.
Fri, Sep 6, 3:39 PMUser Preferences
epriestley requested review of D20787: Add a global setting for controlling the default main menu search scope.
Fri, Sep 6, 3:26 PM
epriestley added a revision to T13405: Support customization of the default global search scope: D20787: Add a global setting for controlling the default main menu search scope.
Fri, Sep 6, 3:25 PMUser Preferences
epriestley triaged T13405: Support customization of the default global search scope as Low priority.
Fri, Sep 6, 3:21 PMUser Preferences
leoluk awarded D20786: When running "arc land" from a detached HEAD, don't try to delete the source ref a Party Time token.
Fri, Sep 6, 8:42 AM

Thu, Sep 5

epriestley added a comment to T13394: Evaluate Okta OAuth.

But did you check your spam folder? 馃槃

Thu, Sep 5, 11:10 PMAuth
swisspol added a comment to T13394: Evaluate Okta OAuth.

But did you check your spam folder? 馃槃

Thu, Sep 5, 10:54 PMAuth
epriestley added a comment to T13394: Evaluate Okta OAuth.

I attempted to register for a developer account and am receiving neither an email verification email nor a password reset email. 馃し

Thu, Sep 5, 9:44 PMAuth
epriestley committed rARC3cdfe1fff806: When running "arc land" from a detached HEAD, don't try to delete the source ref (authored by epriestley).
When running "arc land" from a detached HEAD, don't try to delete the source ref
Thu, Sep 5, 12:31 PM
epriestley closed T10321: Running "arc land" without a branch checked out sort of works but fails when trying to delete the branch as Resolved by committing rARC3cdfe1fff806: When running "arc land" from a detached HEAD, don't try to delete the source ref.
Thu, Sep 5, 12:31 PMBug Report
epriestley closed D20786: When running "arc land" from a detached HEAD, don't try to delete the source ref.
Thu, Sep 5, 12:31 PM
epriestley requested review of D20786: When running "arc land" from a detached HEAD, don't try to delete the source ref.
Thu, Sep 5, 12:25 PM
epriestley added a revision to T10321: Running "arc land" without a branch checked out sort of works but fails when trying to delete the branch: D20786: When running "arc land" from a detached HEAD, don't try to delete the source ref.
Thu, Sep 5, 12:25 PMBug Report
epriestley added a comment to T10321: Running "arc land" without a branch checked out sort of works but fails when trying to delete the branch.

See also https://discourse.phabricator-community.org/t/arc-land-fails-with-detached-head/3078/.

Thu, Sep 5, 12:19 PMBug Report
epriestley committed rPadc2002d2870: Make it easier to parse "X-Forwarded-For" with one or more load balancers (authored by epriestley).
Make it easier to parse "X-Forwarded-For" with one or more load balancers
Thu, Sep 5, 11:30 AM
epriestley closed D20785: Make it easier to parse "X-Forwarded-For" with one or more load balancers.
Thu, Sep 5, 11:30 AM
epriestley closed T13392: Current implementations of "X-Forwarded-For" may take the wrong element as Resolved by committing rPadc2002d2870: Make it easier to parse "X-Forwarded-For" with one or more load balancers.
Thu, Sep 5, 11:30 AMInfrastructure
epriestley requested review of D20785: Make it easier to parse "X-Forwarded-For" with one or more load balancers.
Thu, Sep 5, 11:28 AM
epriestley added a revision to T13392: Current implementations of "X-Forwarded-For" may take the wrong element: D20785: Make it easier to parse "X-Forwarded-For" with one or more load balancers.
Thu, Sep 5, 11:26 AMInfrastructure
epriestley added a comment to T13392: Current implementations of "X-Forwarded-For" may take the wrong element.

Our behavior appears to be correct when the load balancer is an AWS ELB.

Thu, Sep 5, 9:57 AMInfrastructure

Wed, Sep 4

epriestley committed rP764db4869cb0: Make "bin/storage destroy" target individual hosts in database cluster mode (authored by epriestley).
Make "bin/storage destroy" target individual hosts in database cluster mode
Wed, Sep 4, 5:11 PM
epriestley closed D20784: Make "bin/storage destroy" target individual hosts in database cluster mode.
Wed, Sep 4, 5:11 PM
epriestley requested review of D20784: Make "bin/storage destroy" target individual hosts in database cluster mode.
Wed, Sep 4, 5:10 PM
epriestley added a revision to T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE: D20784: Make "bin/storage destroy" target individual hosts in database cluster mode.
Wed, Sep 4, 5:08 PMInfrastructure
Krinkle awarded T13279: Build Charting for Facts a Orange Medal token.
Wed, Sep 4, 4:04 PMPlans, Facts
Harbormaster failed to build B23383: rP0c3f59fd688a: (stable) Update a straggling "getAuthorities()" call in Fund for rP0c3f59fd688a: (stable) Update a straggling "getAuthorities()" call in Fund!
Wed, Sep 4, 3:11 PM
Harbormaster failed to build B23383: rP0c3f59fd688a: (stable) Update a straggling "getAuthorities()" call in Fund for rP0c3f59fd688a: (stable) Update a straggling "getAuthorities()" call in Fund!
Wed, Sep 4, 2:52 PM
Harbormaster failed to build B23383: rP0c3f59fd688a: (stable) Update a straggling "getAuthorities()" call in Fund for rP0c3f59fd688a: (stable) Update a straggling "getAuthorities()" call in Fund!
Wed, Sep 4, 2:17 PM
epriestley committed rP0c3f59fd688a: (stable) Update a straggling "getAuthorities()" call in Fund (authored by epriestley).
(stable) Update a straggling "getAuthorities()" call in Fund
Wed, Sep 4, 2:17 PM
epriestley committed rPf7290bbbf220: Update a straggling "getAuthorities()" call in Fund (authored by epriestley).
Update a straggling "getAuthorities()" call in Fund
Wed, Sep 4, 2:15 PM
epriestley closed D20783: Update a straggling "getAuthorities()" call in Fund.
Wed, Sep 4, 2:15 PM
epriestley requested review of D20783: Update a straggling "getAuthorities()" call in Fund.
Wed, Sep 4, 2:12 PM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20783: Update a straggling "getAuthorities()" call in Fund.
Wed, Sep 4, 2:11 PMPhortune, Phacility
swisspol added a comment to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.

That actually using MySQL official Docker image.

Wed, Sep 4, 3:12 AMDatabase, Infrastructure

Tue, Sep 3

epriestley added a comment to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.

There are only 23 occurrences of the string "GROUP BY" in the codebase, and, from inspection, many obviously do not conflict with ONLY_FULL_GROUP_BY.

Tue, Sep 3, 11:54 PMDatabase, Infrastructure
epriestley committed rP22b075df9716: Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries (authored by epriestley).
Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries
Tue, Sep 3, 11:50 PM
epriestley closed D20782: Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries.
Tue, Sep 3, 11:50 PM
epriestley requested review of D20782: Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries.
Tue, Sep 3, 11:44 PM
epriestley added a revision to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY: D20782: Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries.
Tue, Sep 3, 11:43 PMDatabase, Infrastructure
epriestley triaged T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY as Wishlist priority.
Tue, Sep 3, 11:23 PMDatabase, Infrastructure
epriestley closed T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues as Resolved.
Tue, Sep 3, 7:54 PMDatabase, Config
epriestley committed rPe0d6994adb1c: Use the "@" operator to silence connection retry messages if initializing the鈥 (authored by epriestley).
Use the "@" operator to silence connection retry messages if initializing the鈥
Tue, Sep 3, 7:54 PM
epriestley closed D20781: Use the "@" operator to silence connection retry messages if initializing the stack with database config optional.
Tue, Sep 3, 7:54 PM
epriestley committed rPf8eec38c9419: When "mysqli->real_connect()" fails without setting an error code, recover more鈥 (authored by epriestley).
When "mysqli->real_connect()" fails without setting an error code, recover more鈥
Tue, Sep 3, 7:51 PM
epriestley closed D20780: When "mysqli->real_connect()" fails without setting an error code, recover more gracefully.
Tue, Sep 3, 7:51 PM
epriestley committed rPd9badba14786: Give "bin/config" a friendlier error message if "local.json" is not writable (authored by epriestley).
Give "bin/config" a friendlier error message if "local.json" is not writable
Tue, Sep 3, 7:47 PM
epriestley closed D20779: Give "bin/config" a friendlier error message if "local.json" is not writable.
Tue, Sep 3, 7:47 PM
epriestley added a comment to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover.

Also remaining is to extend this behavior to the HTTP pathway (and to Mercurial/SVN, eventually).

Tue, Sep 3, 7:35 PMClusters, Diffusion
epriestley committed rP8ff3a133c4d7: Generalize repository proxy retry logic to writes (authored by epriestley).
Generalize repository proxy retry logic to writes
Tue, Sep 3, 7:34 PM
epriestley closed D20778: Generalize repository proxy retry logic to writes.
Tue, Sep 3, 7:34 PM
epriestley requested review of D20781: Use the "@" operator to silence connection retry messages if initializing the stack with database config optional.
Tue, Sep 3, 7:28 PM
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: D20781: Use the "@" operator to silence connection retry messages if initializing the stack with database config optional.
Tue, Sep 3, 7:26 PMDatabase, Config
epriestley requested review of D20780: When "mysqli->real_connect()" fails without setting an error code, recover more gracefully.
Tue, Sep 3, 7:25 PM
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: D20780: When "mysqli->real_connect()" fails without setting an error code, recover more gracefully.
Tue, Sep 3, 7:23 PMDatabase, Config
epriestley requested review of D20779: Give "bin/config" a friendlier error message if "local.json" is not writable.
Tue, Sep 3, 7:22 PM
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: D20779: Give "bin/config" a friendlier error message if "local.json" is not writable.
Tue, Sep 3, 7:19 PMDatabase, Config
epriestley triaged T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues as Low priority.
Tue, Sep 3, 7:05 PMDatabase, Config
epriestley requested review of D20778: Generalize repository proxy retry logic to writes.
Tue, Sep 3, 6:39 PM
epriestley added a revision to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover: D20778: Generalize repository proxy retry logic to writes.
Tue, Sep 3, 6:37 PMClusters, Diffusion
epriestley added a comment to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover.
  • if we have already retried 3 times, do not retry;
Tue, Sep 3, 6:07 PMClusters, Diffusion
epriestley committed rPff3d1769b475: Instead of retrying safe reads 3 times, retry each eligible service once (authored by epriestley).
Instead of retrying safe reads 3 times, retry each eligible service once
Tue, Sep 3, 5:43 PM
epriestley closed D20777: Instead of retrying safe reads 3 times, retry each eligible service once.
Tue, Sep 3, 5:43 PM
epriestley requested review of D20777: Instead of retrying safe reads 3 times, retry each eligible service once.
Tue, Sep 3, 5:43 PM
epriestley added a revision to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover: D20777: Instead of retrying safe reads 3 times, retry each eligible service once.
Tue, Sep 3, 5:41 PMClusters, Diffusion
epriestley committed rP95fb237ab393: On Git cluster read failure, retry safe requests (authored by epriestley).
On Git cluster read failure, retry safe requests
Tue, Sep 3, 5:08 PM
epriestley closed D20776: On Git cluster read failure, retry safe requests.
Tue, Sep 3, 5:08 PM
epriestley committed rPb6420e0f0ad8: Allow repository service lookups to return an ordered list of service refs (authored by epriestley).
Allow repository service lookups to return an ordered list of service refs
Tue, Sep 3, 5:05 PM
epriestley closed D20775: Allow repository service lookups to return an ordered list of service refs.
Tue, Sep 3, 5:05 PM
epriestley requested review of D20776: On Git cluster read failure, retry safe requests.
Tue, Sep 3, 4:53 PM
epriestley added a revision to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover: D20776: On Git cluster read failure, retry safe requests.
Tue, Sep 3, 4:50 PMClusters, Diffusion
epriestley added a comment to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover.

we'll reduce silly client-visible behavior where you request /tourtle.git instead of /turtle.git and the server seems confused...

Tue, Sep 3, 4:32 PMClusters, Diffusion
epriestley requested review of D20775: Allow repository service lookups to return an ordered list of service refs.
Tue, Sep 3, 4:00 PM
epriestley added a revision to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover: D20775: Allow repository service lookups to return an ordered list of service refs.
Tue, Sep 3, 3:58 PMClusters, Diffusion

Mon, Sep 2

epriestley created T13402: Owner audit flag got flipped in update?.
Mon, Sep 2, 3:06 PMAudit
epriestley added a comment to T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases.

See also https://discourse.phabricator-community.org/t/diffusion-search-how-to-do-case-insensitive-search/2854/.

Mon, Sep 2, 3:04 PMDiffusion, Conduit
epriestley closed T13393: Improve repository shard migration pathway in the shared cluster as Resolved.

The migration in PHI1403 seems to have gone through cleanly. This workflow can continue to improve, but it's in relatively good shape now.

Mon, Sep 2, 3:02 PMPhacility, Infrastructure
epriestley committed rP9316cbf7fd27: Move web application classes into "phabricator/" (authored by epriestley).
Move web application classes into "phabricator/"
Mon, Sep 2, 2:59 PM
epriestley closed D20774: Move web application classes into "phabricator/".
Mon, Sep 2, 2:59 PM
epriestley committed rPHUf51f1b3f72b5: Remove "Web Application Only" classes from libphutil (authored by epriestley).
Remove "Web Application Only" classes from libphutil
Mon, Sep 2, 2:59 PM
epriestley closed D20773: Remove "Web Application Only" classes from libphutil.
Mon, Sep 2, 2:59 PM
epriestley requested review of D20774: Move web application classes into "phabricator/".
Mon, Sep 2, 2:22 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20774: Move web application classes into "phabricator/".
Mon, Sep 2, 2:20 PMlibphutil
epriestley requested review of D20773: Remove "Web Application Only" classes from libphutil.
Mon, Sep 2, 1:43 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20773: Remove "Web Application Only" classes from libphutil.
Mon, Sep 2, 1:43 PMlibphutil
epriestley lowered the priority of T13396: Support downloads of 2GB+ files with HTTPSFuture from Normal to Wishlist.
Mon, Sep 2, 1:11 PMInfrastructure, libphutil
epriestley added a comment to T13397: "bin/host upload" and the Uploader wrapper should retry chunks on HTTP/504, and perhaps other status codes.

A generally cleaner version of this would also fix the parallelization TODO (just above the patch in the previous comment). This probably needs FutureIterator to be better at managing in-flight changes to the working set.

Mon, Sep 2, 1:11 PMInfrastructure, Arcanist
epriestley closed T13401: Phacility 2019 Week 35 Deployment Log as Resolved.

Everything here appears to have made it to production cleanly.

Mon, Sep 2, 1:07 PMPhacility
epriestley updated the task description for T13401: Phacility 2019 Week 35 Deployment Log.
Mon, Sep 2, 1:05 PMPhacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Mon, Sep 2, 1:04 PMPhortune, Phacility
epriestley added a revision to T13401: Phacility 2019 Week 35 Deployment Log: Unknown Object (Differential Revision).
Mon, Sep 2, 1:04 PMPhacility
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Mon, Sep 2, 12:57 PMPhacility, Infrastructure

Sun, Sep 1

epriestley added a comment to T13400: Evaluate performance impact of performing MySQL dump/restore in parallel.

Anecdata: locally, using 2 subprocesses went twice as fast (~85s -> ~42s). 4 subprocesses chopped another ~20% of the time off (~42s > ~35s). It stopped getting faster at 4. However, the largest table took 24s, so even if this was completely parallelizable we wouldn't expect it to drop lower than that.

Sun, Sep 1, 11:19 PMInfrastructure, Database
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Restricted Differential Revision.
Sun, Sep 1, 8:12 PMPhacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sun, Sep 1, 8:08 PMPhacility, Infrastructure
epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.

Anecdotally from the last time around, gzipping the tarball didn't really do much. Possibly, this might more broadly imply that we'd be better off not compressing repository backups.

Sun, Sep 1, 7:26 PMPhacility, Infrastructure
epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.

I believe I've moved "core/" from "instances.queryinstances" and sequenced all the followup changes properly, now, and that the only remaining piece is glue.

Sun, Sep 1, 5:48 PMPhacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Restricted Differential Revision.
Sun, Sep 1, 5:31 PMPhacility, Infrastructure