I think I missed one case here: the global preference will currently show custom personal queries for the viewing user, but selecting these queries won't work (at least, not completely) for other users. Instead, the control should offer only hard-coded options and global queries.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Sep 6 2019
Sep 6 2019
epriestley committed rP7e2bec92807d: Add a global setting for controlling the default main menu search scope (authored by epriestley).
Add a global setting for controlling the default main menu search scope
epriestley triaged T13405: Support customization of the default global search scope as Low priority.
leoluk awarded D20786: When running "arc land" from a detached HEAD, don't try to delete the source ref a Party Time token.
Sep 5 2019
Sep 5 2019
But did you check your spam folder? 😄
But did you check your spam folder? 😄
I attempted to register for a developer account and am receiving neither an email verification email nor a password reset email. 🤷
epriestley committed rARC3cdfe1fff806: When running "arc land" from a detached HEAD, don't try to delete the source ref (authored by epriestley).
When running "arc land" from a detached HEAD, don't try to delete the source ref
epriestley committed rPadc2002d2870: Make it easier to parse "X-Forwarded-For" with one or more load balancers (authored by epriestley).
Make it easier to parse "X-Forwarded-For" with one or more load balancers
epriestley added a comment to T13392: Current implementations of "X-Forwarded-For" may take the wrong element.
Our behavior appears to be correct when the load balancer is an AWS ELB.
Sep 4 2019
Sep 4 2019
epriestley committed rP764db4869cb0: Make "bin/storage destroy" target individual hosts in database cluster mode (authored by epriestley).
Make "bin/storage destroy" target individual hosts in database cluster mode
Krinkle awarded T13279: Build Charting for Facts a Orange Medal token.
epriestley committed rP0c3f59fd688a: (stable) Update a straggling "getAuthorities()" call in Fund (authored by epriestley).
(stable) Update a straggling "getAuthorities()" call in Fund
epriestley committed rPf7290bbbf220: Update a straggling "getAuthorities()" call in Fund (authored by epriestley).
Update a straggling "getAuthorities()" call in Fund
That actually using MySQL official Docker image.
Sep 3 2019
Sep 3 2019
There are only 23 occurrences of the string "GROUP BY" in the codebase, and, from inspection, many obviously do not conflict with ONLY_FULL_GROUP_BY.
epriestley committed rP22b075df9716: Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries (authored by epriestley).
Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries
epriestley triaged T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY as Wishlist priority.
epriestley committed rPe0d6994adb1c: Use the "@" operator to silence connection retry messages if initializing the… (authored by epriestley).
Use the "@" operator to silence connection retry messages if initializing the…
epriestley committed rPf8eec38c9419: When "mysqli->real_connect()" fails without setting an error code, recover more… (authored by epriestley).
When "mysqli->real_connect()" fails without setting an error code, recover more…
epriestley committed rPd9badba14786: Give "bin/config" a friendlier error message if "local.json" is not writable (authored by epriestley).
Give "bin/config" a friendlier error message if "local.json" is not writable
epriestley added a comment to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover.
Also remaining is to extend this behavior to the HTTP pathway (and to Mercurial/SVN, eventually).
epriestley committed rP8ff3a133c4d7: Generalize repository proxy retry logic to writes (authored by epriestley).
Generalize repository proxy retry logic to writes
epriestley added a comment to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover.
- if we have already retried 3 times, do not retry;
epriestley committed rPff3d1769b475: Instead of retrying safe reads 3 times, retry each eligible service once (authored by epriestley).
Instead of retrying safe reads 3 times, retry each eligible service once
epriestley committed rP95fb237ab393: On Git cluster read failure, retry safe requests (authored by epriestley).
On Git cluster read failure, retry safe requests
epriestley committed rPb6420e0f0ad8: Allow repository service lookups to return an ordered list of service refs (authored by epriestley).
Allow repository service lookups to return an ordered list of service refs
epriestley added a comment to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover.
we'll reduce silly client-visible behavior where you request /tourtle.git instead of /turtle.git and the server seems confused...
Sep 2 2019
Sep 2 2019
epriestley closed T13393: Improve repository shard migration pathway in the shared cluster as Resolved.
The migration in PHI1403 seems to have gone through cleanly. This workflow can continue to improve, but it's in relatively good shape now.
epriestley committed rP9316cbf7fd27: Move web application classes into "phabricator/" (authored by epriestley).
Move web application classes into "phabricator/"
epriestley committed rPHUf51f1b3f72b5: Remove "Web Application Only" classes from libphutil (authored by epriestley).
Remove "Web Application Only" classes from libphutil
epriestley lowered the priority of T13396: Support downloads of 2GB+ files with HTTPSFuture from Normal to Wishlist.
epriestley added a comment to T13397: "bin/host upload" and the Uploader wrapper should retry chunks on HTTP/504, and perhaps other status codes.
A generally cleaner version of this would also fix the parallelization TODO (just above the patch in the previous comment). This probably needs FutureIterator to be better at managing in-flight changes to the working set.
Everything here appears to have made it to production cleanly.
epriestley added a revision to T13401: Phacility 2019 Week 35 Deployment Log: Unknown Object (Differential Revision).
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sep 1 2019
Sep 1 2019
epriestley added a comment to T13400: Evaluate performance impact of performing MySQL dump/restore in parallel.
Anecdata: locally, using 2 subprocesses went twice as fast (~85s -> ~42s). 4 subprocesses chopped another ~20% of the time off (~42s > ~35s). It stopped getting faster at 4. However, the largest table took 24s, so even if this was completely parallelizable we wouldn't expect it to drop lower than that.
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Restricted Differential Revision.
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.
Anecdotally from the last time around, gzipping the tarball didn't really do much. Possibly, this might more broadly imply that we'd be better off not compressing repository backups.
epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.
I believe I've moved "core/" from "instances.queryinstances" and sequenced all the followup changes properly, now, and that the only remaining piece is glue.
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Restricted Differential Revision.