cd provides "at least once" delivery guarantees.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jun 26 2019
Jun 26 2019
amckinley added a comment to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.
Jun 25 2019
Jun 25 2019
D20620: When matching process titles, don't attempt a match if we're out of "argv" parts is now accepted and ready to land.
epriestley committed rPHU71666e588072: Make "PhutilProcessQuery" detection of overseer processes more robust (authored by epriestley).
Make "PhutilProcessQuery" detection of overseer processes more robust
epriestley committed rP2d2626d73f0b: (stable) Bump the remarkup cache version after JIRA/Asana rule changes (authored by epriestley).
(stable) Bump the remarkup cache version after JIRA/Asana rule changes
epriestley committed rP987e10461056: Bump the remarkup cache version after JIRA/Asana rule changes (authored by epriestley).
Bump the remarkup cache version after JIRA/Asana rule changes
epriestley added a comment to D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.
Yeah, I suppose most of my skepticism comes from not knowing any other examples of long-loved processes parsing ps output instead of using PID files.
D20619: Bump the remarkup cache version after JIRA/Asana rule changes is now accepted and ready to land.
amckinley added a comment to D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.
Oh, and this might be useful, but is probably less portable than just using ps.
D20616: Make "PhutilProcessQuery" detection of overseer processes more robust is now accepted and ready to land.
In D20616#260712, @epriestley wrote:
- The disk can be full, or read-only. Or become full later, including while the daemon is running.
- Any of these policy/disk state problems can pass any effort we make to test them early, then fail after the process daemonizes, making it difficult to report the failure to the user.
epriestley requested review of D20619: Bump the remarkup cache version after JIRA/Asana rule changes.
epriestley added a comment to D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.
- Fix typo.
- Fix out-of-date comment/logic around overseer tests.
epriestley added a comment to D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.
This whole series of changes is motivated by "a PID file was out of date because of a reboot, and we tried to kill some other random process", right? Was there anything else that PID file tracking wasn't doing correctly?
amckinley added a comment to D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.
This whole series of changes is motivated by "a PID file was out of date because of a reboot, and we tried to kill some other random process", right? Was there anything else that PID file tracking wasn't doing correctly?
epriestley added a revision to T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts: Unknown Object (Differential Revision).
epriestley added a comment to T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts.
This incantation seems to work as an upstart job:
epriestley added a comment to T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts.
I'm going to install an upstart task on secure004 and kick it a few times, some stuff might be sketchy until I figure that out.
epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Support multiple request encodings (likely BSON, protobuf, or messagepack). Leave JSON as the default, but in cases where messages can not be represented in JSON this gives us a plausible way forward.
epriestley added a comment to T13328: Database dumps can buffer (?) too much data to hold in memory.
The stalled production backup process completed successfully after deploying the change.
epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".
See also PHI1318. The new behavior here has tightened our rules about which users we act as.
epriestley committed rPccf207f20928: (stable) Limit the read buffer size in `bin/storage dump` (authored by epriestley).
(stable) Limit the read buffer size in `bin/storage dump`
epriestley added a comment to T13328: Database dumps can buffer (?) too much data to hold in memory.
I'm going to try to sneak this out to the db tier to resolve things before the west coast wakes up, at least.
epriestley committed rPeaa60334ec16: Limit the read buffer size in `bin/storage dump` (authored by epriestley).
Limit the read buffer size in `bin/storage dump`
D20617: Limit the read buffer size in `bin/storage dump` is now accepted and ready to land.
epriestley added a comment to T13328: Database dumps can buffer (?) too much data to hold in memory.
PHP Fatal error: Out of memory (allocated 311164928) (tried to allocate 105988097 bytes) in /core/lib/libphutil/src/future/exec/ExecFuture.php on line 246
epriestley requested review of D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.
Jun 24 2019
Jun 24 2019
epriestley committed rPd1704f04d331: (stable) Consider "all account members are disabled" to be a permanent failure… (authored by epriestley).
(stable) Consider "all account members are disabled" to be a permanent failure…
epriestley committed rPccfc74702f67: (stable) Make "bin/files" parsing of working set arguments more consistent (authored by epriestley).
(stable) Make "bin/files" parsing of working set arguments more consistent
epriestley committed rPda0dfc057d64: Make "bin/files" parsing of working set arguments more consistent (authored by epriestley).
Make "bin/files" parsing of working set arguments more consistent
D20614: Make "bin/files" parsing of working set arguments more consistent is now accepted and ready to land.
epriestley committed rPa3397fb87613: Consider "all account members are disabled" to be a permanent failure when… (authored by epriestley).
Consider "all account members are disabled" to be a permanent failure when…
D20613: Consider "all account members are disabled" to be a permanent failure when billing a Phortune subscription is now accepted and ready to land.
epriestley requested review of D20614: Make "bin/files" parsing of working set arguments more consistent.
epriestley committed rP65bc481c91de: Remove "phd.pid-directory" configuration and stop passing "piddir" to daemons (authored by epriestley).
Remove "phd.pid-directory" configuration and stop passing "piddir" to daemons
Stop writing PID files in daemons
epriestley committed rP2498e373b955: Make "phd start" and "phd reload" use the process list, not PID files (authored by epriestley).
Make "phd start" and "phd reload" use the process list, not PID files
epriestley committed rP08b9e70bea5c: Make "bin/phd status" report local daemons from the process list, not a mess of… (authored by epriestley).
Make "bin/phd status" report local daemons from the process list, not a mess of…
epriestley committed rPHUac8e57402236: Remove "PhutilDaemonOverseer->findRunningDaemons()" (authored by epriestley).
Remove "PhutilDaemonOverseer->findRunningDaemons()"
epriestley committed rPb99c240aa374: Deprecate "bin/phd ... --gently" and update documentation (authored by epriestley).
Deprecate "bin/phd ... --gently" and update documentation
epriestley committed rPd98bf8ef8ee6: Drive "phd stop" entirely from the process list, not PID files on disk (authored by epriestley).
Drive "phd stop" entirely from the process list, not PID files on disk
epriestley added a comment to D20601: Drive "phd stop" entirely from the process list, not PID files on disk.
- Rebase to clear tests.
Harbormaster failed remote builds in B23039: Diff 49165 for D20601: Drive "phd stop" entirely from the process list, not PID files on disk!
epriestley added a comment to D20601: Drive "phd stop" entirely from the process list, not PID files on disk.
- Wordsmithing: "any instance" -> "all instances"
epriestley committed rPHUb6505e98bfbc: Formalize a "Query" class for looking at the process list (authored by epriestley).
Formalize a "Query" class for looking at the process list
epriestley committed rPHUb9f35642c4e0: Parse remarkup tables with something like a real parser instead of regular… (authored by epriestley).
Parse remarkup tables with something like a real parser instead of regular…
epriestley committed rP09ecf49ee454: (stable) Require commit identities when editing commits to resolve an issue… (authored by epriestley).
(stable) Require commit identities when editing commits to resolve an issue…
epriestley committed rP75c359835903: Require commit identities when editing commits to resolve an issue with audit… (authored by epriestley).
Require commit identities when editing commits to resolve an issue with audit…
D20612: Require commit identities when editing commits to resolve an issue with audit actions not applying properly is now accepted and ready to land.
Jun 22 2019
Jun 22 2019
epriestley added a comment to T13306: Provide a mechanism for importing local disk file backups into the Phacility cluster.
See one followup in T13326. The "import from disk" part seems to have worked properly in production.
epriestley committed rPHUb675a06bf741: (stable) Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort… (authored by epriestley).
(stable) Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort…
epriestley committed rPHUf5879cc6a9dc: Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function (authored by epriestley).
Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function
Herald added 1 auditor(s) for rARCdb4cd55d4673: Merge branch "master" into "experimental".: Cowboy Commits.
Merge branch "master" into "experimental".
(stable) Promote 2019 Week 25
(stable) Promote 2019 Week 25
(stable) Promote 2019 Week 25
Jun 21 2019
Jun 21 2019
20after4 awarded T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion a Mountain of Wealth token.
20after4 added a comment to D20539: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference source files in Diffusion.
I've been wishing for this literally forever. If I could award more mountains of wealth tokens, I most certainly would!
20after4 awarded D20539: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference source files in Diffusion a Mountain of Wealth token.
epriestley committed rPca56e8590a3d: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way… (authored by epriestley).
Don't handle JIRA/Asana URIs with anchors or query parameters in a special way…
epriestley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).
I'm just going to land this as-is pending feedback on actual use cases, anticipating a followup to do parameter/anchor support if some reasonable #comment-123 URI exists in either external system. Then it will at least be easy for us to link-and-preserve-parameters or decline-to-link and we can figure out whatever else arises on a case-by-case basis.