Page MenuHomePhabricator
Feed All Stories

May 30 2019

epriestley created T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.
May 30 2019, 7:09 PM · Transactions
epriestley added a comment to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.

This likely affects other similar dialogs. The fix is to duct-tape something in Quicksand to something in the "click an area to click a link" behavior, most likely.

May 30 2019, 7:07 PM · Quicksand
epriestley added a comment to D20561: Add a "View Task" button to HTML mail from Maniphest.

Oh, sure, that's pretty reasonable.

May 30 2019, 7:07 PM
D20561: Add a "View Task" button to HTML mail from Maniphest is now accepted and ready to land.

Shouldn't DifferentialTransactionEditor->buildMailBody() get an update to use this new API?

May 30 2019, 7:06 PM
epriestley created T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.
May 30 2019, 7:05 PM · Quicksand
D20560: Clean up "phabricator.timezone" configuration instructions a little bit is now accepted and ready to land.
May 30 2019, 7:03 PM
epriestley updated the summary of D20559: Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles")..
May 30 2019, 7:03 PM
D20559: Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles"). is now accepted and ready to land.

¯\_(ツ)_/¯

May 30 2019, 7:00 PM
amckinley updated the test plan for D20559: Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles")..
May 30 2019, 7:00 PM
asherkin added a comment to T13296: PCRE segfaults after "fork()" on PHP 7.3+ on MacOS with "pcre.jit" enabled.

The changelog for PHP 7.3.6 mentions "Fixed possible crashes, because of inconsistent PCRE cache and opcache SHM reset." which might be relevant, but no bug link so who knows.

May 30 2019, 6:52 PM · Infrastructure
epriestley requested review of D20561: Add a "View Task" button to HTML mail from Maniphest.
May 30 2019, 5:16 PM
epriestley created T13301: Browser "Find..." feature isn't very useful in Safari on Workboards.
May 30 2019, 3:29 PM · Workboards
epriestley updated the summary of D20559: Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles")..
May 30 2019, 3:20 PM
epriestley added a comment to D20560: Clean up "phabricator.timezone" configuration instructions a little bit.

May 30 2019, 3:19 PM
epriestley requested review of D20560: Clean up "phabricator.timezone" configuration instructions a little bit.
May 30 2019, 3:18 PM
epriestley requested review of D20559: Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles")..
May 30 2019, 3:09 PM

May 28 2019

epriestley edited the content of Changelog.
May 28 2019, 5:29 PM
epriestley committed rPHU0d206344cfd3: (stable) Promote 2019 Week 21 (authored by epriestley).
(stable) Promote 2019 Week 21
May 28 2019, 5:28 PM
Herald added 1 auditor(s) for rARCbbbd1502f078: (stable) Promote 2019 Week 21: Cowboy Commits.
(stable) Promote 2019 Week 21
May 28 2019, 5:28 PM
Herald added 1 auditor(s) for rPd9b41d3a0f87: (stable) Promote 2019 Week 21: Cowboy Commits.
(stable) Promote 2019 Week 21
May 28 2019, 5:27 PM
epriestley created an object: 2019 Week 21 (Very Late May).
May 28 2019, 5:27 PM
epriestley triaged T13300: When a "Draft" revision is closed into "Published" (not "Abandoned"), it should immediately promote as Low priority.
May 28 2019, 5:22 PM · Diffusion, Differential
epriestley created T13300: When a "Draft" revision is closed into "Published" (not "Abandoned"), it should immediately promote.
May 28 2019, 5:22 PM · Diffusion, Differential
amckinley awarded D20558: Test for "CAN_INTERACT" on comment edits in a way that survives objects which only implement "CAN_VIEW" a Manufacturing Defect? token.
May 28 2019, 5:20 PM
epriestley committed rP53b9acfb7d58: Test for "CAN_INTERACT" on comment edits in a way that survives objects which… (authored by epriestley).
Test for "CAN_INTERACT" on comment edits in a way that survives objects which…
May 28 2019, 5:14 PM
epriestley added a revision to T13289: Plans: 2019 Week 21-23 Bonus Content: D20558: Test for "CAN_INTERACT" on comment edits in a way that survives objects which only implement "CAN_VIEW".
May 28 2019, 5:14 PM · Plans

May 27 2019

epriestley committed rPHU86ee6e90797c: If "vi" or "vim" exit with an error code, test for error-on-interactive-mistake… (authored by epriestley).
If "vi" or "vim" exit with an error code, test for error-on-interactive-mistake…
May 27 2019, 11:49 PM
epriestley closed D20556: If "vi" or "vim" exit with an error code, test for error-on-interactive-mistake behavior.
May 27 2019, 11:49 PM
joshuaspence added a comment to D20557: Allow linter to be passed into `ArcanistLinterTestCase::executeTestsInDirectory`.

This is the last of my linter improvement diffs for a while.

May 27 2019, 9:57 PM
joshuaspence requested review of D20557: Allow linter to be passed into `ArcanistLinterTestCase::executeTestsInDirectory`.
May 27 2019, 9:51 PM
epriestley moved T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive from Far Future to Next on the Herald board.
May 27 2019, 3:36 PM · Diffusion, Herald
epriestley added a comment to T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive.

A sort of broad issue here is that Herald sometimes knows (or could know, or could guess, or maybe could speculate) that a rule won't do what you expect, but it doesn't tell you.

May 27 2019, 3:36 PM · Diffusion, Herald
epriestley triaged T13299: Herald only triggers for commits once, during the initial publish phase as Normal priority.
May 27 2019, 3:34 PM · Diffusion, Herald
epriestley closed T13283: When Herald acts, include the transaction group as part of the "state" it acts upon as Resolved.

I think this is about as good as we're going to get, and we've only taken a very small step toward the precipice of a self-aware Herald that hates humankind.

May 27 2019, 2:56 PM · Herald
epriestley triaged T13298: Improve Herald profiling information available in transcripts as Normal priority.
May 27 2019, 2:54 PM · Herald
epriestley closed T12257: Add an "author email" field to the "Differential Diff" Herald rule as Wontfix.

KDE appears to be moving to GitLab (see: https://gitlab.com/gitlab-org/gitlab-ce/issues/53206) and we haven't seen this request from other installs, so I'm just going to close this out.

May 27 2019, 2:38 PM · KDE, Herald, Differential
epriestley closed T8804: Replacing a Herald rule with a Doorkeeper extension as Wontfix.

I think the modern answer here is "use Webhooks". They may not do everything you want if you're writing a chat bot (notably, they intentionally do not currently provide a human-readable text representation of transactions) but there generally suitable for publishing changes to Phabricator objects into a remote system and will produce a program with generally reasonable behaviors and no weird demons lurking under the surface.

May 27 2019, 2:30 PM · Restricted Project, Herald, Doorkeeper

May 26 2019

joshuaspence added inline comments to D20555: Add a hook method that is called before `ArcanistLinter::getLinterConfigurationOptions`.
May 26 2019, 10:19 PM

May 25 2019

amckinley accepted D20556: If "vi" or "vim" exit with an error code, test for error-on-interactive-mistake behavior.
May 25 2019, 3:41 PM

May 24 2019

epriestley added a comment to T13297: "vi" and "vim" may exit with errors even though edits succeed.

Here's a more concise test:

May 24 2019, 9:10 PM · Arcanist
avivey awarded D20556: If "vi" or "vim" exit with an error code, test for error-on-interactive-mistake behavior a Baby Tequila token.
May 24 2019, 9:04 PM
avivey added a comment to T13297: "vi" and "vim" may exit with errors even though edits succeed.

Running the thing on my ubuntu exists with 0...

$ vi --version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Apr 10 2018 21:31:58)
Included patches: 1-1453
.....
.....
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H   -Wdate-time  -g -O2 -fdebug-prefix-map=/build/vim-NQEcoP/vim-8.0.1453=. -fstack-protector-strong -Wformat -Werror=format-security -DTINY_VIMRC -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o vim    -lSM -lICE -lXpm -lXt -lX11 -lXdmcp -lSM -lICE  -lm -ltinfo  -lselinux -lacl -lattr -ldl
May 24 2019, 9:04 PM · Arcanist
epriestley requested review of D20556: If "vi" or "vim" exit with an error code, test for error-on-interactive-mistake behavior.
May 24 2019, 8:35 PM
epriestley triaged T13297: "vi" and "vim" may exit with errors even though edits succeed as Low priority.
May 24 2019, 8:15 PM · Arcanist
trevorsummerssmith awarded T6004: When moving a wiki page with subpages prompt to also move subpages a Like token.
May 24 2019, 1:54 PM · Phriction
thuffir added a comment to T4752: Daemons may not have permission to remove files from local disk storage engine.

setfacl -Rdm u:phab-phd:rw /var/local/phabricator/filestore
setfacl -Rm u:phab-phd:rw /var/local/phabricator/filestore

May 24 2019, 9:21 AM · Files
joshuaspence requested review of D20555: Add a hook method that is called before `ArcanistLinter::getLinterConfigurationOptions`.
May 24 2019, 4:45 AM
epriestley committed rPce6fc5be9092: Fix a looping workflow when trying to submit a partially-effectless transaction… (authored by epriestley).
Fix a looping workflow when trying to submit a partially-effectless transaction…
May 24 2019, 2:16 AM
epriestley closed D20552: Fix a looping workflow when trying to submit a partially-effectless transaction group.
May 24 2019, 2:16 AM
epriestley committed rP719dd6d3f442: Remove the "search_documentfield" table (authored by epriestley).
Remove the "search_documentfield" table
May 24 2019, 2:11 AM
epriestley closed D20549: Remove the "search_documentfield" table.
May 24 2019, 2:11 AM
epriestley committed rPaacc62463d61: Prevent editing and deleting comments in locked conversations (authored by epriestley).
Prevent editing and deleting comments in locked conversations
May 24 2019, 2:05 AM
epriestley closed D20551: Prevent editing and deleting comments in locked conversations.
May 24 2019, 2:05 AM
epriestley committed rPf838ad182753: Fix two straggling pagination issues in Drydock (authored by epriestley).
Fix two straggling pagination issues in Drydock
May 24 2019, 1:50 AM
epriestley closed D20553: Fix two straggling pagination issues in Drydock.
May 24 2019, 1:50 AM
epriestley committed rPHU1422024de70d: Disable PHP config option "pcre.jit" to work around PCRE segfault after "fork()" (authored by epriestley).
Disable PHP config option "pcre.jit" to work around PCRE segfault after "fork()"
May 24 2019, 1:39 AM
epriestley closed D20554: Disable PHP config option "pcre.jit" to work around PCRE segfault after "fork()".
May 24 2019, 1:39 AM
joshuaspence updated the diff for D20523: Add a hook method that is called after `ArcanistLinter::setEngine`.

Rebase

May 24 2019, 12:22 AM

May 23 2019

amckinley accepted D20554: Disable PHP config option "pcre.jit" to work around PCRE segfault after "fork()".
May 23 2019, 11:58 PM
epriestley lowered the priority of T13296: PCRE segfaults after "fork()" on PHP 7.3+ on MacOS with "pcre.jit" enabled from Normal to Low.
May 23 2019, 11:54 PM · Infrastructure
epriestley added a comment to T13296: PCRE segfaults after "fork()" on PHP 7.3+ on MacOS with "pcre.jit" enabled.

I built my PHP from source in T13232 so this is presumably not a Homebrew issue.

May 23 2019, 11:49 PM · Infrastructure
epriestley updated the task description for T13296: PCRE segfaults after "fork()" on PHP 7.3+ on MacOS with "pcre.jit" enabled.
May 23 2019, 11:42 PM · Infrastructure
epriestley requested review of D20554: Disable PHP config option "pcre.jit" to work around PCRE segfault after "fork()".
May 23 2019, 11:36 PM
epriestley added a revision to T13296: PCRE segfaults after "fork()" on PHP 7.3+ on MacOS with "pcre.jit" enabled: D20554: Disable PHP config option "pcre.jit" to work around PCRE segfault after "fork()".
May 23 2019, 11:36 PM · Infrastructure
epriestley triaged T13296: PCRE segfaults after "fork()" on PHP 7.3+ on MacOS with "pcre.jit" enabled as Normal priority.
May 23 2019, 11:29 PM · Infrastructure
joshuaspence updated the diff for D20526: Make it easier to parse external linter versions.

Minor

May 23 2019, 10:20 PM
joshuaspence updated the summary of D20526: Make it easier to parse external linter versions.
May 23 2019, 10:10 PM
amckinley accepted D20551: Prevent editing and deleting comments in locked conversations.
May 23 2019, 8:16 PM
amckinley accepted D20552: Fix a looping workflow when trying to submit a partially-effectless transaction group.
May 23 2019, 8:11 PM
amckinley accepted D20553: Fix two straggling pagination issues in Drydock.
May 23 2019, 8:10 PM
epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
May 23 2019, 7:03 PM · Plans
epriestley requested review of D20553: Fix two straggling pagination issues in Drydock.
May 23 2019, 6:56 PM
epriestley added a revision to T13289: Plans: 2019 Week 21-23 Bonus Content: D20553: Fix two straggling pagination issues in Drydock.
May 23 2019, 6:55 PM · Plans
epriestley requested review of D20552: Fix a looping workflow when trying to submit a partially-effectless transaction group.
May 23 2019, 6:46 PM
epriestley added a revision to T13289: Plans: 2019 Week 21-23 Bonus Content: D20552: Fix a looping workflow when trying to submit a partially-effectless transaction group.
May 23 2019, 6:45 PM · Plans
epriestley triaged T13295: Clean up magic / passthrough request parameters as Low priority.
May 23 2019, 6:34 PM · Transactions
epriestley requested review of D20551: Prevent editing and deleting comments in locked conversations.
May 23 2019, 6:03 PM
epriestley added a revision to T13289: Plans: 2019 Week 21-23 Bonus Content: D20551: Prevent editing and deleting comments in locked conversations.
May 23 2019, 6:02 PM · Plans
epriestley planned changes to D20550: Remove misleading reference to "search_documentfield" in documentation.

I'll just hold on to it for now in case something weird comes up, not a big deal if this doesn't land at the earliest possible moment.

May 23 2019, 5:57 PM
amckinley added a comment to D20550: Remove misleading reference to "search_documentfield" in documentation.

This looks good, except as you said, we can't land it until after we remove conpherence_index as well. Should I just approve it now and let it hang around in your unlanded revisions?

May 23 2019, 5:28 PM
epriestley added a comment to D20549: Remove the "search_documentfield" table.

Yeah, the end goal is to get those two MyISAM lines out of quickstart.sql. This gets one of 'em but is probably less than half the work. 🙈

May 23 2019, 5:26 PM
amckinley added a comment to D20549: Remove the "search_documentfield" table.

If we're trying to drop the MyISAM dependency, don't forget to update the quickstart when we're finished: https://secure.phabricator.com/source/phabricator/browse/master/resources/sql/quickstart.sql$9727

May 23 2019, 5:25 PM
amckinley accepted D20549: Remove the "search_documentfield" table.
May 23 2019, 5:18 PM
epriestley requested review of D20550: Remove misleading reference to "search_documentfield" in documentation.
May 23 2019, 5:01 PM
epriestley added a revision to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): D20550: Remove misleading reference to "search_documentfield" in documentation.
May 23 2019, 5:00 PM
epriestley requested review of D20549: Remove the "search_documentfield" table.
May 23 2019, 4:56 PM
epriestley added a revision to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): D20549: Remove the "search_documentfield" table.
May 23 2019, 4:55 PM
epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
May 23 2019, 4:42 PM · Plans
epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
May 23 2019, 4:11 PM · Plans
epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
May 23 2019, 3:51 PM · Plans
epriestley moved T6276: Cannot Create Named Link to URI with Brackets from Parser to Next on the Remarkup board.
May 23 2019, 2:49 PM · Remarkup
epriestley moved T12191: Remarkup autocomplete can remain open after keyboard form submission from Backlog to Next on the Remarkup board.
May 23 2019, 2:48 PM · Remarkup, PHUI
epriestley removed a project from T10667: Improve ambiguity when resolving commits that appear in multiple repositories: Remarkup.
May 23 2019, 2:48 PM · Diffusion (v3)
epriestley moved T7967: impossible to link string that contain ']' with remarkup syntax. from Backlog to Next on the Remarkup board.
May 23 2019, 2:47 PM · Remarkup
epriestley edited projects for T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster, added: Phacility; removed Customer Impact, Remarkup, Feature Request.
May 23 2019, 2:46 PM · Phacility
epriestley moved T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained from Backlog to Next on the Remarkup board.
May 23 2019, 2:46 PM · Documentation, Remarkup
epriestley moved T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion from Backlog to Next on the Remarkup board.
May 23 2019, 2:45 PM · Remarkup, Diffusion
epriestley edited projects for T9825: Remarkup is rendered literally in Diviner, added: Diviner; removed Remarkup.
May 23 2019, 2:45 PM · Diviner
epriestley removed a project from T12973: Commit list changes based on hash in URL: Remarkup.
May 23 2019, 2:44 PM · Diffusion
asherkin added a comment to D19681: Fix arc land on odd/modern git-svn checkouts.

Thanks for the review - I dropped in a comment referencing the task when committing so it's clear why this is here when the refactoring comes along 🙂

May 23 2019, 10:01 AM