There's no specific performance/scale issue here, so waiting until one arises or this pops up on a profile.
Apr 15 2019
Apr 14 2019
- Slightly smaller/more accurate change: this does not affect "Push" rules, which still act on every commit.
Okay. I'm not crazy, I'm just really bad at reading.
Examining "master" (branch) at "02f94cd7d2885de502d03934af3a0c24453e8e58" (autoclose: Y). Skipping, HEAD is known. Examining "stable" (branch) at "d3df0a49f92a8be2f5b8a030af2f8fa5471cc45d" (autoclose: Y). Skipping, HEAD is known. Examining "refs/pull/846/merge" (ref) at "d816dc011f935fdda9468c905e4af4c7fc73b322" (autoclose: N). Skipping, HEAD is known. Examining "refs/pull/839/head" (ref) at "d3df0a49f92a8be2f5b8a030af2f8fa5471cc45d" (autoclose: N). Skipping, HEAD is known. Examining "refs/pull/846/head" (ref) at "1263f335abfc5bcf7b5e2c60ae0632b4660815d8" (autoclose: N). Skipping, HEAD is known. < ... > < ... many many non-branch refs properly identified as non-autoclosing ... > < ... > Examining "refs/pull/4/head" (ref) at "e282a7707da11e3e2bca2b3a41925aeefd4f22c9" (autoclose: N). Skipping, HEAD is known.
Only branches can be "Autoclose".
Apr 13 2019
Apr 12 2019
- Let's move forward with this after all: although we need some more work to fix the "Default XYZ Policy" stuff, this is the best path forward for PHI1204 (which requests that build plan behaviors have configurable defaults).
This (and other changes in this series) require a reindex, but I'm planning to probably let migrations run a bin/search index --type ... via the Worker queue so this happens automatically a little later on, since all the stuff we need to reindex (panels, herald rules, dashboards, portals) should only take a minute or two to reindex.
The edge no longer does anything, and was always redundant with the actual panel layout information.