Page MenuHomePhabricator
Feed All Stories

Mon, Apr 15

epriestley moved T13109: Improve cluster write feedback and write routing from Backlog to Clusters on the Diffusion board.
Mon, Apr 15, 3:33 PM · Diffusion
epriestley moved T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs" from Backlog to "Track Only" on the Diffusion board.
Mon, Apr 15, 3:30 PM · Plans, Diffusion
epriestley closed T12749: Performance test and tune DiffusionHistoryListView, a subtask of T12824: Redesign Diffusion, as Wontfix.
Mon, Apr 15, 3:30 PM · Design, Diffusion
epriestley closed T12749: Performance test and tune DiffusionHistoryListView as Wontfix.

There's no specific performance/scale issue here, so waiting until one arises or this pops up on a profile.

Mon, Apr 15, 3:30 PM · Performance, Diffusion
epriestley moved T13211: Improve intracluster synchronization routing from Backlog to Clusters on the Diffusion board.
Mon, Apr 15, 2:45 PM · Clusters, Diffusion
epriestley requested review of D20426: Expose repository ref rules via "diffusion.repository.search".
Mon, Apr 15, 1:59 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20426: Expose repository ref rules via "diffusion.repository.search".
Mon, Apr 15, 1:57 PM · Plans, Diffusion
epriestley requested review of D20425: Move the repository "Publishing" option to the "Basics" panel in repository management.
Mon, Apr 15, 1:31 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20425: Move the repository "Publishing" option to the "Basics" panel in repository management.
Mon, Apr 15, 1:29 PM · Plans, Diffusion
Krenair updated Krenair.
Mon, Apr 15, 1:22 AM

Sun, Apr 14

epriestley requested review of D20424: In repository settings, fold "Autoclose On/Off" into "Publishing On/Off".
Sun, Apr 14, 8:52 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20424: In repository settings, fold "Autoclose On/Off" into "Publishing On/Off".
Sun, Apr 14, 8:50 PM · Plans, Diffusion
epriestley requested review of D20423: Rename most user-facing "Autoclose" strings to "Permanent Refs".
Sun, Apr 14, 8:50 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20423: Rename most user-facing "Autoclose" strings to "Permanent Refs".
Sun, Apr 14, 8:27 PM · Plans, Diffusion
epriestley requested review of D20422: Add "Fetch Rules" to observed Git repositories.
Sun, Apr 14, 8:15 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20422: Add "Fetch Rules" to observed Git repositories.
Sun, Apr 14, 8:14 PM · Plans, Diffusion
epriestley requested review of D20421: When observing a repository in Git, just "fetch <url>" without worrying about the "origin" remote.
Sun, Apr 14, 7:26 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20421: When observing a repository in Git, just "fetch <url>" without worrying about the "origin" remote.
Sun, Apr 14, 7:24 PM · Plans, Diffusion
epriestley requested review of D20420: Accept pushes with arbitrary Git refs.
Sun, Apr 14, 6:58 PM
epriestley updated the task description for T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".
Sun, Apr 14, 6:58 PM · Plans, Diffusion
epriestley added a revision to T8936: Unable to identify the reftype of 'refs/remotes/origin/master'. Rejecting push.: D20420: Accept pushes with arbitrary Git refs.
Sun, Apr 14, 6:57 PM · Diffusion
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20420: Accept pushes with arbitrary Git refs.
Sun, Apr 14, 6:57 PM · Plans, Diffusion
epriestley updated the diff for D20419: Do not publish/notify about commits which are not reachable from any "Autoclose" ref.
  • Slightly smaller/more accurate change: this does not affect "Push" rules, which still act on every commit.
Sun, Apr 14, 6:48 PM
epriestley closed T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs as Resolved.

See D20419 and T13277.

Sun, Apr 14, 6:46 PM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
epriestley requested review of D20419: Do not publish/notify about commits which are not reachable from any "Autoclose" ref.
Sun, Apr 14, 6:40 PM
epriestley added a revision to T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs: D20419: Do not publish/notify about commits which are not reachable from any "Autoclose" ref.
Sun, Apr 14, 6:39 PM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20419: Do not publish/notify about commits which are not reachable from any "Autoclose" ref.
Sun, Apr 14, 6:39 PM · Plans, Diffusion
epriestley retitled D20418: Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories from Use repository identities, not denoralized strings, to identify authors for "Revision closed by commit X" stories to Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories.
Sun, Apr 14, 6:38 PM
epriestley updated the task description for T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".
Sun, Apr 14, 6:29 PM · Plans, Diffusion
epriestley updated the task description for T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".
Sun, Apr 14, 6:29 PM · Plans, Diffusion
epriestley added a comment to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

Okay. I'm not crazy, I'm just really bad at reading.

Sun, Apr 14, 6:08 PM · Plans, Diffusion
epriestley added a comment to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".
Examining "master" (branch) at "02f94cd7d2885de502d03934af3a0c24453e8e58" (autoclose: Y).
Skipping, HEAD is known.
Examining "stable" (branch) at "d3df0a49f92a8be2f5b8a030af2f8fa5471cc45d" (autoclose: Y).
Skipping, HEAD is known.
Examining "refs/pull/846/merge" (ref) at "d816dc011f935fdda9468c905e4af4c7fc73b322" (autoclose: N).
Skipping, HEAD is known.
Examining "refs/pull/839/head" (ref) at "d3df0a49f92a8be2f5b8a030af2f8fa5471cc45d" (autoclose: N).
Skipping, HEAD is known.
Examining "refs/pull/846/head" (ref) at "1263f335abfc5bcf7b5e2c60ae0632b4660815d8" (autoclose: N).
Skipping, HEAD is known.
< ... >
< ... many many non-branch refs properly identified as non-autoclosing ... >
< ... >
Examining "refs/pull/4/head" (ref) at "e282a7707da11e3e2bca2b3a41925aeefd4f22c9" (autoclose: N).
Skipping, HEAD is known.
Sun, Apr 14, 6:01 PM · Plans, Diffusion
epriestley added a comment to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

Only branches can be "Autoclose".

Sun, Apr 14, 5:58 PM · Plans, Diffusion
epriestley added a comment to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".
Sun, Apr 14, 5:56 PM · Plans, Diffusion
epriestley requested review of D20418: Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories.
Sun, Apr 14, 5:53 PM
epriestley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D20418: Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories.
Sun, Apr 14, 5:51 PM · Customer Impact, Diffusion (v3)
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20418: Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories.
Sun, Apr 14, 5:51 PM · Diffusion, Harbormaster, Herald, Audit
Harbormaster failed to build B22588: rPf13709b13b68: Update search indexes for Dashboards and Panels to Ferret, plus various minor… for rPf13709b13b68: Update search indexes for Dashboards and Panels to Ferret, plus various minor…!
Sun, Apr 14, 5:29 PM
epriestley committed rPf13709b13b68: Update search indexes for Dashboards and Panels to Ferret, plus various minor… (authored by epriestley).
Update search indexes for Dashboards and Panels to Ferret, plus various minor…
Sun, Apr 14, 5:28 PM
epriestley closed D20411: Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes.
Sun, Apr 14, 5:28 PM
epriestley committed rP80b7274e0bf6: Remove legacy "DashboardInstall" table (authored by epriestley).
Remove legacy "DashboardInstall" table
Sun, Apr 14, 5:28 PM
epriestley closed D20410: Remove legacy "DashboardInstall" table.
Sun, Apr 14, 5:28 PM
epriestley committed rPfb994909cf9c: Make "Move Panel" on dashboards use the new storage and transactions (authored by epriestley).
Make "Move Panel" on dashboards use the new storage and transactions
Sun, Apr 14, 5:25 PM
epriestley closed D20409: Make "Move Panel" on dashboards use the new storage and transactions.
Sun, Apr 14, 5:25 PM
epriestley committed rP82c46f4b93bd: Update "add panel" and "remove panel" Dashboard flows to the new panel storage… (authored by epriestley).
Update "add panel" and "remove panel" Dashboard flows to the new panel storage…
Sun, Apr 14, 5:25 PM
epriestley closed D20408: Update "add panel" and "remove panel" Dashboard flows to the new panel storage format.
Sun, Apr 14, 5:25 PM
epriestley committed rPa3c43c473be9: Convert dashboard read/display pathways to the new panel storage format (authored by epriestley).
Convert dashboard read/display pathways to the new panel storage format
Sun, Apr 14, 5:23 PM
epriestley closed D20407: Convert dashboard read/display pathways to the new panel storage format.
Sun, Apr 14, 5:23 PM
epriestley committed rP0381eed6e619: Modularize dashboard layout modes (one column, two columns, etc) (authored by epriestley).
Modularize dashboard layout modes (one column, two columns, etc)
Sun, Apr 14, 5:23 PM
epriestley closed D20406: Modularize dashboard layout modes (one column, two columns, etc).
Sun, Apr 14, 5:23 PM
epriestley committed rPd0078570cc50: Convert dashboard panel storage to a format which can handle duplicates (authored by epriestley).
Convert dashboard panel storage to a format which can handle duplicates
Sun, Apr 14, 5:22 PM
epriestley closed D20405: Convert dashboard panel storage to a format which can handle duplicates.
Sun, Apr 14, 5:22 PM

Sat, Apr 13

epriestley requested review of D20417: Distinguish between "bad record format" and "bad record value" when validating Trigger rules.
Sat, Apr 13, 4:35 PM
epriestley added a revision to T13269: Improve initial implementations of Workboard triggers and groups: D20417: Distinguish between "bad record format" and "bad record value" when validating Trigger rules.
Sat, Apr 13, 4:33 PM · Workboards (v3)
epriestley requested review of D20416: Improve trigger editor behavior when switching to/from tokenizers.
Sat, Apr 13, 4:09 PM
epriestley added a revision to T13269: Improve initial implementations of Workboard triggers and groups: D20416: Improve trigger editor behavior when switching to/from tokenizers.
Sat, Apr 13, 4:07 PM · Workboards (v3)
epriestley retitled D20415: Reduce drag-and-drop jank on dashboards from Reduce drag-and-drop jank on workboards to Reduce drag-and-drop jank on dashboards.
Sat, Apr 13, 12:26 AM
epriestley requested review of D20415: Reduce drag-and-drop jank on dashboards.
Sat, Apr 13, 12:22 AM
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20415: Reduce drag-and-drop jank on dashboards.
Sat, Apr 13, 12:20 AM · Dashboards

Fri, Apr 12

epriestley requested review of D20414: Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pages.
Fri, Apr 12, 11:49 PM
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20414: Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pages.
Fri, Apr 12, 11:48 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Fri, Apr 12, 11:48 PM · Dashboards
epriestley updated the diff for D19746: Make the Harbormaster build plan edit engine forms configurable.
  • Let's move forward with this after all: although we need some more work to fix the "Default XYZ Policy" stuff, this is the best path forward for PHI1204 (which requests that build plan behaviors have configurable defaults).
Fri, Apr 12, 11:20 PM
epriestley requested review of D20413: Index and show Owners packages affected by Herald rules.
Fri, Apr 12, 11:19 PM
epriestley requested review of D20412: Reindex dashboards and panels (allow migrations to queue a job to queue other indexing jobs).
Fri, Apr 12, 11:02 PM
amckinley accepted D20411: Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes.
Fri, Apr 12, 9:56 PM
amckinley accepted D20410: Remove legacy "DashboardInstall" table.
Fri, Apr 12, 9:47 PM
amckinley added inline comments to D20409: Make "Move Panel" on dashboards use the new storage and transactions.
Fri, Apr 12, 9:47 PM
epriestley added inline comments to D20409: Make "Move Panel" on dashboards use the new storage and transactions.
Fri, Apr 12, 9:32 PM
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20412: Reindex dashboards and panels (allow migrations to queue a job to queue other indexing jobs).
Fri, Apr 12, 9:27 PM · Dashboards
amckinley accepted D20409: Make "Move Panel" on dashboards use the new storage and transactions.
Fri, Apr 12, 8:41 PM
amckinley accepted D20408: Update "add panel" and "remove panel" Dashboard flows to the new panel storage format.
Fri, Apr 12, 8:30 PM
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Fri, Apr 12, 8:17 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Fri, Apr 12, 8:16 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Fri, Apr 12, 8:13 PM · Dashboards
epriestley added a comment to D20411: Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes.

This (and other changes in this series) require a reindex, but I'm planning to probably let migrations run a bin/search index --type ... via the Worker queue so this happens automatically a little later on, since all the stuff we need to reindex (panels, herald rules, dashboards, portals) should only take a minute or two to reindex.

Fri, Apr 12, 8:10 PM
epriestley requested review of D20411: Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes.
Fri, Apr 12, 8:08 PM
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20411: Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes.
Fri, Apr 12, 8:06 PM · Dashboards
epriestley added a comment to D20407: Convert dashboard read/display pathways to the new panel storage format.

The edge no longer does anything, and was always redundant with the actual panel layout information.

Fri, Apr 12, 7:54 PM
amckinley accepted D20407: Convert dashboard read/display pathways to the new panel storage format.
Fri, Apr 12, 7:45 PM
amckinley accepted D20406: Modularize dashboard layout modes (one column, two columns, etc).
Fri, Apr 12, 7:38 PM
amckinley accepted D20405: Convert dashboard panel storage to a format which can handle duplicates.
Fri, Apr 12, 7:33 PM
epriestley requested review of D20410: Remove legacy "DashboardInstall" table.
Fri, Apr 12, 7:26 PM
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20410: Remove legacy "DashboardInstall" table.
Fri, Apr 12, 7:24 PM · Dashboards
epriestley committed rP2ae7d612f25a: Fix a missing pht() in Ponder (authored by epriestley).
Fix a missing pht() in Ponder
Fri, Apr 12, 7:19 PM
epriestley closed D20404: Fix a missing pht() in Ponder.
Fri, Apr 12, 7:19 PM
epriestley requested review of D20409: Make "Move Panel" on dashboards use the new storage and transactions.
Fri, Apr 12, 7:11 PM
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20409: Make "Move Panel" on dashboards use the new storage and transactions.
Fri, Apr 12, 7:09 PM · Dashboards
epriestley committed rPHU639e4b9cae28: Make the "Reply" and "Quote" Remarkup rules more similar (authored by epriestley).
Make the "Reply" and "Quote" Remarkup rules more similar
Fri, Apr 12, 6:32 PM
epriestley closed D20393: Make the "Reply" and "Quote" Remarkup rules more similar.
Fri, Apr 12, 6:32 PM
epriestley requested review of D20408: Update "add panel" and "remove panel" Dashboard flows to the new panel storage format.
Fri, Apr 12, 6:30 PM
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20408: Update "add panel" and "remove panel" Dashboard flows to the new panel storage format.
Fri, Apr 12, 6:29 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Fri, Apr 12, 5:45 PM · Dashboards
epriestley requested review of D20407: Convert dashboard read/display pathways to the new panel storage format.
Fri, Apr 12, 4:10 PM
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20407: Convert dashboard read/display pathways to the new panel storage format.
Fri, Apr 12, 4:08 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Fri, Apr 12, 4:01 PM · Dashboards
epriestley requested review of D20406: Modularize dashboard layout modes (one column, two columns, etc).
Fri, Apr 12, 3:44 PM
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20406: Modularize dashboard layout modes (one column, two columns, etc).
Fri, Apr 12, 3:43 PM · Dashboards
epriestley requested review of D20405: Convert dashboard panel storage to a format which can handle duplicates.
Fri, Apr 12, 3:12 PM
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20405: Convert dashboard panel storage to a format which can handle duplicates.
Fri, Apr 12, 3:10 PM · Dashboards